Re: [ovs-dev] [PATCH] Fix build when HAVE_LIBCAPNG is not defined.

2015-10-01 Thread Russell Bryant
On 10/01/2015 04:07 PM, Andy Zhou wrote: >> I'm going to look into updating the RPM spec file for the new >> dependency, as well. > What do you plan to change there? I also plan to update the packaging scripts > so that 1) it will create 'ovs' user and group on the box, 2) OVS daemons > will run as

Re: [ovs-dev] [PATCH] Fix build when HAVE_LIBCAPNG is not defined.

2015-10-01 Thread Andy Zhou
> I'm going to look into updating the RPM spec file for the new > dependency, as well. What do you plan to change there? I also plan to update the packaging scripts so that 1) it will create 'ovs' user and group on the box, 2) OVS daemons will run as the ovs user, using the facilities just committe

Re: [ovs-dev] [PATCH] Fix build when HAVE_LIBCAPNG is not defined.

2015-10-01 Thread Russell Bryant
Andy, no problem! It was an easy fix. That's the life of working against master. :-) I'm going to look into updating the RPM spec file for the new dependency, as well. -- Russell Bryant On 10/01/2015 02:48 PM, Andy Zhou wrote: > Russell, > > Thanks for the fix. I have libcap-ng installed on

Re: [ovs-dev] [PATCH] Fix build when HAVE_LIBCAPNG is not defined.

2015-10-01 Thread Andy Zhou
Russell, Thanks for the fix. I have libcap-ng installed on my system and forgot to test compiling without it. Sorry. andy On Thu, Oct 1, 2015 at 8:52 AM, Ben Pfaff wrote: > On Thu, Oct 01, 2015 at 11:29:16AM -0400, Russell Bryant wrote: >> The function daemon_become_new_user_linux was condition

Re: [ovs-dev] [PATCH] Fix build when HAVE_LIBCAPNG is not defined.

2015-10-01 Thread Ben Pfaff
On Thu, Oct 01, 2015 at 11:29:16AM -0400, Russell Bryant wrote: > The function daemon_become_new_user_linux was conditionally defined but > then used in code unconditionally. If HAVE_LIBCAPNG is not defined, the > function would never be called, but it still must exist. > > Adjust the #if guard a

[ovs-dev] [PATCH] Fix build when HAVE_LIBCAPNG is not defined.

2015-10-01 Thread Russell Bryant
The function daemon_become_new_user_linux was conditionally defined but then used in code unconditionally. If HAVE_LIBCAPNG is not defined, the function would never be called, but it still must exist. Adjust the #if guard around the function to be around the body of the function instead of outsid