Re: [ovs-dev] [PATCH] Fix broken build in XenServer DDK 5.6.100-39265p.

2011-10-13 Thread Ben Pfaff
OK, pushed. On Thu, Oct 13, 2011 at 02:51:29PM -0700, Ethan Jackson wrote: > Good enough for me. > > Ethan > > On Thu, Oct 13, 2011 at 14:50, Ben Pfaff wrote: > > OK, now I've actually tested that it builds. > > > > On Thu, Oct 13, 2011 at 02:46:59PM -0700, Ben Pfaff wrote: > >> I tested it to

Re: [ovs-dev] [PATCH] Fix broken build in XenServer DDK 5.6.100-39265p.

2011-10-13 Thread Ethan Jackson
Good enough for me. Ethan On Thu, Oct 13, 2011 at 14:50, Ben Pfaff wrote: > OK, now I've actually tested that it builds. > > On Thu, Oct 13, 2011 at 02:46:59PM -0700, Ben Pfaff wrote: >> I tested it to this extent in the Xen DDK: >> >>     blp@hardrock:~/xenddk-5.6.0$ sudo chroot . >>     [root@

Re: [ovs-dev] [PATCH] Fix broken build in XenServer DDK 5.6.100-39265p.

2011-10-13 Thread Ben Pfaff
OK, now I've actually tested that it builds. On Thu, Oct 13, 2011 at 02:46:59PM -0700, Ben Pfaff wrote: > I tested it to this extent in the Xen DDK: > > blp@hardrock:~/xenddk-5.6.0$ sudo chroot . > [root@hardrock /]# cd > [root@hardrock ~]# cat > foo.c > #include > #include

Re: [ovs-dev] [PATCH] Fix broken build in XenServer DDK 5.6.100-39265p.

2011-10-13 Thread Ben Pfaff
I tested it to this extent in the Xen DDK: blp@hardrock:~/xenddk-5.6.0$ sudo chroot . [root@hardrock /]# cd [root@hardrock ~]# cat > foo.c #include #include [root@hardrock ~]# gcc foo.c In file included from foo.c:2: /usr/include/sys/types.h:62: error: conflicting

Re: [ovs-dev] [PATCH] Fix broken build in XenServer DDK 5.6.100-39265p.

2011-10-13 Thread Ethan Jackson
This seems fine to me if assuming it fixes the errors. Jesse knows more about this sort of thing than I do so perhaps he should take a look. Ethan On Thu, Oct 13, 2011 at 14:38, Ben Pfaff wrote: > Avoids errors like the following: > > In file included from ./include/openvswitch/types.h:21, >  

[ovs-dev] [PATCH] Fix broken build in XenServer DDK 5.6.100-39265p.

2011-10-13 Thread Ben Pfaff
Avoids errors like the following: In file included from ./include/openvswitch/types.h:21, from ./lib/vconn.h:21, from tests/test-vconn.c:18: /usr/include/sys/types.h:52: error: conflicting types for 'ino_t' /usr/include/linux/types.h:14: error: previous declaratio