I will send a v2 soon based on Andy's feedback.
Thanks
Guolin
On Thu, Aug 29, 2013 at 8:43 PM, Ben Pfaff wrote:
> Andy, thanks for the review.
>
> Guolin, are you willing to submit a v2?
>
> Thanks,
>
> Ben.
>
> On Thu, Aug 29, 2013 at 05:21:03PM -0700, Andy Zhou wrote:
> > Good catch. The log
Andy, thanks for the review.
Guolin, are you willing to submit a v2?
Thanks,
Ben.
On Thu, Aug 29, 2013 at 05:21:03PM -0700, Andy Zhou wrote:
> Good catch. The logic looks good to me.
>
> When compiling, I got the following warnings:
>
> b/odp-util.c: In function ?odp_flow_key_from_flow__?:
>
Good catch. The logic looks good to me.
When compiling, I got the following warnings:
b/odp-util.c: In function ‘odp_flow_key_from_flow__’:
lib/odp-util.c:2559:17: error: comparison is always false due to limited
range of data type [-Werror=type-limits]
lib/odp-util.c:2560:31: error: comparison i
From: Guolin Yang
For ICMPv6, when convert flow/mask to flow/mask key, the check
for whether there is ND information is incorrect. Similar error
in reverse conversion.
Signed-off-by: Guolin Yang
---
lib/odp-util.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff
