Re: [ovs-dev] [PATCH] Extend the sFlow agent to report tunnel and MPLS structures

2015-05-26 Thread Neil McKee
Yes. I'll do that. They have changed slightly now that the option to request the actions is an attribute of the "userspace" action. Neil -- Neil McKee InMon Corp. http://www.inmon.com On Tue, May 26, 2015 at 7:17 PM, Ben Pfaff wrote: > On Fri, May 15, 2015 at 05:53:02PM -0700, Jesse Gro

Re: [ovs-dev] [PATCH] Extend the sFlow agent to report tunnel and MPLS structures

2015-05-26 Thread Ben Pfaff
On Fri, May 15, 2015 at 05:53:02PM -0700, Jesse Gross wrote: > On Fri, May 15, 2015 at 3:04 PM, Neil McKee wrote: > > I understand that the (optional) kernel datapath changes will need to > > be submitted as a kernel > > patch on netdev. I can try that, but I'm guessing I won't get much > > atte

Re: [ovs-dev] [PATCH] Extend the sFlow agent to report tunnel and MPLS structures

2015-05-20 Thread Neil McKee
OK, I reworked the kernel patch to apply against the 4.0 kernel and posted it to the netdev mailing list: http://www.spinics.net/lists/netdev/msg329948.html I will now go back and separate this into separate kernel and userspace patches for the ovs tree, especially since the userspace part is n

[ovs-dev] [PATCH] Extend the sFlow agent to report tunnel and MPLS structures

2015-05-18 Thread Neil McKee
Packets are still sampled at ingress only, so the egress tunnel and/or MPLS structures are only included when there is just 1 output port. The actions are either provided by the datapath in the sample upcall or looked up in the userspace cache. The former is preferred because it is more reliable

Re: [ovs-dev] [PATCH] Extend the sFlow agent to report tunnel and MPLS structures

2015-05-15 Thread Jesse Gross
On Fri, May 15, 2015 at 3:04 PM, Neil McKee wrote: > I understand that the (optional) kernel datapath changes will need to > be submitted as a kernel > patch on netdev. I can try that, but I'm guessing I won't get much > attention there without > input from someone they have heard of. How does

Re: [ovs-dev] [PATCH] Extend the sFlow agent to report tunnel and MPLS structures

2015-05-15 Thread Neil McKee
Attachment was stripped - here it is: Subject: [PATCH] Extend the sFlow agent to report ingress and egress tunnel and MPLS structures. Packets are still sampled at ingress only, so the egress tunnel and/or MPLS structures are only included when there is just 1 output port. The actions are eith

[ovs-dev] [PATCH] Extend the sFlow agent to report tunnel and MPLS structures

2015-05-15 Thread Neil McKee
Real-time visibility into mpls and tunneling will be very helpful for monitoring and dynamic control, so please review this patch. Specific questions are tagged with "XXX" comments. I also submitted a git-hub pull-request: https://github.com/openvswitch/ovs/pull/45 I understand that the (optional