Re: [ovs-dev] [PATCH] Change sFlow model to reflect per-bridge sampling

2013-05-03 Thread Ben Pfaff
Thanks, I did want your opinion. I applied this to branch-1.10. On Thu, May 02, 2013 at 05:19:42PM -0700, Neil Mckee wrote: > Thanks! > > If that was a question to me, then yes, I think it would be good to > fix this on branch 1.10 too. The old code resulted in ifIndex==-95 > being offered to t

Re: [ovs-dev] [PATCH] Change sFlow model to reflect per-bridge sampling

2013-05-02 Thread Neil Mckee
Thanks! If that was a question to me, then yes, I think it would be good to fix this on branch 1.10 too. The old code resulted in ifIndex==-95 being offered to the sFlow module for traffic from a non-ifindex-port. -95 being the -errno that the netdev replies with to indicate that it doesn't

Re: [ovs-dev] [PATCH] Change sFlow model to reflect per-bridge sampling

2013-05-02 Thread Ben Pfaff
Applied to master and branch-1.11, thanks. Do we need this on branch-1.10 also? On Tue, Apr 30, 2013 at 10:38:53PM -0700, Neil Mckee wrote: > I learned how to squash patches... > > Change sFlow model to reflect per-bridge sampling. Before we were presenting > a separate > sFlow data-source (sa

[ovs-dev] [PATCH] Change sFlow model to reflect per-bridge sampling

2013-04-30 Thread Neil Mckee
I learned how to squash patches... Change sFlow model to reflect per-bridge sampling. Before we were presenting a separate sFlow data-source (sampler) for each ifIndex-interface, and it was causing problems with samples that did not easily map to an ifIndex being aliased together and breaking