Re: [ovs-dev] [PATCH] Build: shared libraries and versioning

2014-10-27 Thread Thomas Graf
On 10/21/14 at 04:02pm, Scott Mann wrote: > lib/libopenvswitch.sym.in | 4 > lib/libsflow.sym.in | 4 > ofproto/libofproto.sym.in | 4 > ovsdb/libovsdb.sym.in | 4 Scott, Can you add the generated .sym files to .gitignore?

Re: [ovs-dev] [PATCH] Build: shared libraries and versioning

2014-10-23 Thread Thomas Graf
On 10/22/14 at 11:04pm, Scott Mann wrote: > On Wed, Oct 22, 2014 at 10:09 PM, Ben Pfaff wrote: > > I see the failure. > > > > I suspect that the root cause is something different that we should fix > > separately. I spent a few minutes investigating, but I did not > > completely isolate the probl

Re: [ovs-dev] [PATCH] Build: shared libraries and versioning

2014-10-22 Thread Scott Mann
On Wed, Oct 22, 2014 at 10:09 PM, Ben Pfaff wrote: > On Wed, Oct 22, 2014 at 08:54:44PM -0600, Scott Mann wrote: > > On Wed, Oct 22, 2014 at 8:41 PM, Ben Pfaff wrote: > > > > > On Wed, Oct 22, 2014 at 08:23:13PM -0600, Scott Mann wrote: > > > > On Wed, Oct 22, 2014 at 7:29 PM, Ben Pfaff wrote:

Re: [ovs-dev] [PATCH] Build: shared libraries and versioning

2014-10-22 Thread Ben Pfaff
On Wed, Oct 22, 2014 at 08:54:44PM -0600, Scott Mann wrote: > On Wed, Oct 22, 2014 at 8:41 PM, Ben Pfaff wrote: > > > On Wed, Oct 22, 2014 at 08:23:13PM -0600, Scott Mann wrote: > > > On Wed, Oct 22, 2014 at 7:29 PM, Ben Pfaff wrote: > > > > > > > On Wed, Oct 22, 2014 at 04:53:28PM -0700, Guruch

Re: [ovs-dev] [PATCH] Build: shared libraries and versioning

2014-10-22 Thread Scott Mann
On Wed, Oct 22, 2014 at 8:41 PM, Ben Pfaff wrote: > On Wed, Oct 22, 2014 at 08:23:13PM -0600, Scott Mann wrote: > > On Wed, Oct 22, 2014 at 7:29 PM, Ben Pfaff wrote: > > > > > On Wed, Oct 22, 2014 at 04:53:28PM -0700, Gurucharan Shetty wrote: > > > > > I seem to recall that there was a related b

Re: [ovs-dev] [PATCH] Build: shared libraries and versioning

2014-10-22 Thread Ben Pfaff
On Wed, Oct 22, 2014 at 08:23:13PM -0600, Scott Mann wrote: > On Wed, Oct 22, 2014 at 7:29 PM, Ben Pfaff wrote: > > > On Wed, Oct 22, 2014 at 04:53:28PM -0700, Gurucharan Shetty wrote: > > > > I seem to recall that there was a related bug a while back when we > > > > added the existing shared lib

Re: [ovs-dev] [PATCH] Build: shared libraries and versioning

2014-10-22 Thread Scott Mann
On Wed, Oct 22, 2014 at 7:29 PM, Ben Pfaff wrote: > On Wed, Oct 22, 2014 at 04:53:28PM -0700, Gurucharan Shetty wrote: > > > I seem to recall that there was a related bug a while back when we > > > added the existing shared library support. I spent some time looking > > > through the mailing lis

Re: [ovs-dev] [PATCH] Build: shared libraries and versioning

2014-10-22 Thread Ben Pfaff
On Wed, Oct 22, 2014 at 04:53:28PM -0700, Gurucharan Shetty wrote: > > I seem to recall that there was a related bug a while back when we > > added the existing shared library support. I spent some time looking > > through the mailing list and the Git history, though, and I couldn't > > find it. >

Re: [ovs-dev] [PATCH] Build: shared libraries and versioning

2014-10-22 Thread Gurucharan Shetty
> > The reason that it bothers me is that, if I recall correctly, turning > on building shared libraries actually causes every source file to be > built twice, roughly doubling compile time. That's not a big deal > when building for a distribution, etc., but it slows the dev cycle, > which is a bi

Re: [ovs-dev] [PATCH] Build: shared libraries and versioning

2014-10-22 Thread Ben Pfaff
[adding back ovs-dev] On Wed, Oct 22, 2014 at 04:38:48PM -0600, Scott Mann wrote: > On Wed, Oct 22, 2014 at 3:35 PM, Ben Pfaff wrote: > > > On Tue, Oct 21, 2014 at 04:02:53PM -0600, Scott Mann wrote: > > > These changes cause shared libraries to be built by default. In > > > particular, lib/libo

Re: [ovs-dev] [PATCH] Build: shared libraries and versioning

2014-10-22 Thread Ben Pfaff
On Tue, Oct 21, 2014 at 04:02:53PM -0600, Scott Mann wrote: > These changes cause shared libraries to be built by default. In > particular, lib/libopenvwitch.so, lib/libsflow.so, > ofproto/libofproto.so, and ovsdb/libovsdb.so will be built. Original > behavior of building static objects excusively

[ovs-dev] [PATCH] Build: shared libraries and versioning

2014-10-21 Thread Scott Mann
These changes cause shared libraries to be built by default. In particular, lib/libopenvwitch.so, lib/libsflow.so, ofproto/libofproto.so, and ovsdb/libovsdb.so will be built. Original behavior of building static objects excusively may be accomplished by providing the --disable-shared argument to co