Re: [ovs-dev] [PATCH] Bond to use active-backup mode on LACP failure

2013-11-04 Thread Ethan Jackson
This looks pretty much on track. Here's my code review. Please fix up the changes mentioned below and resend it. The first line of the commit message needs period. Could we change it to "bond: Use active-backup mode on LACP failure." to be more similar to the rest of our commit messages? There

Re: [ovs-dev] [PATCH] Bond to use active-backup mode on LACP failure

2013-11-04 Thread Ethan Jackson
Yep I'm looking at it. Ethan On Mon, Nov 4, 2013 at 11:34 AM, Ben Pfaff wrote: > On Wed, Oct 30, 2013 at 08:06:18PM +, Ravi Kondamuru wrote: >> Commit bdebeece5 on git.openvswitch.org (lacp: Require successful LACP >> negotiations when configured.) makes successful LACP negotiation >> mandat

Re: [ovs-dev] [PATCH] Bond to use active-backup mode on LACP failure

2013-11-04 Thread Ben Pfaff
On Wed, Oct 30, 2013 at 08:06:18PM +, Ravi Kondamuru wrote: > Commit bdebeece5 on git.openvswitch.org (lacp: Require successful LACP > negotiations when configured.) makes successful LACP negotiation > mandatory for the bond to come UP. This patch provides a configuration > option to bring up t

[ovs-dev] [PATCH] Bond to use active-backup mode on LACP failure

2013-10-30 Thread Ravi Kondamuru
Commit bdebeece5 on git.openvswitch.org (lacp: Require successful LACP negotiations when configured.) makes successful LACP negotiation mandatory for the bond to come UP. This patch provides a configuration option to bring up the bond by falling back to active-backup mode on LACP negotiation failur