[ovs-dev] [PATCH] BFD: Unit tests for BFD

2013-07-26 Thread Pavithra Ramesh
Added more comments and removed some unnecessary lines. --- tests/automake.mk |1 + tests/bfd.at | 218 tests/testsuite.at |1 + 3 files changed, 220 insertions(+), 0 deletions(-) create mode 100644 tests/bfd.at diff --git a/te

Re: [ovs-dev] [PATCH] BFD: Unit tests for BFD. Add unit tests to verify basic functionality in BFD.

2013-06-25 Thread Ethan Jackson
Thanks for writing these up. They look pretty good, thorough and easy to follow. Comments below. The first test fails on my system. Does it pass on yours against master? I don't think we need to bother setting the datapath-id and the hwaddr on all the bridges at creation time. I wouldn't both

Re: [ovs-dev] [PATCH] BFD: Unit tests for BFD. Add unit tests to verify basic functionality in BFD.

2013-06-25 Thread Ben Pfaff
On Tue, Jun 25, 2013 at 12:55:30PM -0700, Pavithra Ramesh wrote: > Signed-off-by: Pavithra Ramesh This isn't a full review, but: there are tons of [ignore]s in this patch. It's best not to ignore output. Please try to remove as many as you can. ___ de

[ovs-dev] [PATCH] BFD: Unit tests for BFD. Add unit tests to verify basic functionality in BFD.

2013-06-25 Thread Pavithra Ramesh
Signed-off-by: Pavithra Ramesh --- tests/automake.mk |1 + tests/bfd.at | 214 tests/testsuite.at |1 + 3 files changed, 216 insertions(+), 0 deletions(-) create mode 100644 tests/bfd.at diff --git a/tests/automake.mk b/tests/