Re: [ovs-dev] [PATCH] Always check return value of strftime().

2013-05-08 Thread Ben Pfaff
That's how I roll. Thanks, applied to master. On Mon, May 06, 2013 at 01:02:08PM -0700, Andy Zhou wrote: > Looks good. Thanks for addressing it cleanly. > > > On Thu, May 2, 2013 at 4:16 PM, Ben Pfaff wrote: > > > strftime() returns 0 and leaves the contents of the output buffer > > unspecifi

Re: [ovs-dev] [PATCH] Always check return value of strftime().

2013-05-06 Thread Andy Zhou
Looks good. Thanks for addressing it cleanly. On Thu, May 2, 2013 at 4:16 PM, Ben Pfaff wrote: > strftime() returns 0 and leaves the contents of the output buffer > unspecified if the output buffer is not big enough. Thus, one should > check strftime()'s return value. Until now, OVS has had a

[ovs-dev] [PATCH] Always check return value of strftime().

2013-05-02 Thread Ben Pfaff
strftime() returns 0 and leaves the contents of the output buffer unspecified if the output buffer is not big enough. Thus, one should check strftime()'s return value. Until now, OVS has had a few invocations of strftime() that did not check the return value. This commit fixes those. I believe