Re: [ovs-dev] [PATCH] Allow OVS_USERSPACE_ATTR_USERDATA to be variable length.

2013-02-19 Thread Jesse Gross
On Fri, Feb 15, 2013 at 6:20 PM, Ben Pfaff wrote: > On Fri, Feb 15, 2013 at 05:36:00PM -0800, Jesse Gross wrote: >> On Fri, Feb 15, 2013 at 4:48 PM, Ben Pfaff wrote: >> > I tested this just now and found a bug: OVS_USERSPACE_ATTR_USERDATA in >> > the action has to be translated to OVS_PACKET_ATTR

Re: [ovs-dev] [PATCH] Allow OVS_USERSPACE_ATTR_USERDATA to be variable length.

2013-02-15 Thread Ben Pfaff
On Fri, Feb 15, 2013 at 05:36:00PM -0800, Jesse Gross wrote: > On Fri, Feb 15, 2013 at 4:48 PM, Ben Pfaff wrote: > > I tested this just now and found a bug: OVS_USERSPACE_ATTR_USERDATA in > > the action has to be translated to OVS_PACKET_ATTR_USERDATA in the > > kernel->user Netlink message, other

Re: [ovs-dev] [PATCH] Allow OVS_USERSPACE_ATTR_USERDATA to be variable length.

2013-02-15 Thread Jesse Gross
On Fri, Feb 15, 2013 at 4:48 PM, Ben Pfaff wrote: > I tested this just now and found a bug: OVS_USERSPACE_ATTR_USERDATA in > the action has to be translated to OVS_PACKET_ATTR_USERDATA in the > kernel->user Netlink message, otherwise it gets interpreted as > OVS_PACKET_ATTR_KEY. So I applied the

Re: [ovs-dev] [PATCH] Allow OVS_USERSPACE_ATTR_USERDATA to be variable length.

2013-02-15 Thread Ben Pfaff
On Fri, Feb 15, 2013 at 04:17:21PM -0800, Jesse Gross wrote: > On Mon, Feb 4, 2013 at 4:01 PM, Ben Pfaff wrote: > > diff --git a/datapath/datapath.c b/datapath/datapath.c > > index 04a5e7f..2a542da 100644 > > --- a/datapath/datapath.c > > +++ b/datapath/datapath.c > > @@ -678,7 +678,6 @@ static in

Re: [ovs-dev] [PATCH] Allow OVS_USERSPACE_ATTR_USERDATA to be variable length.

2013-02-15 Thread Jesse Gross
On Mon, Feb 4, 2013 at 4:01 PM, Ben Pfaff wrote: > diff --git a/datapath/datapath.c b/datapath/datapath.c > index 04a5e7f..2a542da 100644 > --- a/datapath/datapath.c > +++ b/datapath/datapath.c > @@ -678,7 +678,6 @@ static int validate_userspace(const struct nlattr *attr) > { > static con

Re: [ovs-dev] [PATCH] Allow OVS_USERSPACE_ATTR_USERDATA to be variable length.

2013-02-11 Thread Ben Pfaff
On Mon, Feb 04, 2013 at 04:01:03PM -0800, Ben Pfaff wrote: > Until now, the optional OVS_USERSPACE_ATTR_USERDATA attribute had to be > exactly 64 bits long, if it was present. However, 64 bits is not enough > space to associate as much information with a flow as would be convenient > for some user

[ovs-dev] [PATCH] Allow OVS_USERSPACE_ATTR_USERDATA to be variable length.

2013-02-04 Thread Ben Pfaff
Until now, the optional OVS_USERSPACE_ATTR_USERDATA attribute had to be exactly 64 bits long, if it was present. However, 64 bits is not enough space to associate as much information with a flow as would be convenient for some userspace features now under development. This commit generalizes the