Re: [ovs-dev] [PATCH] Add ifindex column to Interface table

2013-07-08 Thread Ben Pfaff
On Thu, Jun 13, 2013 at 02:52:58PM -0700, Ben Pfaff wrote: > On Thu, Jun 13, 2013 at 02:42:52PM -0700, Neil Mckee wrote: > > This proposed patch adds an "ifindex" column to the "Interface" table in > > the db. So that > > "ovs-vsctl list Interface" can show the ifindex numbers for those > > inte

Re: [ovs-dev] [PATCH] Add ifindex column to Interface table

2013-07-03 Thread Neil Mckee
Oh - it fails some tests now - such as the LACP ones. Looks like ovsrec_interface_set_ifindex() is triggering this error in lib/ovsdb-idl.c:ovsdb_idl_txn_write__() if (row->table->idl->verify_write_only && !write_only) { VLOG_ERR("Bug: Attempt to write to a read/write column (%s:%s

Re: [ovs-dev] [PATCH] Add ifindex column to Interface table

2013-07-02 Thread Ben Pfaff
Thanks Neil. I'm on vacation this week but I'll look at this when I get back next week. On Jul 2, 2013 5:55 PM, "Neil Mckee" wrote: > OK, here's how it looks now (against latest master). I wasn't sure where > to add the NEWS item so I just guessed. > > Signed-off-by: Neil McKee > > --- > NEWS

Re: [ovs-dev] [PATCH] Add ifindex column to Interface table

2013-07-02 Thread Neil Mckee
OK, here's how it looks now (against latest master). I wasn't sure where to add the NEWS item so I just guessed. Signed-off-by: Neil McKee --- NEWS | 2 ++ vswitchd/bridge.c | 11 +++ vswitchd/vswitch.ovsschema | 7 +-- vswitchd/vswitch.xml

Re: [ovs-dev] [PATCH] Add ifindex column to Interface table

2013-06-13 Thread Ethan Jackson
> ifindex is pretty much everywhere because it (as far as I know) > originated in BSD and has since then been enshrined in SNMP and > elsewhere. Fine with me then. Ethan > > On Thu, Jun 13, 2013 at 02:48:56PM -0700, Ethan Jackson wrote: >> Since this is OS specific, perhaps we should put it in t

Re: [ovs-dev] [PATCH] Add ifindex column to Interface table

2013-06-13 Thread Ben Pfaff
On Thu, Jun 13, 2013 at 02:42:52PM -0700, Neil Mckee wrote: > This proposed patch adds an "ifindex" column to the "Interface" table in the > db. So that > "ovs-vsctl list Interface" can show the ifindex numbers for those interfaces > that have > them (and 0 for the rest). > > For example: > >

Re: [ovs-dev] [PATCH] Add ifindex column to Interface table

2013-06-13 Thread Ben Pfaff
ifindex is pretty much everywhere because it (as far as I know) originated in BSD and has since then been enshrined in SNMP and elsewhere. On Thu, Jun 13, 2013 at 02:48:56PM -0700, Ethan Jackson wrote: > Since this is OS specific, perhaps we should put it in the status > column instead? > > Ethan

Re: [ovs-dev] [PATCH] Add ifindex column to Interface table

2013-06-13 Thread Ethan Jackson
Since this is OS specific, perhaps we should put it in the status column instead? Ethan On Thu, Jun 13, 2013 at 2:42 PM, Neil Mckee wrote: > This proposed patch adds an "ifindex" column to the "Interface" table in the > db. So that > "ovs-vsctl list Interface" can show the ifindex numbers for

[ovs-dev] [PATCH] Add ifindex column to Interface table

2013-06-13 Thread Neil Mckee
This proposed patch adds an "ifindex" column to the "Interface" table in the db. So that "ovs-vsctl list Interface" can show the ifindex numbers for those interfaces that have them (and 0 for the rest). For example: % ovs-vsctl --format json --columns name,ofport,ifindex list Interface {"data"