Thanks.
On Thu, Aug 16, 2012 at 02:27:23PM -0700, Mehak Mahajan wrote:
> Thanks Ben for your help/reviews.
>
> I have added this test.
>
> +# actions=dec_ttl(32768,12345,90,765,1024)
> + 0020 2320 0015 0005 80003039005A02fd 0400
> +
>
> I will do a quick retest and w
Thanks Ben for your help/reviews.
I have added this test.
+# actions=dec_ttl(32768,12345,90,765,1024)
+ 0020 2320 0015 0005 80003039005A02fd 0400
+
I will do a quick retest and will push the patch shortly.
thanx!
mehak
On Thu, Aug 16, 2012 at 1:41 PM, Ben Pfaff wro
On Thu, Aug 16, 2012 at 01:36:47PM -0700, Mehak Mahajan wrote:
> Currently, if a controller having a nonzero id registers to get a
> OFPR_INVALID_TTL async message, it will not receive it. This is because
> compose_dec_ttl() only sent the invalid ttl packets to the default controller
> id. NXAST_
Currently, if a controller having a nonzero id registers to get a
OFPR_INVALID_TTL async message, it will not receive it. This is because
compose_dec_ttl() only sent the invalid ttl packets to the default controller
id. NXAST_DEC_TTL_CNT_IDS is a new action that accepts a list of controller
ids,
Hey Ben,
Thanks for the reviews. I am posting a new patch addressing your concerns.
thanx!
mehak
On Thu, Aug 16, 2012 at 10:44 AM, Ben Pfaff wrote:
> This is getting really close.
>
> On Wed, Aug 15, 2012 at 03:00:10PM -0700, Mehak Mahajan wrote:
> > static enum ofperr
> > +dec_ttl_from_openf
This is getting really close.
On Wed, Aug 15, 2012 at 03:00:10PM -0700, Mehak Mahajan wrote:
> static enum ofperr
> +dec_ttl_from_openflow(struct ofpbuf *out)
> +{
> +uint16_t id = 0;
> +struct ofpact_cnt_ids *ids;
> +enum ofperr error = 0;
> +
> +ids = ofpact_put_DEC_TTL(out);
>
Currently, if a controller having a nonzero id registers to get a
OFPR_INVALID_TTL async message, it will not receive it. This is because
compose_dec_ttl() only sent the invalid ttl packets to the default controller
id. NXAST_DEC_TTL_CNT_IDS is a new action that accepts a list of controller
ids,
On Wed, Aug 15, 2012 at 1:20 PM, Ben Pfaff wrote:
> On Wed, Aug 15, 2012 at 11:51:12AM -0700, Mehak Mahajan wrote:
> > On Wed, Aug 15, 2012 at 11:23 AM, Ben Pfaff wrote:
> >
> > > On Wed, Aug 15, 2012 at 12:15:58AM -0700, Mehak Mahajan wrote:
> > > > --- a/include/openflow/nicira-ext.h
> > > > +
On Wed, Aug 15, 2012 at 11:51:12AM -0700, Mehak Mahajan wrote:
> On Wed, Aug 15, 2012 at 11:23 AM, Ben Pfaff wrote:
>
> > On Wed, Aug 15, 2012 at 12:15:58AM -0700, Mehak Mahajan wrote:
> > > --- a/include/openflow/nicira-ext.h
> > > +++ b/include/openflow/nicira-ext.h
> > > @@ -291,7 +291,8 @@ en
Hey Ben,
On Wed, Aug 15, 2012 at 11:23 AM, Ben Pfaff wrote:
> On Wed, Aug 15, 2012 at 12:15:58AM -0700, Mehak Mahajan wrote:
> > --- a/include/openflow/nicira-ext.h
> > +++ b/include/openflow/nicira-ext.h
> > @@ -291,7 +291,8 @@ enum nx_action_subtype {
> > NXAST_OUTPUT_REG, /* st
Yes on both counts.
On Wed, Aug 15, 2012 at 11:33:16AM -0700, Mehak Mahajan wrote:
> Hey Ben,
>
> Thanks for your comments.
>
> Just to be sure that I have understood this correctly.
>
> 1. The NXAST_DEC_TTL must continue to use the same nx_action_header but the
> new message NXAST_DEC_TTL_CNT_
Hey Ben,
Thanks for your comments.
Just to be sure that I have understood this correctly.
1. The NXAST_DEC_TTL must continue to use the same nx_action_header but the
new message NXAST_DEC_TTL_CNT_IDS will use the new data structure ?
2. For both we will still use dec_ttl for the syntax .. i.e fo
On Wed, Aug 15, 2012 at 12:15:58AM -0700, Mehak Mahajan wrote:
> --- a/include/openflow/nicira-ext.h
> +++ b/include/openflow/nicira-ext.h
> @@ -291,7 +291,8 @@ enum nx_action_subtype {
> NXAST_OUTPUT_REG, /* struct nx_action_output_reg */
> NXAST_LEARN,/* struct
Currently, if a controller having a nonzero id registers to get a
OFPR_INVALID_TTL async message, it will not receive it. This is because
compose_dec_ttl() only sent the invalid ttl packets to the default controller
id. NXAST_DEC_TTL_CNT_IDS is a new action that accepts a list of controller
ids,
14 matches
Mail list logo
