Re: [ovs-dev] [PATCH] [RFC] fat-rwlock: New fast but big rwlock implementation.

2014-01-09 Thread Jarno Rajahalme
On Jan 9, 2014, at 12:56 PM, Ethan Jackson wrote: > FWIW the exact percentage gains are different in my setup, but the > general result that these two patches stacked on top of each other > make a big difference is consistent with what I've seen. > I had to bump the number of netperfs up to 50

Re: [ovs-dev] [PATCH] [RFC] fat-rwlock: New fast but big rwlock implementation.

2014-01-09 Thread Ethan Jackson
FWIW the exact percentage gains are different in my setup, but the general result that these two patches stacked on top of each other make a big difference is consistent with what I've seen. Ethan On Thu, Jan 9, 2014 at 12:41 PM, Ben Pfaff wrote: > On Thu, Jan 09, 2014 at 11:50:31AM -0800, Jarno

Re: [ovs-dev] [PATCH] [RFC] fat-rwlock: New fast but big rwlock implementation.

2014-01-09 Thread Ben Pfaff
On Thu, Jan 09, 2014 at 11:50:31AM -0800, Jarno Rajahalme wrote: > I tested this (without the extra malloc), and this is a minor > improvement on master, but a huge, in the order of ~40% performance > increase on top of the NUMA patches I sent yesterday. Also, > performance does not vary so much an

Re: [ovs-dev] [PATCH] [RFC] fat-rwlock: New fast but big rwlock implementation.

2014-01-09 Thread Jarno Rajahalme
Ben, I tested this (without the extra malloc), and this is a minor improvement on master, but a huge, in the order of ~40% performance increase on top of the NUMA patches I sent yesterday. Also, performance does not vary so much any more, and it is now actually beneficial to add more threads an

Re: [ovs-dev] [PATCH] [RFC] fat-rwlock: New fast but big rwlock implementation.

2014-01-08 Thread Ben Pfaff
On Wed, Jan 08, 2014 at 11:07:38AM -0800, Alex Wang wrote: > I suspect that this approach to a rwlock is faster when lots of threads > > try to take the read lock at once, because it should avoid cross-core > > contention on cache lines. > > > > For avoiding the contention, is that only because

Re: [ovs-dev] [PATCH] [RFC] fat-rwlock: New fast but big rwlock implementation.

2014-01-08 Thread Alex Wang
I'm trying to learn, want to ask few questions I suspect that this approach to a rwlock is faster when lots of threads > try to take the read lock at once, because it should avoid cross-core > contention on cache lines. For avoiding the contention, is that only because each thread will have it

[ovs-dev] [PATCH] [RFC] fat-rwlock: New fast but big rwlock implementation.

2014-01-07 Thread Ben Pfaff
I suspect that this approach to a rwlock is faster when lots of threads try to take the read lock at once, because it should avoid cross-core contention on cache lines. I'm sending it out for initial performance testing. The code needs some polish, but there's no point in doing it unless it actua