Re: [ovs-dev] [IP DEFRAG ACTION RFC 2/2] datapath: add ip_defag action

2014-11-14 Thread Thomas Graf
On 11/11/14 at 03:11pm, Andy Zhou wrote: > > > > I would like to keep the option to share the same zones because I > > can see a lot of value to match on CTs which have been created by > > netfilter or vice versa. > Is it sufficient if both ip_defrag and conntrack actions uses the same > zone as th

Re: [ovs-dev] [IP DEFRAG ACTION RFC 2/2] datapath: add ip_defag action

2014-11-11 Thread Andy Zhou
> > I would like to keep the option to share the same zones because I > can see a lot of value to match on CTs which have been created by > netfilter or vice versa. Is it sufficient if both ip_defrag and conntrack actions uses the same zone as their parameters? > >> Technically this cleaner. OVS IP

Re: [ovs-dev] [IP DEFRAG ACTION RFC 2/2] datapath: add ip_defag action

2014-11-11 Thread Thomas Graf
On 11/11/14 at 12:03pm, Andy Zhou wrote: > On Tue, Nov 11, 2014 at 2:48 AM, Thomas Graf wrote: > > Don't you need to pull off the ethernet header first? ip_defrag() > > expects an IP header at skb->data. > I could be wrong on this, but It looks to me ip_defrag uses ip_hdr() > to get the IP header

Re: [ovs-dev] [IP DEFRAG ACTION RFC 2/2] datapath: add ip_defag action

2014-11-11 Thread Andy Zhou
On Tue, Nov 11, 2014 at 2:48 AM, Thomas Graf wrote: > On 11/10/14 at 02:52pm, Andy Zhou wrote: >> Implements ip_defrag action in Linux kenrel using ip_defrag kernel APIs. >> >> Signed-off-by: Andy Zhou >> --- >> datapath/actions.c | 39 ++- >> datapath/fl

Re: [ovs-dev] [IP DEFRAG ACTION RFC 2/2] datapath: add ip_defag action

2014-11-11 Thread Thomas Graf
On 11/10/14 at 02:52pm, Andy Zhou wrote: > Implements ip_defrag action in Linux kenrel using ip_defrag kernel APIs. > > Signed-off-by: Andy Zhou > --- > datapath/actions.c | 39 ++- > datapath/flow_netlink.c | 6 +- > 2 files changed, 43 insertions(+

[ovs-dev] [IP DEFRAG ACTION RFC 2/2] datapath: add ip_defag action

2014-11-10 Thread Andy Zhou
Implements ip_defrag action in Linux kenrel using ip_defrag kernel APIs. Signed-off-by: Andy Zhou --- datapath/actions.c | 39 ++- datapath/flow_netlink.c | 6 +- 2 files changed, 43 insertions(+), 2 deletions(-) diff --git a/datapath/actions.c b/da