Re: [ovs-dev] [DPDK Upcalls v2 3/3] dpif-netdev: Streamline miss handling.

2014-08-18 Thread Ben Pfaff
On Mon, Aug 18, 2014 at 04:44:58PM +1200, Joe Stringer wrote: > On 13 August 2014 06:24, Ben Pfaff wrote: > > > > dp_netdev_flow_add() goes to some trouble to log matches as if they > > were provided as datapath flows, even though they aren't. I think > > that match_format() would be simpler and

Re: [ovs-dev] [DPDK Upcalls v2 3/3] dpif-netdev: Streamline miss handling.

2014-08-17 Thread Joe Stringer
On 13 August 2014 06:24, Ben Pfaff wrote: > > dp_netdev_flow_add() goes to some trouble to log matches as if they > were provided as datapath flows, even though they aren't. I think > that match_format() would be simpler and probably less confusing. In the majority of cases, I agree---however t

Re: [ovs-dev] [DPDK Upcalls v2 3/3] dpif-netdev: Streamline miss handling.

2014-08-13 Thread Ethan Jackson
> In ofproto-dpif-upcall.c, there are two blank lines above upcall_cb > (horrors!). I'm experimenting with a new form of avant-garde post-post-post-modern dadaist syntax formatting. Only those with the most discerning taste could possibly comprehend its momentous implications. > Did you test wit

Re: [ovs-dev] [DPDK Upcalls v2 3/3] dpif-netdev: Streamline miss handling.

2014-08-12 Thread Ben Pfaff
On Wed, Aug 06, 2014 at 07:40:25PM -0700, Ethan Jackson wrote: > This patch avoids the relatively inefficient miss handling processes > dictated by the dpif process, by calling into ofproto-dpif directly > through a callback. > > Signed-off-by: Ethan Jackson In dp_netdev_input(), the variable na

[ovs-dev] [DPDK Upcalls v2 3/3] dpif-netdev: Streamline miss handling.

2014-08-06 Thread Ethan Jackson
This patch avoids the relatively inefficient miss handling processes dictated by the dpif process, by calling into ofproto-dpif directly through a callback. Signed-off-by: Ethan Jackson --- lib/dpif-netdev.c | 299 -- lib/dpif-provider.h