Re: [ovs-dev] [-next] openvswitch BUILD_BUG_ON failed

2013-09-04 Thread Jesse Gross
On Tue, Sep 3, 2013 at 11:55 PM, Geert Uytterhoeven wrote: > On Tue, Sep 3, 2013 at 11:44 PM, Jesse Gross wrote: >> On Sat, Aug 31, 2013 at 5:11 AM, Geert Uytterhoeven >> wrote: >>> On Fri, Aug 30, 2013 at 3:11 AM, Jesse Gross wrote: On Thu, Aug 29, 2013 at 3:10 PM, David Miller wrote: >>

Re: [ovs-dev] [-next] openvswitch BUILD_BUG_ON failed

2013-09-03 Thread Geert Uytterhoeven
On Tue, Sep 3, 2013 at 11:44 PM, Jesse Gross wrote: > On Sat, Aug 31, 2013 at 5:11 AM, Geert Uytterhoeven > wrote: >> On Fri, Aug 30, 2013 at 3:11 AM, Jesse Gross wrote: >>> On Thu, Aug 29, 2013 at 3:10 PM, David Miller wrote: From: Jesse Gross Date: Thu, 29 Aug 2013 14:42:22 -0700 >

Re: [ovs-dev] [-next] openvswitch BUILD_BUG_ON failed

2013-09-03 Thread Jesse Gross
On Sat, Aug 31, 2013 at 5:11 AM, Geert Uytterhoeven wrote: > On Fri, Aug 30, 2013 at 3:11 AM, Jesse Gross wrote: >> On Thu, Aug 29, 2013 at 3:10 PM, David Miller wrote: >>> From: Jesse Gross >>> Date: Thu, 29 Aug 2013 14:42:22 -0700 >>> On Thu, Aug 29, 2013 at 2:21 PM, Geert Uytterhoeven >

Re: [ovs-dev] [-next] openvswitch BUILD_BUG_ON failed

2013-08-31 Thread Geert Uytterhoeven
On Fri, Aug 30, 2013 at 3:11 AM, Jesse Gross wrote: > On Thu, Aug 29, 2013 at 3:10 PM, David Miller wrote: >> From: Jesse Gross >> Date: Thu, 29 Aug 2013 14:42:22 -0700 >> >>> On Thu, Aug 29, 2013 at 2:21 PM, Geert Uytterhoeven >>> wrote: However, I have some doubts about other alignment "

Re: [ovs-dev] [-next] openvswitch BUILD_BUG_ON failed

2013-08-29 Thread Jesse Gross
On Thu, Aug 29, 2013 at 3:10 PM, David Miller wrote: > From: Jesse Gross > Date: Thu, 29 Aug 2013 14:42:22 -0700 > >> On Thu, Aug 29, 2013 at 2:21 PM, Geert Uytterhoeven >> wrote: >>> However, I have some doubts about other alignment "enforcements": >>> >>> "__aligned(__alignof__(long))" makes t

Re: [ovs-dev] [-next] openvswitch BUILD_BUG_ON failed

2013-08-29 Thread David Miller
From: Jesse Gross Date: Thu, 29 Aug 2013 14:42:22 -0700 > On Thu, Aug 29, 2013 at 2:21 PM, Geert Uytterhoeven > wrote: >> However, I have some doubts about other alignment "enforcements": >> >> "__aligned(__alignof__(long))" makes the whole struct aligned to the >> alignment rule for "long": >>

Re: [ovs-dev] [-next] openvswitch BUILD_BUG_ON failed

2013-08-29 Thread Jesse Gross
On Thu, Aug 29, 2013 at 2:21 PM, Geert Uytterhoeven wrote: > However, I have some doubts about other alignment "enforcements": > > "__aligned(__alignof__(long))" makes the whole struct aligned to the > alignment rule for "long": >1. This is only 2 bytes on m68k, i.e. != sizeof(long). >2. T

Re: [ovs-dev] [-next] openvswitch BUILD_BUG_ON failed

2013-08-29 Thread Andy Zhou
Yes, fengguan.Wu has reported the issue. Just sent out a patch for review. You are welcome to review it. http://openvswitch.org/pipermail/dev/2013-August/031247.html On Thu, Aug 29, 2013 at 2:21 PM, Geert Uytterhoeven wrote: > On m68k, where the alignment of 32-bit words is 2 bytes: > > net/ope

[ovs-dev] [-next] openvswitch BUILD_BUG_ON failed

2013-08-29 Thread Geert Uytterhoeven
On m68k, where the alignment of 32-bit words is 2 bytes: net/openvswitch/flow.c:1984:2: error: call to '__compiletime_assert_1984' declared with attribute error: BUILD_BUG_ON failed: sizeof(struct sw_flow_key) % sizeof(long) (http://kisskb.ellerman.id.au/kisskb/buildresult/9422860/) This was int