Re: [ovs-dev] [PATCH 5/5] upcall: Remove datapath flows when setting n-threads.

2014-02-25 Thread Zhou, Han
Hi Joe, On Tue, 2014-02-11 at 13:55 -0800, Joe Stringer wrote: > Previously, we would delete all ukeys when changing the number of > threads, but leave all flows in the datapath. This would cause > double-counting of stats for any flows that remain in the datapath. This > patch fixes the issue by

Re: [ovs-dev] [PATCH V2] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-02-18 Thread Zhou, Han
Hi Alex, On Tue, 2014-02-18 at 10:26 -0800, Alex Wang wrote: > Thanks a lot Han for the close review ;D My pleasure :) > > In this function, you separated vport transaction for creating > vports > and setting channel pids to kernel. But it could lead to >

Re: [ovs-dev] [PATCH V2] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-02-12 Thread Zhou, Han
Hi Alex, On Wed, 2014-02-12 at 20:24 -0800, Alex Wang wrote: > > > I'd very much like to get a full review from you. Are you planning to do > that? > > > Also want to ask about your timetable, do you think you could finish review > this week? > Yes, I will try to finish review by this wee

Re: [ovs-dev] [PATCH V2] ofproto-dpif-upcall: Remove the dispatcher thread.

2014-02-12 Thread Zhou, Han
Hi Alex, On Fri, 2014-02-07 at 17:17 -0800, Alex Wang wrote: > This commit removes the 'dispatcher' thread by allowing 'handler' > threads to read upcalls directly from dpif. vport in dpif will > open netlink sockets for each handler and will use the 5-tuple > hash from the missed packet to choos

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: reduce number of wakeup

2013-11-28 Thread Zhou, Han
Hi, On Wed, Sep 25, 2013 at 01:38:58PM +0900, YAMAMOTO Takashi wrote: > if a queue length is long (ie. non-0), the consumer thread should > already be busy working on the queue. there's no need to wake it > up repeatedly. ... > @@ -530,9 +532,13 @@ recv_upcalls(struct udpif *udpif) > ovs