[ovs-dev] [PATCH 1/3] Fix parent_pid on NetBSD

Fix recently introduced parent_pid macro on NetBSD 7.0. On NetBSD, procfs status file looks like the following. n7% cat /proc/$$/status zsh 18509 12970 18509 18509 5,8 ctty,sldr 1476344459,639266 0,15575 0,15575 pause 1000 100,100,0 n7% Signed-off-by: YAMAMOTO Takashi --- tests

[ovs-dev] [PATCH 2/3] ovn.at: Avoid using "printf -v"

It seems like a non-portable bash extension. Signed-off-by: YAMAMOTO Takashi --- tests/ovn.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index caf9f98..da0291f 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -3618,8 +3618,8 @@ test_dhcp

[ovs-dev] [PATCH 3/3] ovn-controller.at: Stop hardcoding a list of iface types

The list of supported iface types hardcoded in the test is wrong on NetBSD. (or any userland-only ports I guess) Instead of adding another case for NetBSD following WIN32, just get the list from ovsdb. Signed-off-by: YAMAMOTO Takashi --- tests/ovn-controller.at | 8 +--- 1 file changed, 1

[ovs-dev] [PATCH] ovn.at: Use = instead of == for test

== is a GNU extension which might not be available. Signed-off-by: YAMAMOTO Takashi --- tests/ovn.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index feb68d3..3436417 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -839,7 +839,7 @@ for is

[ovs-dev] [PATCH] ovs-numa: Fix a compilation error

Fix the following error on NetBSD 7.0. ../lib/ovs-numa.c: In function 'ovs_numa_set_cpu_mask': ../lib/ovs-numa.c:555:9: error: array subscript has type 'char' [-Werror=char-subscripts] Signed-off-by: YAMAMOTO Takashi --- lib/ovs-numa.c | 2 +- 1 file change

[ovs-dev] [PATCH] netdev-native-tnl: Fix a build error on NetBSD 7.0

netinet/ip6.h is not a standalone header there. Signed-off-by: YAMAMOTO Takashi --- lib/netdev-native-tnl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c index 2e181f2..123f3b2 100644 --- a/lib/netdev-native-tnl.c +++ b/lib/netdev-native

[ovs-dev] [PATCH 4/4] utilities: Tweak python shebangs to use env

) Workaround the issue by using env command for shebangs for these scripts. Noticed with the recent tunnel-push-pop.at tests using ovs-pcap command. Signed-off-by: YAMAMOTO Takashi --- utilities/ovs-check-dead-ifs.in | 2 +- utilities/ovs-dpctl-top.in | 2 +- utilities/ovs-l3ping.in

[ovs-dev] [PATCH 3/4] ovn-controller-vtep.at: Pre-sort output before feeding to "sort -d"

NetBSD's "sort -d" preserves the order of lines which doesn't have alphanumeric and blanks. eg. empty lines and []. It means it sometimes preserve unstable order of the list output. Also, simply remove -d option where the expected output doesn't include []. Signed

[ovs-dev] [PATCH 1/4] dpif: Remove a warning

ic warning. But currently it doesn't make much sense as dp_unregister_provider is only used for --enabled-dummy. Signed-off-by: YAMAMOTO Takashi --- lib/dpif.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/dpif.c b/lib/dpif.c index 5037ac6..2abd1e2 100644 --- a/lib/dpif.c +++ b/

[ovs-dev] [PATCH 2/4] ovsdb-server.at: Fix races

As ovsdb-server creates pid file before unixctl socket, waiting for pid file creation is not enough. Fix the race by retrying with "version" command before assuming the server is up. Signed-off-by: YAMAMOTO Takashi --- tests/ovsdb-server.at | 4 1 file changed, 4 insertions(+)

[ovs-dev] [PATCH] util.h: Restore stdarg.h which is necessary for va_list

Fixes a regression in commit b44ff8d826535025f4f8d12808c4ef36a7a8 . ("Misc cleanup with "util.h" header files") Signed-off-by: YAMAMOTO Takashi --- lib/util.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/util.h b/lib/util.h index a908267..f631bdf 100644 --- a/

[ovs-dev] [PATCH 2/4] ovs_strerror, ovs_format_message: Always use "Success" for errno 0

So that testsuite can compare log messages including the string. Signed-off-by: YAMAMOTO Takashi --- lib/util.c | 20 tests/ofproto-macros.at | 1 - 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/lib/util.c b/lib/util.c index f06dee5..36abeed

[ovs-dev] [PATCH 3/4] vlog.at: Avoid using GNU sed extension

. The matching process tries each alternative in turn, from left to right, and the first one that succeeds is used. It is a GNU extension. Signed-off-by: YAMAMOTO Takashi --- tests/vlog.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/vlog.at b/

[ovs-dev] [PATCH 1/4] INSTALL.NetBSD.md: Update for six

Signed-off-by: YAMAMOTO Takashi --- INSTALL.NetBSD.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/INSTALL.NetBSD.md b/INSTALL.NetBSD.md index 1c571cf..5a1f703 100644 --- a/INSTALL.NetBSD.md +++ b/INSTALL.NetBSD.md @@ -8,6 +8,7 @@ In that case, you need at least the

[ovs-dev] [PATCH 4/4] ofproto/trace: Fix "unchanged" output for Final flow

Clear actset_output so that it can be compared via flow_equal. Note: trace->key has actset_output == 0. Found by OVS flow tests under development for Neutron. [1] [1] https://review.openstack.org/#/c/235155/10/neutron/tests/functional/agent/test_ovs_flows.py@399 Signed-off-by: YAMAMOTO Taka

[ovs-dev] [PATCH 3/3] ovn.at: Fix races

These tests are racy as nothing prevents packet re-ordering. Fix them by sorting outputs before comparing. Signed-off-by: YAMAMOTO Takashi --- tests/ovn.at | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index a4dbf96..3a1ae31 100644

[ovs-dev] [PATCH 2/3] ovn.at: Avoid using GNU sed extension

Signed-off-by: YAMAMOTO Takashi --- tests/ovn.at | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index de0a830..a4dbf96 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -566,7 +566,7 @@ ovn-sbctl dump-flows -- list multicast_group # more

[ovs-dev] [PATCH 1/3] ovn.at: Use {} to make this less ambiguous

While (surprisingly to me) bash interprets $10 as ${1}0, many other shells, including NetBSD's /bin/sh, interpret it as ${10}. Signed-off-by: YAMAMOTO Takashi --- tests/ovn.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovn.at b/tests/ovn.at index 68fcc9a..de

[ovs-dev] [PATCH 17/21] ofproto-dpif.at: Workaround a race

Signed-off-by: YAMAMOTO Takashi --- tests/ofproto-dpif.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index f64c56c..b93c8fb 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -844,6 +844,7 @@ AT_CHECK([ovs-ofctl add-flows br0

[ovs-dev] [PATCH 18/21] ofproto.at: Portability improvement

== is a bash dialect. Use = instead. Signed-off-by: YAMAMOTO Takashi --- tests/ofproto.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ofproto.at b/tests/ofproto.at index 4a94f86..e1cb430 100644 --- a/tests/ofproto.at +++ b/tests/ofproto.at @@ -3642,8 +3642,8

[ovs-dev] [PATCH 19/21] ofproto.at: Workaround a race

While a barrier serializes requests from the same connection, it doesn't wait for requests from other connections to the switch. Replace the barrier with infamous "sleep 1" to workaround the problem. Signed-off-by: YAMAMOTO Takashi --- tests/ofproto.at | 3 +-- 1 file changed, 1

[ovs-dev] [PATCH 20/21] ovs-ofctl.at: Fix a comment typo

Signed-off-by: YAMAMOTO Takashi --- tests/ovs-ofctl.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovs-ofctl.at b/tests/ovs-ofctl.at index 798f81a..4dd10cc 100644 --- a/tests/ovs-ofctl.at +++ b/tests/ovs-ofctl.at @@ -2813,7 +2813,7 @@ AT_CLEANUP dnl Check

[ovs-dev] [PATCH 21/21] classifier-private.h: Whitespace in a comment

Signed-off-by: YAMAMOTO Takashi --- lib/classifier-private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/classifier-private.h b/lib/classifier-private.h index f68a7d2..0f8ad1e 100644 --- a/lib/classifier-private.h +++ b/lib/classifier-private.h @@ -75,7 +75,7

[ovs-dev] [PATCH 14/21] vtep-ctl.at: Fix a regex

} is an ordinary character in "basic" regex. Signed-off-by: YAMAMOTO Takashi --- tests/vtep-ctl.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vtep-ctl.at b/tests/vtep-ctl.at index f4a7edf..99e97e8 100644 --- a/tests/vtep-ctl.at +++ b/tests/vtep-ctl.at

[ovs-dev] [PATCH 16/21] ofproto-dpif: Remove a debug log

The message seems stale and it happens on port-mod. Signed-off-by: YAMAMOTO Takashi --- ofproto/ofproto-dpif.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 5cc64cb..7c5e90d 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto

[ovs-dev] [PATCH 15/21] ofproto-dpif.at: Fix a race

Signed-off-by: YAMAMOTO Takashi --- tests/ofproto-dpif.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index bc2daf1..f64c56c 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -7014,6 +7014,7 @@ AT_CHECK([ovs-ofctl add-flow br0

[ovs-dev] [PATCH 13/21] dpif_dummy_override: Allow overriding a non-existing provider

This allows --enable-dummy=system with a userland-only build. It's useful for testsuite. Signed-off-by: YAMAMOTO Takashi --- lib/dpif-netdev.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 47fa9e2..4dcfded 100644

[ovs-dev] [PATCH 09/21] ofproto-macros.at: Rename vconn_windows_sub to vconn_sub

This is a preparation to add non-windows stuff. Signed-off-by: YAMAMOTO Takashi --- tests/ofproto-macros.at | 4 ++-- tests/ofproto.at| 4 ++-- tests/ovs-ofctl.at | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto

[ovs-dev] [PATCH 11/21] use "/usr/bin/env python" for shebangs for python scripts

On NetBSD, a typical path of python interpreter is /usr/pkg/bin/python. Signed-off-by: YAMAMOTO Takashi --- debian/ovs-monitor-ipsec | 2 +- ofproto/ipfix-gen-entities| 2 +- utilities/ovs-dev.py | 2

[ovs-dev] [PATCH 12/21] ovn-controller-vtep.at: Fix a race

Signed-off-by: YAMAMOTO Takashi --- tests/ovn-controller-vtep.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at index 497386c..fd6026f 100644 --- a/tests/ovn-controller-vtep.at +++ b/tests/ovn-controller-vtep.at @@ -113,6 +113,7

[ovs-dev] [PATCH 10/21] ofproto-macros.at: Add another strerror(0) value

On NetBSD, strerror(0) is "Undefined error: 0". Signed-off-by: YAMAMOTO Takashi --- tests/ofproto-macros.at | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index 94d7c86..368dade 100644 --- a/tests/ofproto-macro

[ovs-dev] [PATCH 07/21] completion.at: Improve portability

Signed-off-by: YAMAMOTO Takashi --- tests/completion.at | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/completion.at b/tests/completion.at index 0aca7aa..79093f9 100644 --- a/tests/completion.at +++ b/tests/completion.at @@ -341,7 +341,8 @@ echo "$@"

[ovs-dev] [PATCH 08/21] test-atomic: Bump test duration for multi-thread tests

This makes tests pass on on my single-cpu NetBSD-7 VM. How frequently preemption happens depends on the cpu scheduler. Signed-off-by: YAMAMOTO Takashi --- tests/test-atomic.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/test-atomic.c b/tests/test-atomic.c

[ovs-dev] [PATCH 01/21] extract-odp-netlink-h: Portablitiy improvement

\t is GNU sed extension. Use [[:space:]] instead. Signed-off-by: YAMAMOTO Takashi --- build-aux/extract-odp-netlink-h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/extract-odp-netlink-h b/build-aux/extract-odp-netlink-h index b414330..aafe69a 100755 --- a/build

[ovs-dev] [PATCH 06/21] daemon_switch_user: Improve portablility

NetBSD doesn't have [gs]etres[ug]id. Signed-off-by: YAMAMOTO Takashi --- lib/daemon-unix.c | 40 ++-- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/lib/daemon-unix.c b/lib/daemon-unix.c index 868e2c9..5b01d06 100644 --- a/lib/daemon-u

[ovs-dev] [PATCH 03/21] tnl-arp-cache: Fix NetBSD build

On NetBSD, netinet/icmp6.h has a few pre-requisite headers. Signed-off-by: YAMAMOTO Takashi --- lib/tnl-arp-cache.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/tnl-arp-cache.c b/lib/tnl-arp-cache.c index d456d0c..8a4f303 100644 --- a/lib/tnl-arp-cache.c +++ b/lib/tnl-arp-cache.c

[ovs-dev] [PATCH 05/21] openvswitch.m4: Portability improvement

${parameter/pattern/string} substituion is not portable. Replace them with $SED equivalent. Signed-off-by: YAMAMOTO Takashi --- m4/openvswitch.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4 index d355811..683a6a7 100644 --- a/m4

[ovs-dev] [PATCH 04/21] netdev-bsd: Update after eth_addr changes

Signed-off-by: YAMAMOTO Takashi --- lib/netdev-bsd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 60e5615..118ef32 100644 --- a/lib/netdev-bsd.c +++ b/lib/netdev-bsd.c @@ -1753,7 +1753,7 @@ set_etheraddr(const char *netdev_name

[ovs-dev] [PATCH 02/21] ofp-actions: Define IPPORT_FTP by ourselves

IPPORT_FTP is not always provided by system headers. (eg. NetBSD, OS X) This hides the enum on Linux but I don't think it causes a problem. Signed-off-by: YAMAMOTO Takashi --- lib/ofp-actions.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/ofp-actions.h b/lib/ofp-actions.h

[ovs-dev] [PATCH] Update my email address

Signed-off-by: YAMAMOTO Takashi --- AUTHORS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS b/AUTHORS index a2b40a7..f155105 100644 --- a/AUTHORS +++ b/AUTHORS @@ -179,7 +179,7 @@ Vivien Bernet-Rollande v...@soprive.net Wang Sheng-Hui shh...@gmail.com Wei

Re: [ovs-dev] [PATCH 3/3] extract-ofp-fields: Detect duplicate fields.

if oxm_type in match_types[prefix]: > +fatal("duplicate match type for %s (conflicts with %s)" % > + (name, match_types[prefix][oxm_type])) > +else: > +match_types[prefix] = dict() > +match_types[prefix][oxm_type] = name why don

Re: [ovs-dev] [PATCH 2/3] extract-ofp-fields: Port to python3.

> Mostly "print foo" -> "print(foo)" and "iteritems() -> items()". The > latter may be less efficient in python2, but we're not dealing with > massive numbers of items here so it shouldn't noticably slow the build. >

Re: [ovs-dev] [PATCH 1/3] extract-ofp-fields: Fix most pep8 style issues.

> Signed-off-by: Joe Stringer Acked-by: YAMAMOTO Takashi ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] datapath: Fix check-export-symbol for non-bash shells

> Thx a lot for fixing this~ > > Acked-by: Alex Wang thank you, applied. YAMAMOTO Takashi > > > > On Sun, Apr 26, 2015 at 11:30 PM, YAMAMOTO Takashi > wrote: > >> Avoid using a bash construct (=~) in the target. >> >> An alternative would be

[ovs-dev] [PATCH] OPENFLOW-1.1+.md: Remove stale notes

These specs have already been published. Signed-off-by: YAMAMOTO Takashi --- OPENFLOW-1.1+.md | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/OPENFLOW-1.1+.md b/OPENFLOW-1.1+.md index 7911406..fcbff32 100644 --- a/OPENFLOW-1.1+.md +++ b/OPENFLOW-1.1+.md @@ -209,8 +209,7

[ovs-dev] [PATCH] datapath: Fix check-export-symbol for non-bash shells

ath: Check the export of public functions in linux/compat/linux/.") Signed-off-by: YAMAMOTO Takashi --- datapath/Makefile.am | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/datapath/Makefile.am b/datapath/Makefile.am index 0b0b0bd..a8e9be4 100644 --- a/datapath/Ma

Re: [ovs-dev] [PATCH] dpctl.at: Fix failures on BSDs

> On Fri, Apr 17, 2015 at 12:38:08PM +0900, YAMAMOTO Takashi wrote: >> Unfortunately ENODEV has different string representations >> among platforms. >> >> References: >> >> >> http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/sys/errno.h?rev=1.40&am

Re: [ovs-dev] [PATCH V2] configure.ac: fix pthread linking on FreeBSD

ad_sigmask, a solution is to check > pthread_create. > > Signed-off-by: Kevin Lo Acked-by: YAMAMOTO Takashi > > --- > PATCH -> V2: > - refine the commit message. > > diff --git a/configure.ac b/configure.ac > index d1b48ca..2d893eb 100644 > --- a/config

Re: [ovs-dev] [PATCH 1/2] configure.ac: Avoid using non-ascii characters in a comment

> On Fri, Apr 17, 2015 at 05:29:55PM +0900, YAMAMOTO Takashi wrote: >> Signed-off-by: YAMAMOTO Takashi > > Acked-by: Ben Pfaff applied. thank you. YAMAMOTO Takashi ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] configure: Fix -Werror build for NetBSD + clang

> On Fri, Apr 17, 2015 at 05:29:56PM +0900, YAMAMOTO Takashi wrote: >> On NetBSD, clang (clang-3.5.0 from pkgsrc) complains >> when "clang -g" is used for linking. Specify -Qunused-arguments >> to suppress the warning. >> >> Signed-off-by: YAMAMOTO

[ovs-dev] [PATCH 1/2] configure.ac: Avoid using non-ascii characters in a comment

Signed-off-by: YAMAMOTO Takashi --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index d1b48ca..62d26b0 100644 --- a/configure.ac +++ b/configure.ac @@ -60,7 +60,7 @@ m4_pattern_forbid([LT_INIT]) dnl Make autoconf fail if libtool

[ovs-dev] [PATCH 2/2] configure: Fix -Werror build for NetBSD + clang

On NetBSD, clang (clang-3.5.0 from pkgsrc) complains when "clang -g" is used for linking. Specify -Qunused-arguments to suppress the warning. Signed-off-by: YAMAMOTO Takashi --- acinclude.m4 | 10 +- configure.ac | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) di

[ovs-dev] [PATCH] dpctl.at: Fix failures on BSDs

004&view=markup#l59 https://msdn.microsoft.com/en-us/library/5814770t.aspx Signed-off-by: YAMAMOTO Takashi --- tests/dpctl.at | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/tests/dpctl.at b/tests/dpctl.at index 7921d03..890fa7c 100644 --- a/te

Re: [ovs-dev] [PATCH] netdev-bsd: Fix use of uninitialized data in netdev_bsd_rxq_recv().

Acked-by: YAMAMOTO Takashi > This one I should take care of it. :-) > > Acked-by: Kevin Lo > > On Thu, Apr 16, 2015 at 03:08:17PM -0700, Jarno Rajahalme wrote: >> >> Subject should be corrected, otherwise: >> >> Acked-by: Jarno Rajahalme >>

Re: [ovs-dev] [PATCH] run-ryu: Use the IANA OpenFlow port number

> On Wed, Apr 15, 2015 at 05:55:04PM +0900, YAMAMOTO Takashi wrote: >> Specify the use of the port 6653 for ryu side explicitly >> because it still defaults to port 6633. >> >> Fixes check-ryu after commit d4763d1d4efbbcfd884df2d668980d61ec89d75a. >> ("Use th

[ovs-dev] [PATCH] run-ryu: Use the IANA OpenFlow port number

Specify the use of the port 6653 for ryu side explicitly because it still defaults to port 6633. Fixes check-ryu after commit d4763d1d4efbbcfd884df2d668980d61ec89d75a. ("Use the IANA-assigned ports for OpenFlow and OVSDB.") Signed-off-by: YAMAMOTO Takashi --- tests/run-ryu | 2

Re: [ovs-dev] [PATCH] netdev-bsd: Remove duplicate header inclusion of

> Hi, > > This patch removes duplicate header inclusion of . > > Signed-off-by: Kevin Lo Acked-by: YAMAMOTO Takashi > > --- > diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c > index 9ed2823..541e5ec 100644 > --- a/lib/netdev-bsd.c > +++ b/lib/netdev-bsd.

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

> On Wed, Apr 15, 2015 at 01:07:30PM +0900, YAMAMOTO Takashi wrote: >> > On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the >> > linker flags for linking with a pthread library. >> > Add macro ax_pthread.m4 from GNU autoconf macro archive

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

e.ac b/configure.ac > index 8d47eb9..531a1f0 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -84,6 +84,11 @@ AC_SEARCH_LIBS([timer_create], [rt]) > AC_SEARCH_LIBS([pthread_sigmask], [pthread]) i guess AC_SEARCH_LIBS for potentially-in-libpthread stuffs should be aft

Re: [ovs-dev] [PATCH] ofp-util: Fix length field of bundle messages

ile. thus ofconn_send is not involved. i'll add ofpmsg_update_length calls in my code for now. YAMAMOTO Takashi [1] https://github.com/osrg/ryu/tree/master/ryu/tests/packet_data_generator2 > Yamamoto, > > ofconn_send(), which will eventually be called for these, already does > of

Re: [ovs-dev] [PATCH] specify -w to set variables for sysctl(8) on NetBSD

> We have to specify -w to set tunable sysctls on NetBSD. > > Signed-off-by: Kevin Lo Acked-by: YAMAMOTO Takashi > --- > > diff --git a/INSTALL.userspace.md b/INSTALL.userspace.md > index 300d6c1..04c02cd 100644 > --- a/INSTALL.userspace.md > +++ b/INSTALL.us

[ovs-dev] [PATCH] ofp-util: Fix length field of bundle messages

Signed-off-by: YAMAMOTO Takashi --- lib/ofp-util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index a0da289..7035c8c 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -8760,6 +8760,7 @@ ofputil_encode_bundle_ctrl_reply(const struct ofp_header *oh

Re: [ovs-dev] [PATCH] ovs-ofctl: batch together OFPC_ADD requests in add-flows command

y > helpful when restarting ovs-vswitchd. > > One possible side effect of this patch is that ovs-ofctl > might ignore some error messages that resulted in failed > OFPC_ADD. this seems like a semantic change in cases where the order of requests matter, right? hav

Re: [ovs-dev] [PATCH 1/2] netdev-bsd: Fix a compilation error

> On Wed, Mar 04, 2015 at 03:00:54PM +0900, YAMAMOTO Takashi wrote: >> Fix a compilation problem introduced by >> commit cf62fa4c7074121184a1f1d07980990113657612 >> ("dp-packet: Remove ofpbuf dependency.") >> >> Signed-off-by: YAMAMOTO Takashi >

Re: [ovs-dev] [PATCH 2/2] dp-packet.h: Fix a typo in #endif comment

> On Wed, Mar 04, 2015 at 03:00:55PM +0900, YAMAMOTO Takashi wrote: >> Signed-off-by: YAMAMOTO Takashi > > Acked-by: Ben Pfaff thank you. applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 2/2] dp-packet.h: Fix a typo in #endif comment

Signed-off-by: YAMAMOTO Takashi --- lib/dp-packet.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index d754984..9cae74d 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -477,4 +477,4 @@ static inline void dp_packet_set_dp_hash(struct

[ovs-dev] [PATCH 1/2] netdev-bsd: Fix a compilation error

Fix a compilation problem introduced by commit cf62fa4c7074121184a1f1d07980990113657612 ("dp-packet: Remove ofpbuf dependency.") Signed-off-by: YAMAMOTO Takashi --- lib/netdev-bsd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 7dfff1

Re: [ovs-dev] [PATCH] vlog: Fix "/dev/log" test

> On Sun, Feb 1, 2015 at 9:18 PM, YAMAMOTO Takashi > wrote: >> commit 7905aae3fc1633c2c44c8fdb9e9d3a3d6e63439b >> ("vlog: Don't fail syslog initialization in chroot.") >> uses os.path.isfile("/dev/log"), which tests if the given path >

[ovs-dev] [PATCH] vlog: Fix "/dev/log" test

rms I looked at. * On Ubuntu 14.04 and CentOS 6.5, /dev/log is a socket * On NetBSD-6, /dev/log is a symlink to a socket Replace the test with os.path.exists() so that it can work as intended for these platforms. Signed-off-by: YAMAMOTO Takashi --- python/ovs/vlog.py | 2 +- 1 file changed, 1

Re: [ovs-dev] OVN architecture

> On Thu, Jan 15, 2015 at 10:38:45AM +0900, YAMAMOTO Takashi wrote: >> > ovn-controller >> > -- >> >> neutron "ofagent" agent has a similar design to ovn-controller. >> you might be able to reuse at least some of code if python+ryu >

Re: [ovs-dev] OVN architecture

midonet uses zookeeper (and cassandra) for similar purposes. we might want to learn from there. http://lists.midonet.org/pipermail/midonet-dev/2015-January/000280.html YAMAMOTO Takashi ___ dev mailing list dev@openvswitch.org http://o

Re: [ovs-dev] [PATCH] ovs-numa.h: Add a missing OVS_UNUSED

> On Wed, Jan 14, 2015 at 12:18:26PM +0900, YAMAMOTO Takashi wrote: >> Suppress the following warning: >> >> > cc1: warnings being treated as errors >> > In file included from ../lib/dpif.h:394:0, >> > from ../lib/netdev

[ovs-dev] [PATCH] ovs-numa.h: Add a missing OVS_UNUSED

parameter 'numa_id' The problem was introduced by commit 9da2564e2bfa4ffc5a05552630ce2aca00a521c9. ("ovs-numa: Refine the module.") Signed-off-by: YAMAMOTO Takashi --- lib/ovs-numa.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ovs-numa.h b/lib/ovs-numa.

Re: [ovs-dev] [PATCH 2/2] route-table-bsd: Retry logic

> On Wed, Dec 17, 2014 at 08:59:57AM +0900, YAMAMOTO Takashi wrote: >> Retry routing requests as the routing socket is unreliable. >> >> Also, add some error checks and logs. >> >> Signed-off-by: YAMAMOTO Takashi > > Seems reasonable to me. > &

Re: [ovs-dev] [PATCH] ofproto-dpif.at: Avoid using GNU sed extensions

> Hey Yamamoto, > > Thx for the fix, so sorry for not being careful about this... > > Acked-by: Alex Wang thank you. applied. YAMAMOTO Takashi ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] ofproto-dpif.at: Avoid using GNU sed extensions

Introduced by commit f9038ef61e0bf89bcd753b7cfd187adb112601ec. ("recirculation: Map recirc_id to ofproto_dpif.") Signed-off-by: YAMAMOTO Takashi --- tests/ofproto-dpif.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpi

Re: [ovs-dev] [RFC recirc-fix] recirculation: Do not change handling of packets after recirculation.

;recirc_id' could work, but it is not > necessary. So, we just go for this way and have a map, i agree it would work for bond. however, for non-bond cases, we need to restore the correct in_port. (the port in recirc_ofproto) YAMAMOTO Takashi > > I'm sending of a new RFC patch so

Re: [ovs-dev] [RFC recirc-fix] recirculation: Do not change handling of packets after recirculation.

i agree on all points. YAMAMOTO Takashi > Yes, I agree we need to encode (bridge, ofp_port). recirc_id (the > upper 16 bit part) is globally unique, so bridge can be recovered by > maintaining recirc_id ->bridge mapping in the user space. > > I agree odp_port could be use

Re: [ovs-dev] [RFC recirc-fix] recirculation: Do not change handling of packets after recirculation.

i agree that the suggested patch was too bond specific. ofp port number is not enough. you need to encode (bridge, ofp_port) pair in some way. it's why i suggested to assign odp port numbers to every pseudo ports. YAMAMOTO Takashi > This is probably obvious: the bond internal flows no

Re: [ovs-dev] [PATCH 1/2] route-table-bsd: Update vlog.h inclusion

> On 12/17/14 at 08:59am, YAMAMOTO Takashi wrote: >> This fixes a build failure introduced by the recent vlog change >> commit e6211adce42c28453e0004c7a3e342a3d52bb97d. >> ("lib: Move vlog.h to ") >> >> Signed-off-by: YAMAMOTO Takashi > > Acked

Re: [ovs-dev] [branch-2.3 V2] recirculation: Do not drop packet when there is no match from internal table.

y, the vlan is set before recirc action, >> the recirc'ed flow will have a vlan id which could lead to totally >> different handling result, >> >> We will discuss further and address it, >> >> Thanks, >> Alex Wang, >> >> On Tue, Dec 16, 2014 a

Re: [ovs-dev] [branch-2.3 V2] recirculation: Do not drop packet when there is no match from internal table.

hi, > Hey Yamamoto, > > >> what will happen if the receiving bridge also has a bond port? >> >> YAMAMOTO Takashi >> > > > For each 'balance-tcp' bond, it will have a unique 'recirc_id'. > > If the receiving bridge has a &

[ovs-dev] [PATCH 2/2] route-table-bsd: Retry logic

Retry routing requests as the routing socket is unreliable. Also, add some error checks and logs. Signed-off-by: YAMAMOTO Takashi --- lib/route-table-bsd.c | 60 --- 1 file changed, 52 insertions(+), 8 deletions(-) diff --git a/lib/route-table

[ovs-dev] [PATCH 1/2] route-table-bsd: Update vlog.h inclusion

This fixes a build failure introduced by the recent vlog change commit e6211adce42c28453e0004c7a3e342a3d52bb97d. ("lib: Move vlog.h to ") Signed-off-by: YAMAMOTO Takashi --- lib/route-table-bsd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/route-table-b

Re: [ovs-dev] [branch-2.3 V2] recirculation: Do not drop packet when there is no match from internal table.

> (with 'recirc_id' set) in default table (table 0) and processing > it until reaching the bridge that owns the bond port. Then, > the misses can hit the post recirculation flows as expected. what will happen if the receiving bridge also has a bond port? YAMAMOTO Takashi

Re: [ovs-dev] [PATCH 3/5] ovs-router: Add "ovs/route/lookup" command

> On Tue, Dec 9, 2014 at 8:35 PM, YAMAMOTO Takashi > wrote: >>> On Wed, Dec 3, 2014 at 2:31 AM, YAMAMOTO Takashi >>> wrote: >>>> This command is useful at least for testing. >>>> >>>> Example output: >>>> % ovs-appct

Re: [ovs-dev] [PATCH 00/10] Expose vlog and vconn in public headers

> On 12/10/14 at 01:29pm, YAMAMOTO Takashi wrote: >> > This series exposes the vlog and vconn API plus all required dependencies. >> > The vconn is only partially usable at this point because ofpbuf cannot >> > be exposed in its current state. A next series will st

Re: [ovs-dev] [PATCH 1/5] route-table-bsd: Stop caching pid

> On Wed, Dec 03, 2014 at 07:31:32PM +0900, YAMAMOTO Takashi wrote: >> The cache here doesn't work anymore as the recent >> commit b772066ffd066d59d9ebce092f6665150723d2ad >> ("route-table: Remove Unregister.") >> made this function called before

Re: [ovs-dev] [PATCH 2/5] ovs-router: non-Linux support

> On Wed, Dec 3, 2014 at 2:31 AM, YAMAMOTO Takashi > wrote: >> Refactor ovs-router so that it can work with non-Linux platforms >> at least in some extent, using the existing route-table code as >> a fallback. Known restriction: for such platforms, "ovs/router/s

Re: [ovs-dev] [PATCH 4/5] route-table-bsd: Provide gateway info

> On Wed, Dec 03, 2014 at 07:31:35PM +0900, YAMAMOTO Takashi wrote: >> For userspace tunneling. >> >> Signed-off-by: YAMAMOTO Takashi > > Acked-by: Ben Pfaff thank you. applied. YAMAMOTO Takashi ___ dev mailing li

Re: [ovs-dev] [PATCH 5/5] route-table-bsd: Add some DBG logs

> On Wed, Dec 03, 2014 at 07:31:36PM +0900, YAMAMOTO Takashi wrote: >> Signed-off-by: YAMAMOTO Takashi > > Acked-by: Ben Pfaff thank you. applied. YAMAMOTO Takashi ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/5] ovs-router: Add "ovs/route/lookup" command

> On Wed, Dec 3, 2014 at 2:31 AM, YAMAMOTO Takashi > wrote: >> This command is useful at least for testing. >> >> Example output: >> % ovs-appctl ovs/route/lookup '10.0.0.1' >> gateway 172.17.0.254 >> dev wm0 >> %

Re: [ovs-dev] [PATCH 00/10] Expose vlog and vconn in public headers

> This series exposes the vlog and vconn API plus all required dependencies. > The vconn is only partially usable at this point because ofpbuf cannot > be exposed in its current state. A next series will start refactoring of > ofpbuf. can you explain your motivation briefly? YAMA

Re: [ovs-dev] [PATCH] ofp-actions: Only set defined bits when encoding "load" actions.

the top 12 bits). > > This commit fixes the problem by omitting invalid bits when encoding a > reg_load action. > > Reported-by: Pravin Shelar > Signed-off-by: Ben Pfaff Acked-by: YAMAMOTO Takashi ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 4/5] route-table-bsd: Provide gateway info

For userspace tunneling. Signed-off-by: YAMAMOTO Takashi --- lib/route-table-bsd.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/route-table-bsd.c b/lib/route-table-bsd.c index 09f9894..d40dd7e 100644 --- a/lib/route-table-bsd.c +++ b/lib/route-table-bsd.c

[ovs-dev] [PATCH 2/5] ovs-router: non-Linux support

Refactor ovs-router so that it can work with non-Linux platforms at least in some extent, using the existing route-table code as a fallback. Known restriction: for such platforms, "ovs/router/show" command does not show "Cached" kernel routes. Signed-off-by: YAMAMOTO Takashi

[ovs-dev] [PATCH 1/5] route-table-bsd: Stop caching pid

The cache here doesn't work anymore as the recent commit b772066ffd066d59d9ebce092f6665150723d2ad ("route-table: Remove Unregister.") made this function called before daemonizing, thus with a different pid. Signed-off-by: YAMAMOTO Takashi --- lib/route-table-bsd.c | 4 +--- 1

[ovs-dev] [PATCH 5/5] route-table-bsd: Add some DBG logs

Signed-off-by: YAMAMOTO Takashi --- lib/route-table-bsd.c | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/route-table-bsd.c b/lib/route-table-bsd.c index d40dd7e..709c9f3 100644 --- a/lib/route-table-bsd.c +++ b/lib/route-table-bsd.c @@ -30,8 +30,12 @@ #include

[ovs-dev] [PATCH 3/5] ovs-router: Add "ovs/route/lookup" command

This command is useful at least for testing. Example output: % ovs-appctl ovs/route/lookup '10.0.0.1' gateway 172.17.0.254 dev wm0 % Signed-off-by: YAMAMOTO Takashi --- lib/ovs-router.c | 27 +++ 1 file changed, 27 insertions(+) diff --git

Re: [ovs-dev] [PATCH v2] route-table: Remove Unregister.

> Since dpif registering for routing table at initialization > there is no need to unregister it. Following patch removes > support for turning routing table notifications on and off. > Due to this change OVS always listens for these > notifications. > > Reported-by: YAMAM

  1   2   3   4   5   6   >