On 7/15/16 9:08 AM, Xiao Liang wrote:
Thanks a lot. Please see inline.
On Fri, Jul 15, 2016 at 7:17 PM, Thomas F Herbert
wrote:
On 7/2/16 10:17 AM, Xiao Liang wrote:
Hi Tom,
Thanks for your test and comments! Please see inline.
On Sat, Jul 2, 2016 at 1:34 AM, Thomas F Herbert
wrote:
Xiao
On 7/15/16 9:09 AM, Xiao Liang wrote:
On Fri, Jul 15, 2016 at 8:08 PM, Thomas F Herbert
wrote:
Eric and Xiao, I am cc'ing this to the ovs-dev list because other reviewers
who reviewed the kernel module may want to weigh in.
--TFH
On 7/12/16 2:17 PM, Eric Garver wrote:
This looks okay
On 7/15/16 9:10 AM, Xiao Liang wrote:
On Fri, Jul 15, 2016 at 8:15 PM, Thomas F Herbert
wrote:
On 7/12/16 11:38 AM, Xiao Liang wrote:
When QinQ is supported, ingress VLAN are kept after push_vlan actions,
so we should expect two VLAN headers.
Am I reading this wrong but it looks like the
On 7/15/16 9:18 AM, Xiao Liang wrote:
On Fri, Jul 15, 2016 at 8:20 PM, Thomas F Herbert
wrote:
On 7/12/16 11:38 AM, Xiao Liang wrote:
Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX
Signed-off-by: Xiao Liang
---
lib/dpif-netdev.c | 1 +
tests/test-odp.c | 1 +
2
On 7/12/16 11:38 AM, Xiao Liang wrote:
Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX
Signed-off-by: Xiao Liang
---
lib/dpif-netdev.c | 1 +
tests/test-odp.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 26cfaff..13c
On 7/12/16 11:38 AM, Xiao Liang wrote:
When QinQ is supported, ingress VLAN are kept after push_vlan actions,
so we should expect two VLAN headers.
Am I reading this wrong but it looks like the 0x8847 mpls type was
dropped from the test packet below?
Signed-off-by: Xiao Liang
---
tests/ofp
Eric and Xiao, I am cc'ing this to the ovs-dev list because other
reviewers who reviewed the kernel module may want to weigh in.
--TFH
On 7/12/16 2:17 PM, Eric Garver wrote:
This looks okay to me. This function was definitely missing a call to
parse_flow_mask_nlattrs() for the masked case. My
On 7/2/16 10:17 AM, Xiao Liang wrote:
Hi Tom,
Thanks for your test and comments! Please see inline.
On Sat, Jul 2, 2016 at 1:34 AM, Thomas F Herbert
wrote:
Xiao,
Thanks. I think this is nice work and I think it advances the ball.
It needs to be rebased to latest. I got some fuzz applying
rsa. This is
regardless whether ovs supports MD type 2 or not. They're just a
different protocol.
In my opinion, starting with MD type 1 is a good way to reduce the
initial scope. I see no problem with adding MD type 2 later.
+1
Jiri
--
*Thomas F Herbert*
SDN Group
Office of Technology
On 5/9/16 2:32 AM, Bhanuprakash Bodireddy wrote:
Refactor the INSTALL.DPDK in to two documents named INSTALL.DPDK and
INSTALL.DPDK-ADVANCED. While INSTALL.DPDK document shall facilitate the
novice user in setting up the OVS DPDK and running it out of box, the
ADVANCED document is targeted at expe
On 5/13/16 11:55 AM, Aaron Conole wrote:
Bhanuprakash Bodireddy writes:
Refactor the INSTALL.DPDK in to two documents named INSTALL.DPDK and
INSTALL.DPDK-ADVANCED. While INSTALL.DPDK document shall facilitate the
novice user in setting up the OVS DPDK and running it out of box, the
ADVANCED do
On 5/9/16 2:32 AM, Bhanuprakash Bodireddy wrote:
Add INSTALL.DPDK-ADVANCED document that is forked off from original
INSTALL.DPDK guide. This document is targeted at users looking for
optimum performance on OVS using dpdk datapath.
Thanks for this effort.
Signed-off-by: Bhanuprakash Bodireddy
On 5/9/16 2:32 AM, Bhanuprakash Bodireddy wrote:
Refactor the INSTALL.DPDK in to two documents named INSTALL.DPDK and
INSTALL.DPDK-ADVANCED. While INSTALL.DPDK document shall facilitate the
novice user in setting up the OVS DPDK and running it out of box, the
ADVANCED document is targeted at expe
On 5/9/16 2:32 AM, Bhanuprakash Bodireddy wrote:
This patchset refactors the present INSTALL.DPDK.md guide.
The INSTALL guide is split in to two documents named INSTALL.DPDK and
INSTALL.DPDK-ADVANCED. The former document is simplified with emphasis
on installation, basic testcases and targets no
On 12/14/15 6:42 AM, Gray, Mark D wrote:
-Original Message-
From: Panu Matilainen [mailto:pmati...@redhat.com]
Sent: Tuesday, December 8, 2015 12:05 PM
To: Gray, Mark D; d...@dpdk.org; us...@dpdk.org; dev@openvswitch.org;
disc...@openvswitch.org
Subject: Re: [ovs-discuss] [announce] dri
On 1/29/16 12:43 PM, Russell Bryant wrote:
On 01/29/2016 12:04 PM, Thomas F Herbert wrote:
On 1/28/16 3:46 PM, Russell Bryant wrote:
On 01/28/2016 02:55 PM, Russell Bryant wrote:
On 01/28/2016 12:56 PM, Guru Shetty wrote:
On 28 January 2016 at 08:46, Russell Bryant mailto:russ...@ovn.org
On 1/28/16 3:46 PM, Russell Bryant wrote:
On 01/28/2016 02:55 PM, Russell Bryant wrote:
On 01/28/2016 12:56 PM, Guru Shetty wrote:
On 28 January 2016 at 08:46, Russell Bryant mailto:russ...@ovn.org>> wrote:
The rpm build instructions did not clarify what spec files were to be
used
e Open vSwitch kernel module, copy
rhel/openvswitch-kmod.files into the RPM sources directory and run:
"""
On 28 January 2016 at 07:58, Thomas F Herbert
mailto:thomasfherb...@gmail.com>> wrote:
On 1/28/16 10:27 AM, Guru Shetty wrote:
On 28 January 2016 at 05:4
may address this issue
for now.
"""
On RHEL 6, to build the Open vSwitch kernel module, copy
rhel/openvswitch-kmod.files into the RPM sources directory and run:
"""
On 28 January 2016 at 07:58, Thomas F Herbert
mailto:thomasfherb...@gmail.com>> wrote:
On 1/28/16 10:27 AM, Guru Shetty wrote:
On 28 January 2016 at 05:48, Thomas F Herbert
mailto:thomasfherb...@gmail.com>> wrote:
Signed-off-by: Thomas F Herbert mailto:thomasfherb...@gmail.com>>
The changes that this commit reverts were initially added as par
On 1/28/16 9:54 AM, Russell Bryant wrote:
On 01/28/2016 08:48 AM, Thomas F Herbert wrote:
In the process of building RPM's in OVS-OPNFV project, it was discovered that
the
Rhel spec file for building the kernel module RPM was broken in such a way to
break
depmod on kernel module ins
Signed-off-by: Thomas F Herbert
---
rhel/openvswitch-kmod-rhel6.spec.in | 2 --
rhel/openvswitch-kmod.files | 3 ---
2 files changed, 5 deletions(-)
delete mode 100644 rhel/openvswitch-kmod.files
diff --git a/rhel/openvswitch-kmod-rhel6.spec.in
b/rhel/openvswitch-kmod-rhel6.spec.in
tos 7
Thomas F Herbert (1):
Fix RHEL Spec file for kmod RPM install.
rhel/openvswitch-kmod-rhel6.spec.in | 2 --
rhel/openvswitch-kmod.files | 3 ---
2 files changed, 5 deletions(-)
delete mode 100644 rhel/openvswitch-kmod.files
--
2.5.0
__
On 12/14/15 6:42 AM, Gray, Mark D wrote:
-Original Message-
From: Panu Matilainen [mailto:pmati...@redhat.com]
Sent: Tuesday, December 8, 2015 12:05 PM
To: Gray, Mark D; d...@dpdk.org; us...@dpdk.org; dev@openvswitch.org;
disc...@openvswitch.org
Subject: Re: [ovs-discuss] [announce] dri
On 11/25/15 11:54 AM, Flavio Leitner wrote:
Hi,
In order to build the Fedora RPM with DPDK some changes to the
spec file are required. However, I was told that not all users
want to build with DPDK or even have the DPDK libs installed. It
seems a fair request if you are working with OVS only.
On 11/25/15 12:54 AM, Ben Pfaff wrote:
On Mon, Nov 09, 2015 at 08:30:19PM -0800, Thomas F Herbert wrote:
On 11/9/15 12:58 PM, Ben Pfaff wrote:
On Fri, Oct 02, 2015 at 05:31:58PM -0400, Thomas F Herbert wrote:
From: "Thomas F. Herbert"
ToDo: The flow structure needs to be updat
On 9/30/15 5:47 AM, mengke wrote:
This patch adds a new type port ("eth_nsh" type) for Ethernet NSH, add related
decapsulation and encapsulation implementation at data plane level in user
space and modify the related codes at control plane level in user space.
When vport of Ethernet-NSH-Netdev r
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux
adjustment added for double tagged vlans.
Signed-off-by: Thomas F Herbert
---
net/openvswitch/actions.c | 6 +-
net/openvswitch/flow.c | 76 ++
net/openvswitch/flow.h | 8 +-
net/openvswitch/flow_netlink.c | 233 ++---
net
This is to simplify using double tagged vlans. This function allows all
valid vlan ethertypes to be checked in a single function call.
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/linux/if_vlan.h b
ing list,
openvswitch.org/pipermail/dev/..
Thomas F Herbert (3):
openvswitch: 802.1ad uapi changes.
Check for vlan ethernet types for 8021.q or 802.1ad
802.1AD: Flow handling, actions, vlan parsing and netlink attributes
include/linux/if_vlan.h | 16 +++
include/uapi/linux/ope
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap attributes to represent double
tagged vlan. Inner TPID encoded along with ctci in nested attributes.
Signed-off-by: Thomas F
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux
This is to simplify using double tagged vlans. This function allows all
valid vlan ethertypes to be checked in a single function call.
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/linux/if_vlan.h b
h and the user code patch see the OVS dev mailing list,
openvswitch.org/pipermail/dev/..
Thomas F Herbert (3):
openvswitch: 802.1ad uapi changes.
Check for vlan ethernet types for 8021.q or 802.1ad
802.1AD: Flow handling, actions, vlan parsing and netlink attributes
include/linux
Pravin, please look at comment inline below:
On 10/27/15 1:22 PM, Pravin Shelar wrote:
On Tue, Oct 27, 2015 at 9:45 AM, Thomas F Herbert
wrote:
On 10/26/15 10:10 PM, Pravin Shelar wrote:
Thanks for the review.
On Sun, Oct 25, 2015 at 5:11 PM, Thomas F Herbert
wrote:
Add support for 802.1ad
On 10/26/15 10:10 PM, Pravin Shelar wrote:
Thanks for the review.
On Sun, Oct 25, 2015 at 5:11 PM, Thomas F Herbert
wrote:
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap
On 10/26/15 8:14 AM, Albino B Neto wrote:
2015-10-25 22:11 GMT-02:00 Thomas F Herbert :
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 67ce5bd..d2494b5
encoded in the flow key.
Signed-off-by: Thomas F Herbert
---
net/openvswitch/actions.c | 6 +-
net/openvswitch/flow.c | 76
net/openvswitch/flow.h | 8 +-
net/openvswitch/flow_netlink.c | 199 +
net/openvswitch/vport
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 67ce5bd..d2494b5 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,6 +627,22
anges suggested by reviewers
V6: Rebased to net-next
V5: Use encapsulated attributes
For discussion, history and previous versions of the kernel module
patch and the user code patch see the OVS dev mailing list,
openvswitch.org/pipermail/dev/..
Thomas F Herbert (3):
openvswitch: 802.1ad
On 10/23/15 3:26 PM, Pravin Shelar wrote:
On Wed, Oct 21, 2015 at 7:39 AM, Thomas F Herbert wrote:
On 10/20/15 4:34 PM, Pravin Shelar wrote:
On Tue, Oct 20, 2015 at 7:26 AM, Thomas F Herbert
wrote:
On 10/19/15 2:28 PM, Pravin Shelar wrote:
On Sat, Oct 17, 2015 at 6:12 PM, Thomas F
On 10/20/15 4:34 PM, Pravin Shelar wrote:
On Tue, Oct 20, 2015 at 7:26 AM, Thomas F Herbert
wrote:
On 10/19/15 2:28 PM, Pravin Shelar wrote:
On Sat, Oct 17, 2015 at 6:12 PM, Thomas F Herbert
wrote:
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add
On 10/19/15 2:28 PM, Pravin Shelar wrote:
On Sat, Oct 17, 2015 at 6:12 PM, Thomas F Herbert
wrote:
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap attributes to represent
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 67ce5bd..d2494b5 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,6 +627,22
s
V6: Rebased to net-next
V5: Use encapsulated attributes
For discussion, history and previous versions of the kernel module
patch and the user code patch see the OVS dev mailing list,
openvswitch.org/pipermail/dev/..
Thomas F Herbert (3):
openvswitch: 802.1ad uapi changes.
Check for
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap attributes to represent double
tagged vlan. Inner TPID encoded along with ctci in nested attributes.
Signed-off-by: Thomas F
On 10/16/15 2:16 AM, David Miller wrote:
From: Thomas F Herbert
Date: Thu, 15 Oct 2015 10:01:52 -0400
This patch accompanies version 14 of the user level openvswitch patch
submitted to openvswitch dev list.
V16,15: Implement reviewer comments.
Missing signoffs, missed handling of
On 10/15/15 8:37 PM, Pravin Shelar wrote:
On Thu, Oct 15, 2015 at 4:48 PM, Thomas F Herbert
wrote:
On 10/15/15 7:02 PM, Pravin Shelar wrote:
Thanks for the review. See my comment below.
--TFH
On Thu, Oct 15, 2015 at 7:01 AM, Thomas F Herbert
wrote:
Add support for 802.1ad including the
On 10/15/15 7:02 PM, Pravin Shelar wrote:
Thanks for the review. See my comment below.
--TFH
On Thu, Oct 15, 2015 at 7:01 AM, Thomas F Herbert
wrote:
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
---
include/linux/if_vlan.h | 16
1 file changed, 16 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 67ce5bd..ac23521 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,6 +627,22 @@ static inline netdev_features_t vlan_fe
/..
Thomas F Herbert (3):
openvswitch: 802.1ad uapi changes.
Check for vlan ethernet types for 8021.q or 802.1ad
802.1AD: Flow handling, actions, vlan parsing and netlink attributes
include/linux/if_vlan.h | 16
include/uapi/linux/openvswitch.h | 17 ++--
net/openvswitch
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap attributes to represent double
tagged vlan. Inner TPID encoded along with ctci in nested attributes.
Signed-off-by: Thomas F
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux
On 10/13/15 2:14 PM, Pravin Shelar wrote:
On Tue, Oct 13, 2015 at 10:39 AM, Thomas F Herbert
wrote:
Pravin,
Thanks for the review.
On 10/13/15 7:47 AM, Pravin Shelar wrote:
On Sat, Oct 10, 2015 at 4:40 PM, Thomas F Herbert
wrote:
Add support for 802.1ad including the ability to push
Pravin,
Thanks for the review.
On 10/13/15 7:47 AM, Pravin Shelar wrote:
On Sat, Oct 10, 2015 at 4:40 PM, Thomas F Herbert
wrote:
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double
On 10/13/15 3:58 AM, David Miller wrote:
From: Thomas F Herbert
Date: Sat, 10 Oct 2015 19:40:30 -0400
Thomas F Herbert (3):
openvswitch: 802.1ad uapi changes.
Check for vlan ethernet types for 8021.q or 802.1ad
802.1AD: Flow handling, actions, vlan parsing and netlink attributes
I
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux
Thomas F Herbert (3):
openvswitch: 802.1ad uapi changes.
Check for vlan ethernet types for 8021.q or 802.1ad
802.1AD: Flow handling, actions, vlan parsing and netlink attributes
include/linux/if_vlan.h | 17
include/uapi/linux/openvswitch.h | 17 ++--
net/openvswitch
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 67ce5bd..88d1be4 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,6 +627,23
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap attributes to represent double
tagged vlan. Inner TPID encoded along with ctci in nested attributes.
Signed-off-by: Thomas F
On 9/30/15 11:33 PM, Thomas F Herbert wrote:
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap attributes to represent double
tagged vlan. Inner TPID encoded along with ctci
From: "Thomas F. Herbert"
This patch adds tests of the user space actions for 802.1q and 802.1ad.
Signed-off-by: Thomas F Herbert
Signed-off-by: Dave Benson
---
tests/ofproto-dpif.at | 40
1 file changed, 40 insertions(+)
diff --git a/tes
From: "Thomas F. Herbert"
ToDo: The flow structure needs to be updated to hold both the inner and outer
tpid since these are encoded by the kernel module.
The flow structure is updated to hold the customer tci.
Flow key extraction is changed to add support for ctci and both TPIDs.
From: "Thomas F. Herbert"
Netlink parsing and flow key conversion. Netlink attribute encoding is done
with double encap attributes. Netlink attributes for 802.1ad look like
the following:
eth_type(0x88a8),vlan(vid=100),encap(eth_type(0x8100), vlan(vid=200),
enca
From: "Thomas F. Herbert"
Signed-off-by: Thomas F Herbert
---
NEWS | 2 ++
utilities/ovs-ofctl.8.in | 3 +--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index ca22c8e..abfa32e 100644
--- a/NEWS
+++ b/NEWS
@@ -25,6 +25,8 @@ P
From: "Thomas F. Herbert"
This series requires the 802.1ad kernel patch V14 recently submitted to
net-next.
The kernel changes for conntrak need to be backported to OVS for
this patch to work without errors so user space and kernel are compiled
with the same uapi openvswitch.h.
ToDo
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap attributes to represent double
tagged vlan. Inner TPID encoded along with ctci in nested attributes.
Signed-off-by: Thomas F
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 67ce5bd..88d1be4 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,6 +627,23
attributes
For discussion, history and previous versions of the kernel module
patch and the user code patch see the OVS dev mailing list,
openvswitch.org/pipermail/dev/..
Thomas F Herbert (3):
openvswitch: 802.1ad uapi changes.
Check for vlan ethernet types for 8021.q or 802.1ad
802.1AD: Flow
On 9/25/15 1:56 PM, Joe Stringer wrote:
On 25 September 2015 at 05:10, Thomas F Herbert
wrote:
On 9/24/15 7:43 PM, Pravin Shelar wrote:
On Thu, Sep 24, 2015 at 11:25 AM, Thomas F Herbert
wrote:
Pravin,
I am you hoping you can take a look at a potential problem with my kernel
module patch
On 9/29/15 6:56 PM, Pravin Shelar wrote:
On Fri, Sep 25, 2015 at 3:35 PM, Thomas F Herbert
wrote:
Pravin,
Another comment and question. Please seen inline below.
Thanks,
--Tom
On 9/24/15 7:42 PM, Pravin Shelar wrote:
On Thu, Sep 24, 2015 at 10:58 AM, Thomas F Herbert
wrote:
Add support
Pravin,
Another comment and question. Please seen inline below.
Thanks,
--Tom
On 9/24/15 7:42 PM, Pravin Shelar wrote:
On Thu, Sep 24, 2015 at 10:58 AM, Thomas F Herbert
wrote:
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to
Pravin,
Thanks for the review,
Comments in line below.
--TFH
On 9/24/15 7:42 PM, Pravin Shelar wrote:
On Thu, Sep 24, 2015 at 10:58 AM, Thomas F Herbert
wrote:
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and
On 9/24/15 7:43 PM, Pravin Shelar wrote:
On Thu, Sep 24, 2015 at 11:25 AM, Thomas F Herbert
wrote:
Pravin,
I am you hoping you can take a look at a potential problem with my kernel
module patch submitted to net-dev today. I decided to submit it anyway
because that is the best way to get eyes
st=192.168.1.2,proto=1,tos=0,ttl=64,frag=no),icmp(type=0,code=0)))
Thanks in advance,
Tom Herbert
Red Hat
Forwarded Message
Subject: [PATCH 3/3] 802.1AD: Flow handling, actions, vlan parsing and
netlink attributes
Date: Thu, 24 Sep 2015 13:58:18 -0400
From: Thoma
openvswitch: Add support for 8021.AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux
Add support for 802.1ad including the ability to push and pop double
tagged vlans. Add support for 802.1ad to netlink parsing and flow
conversion. Uses double nested encap attributes to represent double
tagged vlan. Inner TPID encoded along with ctci in nested attributes.
Signed-off-by: Thomas F
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 67ce5bd..88d1be4 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,6 +627,23
user code patch see the OVS dev mailing list,
openvswitch.org/pipermail/dev/..
Thomas F Herbert (3):
openvswitch: 802.1ad uapi changes.
Check for vlan ethernet types for 8021.q or 802.1ad
802.1AD: Flow handling, actions, vlan parsing and netlink attributes
include/linux/if_vlan.h
On 9/22/15 4:15 PM, Pravin Shelar wrote:
On Tue, Sep 22, 2015 at 1:11 PM, Thomas F Herbert
wrote:
On 9/15/15 2:09 PM, Pravin B Shelar wrote:
From: Joe Stringer
Signed-off-by: Joe Stringer
Signed-off-by: Pravin B Shelar
---
.travis.yml |3
On 9/15/15 2:09 PM, Pravin B Shelar wrote:
From: Joe Stringer
Signed-off-by: Joe Stringer
Signed-off-by: Pravin B Shelar
---
.travis.yml |3 +-
FAQ.md|1 +
acinclude.m4
On 9/17/15 3:50 AM, openvswitcher wrote:
Hi, all
Could you tell me when the attribute OVS_KEY_ATTR_ENCAP will be used?
That is the encapsulation attribute used for the netlink serialization
encoding.
If the packet is 802.1q, then OVS_KEY_ATTR_VLAN will be used to store the vlan
tci,
so wh
On 8/14/15 12:04 PM, Gray, Mark D wrote:
Hi Daniele,
Thanks for starting this conversation. It is a good list :) I have
crossed-posted this
to dpdk.org as I feel that some of the points could be interesting to that
community
as they are related to how DPDK is used.
How do "users" of OVS with
On 8/6/15 5:29 PM, Flavio Leitner wrote:
On Thu, Aug 06, 2015 at 03:24:29PM -0400, Thomas F Herbert wrote:
On 8/6/15 1:40 PM, Flavio Leitner wrote:
On Thu, Aug 06, 2015 at 12:39:29PM -0400, Thomas F Herbert wrote:
On 7/31/15 6:30 PM, Flavio Leitner wrote:
This RFC is based on the vhost
On 8/6/15 1:40 PM, Flavio Leitner wrote:
On Thu, Aug 06, 2015 at 12:39:29PM -0400, Thomas F Herbert wrote:
On 7/31/15 6:30 PM, Flavio Leitner wrote:
This RFC is based on the vhost multiple queues work on
dpdk-dev: http://dpdk.org/ml/archives/dev/2015-June/019345.html
Signed-off-by: Flavio
On 7/31/15 6:30 PM, Flavio Leitner wrote:
This RFC is based on the vhost multiple queues work on
dpdk-dev: http://dpdk.org/ml/archives/dev/2015-June/019345.html
Signed-off-by: Flavio Leitner
---
lib/netdev-dpdk.c | 61 ---
1 file changed, 4
On 8/4/15 10:50 AM, Russell Bryant wrote:
On 08/04/2015 08:37 AM, ravali.bu...@wipro.com wrote:
Hi Team,
I have added the new file to ovs-master for MSTP but while compiling
I am unable include the new header file in the file.
I have added the reference for the new files in lib/automake.mk eve
a Kumar R
___
From: Thomas F Herbert
Sent: Friday, July 31, 2015 9:58 PM
To: Ravulakollu Udaya Kumar (WT01 - Digital Marketing);
thomasfherb...@gmail.com; net...@vger.kernel.org; pshe...@nicira.com
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH net-next 3/3] openvswitch
rds,
Uday
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Thomas F Herbert
Sent: Sunday, July 26, 2015 8:23 PM
To: net...@vger.kernel.org; pshe...@nicira.com
Cc: dev@openvswitch.org; therb...@redhat.com
Subject: [ovs-dev] [PATCH net-next 3/3] openvswitc
On 7/28/15 3:19 AM, Finucane, Stephen wrote:
For what it's worth, I also think that something like Gerrit would be
useful given the number of platforms that OVS is running on. Right
now, it's seems like we're doing the human-powered version, which is
Guru, Daniele, or Ben complain when something
0x88a8 on inner or outer tags.
Signed-off-by: Thomas F Herbert
---
net/openvswitch/flow.c | 84 +++---
net/openvswitch/flow.h | 5 ++
net/openvswitch/flow_netlink.c | 196 ++---
3 files changed, 243 insertions(+), 42 deletions
Signed-off-by: Thomas F Herbert
---
include/linux/if_vlan.h | 17 +
1 file changed, 17 insertions(+)
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 67ce5bd..88d1be4 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,6 +627,23
openvswitch: Add support for 802.1AD
Change the description of the VLAN tpid field.
Signed-off-by: Thomas F Herbert
---
include/uapi/linux/openvswitch.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux
/..
Thomas F Herbert (3):
openvswitch: 802.1ad uapi changes.
Check for vlan ethernet types for 8021.q or 802.1ad
802.1AD: Flow handling, actions, vlan parsing and netlink attributes
include/linux/if_vlan.h | 17
include/uapi/linux/openvswitch.h | 17 ++--
net/openvswitch/flow.c
ID of outgoing packets is miss-reported as 0x8100
whether or not the tpid is actually 0x88a8
Could you please let me know , whether the below mentioned patch helps here.
Thanks in Advance,
Uday
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Thomas F Herbert
On 6/30/15 12:16 AM, Pravin Shelar wrote:
On Tue, Jun 23, 2015 at 11:26 AM, Thomas F Herbert
Pravin, I apologize because I realize now that I am finishing V12 of
this patch that I never responded to your comments in this email.
wrote:
Add support for 802.1ad including the ability to push and
1 - 100 of 199 matches
Mail list logo
