Re: [ovs-dev] [PATCH] BFD: Edit the unit test time/stop command

2013-08-05 Thread Pavithra Ramesh
I just saw this. Sorry about the delay! Signed-off-by: Pavithra Ramesh Thanks, Pavithra - Original Message - From: "Ethan Jackson" To: "Pavithra Ramesh" Cc: dev@openvswitch.org Sent: Thursday, August 1, 2013 12:41:00 PM Subject: Re: [ovs-dev] [PATCH] BFD: Edit the

Re: [ovs-dev] [PATCH] BFD: Populate ToS field in BFD packets.

2013-08-05 Thread Pavithra Ramesh
Signed-off-by: Pavithra Ramesh Thanks, Pavithra - Original Message - From: "Ethan Jackson" To: "Pavithra Ramesh" Cc: dev@openvswitch.org Sent: Sunday, August 4, 2013 11:10:04 AM Subject: Re: [ovs-dev] [PATCH] BFD: Populate ToS field in BFD packets. This looks g

[ovs-dev] [PATCH] BFD: Edit the unit test time/stop command

2013-07-31 Thread Pavithra Ramesh
Run the ovs-appctl time/stop command after OVS_VSWITCHD_START. Also increase the wait time before checking if BFD session is up in test 4. --- tests/bfd.at | 12 +--- 1 files changed, 5 insertions(+), 7 deletions(-) diff --git a/tests/bfd.at b/tests/bfd.at index d95f8ab..c54fff0 100644

[ovs-dev] [PATCH] BFD: Unit tests for BFD

2013-07-26 Thread Pavithra Ramesh
Added more comments and removed some unnecessary lines. --- tests/automake.mk |1 + tests/bfd.at | 218 tests/testsuite.at |1 + 3 files changed, 220 insertions(+), 0 deletions(-) create mode 100644 tests/bfd.at diff --git a/te

Re: [ovs-dev] [PATCH] Unit tests for BFD.

2013-07-26 Thread Pavithra Ramesh
Forgot to sign off. Signed-off-by: Pavithra Ramesh Thanks, Pavithra - Original Message - From: "Pavithra Ramesh" To: dev@openvswitch.org Cc: "Pavithra Ramesh" Sent: Friday, July 26, 2013 12:14:20 PM Subject: [PATCH] Unit tests for BFD. --- tests/automake.mk |

[ovs-dev] [PATCH] Unit tests for BFD.

2013-07-26 Thread Pavithra Ramesh
--- tests/automake.mk |1 + tests/bfd.at | 206 tests/testsuite.at |1 + 3 files changed, 208 insertions(+), 0 deletions(-) create mode 100644 tests/bfd.at diff --git a/tests/automake.mk b/tests/automake.mk index 755d88e..f531b

[ovs-dev] [PATCH] BFD: Populate ToS field in BFD packets.

2013-07-19 Thread Pavithra Ramesh
--- lib/bfd.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/bfd.c b/lib/bfd.c index 3ac257a..a36b8f3 100644 --- a/lib/bfd.c +++ b/lib/bfd.c @@ -16,6 +16,7 @@ #include "bfd.h" #include +#include #include "byte-order.h" #include "csum.h" @@ -55,9 +56,7

[ovs-dev] [PATCH] ovs-vswitchd: Document the ovs-appctl bfd/* commands.

2013-07-18 Thread Pavithra Ramesh
Added man-page entries for bfd/show and bfd/set-forwarding commands. Signed-off-by: Pavithra Ramesh --- vswitchd/ovs-vswitchd.8.in |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/vswitchd/ovs-vswitchd.8.in b/vswitchd/ovs-vswitchd.8.in index f17f873..37b32d0

[ovs-dev] [PATCH] ovs-vswitchd: Document the ovs-appctl bfd/show command.

2013-07-18 Thread Pavithra Ramesh
Signed-off-by: Pavithra Ramesh --- vswitchd/ovs-vswitchd.8.in |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/vswitchd/ovs-vswitchd.8.in b/vswitchd/ovs-vswitchd.8.in index f17f873..8476776 100644 --- a/vswitchd/ovs-vswitchd.8.in +++ b/vswitchd/ovs-vswitchd.8.in

[ovs-dev] [PATCH] BFD: Add BFD output to bugtool

2013-07-16 Thread Pavithra Ramesh
This change includes the output of ovs-appctl bfd/show to ovs-bugtool output. Signed-off-by: Pavithra Ramesh --- utilities/bugtool/automake.mk |1 + utilities/bugtool/ovs-bugtool-bfd-show | 19 +++ .../bugtool/plugins/network-status

[ovs-dev] [PATCH] BFD: Add check_tnl_key feature to BFD code.

2013-07-15 Thread Pavithra Ramesh
This change adds the check_tnl_key functionality for BFD. When the feature is enabled, BFD will only accept control packets with a tunnel key of 0. Signed-off-by: Pavithra Ramesh --- lib/bfd.c| 16 ++-- lib/bfd.h|4 +++- ofproto/ofproto

[ovs-dev] [PATCH] BFD: Add small features to existing BFD code.

2013-07-15 Thread Pavithra Ramesh
This change adds the check_tnl_key functionality for BFD. It also populates the ToS field for BFD packets. Signed-off-by: Pavithra Ramesh --- lib/bfd.c| 19 --- lib/bfd.h|4 +++- ofproto/ofproto-dpif-xlate.c |2 +- 3 files

[ovs-dev] [PATCH] BFD: Add forwarding_override command for BFD.

2013-06-28 Thread Pavithra Ramesh
Added appctl commands to override the bfd forwarding status. Values of true/false/normal are allowed. When set to normal, the bfd forwarding status is left unchanged. Else, the forwarding status is set to the specified value - true/false. Signed-off-by: Pavithra Ramesh --- lib/bfd.c | 47

[ovs-dev] [PATCH] BFD: Add forwarding_override command for BFD.

2013-06-28 Thread Pavithra Ramesh
Added appctl commands to override the bfd forwarding status. Values of true/false/normal are allowed. When set to normal, the bfd forwarding status is left unchanged. Else, the forwarding status is set to the specified value - true/false. --- lib/bfd.c | 46 ++

[ovs-dev] [PATCH] BFD: Unit tests for BFD. Add unit tests to verify basic functionality in BFD.

2013-06-25 Thread Pavithra Ramesh
Signed-off-by: Pavithra Ramesh --- tests/automake.mk |1 + tests/bfd.at | 214 tests/testsuite.at |1 + 3 files changed, 216 insertions(+), 0 deletions(-) create mode 100644 tests/bfd.at diff --git a/tests/automake.mk b/tests

[ovs-dev] [PATCH] BFD: Reconfigure BFD on port deletion.

2013-05-28 Thread Pavithra Ramesh
Invoke the function to reconfigure BFD when a port/interface is deleted. Signed-off-by: Pavithra Ramesh --- lib/bfd.c |5 +++-- ofproto/ofproto-dpif.c |2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/bfd.c b/lib/bfd.c index 95dad2d..761c91c 100644

[ovs-dev] [PATCH] BFD: Reconfigure BFD on port deletion.

2013-05-28 Thread Pavithra Ramesh
Invoke the function to reconfigure BFD when a port/interface is deleted. --- lib/bfd.c |5 +++-- ofproto/ofproto-dpif.c |2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/bfd.c b/lib/bfd.c index 95dad2d..761c91c 100644 --- a/lib/bfd.c +++ b/lib/bfd.c @@

[ovs-dev] [PATCH] BFD: Reconfigure BFD on port deletion

2013-05-23 Thread Pavithra Ramesh
Invoke the function to reconfigure BFD when a port/interface is deleted. Signed-off-by: Pavithra Ramesh --- lib/bfd.c |2 +- ofproto/ofproto-dpif.c |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/bfd.c b/lib/bfd.c index 95dad2d..48c0e38 100644

Re: [ovs-dev] [PATCH] stream-unix: append ovs_rundir to socket

2013-02-11 Thread Pavithra Ramesh
there is no '/' in socket name. Signed-off-by: Pavithra Ramesh Thanks, Pavithra - Original Message ----- From: "Ben Pfaff" To: "Pavithra Ramesh" Cc: dev@openvswitch.org Sent: Monday, February 11, 2013 10:48:28 AM Subject: Re: [ovs-dev] [PATCH] stream-unix: a

[ovs-dev] [PATCH] stream-unix: append ovs_rundir to socket

2013-02-08 Thread Pavithra Ramesh
If socket path specified is relative to ovs_rundir(), append the directory name to in unix_open and punix_open. Made the change in the stream-unix implementation of C and Python. Also modified bridge.c to relax the whitelist check, only if there is no '/' in socket name. --- lib/stream-unix.c

Re: [ovs-dev] [PATCH] stream-unix: append ovs_rundir to socket

2013-02-08 Thread Pavithra Ramesh
Sure, I've made the change and will send out a new patch. Can you push this one? Thanks, Pavithra - Original Message - From: "Ben Pfaff" To: "Pavithra Ramesh" Cc: dev@openvswitch.org Sent: Friday, February 8, 2013 11:18:38 AM Subject: Re: [ovs-dev] [P

Re: [ovs-dev] [PATCH] stream-unix: append ovs_rundir to socket

2013-02-08 Thread Pavithra Ramesh
Thanks Ben. The patch looks good. Do we also want to change the python stream implementation to behave the same way? -Pavithra - Original Message - From: "Ben Pfaff" To: "Pavithra Ramesh" Cc: dev@openvswitch.org Sent: Friday, February 8, 2013 9:14:13 AM Subject:

[ovs-dev] [PATCH] stream-unix: append ovs_rundir to socket

2013-02-07 Thread Pavithra Ramesh
If socket path specified is relative to ovs_rundir(), append the directory name to in unix_open and punix_open. Freed the new newly allocated strings. Also included the change in bridge.c to relax the whitelist check, only if there is no /. Signed-off-by: Pavithra Ramesh --- lib/stream-unix.c

[ovs-dev] [PATCH] stream-unix: append ovs_rundir to socket

2013-02-07 Thread Pavithra Ramesh
Incorporated Ben's comments. If socket path specified is relative to ovs_rundir(), append the directory name to in unix_open and punix_open. Also included the change in bridge.c to relax the whitelist check, only if there is no /. Signed-off-by: Pavithra Ramesh --- lib/stream-unix.c |

[ovs-dev] [PATCH] stream-unix: append ovs_rundir to socket If socket path specified is relative to ovs_rundir(), append the directory name to in unix_open.

2013-02-06 Thread Pavithra Ramesh
Taken care of the memroy leak, used xasprintf instead. Also included the change in bridge.c to relax the whitelist check. Signed-off-by: Pavithra Ramesh --- lib/stream-unix.c | 11 ++- vswitchd/bridge.c |6 -- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/lib

[ovs-dev] [PATCH] stream-unix: append ovs_rundir to socket

2013-02-05 Thread Pavithra Ramesh
If socket path specified is relative to ovs_rundir(), append the directory name to in unix_open. Signed-off-by: Pavithra Ramesh --- lib/stream-unix.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/lib/stream-unix.c b/lib/stream-unix.c index 6ed7648..8764b6c

Re: [ovs-dev] [PATCH] bridge: Modify equal_pathnames function

2013-01-23 Thread Pavithra Ramesh
Hi Ben, Thanks for taking a look. This patch looks good. Thanks, Pavithra - Original Message - From: "Ben Pfaff" To: "Pavithra Ramesh" Cc: dev@openvswitch.org Sent: Wednesday, January 23, 2013 1:29:49 PM Subject: Re: [ovs-dev] [PATCH] bridge: Modify equal_pathna

[ovs-dev] [PATCH] bridge: Modify equal_pathnames function

2013-01-23 Thread Pavithra Ramesh
Modify equal_pathnames to return true when one string is substring of the other(when a value smaller than SIZE_MAX is supplied as stop_len) --- vswitchd/bridge.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 82c3bff..792a131

[ovs-dev] [PATCH] bridge: Append the ovs_rundir to socket.

2013-01-18 Thread Pavithra Ramesh
If socket path specified in the set-controller command is relative to ovs_rundir(), append the directory name to target. Bug#14029 Signed-off-by: Pavithra Ramesh --- vswitchd/bridge.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a

[ovs-dev] [PATCH] bridge: Remove restriction on socket name.

2013-01-15 Thread Pavithra Ramesh
#14029 Signed-off-by: Pavithra Ramesh --- vswitchd/bridge.c | 46 -- 1 files changed, 32 insertions(+), 14 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 348faef..f647301 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c

Re: [ovs-dev] [PATCH] remove restriction on socket name

2013-01-14 Thread Pavithra Ramesh
Sorry about the formatting. I sent out another one using git send-email. Thanks, Pavithra - Original Message - From: "Jesse Gross" To: "Ben Pfaff" Cc: "Pavithra Ramesh" , dev@openvswitch.org Sent: Monday, January 14, 2013 6:14:47 PM Subject: Re: [ovs-dev]

[ovs-dev] [PATCH] remove restriction on socket name

2013-01-14 Thread Pavithra Ramesh
Following patch removes restriction on the listening socket name that gets configured as bridge controller. Currently, we only connect to sockets in a specific directory with the name of the bridge. This patch removes the restriction on the bridge name (but keep the directory restriction). Is