Re: [ovs-dev] [PATCH 5/5] lib/netdev-dpdk: copy large packet to multi-segment mbufs

2016-11-01 Thread Michael Qiu
t number needed by the packet and copy the data to different segments. Signed-off-by: Michael Qiu Signed-off-by: Jijiang Liu --- lib/netdev-dpdk.c | 55 --- 1 file changed, 48 insertions(+), 7 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/net

Re: [ovs-dev] [PATCH 5/5] lib/netdev-dpdk: copy large packet to multi-segment mbufs

2016-11-01 Thread Michael Qiu
t number needed by the packet and copy the data to different segments. Signed-off-by: Michael Qiu Signed-off-by: Jijiang Liu --- lib/netdev-dpdk.c | 55 --- 1 file changed, 48 insertions(+), 7 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/net

Re: [ovs-dev] [PATCH 4/5] lib/dp-packet: copy multi-segments data from DPDK mbuf

2016-10-31 Thread Michael Qiu
2016/10/28 18:50, Kavanagh, Mark B : When doing packet clone, if packet source is from DPDK driver, multi-segment must be considered, and copy the segment's data one by one. Signed-off-by: Michael Qiu Signed-off-by: Jijiang Liu --- lib/dp-packet.c | 25 ++--- 1

Re: [ovs-dev] [PATCH 1/5] lib/dp-packet: init the mbuf to zero when build with DPDK

2016-10-31 Thread Michael Qiu
river may hang. Signed-off-by: Michael Qiu Signed-off-by: Jijiang Liu Thanks for the patch Michael; one minor nit, but otherwise looks good to me. --- lib/dp-packet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/dp-packet.c b/lib/dp-packet.c index 8e7defc..bf8522e 100644 --- a/l

Re: [ovs-dev] [PATCH 1/5] lib/dp-packet: init the mbuf to zero when build with DPDK

2016-10-31 Thread Michael Qiu
r may hang. Signed-off-by: Michael Qiu Signed-off-by: Jijiang Liu Thanks for the patch Michael; one minor nit, but otherwise looks good to me. --- lib/dp-packet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/dp-packet.c b/lib/dp-packet.c index 8e7defc..bf8522e 100644 --- a/l

Re: [ovs-dev] [PATCH 3/5] lib/dp-packet: Fix data_len issue with multi-segments

2016-10-31 Thread Michael Qiu
tains multipule segments, data_len is not equal to the Typo in the previous line - 'multipule' Thanks for point it out, I'll fix it. packet size. This patch fix this issue. Signed-off-by: Michael Qiu Signed-off-by: Marcin Ksiadz Signed-off-by: Mark Kavanagh Signed-off-by:

Re: [ovs-dev] [PATCH 2/5] lib/dp-packet: copy additional packet info when do packet copy

2016-10-31 Thread Michael Qiu
2016/10/28 17:47, Kavanagh, Mark B : Currently, when doing packet copy, lots of DPDK mbuf's info will be missed, like packet type, ol_flags, etc. Those information is very important for DPDK to do packets processing. Signed-off-by: Michael Qiu Signed-off-by: Jijiang Liu --- lib/dp-pac

[ovs-dev] [PATCH 4/5] lib/dp-packet: copy multi-segments data from DPDK mbuf

2016-10-26 Thread Michael Qiu
When doing packet clone, if packet source is from DPDK driver, multi-segment must be considered, and copy the segment's data one by one. Signed-off-by: Michael Qiu Signed-off-by: Jijiang Liu --- lib/dp-packet.c | 25 ++--- 1 file changed, 22 insertions(+), 3 dele

[ovs-dev] [PATCH 5/5] lib/netdev-dpdk: copy large packet to multi-segment mbufs

2016-10-26 Thread Michael Qiu
Currently, one packet is only copied to one segment in function dpdk_do_tx_copy(), this could be an issue when a jumboframe comes, especially for multipile segments. This patch calculate the segment number needed by the packet and copy the data to different segments. Signed-off-by: Michael Qiu

[ovs-dev] [PATCH 3/5] lib/dp-packet: Fix data_len issue with multi-segments

2016-10-26 Thread Michael Qiu
When a packet is from DPDK source, and it contains multipule segments, data_len is not equal to the packet size. This patch fix this issue. Signed-off-by: Michael Qiu Signed-off-by: Marcin Ksiadz Signed-off-by: Mark Kavanagh Signed-off-by: Przemyslaw Lal Signed-off-by: Yuanhan Liu --- lib

[ovs-dev] [PATCH 2/5] lib/dp-packet: copy additional packet info when do packet copy

2016-10-26 Thread Michael Qiu
Currently, when doing packet copy, lots of DPDK mbuf's info will be missed, like packet type, ol_flags, etc. Those information is very important for DPDK to do packets processing. Signed-off-by: Michael Qiu Signed-off-by: Jijiang Liu --- lib/dp-packet.c | 3 +++ lib/netdev-dpdk.c | 4 ++

[ovs-dev] [PATCH 1/5] lib/dp-packet: init the mbuf to zero when build with DPDK

2016-10-26 Thread Michael Qiu
When building with DPDK, and using xmalloc() to get a new packet, field mbuf of the packet will not be initialized, but it's very important for DPDK port when copying the data to DPDK mbuf, because if ol_flags and other info are random values, DPDK driver may hang. Signed-off-by: Michae

[ovs-dev] [PATCH 0/5] DPDK multi-segment mbuf support

2016-10-26 Thread Michael Qiu
eeds multi-segment mbuf's support. This patchset enable DPDK multi-segment mbuf support in OVS. Michael Qiu (5): lib/dp-packet: init the mbuf to zero when build with DPDK DPDK: copy additional packet info when do packet copy lib/dp-packet: Fix data_len issue with multi-segments lib/dp-pac

Re: [ovs-dev] Issue about "action=normal" in OVS-DPDK

2016-10-24 Thread Michael Qiu
在 2016/10/25 1:16, Daniele Di Proietto 写道: On 24/10/2016 00:31, "Michael Qiu" <08005...@163.com> wrote: Hi, all When I self-compiled the OVS-2.6 from commit: commit 7a0f907b2393626dac1387617355990eab69aef7 Author: Justin Pettit Date: Tue Sep 27 10:13:42 2016 -0700

[ovs-dev] Issue about "action=normal" in OVS-DPDK

2016-10-24 Thread Michael Qiu
Hi, all When I self-compiled the OVS-2.6 from commit: commit 7a0f907b2393626dac1387617355990eab69aef7 Author: Justin Pettit Date: Tue Sep 27 10:13:42 2016 -0700 Set release date for 2.6.0. Signed-off-by: Justin Pettit Acked-by: Ben Pfaff I found that when I using "action=nor

Re: [ovs-dev] The Patch netdev-dpdk: add TSO support for vhost-user ports

2016-10-18 Thread Michael Qiu
[+cc DPDK jianfeng] For the gap, is it been fixed by below commit? commit c59faf3fe8fe6dbd99e8cd9d703839728264c5ae Author: Jianfeng Tan Date: Mon Aug 1 03:56:54 2016 + net/i40e: support TSO on tunneling packet I just tested your vlan patch, the same thing happens as vxlan tunnel T

Re: [ovs-dev] The Patch netdev-dpdk: add TSO support for vhost-user ports

2016-10-13 Thread Michael Qiu
Hi, Mark I have reviewed your RFC patch, I found one place could have issue, see below: +if (v > ETHER_MAX_LEN) { +b->mbuf.data_len = +(uint16_t)(b->mbuf.buf_len - b->mbuf.data_off); +} else { +b->mbuf.data_len = (uint16_t)v; +} + Here, what will happ

Re: [ovs-dev] The Patch netdev-dpdk: add TSO support for vhost-user ports

2016-10-11 Thread Michael Qiu
Hi, Mark OK, once it's ready, pls let me know and I'm glade to help to test it. BTW, you mentioned the gap, is that the TSO and CSUM of tunnel offload? I'm familiar with it, and I hope I could do something on it if possible. 2016/10/11 22:34, Kavanagh, Mark B : Hi, all This patch is v

[ovs-dev] The Patch netdev-dpdk: add TSO support for vhost-user ports

2016-10-11 Thread Michael Qiu
Hi, all This patch is very important for users want to improve the performance of the large packets. But you know, in data center, lots of networks using vxlan, so if it supports vxlan, then it will be very useful. Would you guys has a plan to support it? I would like to help test it,