Re: [ovs-dev] [PATCH v3] Rapid Spanning Protocol Implementation (IEEE 802.1D) + functional tests

Jarno Rajahalme wrote: Daniele, Martino, Thank you for the contribution, and sorry that it has taken so long for me to get to the review! [...] Dear all, we are working on Jarno revision, and we will provide shortly a revised patch. In the meantime, I would like to ask for advice on an issue

Re: [ovs-dev] [PATCH v3] Rapid Spanning Protocol Implementation (IEEE 802.1D) + functional tests

Jarno Rajahalme wrote: Another high-level thing is that in OVS we use the ‘ovs_beXX’ types to annotate integers in network byte order, and the corresponding ‘uintXX_t’ types for the host byte order equivalents. You would use ovs_beXX types to define the BPDUs, and then convert each member to h

Re: [ovs-dev] [PATCH v3] Rapid Spanning Protocol Implementation (IEEE 802.1D) + functional tests

Jarno Rajahalme wrote: move_rstp() does not check ‘changes’ before clearing it. Consider enforcing the invariant, or maybe do not bother setting ‘changes’ right before calling ‘move_rstp()’ ? Not clear to me. Function move_rstp does check 'changes': move_rstp(struct rstp *rstp ) { int port_n

Re: [ovs-dev] [PATCH v3] Rapid Spanning Protocol Implementation (IEEE 802.1D) + functional tests

Jarno Rajahalme wrote: Daniele, Martino, Thank you for the contribution, and sorry that it has taken so long for me to get to the review! Thank you for the thorough revision. We are going to take a deeper look at it and provide modifications/comments. B.R., Martino. __

Re: [ovs-dev] [PATCH] Rapid Spanning Protocol Implementation (IEEE 802.1D) + functional tests

Jarno Rajahalme wrote: On Feb 25, 2014, at 2:58 PM, Ben Pfaff > wrote: Jarno, would you mind reviewing this? Not at all, but it’ll take some days, as I haven’t looked at RSTP before :-) Jarno Feel free to contact me and my colleague Daniele (daniele.ventur...@m

Re: [ovs-dev] Rapid Spanning Tree Protocol (RSTP) implementation

best guess is to use the ofport->may-enable flag after its setting inside inside port_run() function [ofproto/ofproto-dpif-xlate.c]. Is this ok or you can suggest a better one? Regards, Martino Fornasa. ___ dev mailing list dev@openvswitch.org h

Re: [ovs-dev] Rapid Spanning Tree Protocol (RSTP) implementation

Ben Pfaff wrote: On Tue, Sep 10, 2013 at 05:34:28PM +0200, Martino Fornasa wrote: Ben Pfaff wrote: On Tue, Sep 10, 2013 at 03:26:48PM +0200, Martino Fornasa wrote: This sounds very nice. Do you plan to make the result available to the Open vSwitch community? We do, as soon as we reach a

Re: [ovs-dev] Rapid Spanning Tree Protocol (RSTP) implementation

Ben Pfaff wrote: On Tue, Sep 10, 2013 at 03:26:48PM +0200, Martino Fornasa wrote: This sounds very nice. Do you plan to make the result available to the Open vSwitch community? We do, as soon as we reach a decent stage in the porting. In this moment we are dealing with stp-related components

[ovs-dev] Rapid Spanning Tree Protocol (RSTP) implementation

Hi, at M3S (http://www.m3s.it) we developed a complete implementation of the Rapid Spanning Tree Protocol (RSTP) as defined in the standard IEEE 802.1D-2004 (which is the evolution of the first standard defining RSTP, IEEE 802.1w). The implementation has been tested in a lab environment and we