amp; nxm_field(header) == 38) {
in nxm_field_by_header().
Signed-off-by: Madhu Challa
---
build-aux/extract-ofp-fields |6 +-
lib/automake.mk |2 +
lib/flow.c | 13 +-
lib/flow.h |4 +-
lib/match.c | 22 ++-
eir end.
>
> On Fri, Jan 02, 2015 at 02:52:47PM -0800, Ben Pfaff wrote:
> > Hmm. Currently --with-debug has no effect at all outside of Windows.
> > I agree, it would make sense to do the same thing.
> >
> > On Fri, Jan 02, 2015 at 02:50:58PM -0800, Madhu Challa wrote:
&g
It would be nice if we have the same behavior for --with-debug as well.
Today the debug build adds -g -O2, I manually change it to O0 since some of
the local variables get optimized out otherwise.
Thanks.
On Fri, Jan 2, 2015 at 2:39 PM, Ben Pfaff wrote:
> CFLAGS follows OVS_CFLAGS in the compil
Thanks for the helpful explanation.
Thanks.
On Wed, Dec 17, 2014 at 12:45 PM, Jarno Rajahalme
wrote:
>
>
> On Dec 17, 2014, at 12:07 PM, Madhu Challa
> wrote:
>
> Jarno,
>
> I did some simple tests increasing flow_tnl size and trying to match on it
> looks good. Than
Jarno,
I did some simple tests increasing flow_tnl size and trying to match on it
looks good. Thanks for solving this. I have a question inline around
miniflow_extract. Other than that the diff looks good to me.
Thanks.
On Wed, Dec 17, 2014 at 10:30 AM, Jarno Rajahalme
wrote:
>
> So far the com
all. If
> we decide that
> this is important for correctness, we will have to write new code to
> implement it.
>
> On Fri, Dec 5, 2014 at 11:21 AM, Madhu Challa
> wrote:
> > Yes it does get a barrier reply. Pl see the logs below. We do see
> > revalidator21 wakeup, but may
, 2014 at 9:42 AM, Ben Pfaff wrote:
> On Thu, Dec 4, 2014 at 3:17 PM, Madhu Challa
> wrote:
> > 6 of the tests fail because we failed to revalidate the flows fast
> enough.
> >
> > e.g the pktact priority tests
> > add flow in_port=1, match M actions=output:2 w
ng why, but I don't have time to look at the
> details this week.
>
> It's very interesting that it's timing-related; that's a good hint
> already.
>
> On Wed, Dec 03, 2014 at 11:25:11AM -0800, Madhu Challa wrote:
> > Its interesting to see that some of these
Its interesting to see that some of these tests pass when run under pdb or
if I put a sleep(1) between verify flow and install of new flow. That tells
me it has something to do with the timing. Here are the tests that fail.
pktact.WildcardPriorityWithDelete ... FAIL
pktact.WildcardPriority ... FAI
Verified the fix. Looks good.
Thanks.
On Fri, Nov 14, 2014 at 1:24 PM, Pravin B Shelar wrote:
> ovs-dpctl crashed due to uninitialized router classifier. To
> fix this issue move ovs router initialization to route table
> module.
>
> Reported-by: Madhu Challa
> Signed-off-b
That was quick. Thanks !
On Fri, Nov 14, 2014 at 1:25 PM, Pravin Shelar wrote:
> On Fri, Nov 14, 2014 at 10:23 AM, Madhu Challa
> wrote:
> > Looks like ovs_router_unixctl_register() isn't getting called in
> ovs-dpctl,
> > so we hit this crash. If I explicitly call
Looks like ovs_router_unixctl_register() isn't getting called in ovs-dpctl,
so we hit this crash. If I explicitly call this after main, it works fine.
I am not sure when this broke and am trying to figure that out.
Thanks.
Starting program: /usr/local/bin/ovs-dpctl show
warning: no loadable secti
sorry forgot to put that.
On Tue, Oct 21, 2014 at 7:43 AM, Ben Pfaff wrote:
> On Sat, Oct 18, 2014 at 01:18:01PM -0700, Madhu Challa wrote:
> > When flow_get fails (in this case flow does not exist) simply log
> > the key part of the get and erase the rest of the flow because it
When flow_get fails (in this case flow does not exist) simply log
the key part of the get and erase the rest of the flow because it
is invalid.
verified the fix by doing ovs-ofctl del-flows when traffic is running
2014-10-18T20:12:13.785Z|00011|dpif(revalidator20)|WARN|system@ovs-system:
failed
Do not log_flow_get_message on error since the flow isn't available
---
lib/dpif.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/dpif.c b/lib/dpif.c
index d088f68..f7aafa8 100644
--- a/lib/dpif.c
+++ b/lib/dpif.c
@@ -1155,10 +1155,11 @@ dpif_operate(struct dpif *dpif
inconsistent, I have seen it a few times, I have not seen
it since I sent my last message.
Thanks.
Thanks.
On Fri, Oct 17, 2014 at 5:09 PM, Madhu Challa
wrote:
> I am able to recreate it. I suspect its some bug at the dpif_netlink
> layer. I am trying to narrow it down further. Anythi
(arg=0x7fee162a5700) at
pthread_create.c:308
#11 0x7fee18fba3fd in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:112
#12 0x in ?? ()
On Fri, Oct 17, 2014 at 4:17 PM, Ben Pfaff wrote:
> On Fri, Oct 17, 2014 at 04:07:25PM -0700, Madhu Challa wrote:
> > dpif_flow_get
000 in ?? ()
On Fri, Oct 17, 2014 at 4:25 PM, Madhu Challa
wrote:
> You are correct Ben. I confused with the put that has actions in
> dpif_flow_put. I guess I was not able to repro the issue then. Let me repro
> it and I will resend the fix.
>
> Thanks.
>
> On Fri, Oct 17, 20
You are correct Ben. I confused with the put that has actions in
dpif_flow_put. I guess I was not able to repro the issue then. Let me repro
it and I will resend the fix.
Thanks.
On Fri, Oct 17, 2014 at 4:17 PM, Ben Pfaff wrote:
> On Fri, Oct 17, 2014 at 04:07:25PM -0700, Madhu Challa wr
is going on
Signed-off-by: Madhu Challa
---
lib/dpif.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/dpif.c b/lib/dpif.c
index d088f68..72ae2d4 100644
--- a/lib/dpif.c
+++ b/lib/dpif.c
@@ -840,6 +840,8 @@ dpif_flow_get(struct dpif *dpif,
struct dpif_op *opp;
struct
8:36 AM, Ben Pfaff wrote:
> On Wed, Oct 08, 2014 at 08:20:25AM -0700, Madhu Challa wrote:
> > When I was testing this with 3.17 I had seen similar errors. It was
> because
> > the kernel module loaded was the one that came with 3.17 kernel and not
> the
> > one I comp
When I was testing this with 3.17 I had seen similar errors. It was because
the kernel module loaded was the one that came with 3.17 kernel and not the
one I compiled with the latest ovs. I remember they get installed in
different locations. Could you pl check your /lib/modules directory and
make s
On Wed, Oct 1, 2014 at 5:53 PM, Justin Pettit wrote:
> On Wed, Sep 17, 2014 at 4:12 PM, Madhu Challa
> wrote:
>
>>
>> I got a chance to try out your code with the example flows and measure
>> raw packet throughput with and without connection tracking. The code w
Hi Justin,
I got a chance to try out your code with the example flows and measure raw
packet throughput with and without connection tracking. The code works and
the performance numbers look pretty good.
I ran two sets of tests both with 4 iptable rules in chain input and 8 in
chain forward, all d
error string should be freed in all cases.
Signed-off-by: Madhu Challa
---
vtep/vtep-ctl.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/vtep/vtep-ctl.c b/vtep/vtep-ctl.c
index 0b9463a..064ad1f 100644
--- a/vtep/vtep-ctl.c
+++ b/vtep/vtep-ctl.c
@@ -3199,11 +3199,13
call odp_execute_actions__ only if there are any subactions to prevent null
pointer dereference in nl_attr_get().
Signed-off-by: Madhu Challa
---
lib/odp-execute.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/odp-execute.c b/lib/odp-execute.c
index e1e9b57..607af03 100644
--- a
014 at 11:48 AM, Madhu Challa
> wrote:
> > These come from dpif_flow_put() in check_max_mpls_depth() when adding a
> > datapath. The key length is variable depending on number of MPLS labels.
> By
> > initializing to -1 kmod will not check for the key length.
> > Signe
These come from dpif_flow_put() in check_max_mpls_depth() when adding a
datapath. The key length is variable depending on number of MPLS labels. By
initializing to -1 kmod will not check for the key length.
Signed-off-by: Madhu Challa
---
datapath/flow_netlink.c |1 +
1 file changed, 1
28 matches
Mail list logo
