Re: [ovs-dev] [PATCH] util: Generalize rightmost_1bit_idx(), leftmost_1bit_idx().

2015-09-30 Thread Kyle Upton
On 09/30/2015 02:11 AM, Ben Pfaff wrote: > On Tue, Sep 29, 2015 at 04:46:37PM -0700, Ben Pfaff wrote: >> On Wed, Sep 23, 2015 at 02:25:47PM -0700, Andy Zhou wrote: >>> On Fri, Sep 18, 2015 at 3:26 PM, Ben Pfaff wrote: These functions could only work with 32-bit integers because of their >>>

Re: [ovs-dev] [PATCH]: Use ctz64() instead of rightmost_1bit_idx() with 64 bit arg

2015-09-28 Thread Kyle Upton
Hi Ben, Thanks for your reply below. I was wondering what the status of the alternative patch is. Is there something that should be done within that thread? Thanks, -Kyle On 09/21/2015 03:27 PM, Kyle Upton wrote: > Looks good to me. Cleaner and more general. > > Thanks, > -Ky

Re: [ovs-dev] [PATCH]: Use ctz64() instead of rightmost_1bit_idx() with 64 bit arg

2015-09-21 Thread Kyle Upton
Looks good to me. Cleaner and more general. Thanks, -Kyle On 09/18/2015 06:26 PM, Ben Pfaff wrote: > On Wed, Sep 16, 2015 at 01:08:48PM -0400, Kyle Upton wrote: >> Applied a patch which changed value of OFPACT_SET_QUEUE to be greater >> than 32. Tracked down a subsequent auto

[ovs-dev] [PATCH]: Use ctz64() instead of rightmost_1bit_idx() with 64 bit arg

2015-09-16 Thread Kyle Upton
nces where rightmost_1bit_idx() is invoked with a 64-bit argument to use ctz64() instead. Tested by running 'make check'. Signed-off-by: Kyle Upton diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index 88f0f85..93d34f1 100644 --- a/lib/ofp-actions.c +++ b/lib/ofp-actions.

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Kyle Upton
On the master branch, it appears my change wasn't necessary. I had merged 4249b54 and run into the problem. However, 10 pushes later, 3d8dede seems to have fixed the problem without my change. Sorry about that. Thanks, Kyle On 07/20/2015 03:11 PM, Kyle Upton wrote: > Without the c

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Kyle Upton
ry `/home/kyle/baygit/openvswitch.new/ovs' make: *** [build] Error 2 Thanks, Kyle Upton On 07/20/2015 02:27 PM, Ben Pfaff wrote: > OK, now I need an explanation myself. The Debian builds worked fine for > me both before and after this patch. What problem do you see? > > On Mon

[ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-09 Thread Kyle Upton
Fix dependency issues with lib/ofp-errors.lo and lib/ofp-msgs.lo that caused problems when building debian packages. Signed-off-by: Kyle Upton --- lib/automake.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/automake.mk b/lib/automake.mk index f72eb32..fe40e4a