Bitwise not operator has higher precedence than Bitwise right shift
operator, so the MFF_IP_DSCP_SHIFTED case always returns true currently.
Signed-off-by: Kmindg
---
lib/meta-flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/meta-flow.c b/lib/meta-flow.c
index
Suggested-by: Ben Pfaff
Signed-off-by: Kmindg
---
tests/automake.mk |1 +
tests/library.at|5 ++
tests/test-bitmap.c | 160 +++
3 files changed, 166 insertions(+)
create mode 100644 tests/test-bitmap.c
diff --git a/tests
The first user of this will be the bitmap.
Signed-off-by: Kmindg
---
lib/util.h |8
1 file changed, 8 insertions(+)
diff --git a/lib/util.h b/lib/util.h
index dc34ee5..7b506bd 100644
--- a/lib/util.h
+++ b/lib/util.h
@@ -475,6 +475,14 @@ rightmost_1bit_idx(uint32_t x)
return
ovstest test-bitmap benchmark 10 (without this commit):
bitmap equal: 52 ms
bitmap scan:758 ms
ovstest test-bitmap benchmark 10 (with this commit):
bitmap equal: 37 ms
bitmap scan: 34 ms
Tested on Intel Xeon E5-2620 v2 @ 2.10GHz
Signed-off-by: Kmindg
---
lib/bitmap.c
On Tue, Jul 29, 2014 at 1:01 AM, Ben Pfaff wrote:
> Needs a sign-off.
>
Oh.. I will not forget it in the next version.
>
> I'm pretty sure that bitmap_equal() is wrong: doesn't it access one
> past the end of the bitmap arrays?
You are right. I'll fix it.
> I think that rightmost_1bit_idx
When vid is OFPVID12_NONE, we should match only packets without vlan
tag. Before this commit we set vlan_tci to 0x/0x1fff which is fine
because it's only match packets without vlan tag too. But if we add flow
using:
ovs-ofctl -O OpenFlow10 add-flow br0 dl_vlan=0x,actions=drop
ovs-of
connmgr_wants_packet_in_on_miss would be invoked in the handler threads,
while ofconn in mgr->all_conns may be destroyed in the main thread. So
we should acquire ofproto_mutex to prevent us from using ofconn which
has been freed.
---
ofproto/connmgr.c | 3 +++
1 file changed, 3 insertions(+)
diff
---
lib/bitmap.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index 7889aa1..b62a8be 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -65,16 +65,17 @@ bool
bitmap_equal(const unsigned long *a, const unsigned
predict which flow will be
chosen. It does not
mean one flow will not be chosen forever.
>
>
> 2014-05-22 17:46 GMT+08:00 Kmindg G :
>
>> On Thu, May 22, 2014 at 4:54 PM, chen zhang <3zhangchen9...@gmail.com>
>> wrote:
>> > but i know that when a ofp_match has
ltiple flows, the highest priority of
flow will be chosen.
>
>
> 2014-05-22 16:12 GMT+08:00 Kmindg G :
>
>> On Thu, May 22, 2014 at 3:21 PM, chen zhang <3zhangchen9...@gmail.com>
>> wrote:
>> > hi, everybody
>> > this is my table entry:
>> &
ibssp
--enable-gnu-unique-object --enable-linker-build-id
--enable-cloog-backend=isl --disable-cloog-version-check --enable-lto
--enable-plugin --enable-install-libiberty
--with-linker-hash-style=gnu --disable-multilib --disable-werror
--enable-checking=release
Thread model: posix
gcc version 4.9.0 20140507 (prerelease) (GCC)
Thanks,
Kmindg
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
hat I misunderstood these code before.
Sorry for the noise.
> Ethan
>
> On Sat, Apr 19, 2014 at 10:09 PM, Kmindg G wrote:
>> On Sat, Apr 19, 2014 at 3:42 AM, Jarno Rajahalme
>> wrote:
>>> This allows use of miniflows that have all of their values inline.
>>&
On Sat, Apr 19, 2014 at 3:42 AM, Jarno Rajahalme wrote:
> This allows use of miniflows that have all of their values inline.
>
> Signed-off-by: Jarno Rajahalme
> ---
> lib/classifier.c | 36 +++--
> lib/dpif-netdev.c | 32 ++-
> lib/flow.c| 91
> ++
On Sat, Apr 19, 2014 at 3:42 AM, Jarno Rajahalme wrote:
> Change the classifier to allocate variable sized miniflows and
> minimasks in cls_match and cls_subtable, respectively. Do not
> duplicate the mask in cls_rule any more.
>
> miniflow_clone and miniflow_move can now take variably sized mini
t;
> These tests were introduced by commit 6d56c1f1.
> ("ofproto: Update rule's priority in eviction group.")
>
> Signed-off-by: YAMAMOTO Takashi
> Cc: Kmindg G
> Acked-by: Ben Pfaff
>
> diff --git a/tests/ofproto.at b/tests/ofproto.at
&g
> Also, use time/stop to avoid relying on how long an add-flow would take.
>
> These tests were introduced by commit 6d56c1f1.
> ("ofproto: Update rule's priority in eviction group.")
>
> Signed-off-by: YAMAMOTO Takashi
> Cc: Kmindg G
> A
These tests were introduced by commit 6d56c1f1.
> ("ofproto: Update rule's priority in eviction group.")
>
> Signed-off-by: YAMAMOTO Takashi
> Cc: Kmindg G
> Acked-by: Ben Pfaff
>
> diff --git a/tests/ofproto.at b/tests/ofproto.at
> index e
On Mon, Mar 31, 2014 at 2:24 PM, YAMAMOTO Takashi
wrote:
> Bump timeout differences, because timeouts different by 1s might end up
> to have the same position in the heap as rule_eviction_priority() uses
> 1024ms as a unit.
>
> Also, use time/stop to avoid relying on how long an add-flow would tak
On Fri, Mar 14, 2014 at 7:13 PM, Rizwan Jamil wrote:
> Hi!
>
> Search is provided in mininet-discuss and openflow-discuss mailing archives.
> But why it has not been provided in ovs-dev and ovs-discuss archives? How
> can I search my question in ovs-dev and ovs-discuss?
google always is your frie
On Sun, Mar 16, 2014 at 12:50 AM, Ben Pfaff wrote:
> On Wed, Mar 12, 2014 at 03:31:26PM +0800, Kmindg G wrote:
>> On Wed, Mar 12, 2014 at 1:41 PM, Ben Pfaff wrote:
>> > On Sun, Mar 09, 2014 at 05:48:52PM +0800, kmindg wrote:
>> >> The restriction only allows to se
On Wed, Mar 12, 2014 at 1:41 PM, Ben Pfaff wrote:
> On Sun, Mar 09, 2014 at 05:48:52PM +0800, kmindg wrote:
>> The restriction only allows to send bpdu in forwarding state in
>> compose_output_action__. But a port could send bpdu in listening
>> and learning state accordi
On Wed, Mar 12, 2014 at 1:36 PM, Ben Pfaff wrote:
> On Sun, Mar 09, 2014 at 05:48:04PM +0800, kmindg wrote:
>> We do call heap_rebuild in ofproto_run, but we do not update rule's
>> priority with latest hard_timeout and idle_timeout before heap_rebuild.
>>
>>
The restriction only allows to send bpdu in forwarding state in
compose_output_action__. But a port could send bpdu in listening
and learning state according to comments in lib/stp.h(State of
an STP port).
Signed-off-by: kmindg
---
lib/stp.c| 9 +
lib/stp.h
imeout and idle_timwout.
Signed-off-by: kmindg
---
lib/heap.h| 1 -
ofproto/ofproto.c | 18 --
tests/ofproto.at | 74 +++
3 files changed, 85 insertions(+), 8 deletions(-)
diff --git a/lib/heap.h b/lib/heap.h
index 870f582..8829
On Sat, Feb 22, 2014 at 12:42 AM, Ben Pfaff wrote:
> On Fri, Feb 21, 2014 at 10:07:14AM +0800, Kmindg G wrote:
>> On Fri, Feb 21, 2014 at 5:19 AM, Ben Pfaff wrote:
>> > On Thu, Feb 20, 2014 at 12:45:49PM +0800, Kmindg G wrote:
>> >> On Thu, Feb 20, 201
On Fri, Feb 21, 2014 at 5:19 AM, Ben Pfaff wrote:
> On Thu, Feb 20, 2014 at 12:45:49PM +0800, Kmindg G wrote:
>> On Thu, Feb 20, 2014 at 3:20 AM, Ben Pfaff wrote:
>> > Until now, when it processes OFPT_PORT_MOD message, Open vSwitch has waited
>> > for ports to noti
se to send such port status updates,
> and I couldn't quickly find anything in OF1.3 or OF1.4 that said they
> shouldn't be sent.
>
> Signed-off-by: Ben Pfaff
> Reported-by: Kmindg G
> ---
> AUTHORS |1 +
> ofproto/ofproto.c | 25 +--
Signed-off-by: kmindg
---
lib/ofp-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 7de82c6..aa25e67 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -3640,7 +3640,7 @@ ofputil_decode_ofp11_port(struct ofputil_phy_port *pp
On Sun, Feb 9, 2014 at 9:56 AM, Jarno Rajahalme wrote:
>
>> On Feb 8, 2014, at 12:49 AM, Kmindg G wrote:
>>
>> Hi all,
>> I have a little question about miniflow_hash().
>> At the end of miniflow_hash, "p - flow->values" is used as the second
>
int32_t basis)
hash = mhash_add(hash, hash_map);
hash = mhash_add(hash, hash_map >> 32);
-return mhash_finish(hash, p - flow->values);
+return mhash_finish(hash,
+sizeof hash_map + count_1bits(hash_map) * sizeof *p);
}
cheers,
kmindg
__
30 matches
Mail list logo
