Re: [ovs-dev] NSH Option 2 implementation

2016-09-21 Thread Jesse Gross
On Tue, Sep 20, 2016 at 3:52 AM, Jan Scheurich wrote: >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Friday, 16 September, 2016 01:38 >> >> I think the main issue is that when packets are being tunneled and NSH is in >> use, the encapsulation format (and

Re: [ovs-dev] [PATCH v2 rebase] tun-metadata: Manage tunnel TLV mapping table on a per-bridge basis.

2016-09-19 Thread Jesse Gross
On Mon, Sep 19, 2016 at 8:48 AM, Ben Pfaff wrote: > On Thu, Sep 15, 2016 at 09:28:37AM -0700, Jesse Gross wrote: >> When using tunnel TLVs (at the moment, this means Geneve options), a >> controller must first map the class and type onto an appropriate OXM >> field so that

Re: [ovs-dev] [PATCH] datapath: backport: openvswitch: use alias for genetlink family names

2016-09-16 Thread Jesse Gross
On Fri, Sep 16, 2016 at 11:52 AM, Thadeu Lima de Souza Cascardo wrote: > Upstream commit: > openvswitch: use alias for genetlink family names > > When userspace tries to create datapaths and the module is not loaded, > it will simply fail. With this patch, the module will be automatica

Re: [ovs-dev] NSH Option 2 implementation

2016-09-15 Thread Jesse Gross
type-aware pipeline or is generalized otherwise, e.g. when >> introducing support for P4. >> >> BR, Jan >> >> > -Original Message- >> > From: Ben Pfaff [mailto:b...@ovn.org] >> > Sent: Tuesday, 06 September, 2016 16:31 >> > To: Jesse Gr

Re: [ovs-dev] [PATCH] datapath: compat: tunnels: Log error during initialization.

2016-09-15 Thread Jesse Gross
. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovs-save: Use ${bridge} when dumping TLV map.

2016-09-15 Thread Jesse Gross
On Thu, Sep 15, 2016 at 10:43 AM, Ben Pfaff wrote: > On Sun, Sep 11, 2016 at 06:26:23PM -0700, Jesse Gross wrote: >> The script accidentally hardcoded the bridge name as 'br-int', >> a leftover from testing. >> >> Reported-by: Huanle Han >> Signed-o

[ovs-dev] [PATCH v2 rebase] tun-metadata: Manage tunnel TLV mapping table on a per-bridge basis.

2016-09-15 Thread Jesse Gross
in the original packet format in more cases. This helps when copies need to be made as the amount of data touched is only what is present in the packet rather than the maximum amount of metadata supported. Co-authored-by: Madhu Challa Signed-off-by: Madhu Challa Signed-off-by: Jesse Gross

Re: [ovs-dev] Open vSwitch 2.6 release scheduled for Sept. 15

2016-09-13 Thread Jesse Gross
On Tue, Sep 13, 2016 at 1:18 PM, Alin Serdean wrote: > On the Windows side we still have to integrate multiple internal/external > ports. As it was discussed before, I was wondering if they could be > integrated in 2.6. I think we're really past the time where it makes sense to be adding new fe

Re: [ovs-dev] [PATCH] datapath: compat: geneve: use ovs specific device type for compat geneve module.

2016-09-12 Thread Jesse Gross
On Mon, Sep 12, 2016 at 2:48 PM, Pravin B Shelar wrote: > This allows openvswitch and geneve module co-exist kernel on newer > kernels. > > Reported-by: Joe Stringer > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev m

Re: [ovs-dev] procfs interface to openvswitch kernel module to help debugging

2016-09-12 Thread Jesse Gross
On Mon, Sep 12, 2016 at 10:22 AM, Ramu Ramamurthy wrote: > Hi, > > I dont see a /proc filesystem based interface to help debug the > openvswitch kernel module. Some of the knobs that may be useful are: > a) debug knobs for stats (for those stats are not already reported), > b) control knobs like:

[ovs-dev] [PATCH] ovs-save: Use ${bridge} when dumping TLV map.

2016-09-11 Thread Jesse Gross
The script accidentally hardcoded the bridge name as 'br-int', a leftover from testing. Reported-by: Huanle Han Signed-off-by: Jesse Gross --- utilities/ovs-save | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-save b/utilities/ovs-save index 4ae8fd

Re: [ovs-dev] [PATCH] datapath: Use pre-routing hook for conntrack.

2016-09-09 Thread Jesse Gross
On Fri, Sep 9, 2016 at 2:37 PM, Joe Stringer wrote: > On 8 September 2016 at 08:49, Jesse Gross wrote: >> On Wed, Sep 7, 2016 at 5:18 PM, Joe Stringer wrote: >>> On 1 September 2016 at 18:08, Jesse Gross wrote: >>>> On Thu, Sep 1, 2016 at 5:01 PM, Joe Stringer

Re: [ovs-dev] Open vSwitch 2.6 release scheduled for Sept. 15

2016-09-09 Thread Jesse Gross
On Fri, Sep 9, 2016 at 8:55 AM, Ben Pfaff wrote: > Our previously announced plan for OVS 2.6 is to release on Sept. 15, in > less than a week. In the OVN meeting in IRC yesterday, we already > discussed a few OVN bugs that should be fixed before the release. All > of them seem like they can be f

Re: [ovs-dev] [PATCH] datapath: Use pre-routing hook for conntrack.

2016-09-08 Thread Jesse Gross
On Wed, Sep 7, 2016 at 5:18 PM, Joe Stringer wrote: > On 1 September 2016 at 18:08, Jesse Gross wrote: >> On Thu, Sep 1, 2016 at 5:01 PM, Joe Stringer wrote: >>> The upstream code uses NF_INET_PRE_ROUTING hook for the nf_conntrack_in() >>> call, which does deeper (eg

Re: [ovs-dev] [PATCH] datapath: Use pre-routing hook for conntrack.

2016-09-01 Thread Jesse Gross
erved. Therefore it appears to be safe to bring this in > line with upstream without any other workarounds. > > Reported-by: Jesse Gross > Signed-off-by: Joe Stringer If you are confident that it doesn't cause problems on older kernels, the change looks obviously correct to me

[ovs-dev] [PATCH v2] tun-metadata: Manage tunnel TLV mapping table on a per-bridge basis.

2016-09-01 Thread Jesse Gross
in the original packet format in more cases. This helps when copies need to be made as the amount of data touched is only what is present in the packet rather than the maximum amount of metadata supported. Co-authored-by: Madhu Challa Signed-off-by: Madhu Challa Signed-off-by: Jesse Gross

Re: [ovs-dev] [PATCH] tun-metadata: Manage tunnel TLV mapping table on a per-bridge basis.

2016-09-01 Thread Jesse Gross
On Tue, Aug 30, 2016 at 1:17 PM, Ben Pfaff wrote: > On Tue, Aug 23, 2016 at 02:28:27PM -0700, Jesse Gross wrote: >> When using tunnel TLVs (at the moment, this means Geneve options), a >> controller must first map the class and type onto an appropriate OXM >> field so that

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-09-01 Thread Jesse Gross
On Thu, Sep 1, 2016 at 10:17 AM, Daniele Di Proietto wrote: > Let me try to sum up the problem further > > 1) Behavior on master, before commit 47bf118665a3("ofproto: Always set MTU > for new internal ports."): > > a) When an internal interface is added, or its MTU has changed we only > chan

Re: [ovs-dev] [PATCH v2 1/5] ofproto-dpif-xlate: Don't unwildcard tunnel attributes on set.

2016-08-31 Thread Jesse Gross
On Tue, Aug 30, 2016 at 6:47 PM, Daniele Di Proietto wrote: > When translating a set action we also unwildcard the field in question. > This is done to correctly translate set actions with the value identical > to the ingress flow, like in the following example: > > flow table: > > tcp,actions=set

Re: [ovs-dev] one issue about vhost xstats with/without CRC

2016-08-31 Thread Jesse Gross
On Wed, Aug 31, 2016 at 2:30 AM, Yang, Zhiyong wrote: > Hi, all: > > Physical NIC has a set of hardware counters, such as > u64 prc64; > u64 prc127; > u64 prc255; etc. > DPDK counts the prc64 in two ways. Physical NIC counts prc64 with CRC by > hardware. Virtio computes the counter like prc64 with

Re: [ovs-dev] [PATCH] ovs-save: Restore tunnel TLV map before flows.

2016-08-30 Thread Jesse Gross
On Tue, Aug 30, 2016 at 3:34 PM, Ben Pfaff wrote: > On Tue, Aug 30, 2016 at 02:16:36PM -0700, Jesse Gross wrote: >> Scripts that integrate OVS with a distribution often save and >> restore flows across distruptive events, such as an upgrade. The >> ovs-save utility generat

Re: [ovs-dev] [PATCH 1/2] ovs-ofctl: Fix crash with replace-flows and diff-flows with tunnel metadata.

2016-08-30 Thread Jesse Gross
On Tue, Aug 30, 2016 at 3:22 PM, Ben Pfaff wrote: > On Mon, Aug 29, 2016 at 11:58:14AM -0700, Jesse Gross wrote: >> When flows are read by ovs-ofctl (either from a switch or a file), >> tunnel metadata space is dynamically allocated since there isn't a >> preset table.

[ovs-dev] [PATCH] ovs-save: Restore tunnel TLV map before flows.

2016-08-30 Thread Jesse Gross
. Otherwise, the instance of OVS receiving the new flows won't know the meaning of these fields and will ignore them. Signed-off-by: Jesse Gross --- utilities/ovs-save | 6 ++ 1 file changed, 6 insertions(+) diff --git a/utilities/ovs-save b/utilities/ovs-save index d4d3c35..4ae8fde 100755

Re: [ovs-dev] [PATCH] ovn-controller: Convert encaps module back to full processing

2016-08-30 Thread Jesse Gross
On Sun, Aug 28, 2016 at 3:51 PM, Ryan Moats wrote: > diff --git a/ovn/controller/encaps.c b/ovn/controller/encaps.c > index d99ba05..87f 100644 > --- a/ovn/controller/encaps.c > +++ b/ovn/controller/encaps.c > +SBREC_CHASSIS_FOR_EACH (chassis_rec, ctx->ovnsb_idl) { > +for (int i =

Re: [ovs-dev] [PATCH] ipsec: Do not allow ipsec_gre tunnel traffic to exit unencrypted

2016-08-29 Thread Jesse Gross
king to work >properly with tunnels) > 2. ca3574d5 (IPsec: refactor out some code in >OVS_MONITOR_IPSEC_START macro) > > Signed-off-by: Ansis Atteka > Reported-by: Steffen Birkeland Acked-by: Jesse Gross ___ dev mailing list de

[ovs-dev] [PATCH 2/2] ovs-ofctl: Extract tunnel metadata correctly when sorting flows.

2016-08-29 Thread Jesse Gross
returned field is simply zeroed. This makes sorting based on tunnel metadata non-deterministic. We have the tunnel allocation stored in match metadata with each flow, so we can simply extract the data from there rather than trying to build and populate a global mapping table. Signed-off-by: Jesse Gross

[ovs-dev] [PATCH 1/2] ovs-ofctl: Fix crash with replace-flows and diff-flows with tunnel metadata.

2016-08-29 Thread Jesse Gross
lows. Signed-off-by: Jesse Gross --- tests/ovs-ofctl.at| 28 +++ utilities/ovs-ofctl.c | 209 +- 2 files changed, 218 insertions(+), 19 deletions(-) diff --git a/tests/ovs-ofctl.at b/tests/ovs-ofctl.at index 00db247..d966fc2 100644 --- a/test

Re: [ovs-dev] [RFC PATCHv6] netdev-dpdk: Enable Rx checksum offloading feature on DPDK physical ports.

2016-08-27 Thread Jesse Gross
Rx checksum offloading still offers 8-9% of improvement on VxLAN tunneling > decapsulation even though the SSE vector Rx function is disabled in DPDK poll > mode driver. > > Signed-off-by: Sugesh Chandran Thanks for all of the revisions! This one looks good to me. I'll look forwar

Re: [ovs-dev] [RFC PATCHv5] netdev-dpdk: Enable Rx checksum offloading feature on DPDK physical ports.

2016-08-26 Thread Jesse Gross
On Fri, Aug 26, 2016 at 2:39 AM, Chandran, Sugesh wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Thursday, August 25, 2016 10:09 PM >> To: Chandran, Sugesh >> Cc: ovs dev >> Subject: Re: [RFC PATCHv5] netdev

Re: [ovs-dev] [RFC PATCHv5] netdev-dpdk: Enable Rx checksum offloading feature on DPDK physical ports.

2016-08-25 Thread Jesse Gross
On Thu, Aug 25, 2016 at 2:43 AM, Sugesh Chandran wrote: > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index 6d334db..46c4045 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > static void > +dpdk_eth_checksum_offload_configure(struct netdev_dpdk *dev) > +OVS_REQUIRES(dev->m

Re: [ovs-dev] [PATCH] netdev-dpdk: Enable Rx checksum offloading feature on DPDK physical ports.

2016-08-24 Thread Jesse Gross
On Wed, Aug 24, 2016 at 7:54 AM, Sugesh Chandran wrote: > diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c > index ce2582f..31a12d6 100644 > --- a/lib/netdev-native-tnl.c > +++ b/lib/netdev-native-tnl.c > @@ -179,20 +181,26 @@ udp_extract_tnl_md(struct dp_packet *packet, struct > fl

Re: [ovs-dev] [RFC PATCHv3] netdev-dpdk: Enable Rx checksum offloading feature on DPDK physical ports.

2016-08-23 Thread Jesse Gross
On Tue, Aug 23, 2016 at 2:57 AM, Chandran, Sugesh wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Monday, August 22, 2016 7:50 PM >> To: Chandran, Sugesh >> Cc: ovs dev >> Subject: Re: [RFC PATCHv3] netdev

Re: [ovs-dev] NSH Option 2 implementation

2016-08-23 Thread Jesse Gross
On Tue, Aug 23, 2016 at 9:12 AM, Jan Scheurich wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Monday, 15 August, 2016 19:12 >> >> On Fri, Aug 12, 2016 at 1:01 AM, Jan Scheurich >> wrote: >> > The only cle

[ovs-dev] [PATCH] tun-metadata: Manage tunnel TLV mapping table on a per-bridge basis.

2016-08-23 Thread Jesse Gross
in the original packet format in more cases. This helps when copies need to be made as the amount of data touched is only what is present in the packet rather than the maximum amount of metadata supported. Co-authored-by: Madhu Challa Signed-off-by: Madhu Challa Signed-off-by: Jesse Gross

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 4.7

2016-08-22 Thread Jesse Gross
-- > 5 files changed, 17 insertions(+), 4 deletions(-) Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [RFC PATCHv3] netdev-dpdk: Enable Rx checksum offloading feature on DPDK physical ports.

2016-08-22 Thread Jesse Gross
On Mon, Aug 22, 2016 at 6:40 AM, Sugesh Chandran wrote: > diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c > index ce2582f..78ce0c9 100644 > --- a/lib/netdev-native-tnl.c > +++ b/lib/netdev-native-tnl.c > @@ -85,11 +85,17 @@ netdev_tnl_ip_extract_tnl_md(struct dp_packet *packet, > s

Re: [ovs-dev] [RFC PATCHv2] netdev-dpdk: Enable Rx checksum offloading feature on DPDK physical ports.

2016-08-22 Thread Jesse Gross
On Mon, Aug 22, 2016 at 6:38 AM, Chandran, Sugesh wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Saturday, August 20, 2016 2:07 AM >> To: Chandran, Sugesh >> Cc: ovs dev >> Subject: Re: [RFC PATCHv2] netdev

Re: [ovs-dev] [RFC PATCHv2] netdev-dpdk: Enable Rx checksum offloading feature on DPDK physical ports.

2016-08-19 Thread Jesse Gross
On Fri, Aug 19, 2016 at 3:40 AM, Sugesh Chandran wrote: > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index e5f2cdd..113e6d8 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -1090,6 +1127,15 @@ netdev_dpdk_set_config(struct netdev *netdev, const > struct smap *args) > >

Re: [ovs-dev] [PATCH] match: Only print external tunnel flags.

2016-08-19 Thread Jesse Gross
On Fri, Aug 19, 2016 at 8:54 AM, Ben Pfaff wrote: > On Thu, Aug 18, 2016 at 05:25:25PM -0700, Jesse Gross wrote: >> Some tunnel flags are purely internal implementation details (primarily >> FLOW_TNL_F_UDPIF). These shouldn't be output when we format tunnel >> flo

Re: [ovs-dev] Will openvSwitch-2.5.0 supports VXLAN over IPSEC ?

2016-08-19 Thread Jesse Gross
On Thu, Aug 18, 2016 at 9:23 PM, santhu vaddepally wrote: > Hi, > > Please , Can any one tell me whether openvSwitch-2.5.0 supports VXLAN > over IPSEC. I didn't find any stuff regarding support of VXLAN over IPSEC > in README or other. Is this feasible with the updated package ? No, it's not

[ovs-dev] [PATCH] match: Only print external tunnel flags.

2016-08-18 Thread Jesse Gross
Some tunnel flags are purely internal implementation details (primarily FLOW_TNL_F_UDPIF). These shouldn't be output when we format tunnel flows, so this masks them out. Signed-off-by: Jesse Gross --- lib/match.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [ovs-dev] [PATCH] tests: Avoid race in tunnel-push-pop tests.

2016-08-18 Thread Jesse Gross
On Thu, Aug 18, 2016 at 4:36 PM, pravin shelar wrote: > On Thu, Aug 18, 2016 at 12:26 PM, Jesse Gross wrote: >> These tests dump the flows currently in the datapath but they aren't >> the first to run and might have existing flows left over. We don't >> really

Re: [ovs-dev] [PATCH v2] datapath: compat: backport LCO optimization.

2016-08-18 Thread Jesse Gross
On Wed, Aug 17, 2016 at 10:17 PM, pravin shelar wrote: > On Wed, Aug 17, 2016 at 5:26 PM, Jesse Gross wrote: >> On Wed, Aug 17, 2016 at 10:23 AM, Pravin B Shelar wrote: >>> diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c >>> index 89df07

[ovs-dev] [PATCH] tests: Avoid race in tunnel-push-pop tests.

2016-08-18 Thread Jesse Gross
These tests dump the flows currently in the datapath but they aren't the first to run and might have existing flows left over. We don't really care if there are others flows present so filter on the ones we want to avoid being affected by the timing of flow eviction. Signed-off-by: J

Re: [ovs-dev] [PATCH RFC] netdev-dpdk: Rx checksum offloading feature on DPDK physical ports.

2016-08-17 Thread Jesse Gross
On Tue, Aug 16, 2016 at 3:06 AM, Chandran, Sugesh wrote: >> -Original Message- >> From: Jesse Gross [mailto:je...@kernel.org] >> Sent: Monday, August 15, 2016 6:44 PM >> To: Chandran, Sugesh >> Cc: ovs dev >> Subject: Re: [PATCH RFC] netdev-dpd

Re: [ovs-dev] [PATCH v2] datapath: compat: backport LCO optimization.

2016-08-17 Thread Jesse Gross
On Wed, Aug 17, 2016 at 10:23 AM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c > index 89df07f..48a56b9 100644 > --- a/datapath/linux/compat/gso.c > +++ b/datapath/linux/compat/gso.c > @@ -236,12 +236,12 @@ static int output_ip(struct sk_buff *skb

Re: [ovs-dev] [PATCH] ovn: Set critical bit in Geneve option.

2016-08-16 Thread Jesse Gross
On Tue, Aug 16, 2016 at 2:04 PM, Russell Bryant wrote: > > On Tue, Aug 16, 2016 at 4:58 PM, Jesse Gross wrote: >> >> Currently the Geneve option type that OVN uses is 0, which in >> Geneve marks this as non-critical. Non-critical means that if a >> receiver does no

Re: [ovs-dev] [PATCH 3/3] datapath: compat: gso: use sg and csum features for segmentation.

2016-08-16 Thread Jesse Gross
On Mon, Aug 15, 2016 at 2:11 PM, Pravin B Shelar wrote: > With use of LCO support we can finally enable SG and CSUM > features for GSO backport. > > Signed-off-by: Pravin B Shelar I don't know if this is safe. The kernels where this function is called are the ones without ndo_features_check, so

Re: [ovs-dev] [PATCH 2/3] datapath: compat: handle_offloads: remove csum_help param.

2016-08-16 Thread Jesse Gross
;csum_help' argument to iptunnel_handle_offloads > > All users now pass false, so we can remove it, and remove the code that > was conditional upon it. > > Signed-off-by: Edward Cree > Signed-off-by: David S. Miller > > Signed-off-by: Pravin B Shelar Acked-by: Jesse G

Re: [ovs-dev] [PATCH 1/3] datapath: compat: backport LCO optimization.

2016-08-16 Thread Jesse Gross
On Mon, Aug 15, 2016 at 2:11 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c > index 89df07f..f973fb4 100644 > --- a/datapath/linux/compat/gso.c > +++ b/datapath/linux/compat/gso.c > @@ -236,9 +236,6 @@ static int output_ip(struct sk_buff *skb) >

[ovs-dev] [PATCH] ovn: Set critical bit in Geneve option.

2016-08-16 Thread Jesse Gross
nclude the critical bit to properly mark the intention. Obviously, this will cause interoperability issues with any existing deployments but it should be fine while OVN is still labeled as experimental. Signed-off-by: Jesse Gross --- ovn/controller/physical.h | 2 +- ovn/ovn-architecture.7.xml | 2 +

Re: [ovs-dev] [PATCH RFC] netdev-dpdk: Rx checksum offloading feature on DPDK physical ports.

2016-08-15 Thread Jesse Gross
On Mon, Aug 8, 2016 at 3:03 AM, Sugesh Chandran wrote: > To enable checksum offloading at rx side while adding a port, add the > 'rx-checksum-offload' option to the 'ovs-vsctl add-port' command-line as > below, > > 'ovs-vsctl add-port br0 dpdk0 -- \ > set Interface dpdk0 type=dpdk options:rx-chec

Re: [ovs-dev] NSH Option 2 implementation

2016-08-15 Thread Jesse Gross
On Fri, Aug 12, 2016 at 1:01 AM, Jan Scheurich wrote: > The only clean way to avoid that now would be to maintain the monolithic > push/pop_nsh semantic of the Yi Yang patch and always push/pop NSH header and > outer MAC header together. Together with Simon's patch we could still achieve > NSH

Re: [ovs-dev] [PATCH v2] datapath: backport: openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-15 Thread Jesse Gross
e binding fails (e.g. due to the > port being in use), the error is currently ignored giving the > appearance that the tunnel vport creation completed successfully. > > Signed-off-by: Martynas Pumputis > Acked-by: Pravin B Shelar > Signed-off-by: D

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Use passed ctx in XLATE_REPORT_ERROR.

2016-08-15 Thread Jesse Gross
On Mon, Aug 15, 2016 at 9:22 AM, Ben Pfaff wrote: > On Mon, Aug 15, 2016 at 08:21:19AM -0700, Jesse Gross wrote: >> XLATE_REPORT_ERROR is a macro that takes struct xlate_ctx as an >> argument but also implicitly uses 'ctx' from the local function >> scope. This is

[ovs-dev] [PATCH] ofproto-dpif-xlate: Use passed ctx in XLATE_REPORT_ERROR.

2016-08-15 Thread Jesse Gross
XLATE_REPORT_ERROR is a macro that takes struct xlate_ctx as an argument but also implicitly uses 'ctx' from the local function scope. This is works with current uses but it really should be using the argument. Signed-off-by: Jesse Gross --- ofproto/ofproto-dpif-xlate.c | 2 +- 1 fi

Re: [ovs-dev] [PATCH rebase 3/3] ovn-controller: Use UDP checksums when creating Geneve tunnels.

2016-08-13 Thread Jesse Gross
On Fri, Aug 12, 2016 at 1:06 PM, Ben Pfaff wrote: > On Thu, Aug 11, 2016 at 05:20:34PM -0700, Jesse Gross wrote: >> Currently metadata transmitted by OVN over Geneve tunnels is >> unprotected by any checksum other than the one provided by the link >> layer - this includes

Re: [ovs-dev] [PATCH rebase 3/3] ovn-controller: Use UDP checksums when creating Geneve tunnels.

2016-08-13 Thread Jesse Gross
On Thu, Aug 11, 2016 at 7:10 PM, Ryan Moats wrote: > "dev" wrote on 08/11/2016 07:20:34 PM: > >> From: Jesse Gross >> To: dev@openvswitch.org >> Date: 08/11/2016 07:22 PM >> Subject: [ovs-dev] [PATCH rebase 3/3] ovn-controller: Use UDP >> checksums

Re: [ovs-dev] [PATCH rebase 2/3] ovn-controller: Make encap processing more robust against changes.

2016-08-13 Thread Jesse Gross
On Fri, Aug 12, 2016 at 12:57 PM, Ben Pfaff wrote: > On Thu, Aug 11, 2016 at 05:20:33PM -0700, Jesse Gross wrote: >> Originally, processing of encapsulations simply iterated over all tables on >> every wakeup and would replace anything that changed. This is somewhat >> ineffi

Re: [ovs-dev] [PATCH 2/2] datapath: backport: openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-13 Thread Jesse Gross
On Fri, Aug 12, 2016 at 10:49 AM, Pravin B Shelar wrote: > Upstream commit: > commit 4b5b9ba553f9aa5f484ab972fc9b58061885ceca > Author: Martynas Pumputis > Date: Tue Aug 9 16:24:50 2016 +0100 > > openvswitch: do not ignore netdev errors when creating tunnel vports > > The cr

Re: [ovs-dev] [PATCH 1/2] datapath: backport: OVS: Ignore negative headroom value

2016-08-13 Thread Jesse Gross
ly thus need no modification. > > Thanks to Ben for some pointers from the crash dumps! > > Cc: Benjamin Poirier > Cc: Paolo Abeni > Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1361414 > Signed-off-by: Ian Wienand > Signed-off-by: David S. Miller

[ovs-dev] [PATCH rebase 3/3] ovn-controller: Use UDP checksums when creating Geneve tunnels.

2016-08-11 Thread Jesse Gross
ff-by: Jesse Gross --- ovn/controller-vtep/gateway.c | 9 + ovn/controller/chassis.c | 8 ovn/controller/encaps.c | 12 +++- ovn/ovn-sb.xml| 10 -- ovn/utilities/ovn-sbctl.c | 2 ++ tests/ovn-controller-vtep.at | 1 + tests/ovn-sbc

[ovs-dev] [PATCH rebase 2/3] ovn-controller: Make encap processing more robust against changes.

2016-08-11 Thread Jesse Gross
work incrementally.") Signed-off-by: Jesse Gross --- ovn/controller/encaps.c | 471 +--- ovn/controller/ovn-controller.c | 1 + 2 files changed, 248 insertions(+), 224 deletions(-) diff --git a/ovn/controller/encaps.c b/ovn/controller/encaps.c ind

[ovs-dev] [PATCH rebase 1/3] ovn-controller: Fix memory leak when updating tunnels.

2016-08-11 Thread Jesse Gross
When a tunnel possibly needs to be updated, we are currently allocating a new name for it. This is not necessary and in fact nothing uses the name, which then results in the memory being leaked. Fixes: 1d45d5a9 ("ovn-controller: Change encaps_run to work incrementally.") Signed-off

[ovs-dev] [PATCH rebase 0/3] Enable Geneve checksums in OVN

2016-08-11 Thread Jesse Gross
of incremental processing which the first two patches fix. I'm targetting this for OVS 2.6 since the bulk of the changes are bug fixes and the benefits from the UDP checksums are significant. Jesse Gross (3): ovn-controller: Fix memory leak when updating tunnels. ovn-controller: Make

Re: [ovs-dev] [PATCH v2] datapath: compat: keep skb encapsulation zero on older kernel.

2016-08-11 Thread Jesse Gross
On Thu, Aug 11, 2016 at 2:12 PM, Pravin B Shelar wrote: > When using compat GSO there is no need to turn on skb > encapsulation bit since OVS does not use any tunnel GSO > functionality from the networking stack. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross And,

Re: [ovs-dev] [PATCH 3/3] datapath: compat: vxlan: fix vxlan_notify_add_rx_port().

2016-08-11 Thread Jesse Gross
On Wed, Aug 10, 2016 at 10:34 AM, Pravin B Shelar wrote: > Same as earlier patch this fixes vxlan recieve offload implementation. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvs

Re: [ovs-dev] [PATCH 2/3] datapath: compat: geneve: fix geneve_notify_add_rx_port()

2016-08-11 Thread Jesse Gross
On Wed, Aug 10, 2016 at 10:34 AM, Pravin B Shelar wrote: > Remove mutual exclusion between udp-gro registration and geneve receive port > registration. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@ope

Re: [ovs-dev] [PATCH 1/3] datapath: compat: keep skb encapsulation zero on older kernel.

2016-08-11 Thread Jesse Gross
On Wed, Aug 10, 2016 at 10:34 AM, Pravin B Shelar wrote: > When using compat GSO there is no need to turn on skb > encapsulation bit since OVS does not use any tunnel GSO > functionality from the networking stack. > > Signed-off-by: Pravin B Shelar I'm not sure that this is the best place to cle

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-08-09 Thread Jesse Gross
On Tue, Aug 9, 2016 at 7:52 AM, Simon Horman wrote: > Hi Jesse, > > On Wed, Jul 13, 2016 at 07:35:59AM -0700, Jesse Gross wrote: >> On Wed, Jul 13, 2016 at 4:04 AM, Brady Allen Johnson >> wrote: >> > I wanted to mention though, currently the type 2 metadata (MD2) i

Re: [ovs-dev] [PATCH 2/2] datapath: backport: net: vxlan: lwt: Use source ip address during route lookup.

2016-08-09 Thread Jesse Gross
and GRE. > > Fixes: ee122c79d42 ("vxlan: Flow based tunneling"). > Signed-off-by: Pravin B Shelar > Acked-by: Jiri Benc > Signed-off-by: David S. Miller > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross __

Re: [ovs-dev] [PATCH 1/2] datapath: backport: net: vxlan: lwt: Fix vxlan local traffic.

2016-08-09 Thread Jesse Gross
xlan: Flow based tunneling"). > Reported-by: Jakub Libosvar > Signed-off-by: Pravin B Shelar > Acked-by: Jiri Benc > Signed-off-by: David S. Miller > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross _

Re: [ovs-dev] [PATCH 2/6] datapath: compat: Use checksum offload for outer header.

2016-08-03 Thread Jesse Gross
On Wed, Aug 3, 2016 at 9:00 AM, pravin shelar wrote: > On Tue, Aug 2, 2016 at 4:55 PM, Jesse Gross wrote: >> On Tue, Aug 2, 2016 at 3:55 PM, pravin shelar wrote: >>> On Tue, Aug 2, 2016 at 3:11 PM, Jesse Gross wrote: >>>> On Tue, Aug 2, 2016 at 2:17 PM, Pravin B S

Re: [ovs-dev] [PATCH 1/6] datapath: compat: Use udp-checksum function for compat case.

2016-08-03 Thread Jesse Gross
ng patch couple this function to USE_UPSTREAM_TUNNEL symbol > rather than kernel version. > This is not bug, But it helps in code readability. > > Signed-off-by: Pravin B Shelar Since this is basically a subset of the other patch, with the same cav

Re: [ovs-dev] [PATCH 6/6] datapath: compat: gso: tighen checks for compat GSO code.

2016-08-03 Thread Jesse Gross
On Wed, Aug 3, 2016 at 10:08 AM, Pravin B Shelar wrote: > Few function can be compiled out for non GSO case. This > patch make it bit cleaner to understand GSO compat code. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev

Re: [ovs-dev] [PATCH 5/6] datapath: backport: geneve: fix max_mtu setting

2016-08-03 Thread Jesse Gross
lation data, the max_mtu should subtract > sizeof(ipv6hdr), instead of sizeof(iphdr). > > Signed-off-by: Haishuang Yan > Signed-off-by: David S. Miller > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___

Re: [ovs-dev] [PATCH 4/6] datapath: backport: openvswitch: fix conntrack netlink event delivery

2016-08-03 Thread Jesse Gross
omas Graf > Signed-off-by: Samuel Gauthier > Acked-by: Joe Stringer > Signed-off-by: David S. Miller > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/6] datapath: compat: vxlan: fix udp-csum typo

2016-08-03 Thread Jesse Gross
On Wed, Aug 3, 2016 at 10:08 AM, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar > --- > datapath/linux/compat/vxlan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jesse Gross ___ dev mailing list dev@ope

Re: [ovs-dev] [PATCH 2/6] datapath: fix size of struct ovs_gso_cb

2016-08-03 Thread Jesse Gross
On Wed, Aug 3, 2016 at 10:08 AM, Pravin B Shelar wrote: > struct ovs_gso_cb is stored in skb->cd. avoid going beyond size > of skb->cb. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@op

Re: [ovs-dev] [PATCH 2/6] datapath: compat: Use checksum offload for outer header.

2016-08-02 Thread Jesse Gross
On Tue, Aug 2, 2016 at 3:55 PM, pravin shelar wrote: > On Tue, Aug 2, 2016 at 3:11 PM, Jesse Gross wrote: >> On Tue, Aug 2, 2016 at 2:17 PM, Pravin B Shelar wrote: >>> Signed-off-by: Pravin B Shelar >>> --- >>> datapath/linux/compat/include/net/udp.h | 2

Re: [ovs-dev] [PATCH 6/6] datapath: Add support for kernel 4.7

2016-08-02 Thread Jesse Gross
On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar > --- > FAQ.md | 2 +- > NEWS | 2 +- > acinclude.m4 | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) Should we also add 4.7 to Travis? I noticed that there appear to be at least t

Re: [ovs-dev] [PATCH 5/6] datapath: compat: remove duplicate check.

2016-08-02 Thread Jesse Gross
On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote: > The check for tunnel GSO packet is done at ip-handle-offloads. Remove > same check from udp-handle-offloads. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mail

Re: [ovs-dev] [PATCH 4/6] datapath: compat: fix SKB_INIT_FILL_METADATA_DST definition

2016-08-02 Thread Jesse Gross
On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote: > In case of OVS using compat fill metadata dst implementation we need to > setup temperory dst. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@ope

Re: [ovs-dev] [PATCH 1/6] datapath: compat: Detect GSO support at ovs configure

2016-08-02 Thread Jesse Gross
> Signed-off-by: Pravin B Shelar It looks like RHEL 7.2 has already backported ndo_features_check, so this should give an immediate improvement there - not just a theoretical benefit. Acked-by: Jesse Gross ___ dev mailing list dev@op

Re: [ovs-dev] [PATCH 3/6] datapath: compat: cleanup ip-tunnels

2016-08-02 Thread Jesse Gross
On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote: > Remove kernel version check related to unsupported kernel. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.or

Re: [ovs-dev] [PATCH 2/6] datapath: compat: Use checksum offload for outer header.

2016-08-02 Thread Jesse Gross
On Tue, Aug 2, 2016 at 2:17 PM, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar > --- > datapath/linux/compat/include/net/udp.h | 2 +- > datapath/linux/compat/udp.c | 19 ++- > datapath/linux/compat/udp_tunnel.c | 17 + > 3 files changed

[ovs-dev] [PATCH 3/3] ovn-controller: Use UDP checksums when creating Geneve tunnels.

2016-08-01 Thread Jesse Gross
ff-by: Jesse Gross --- ovn/controller-vtep/gateway.c | 9 + ovn/controller/chassis.c | 8 ovn/controller/encaps.c | 12 +++- ovn/ovn-sb.xml| 10 -- ovn/utilities/ovn-sbctl.c | 2 ++ tests/ovn-controller-vtep.at | 1 + tests/ovn-sbc

[ovs-dev] [PATCH 1/3] ovn-controller: Fix memory leak when updating tunnels.

2016-08-01 Thread Jesse Gross
When a tunnel possibly needs to be updated, we are currently allocating a new name for it. This is not necessary and in fact nothing uses the name, which then results in the memory being leaked. Fixes: 1d45d5a9 ("ovn-controller: Change encaps_run to work incrementally.") Signed-off

[ovs-dev] [PATCH 2/3] ovn-controller: Make encap processing more robust against changes.

2016-08-01 Thread Jesse Gross
work incrementally.") Signed-off-by: Jesse Gross --- ovn/controller/encaps.c | 469 +--- ovn/controller/ovn-controller.c | 1 + 2 files changed, 247 insertions(+), 223 deletions(-) diff --git a/ovn/controller/encaps.c b/ovn/controller/encaps.c ind

[ovs-dev] [PATCH 0/3] Enable Geneve checksums in OVN

2016-08-01 Thread Jesse Gross
of incremental processing which the first two patches fix. I'm targetting this for OVS 2.6 since the bulk of the changes are bug fixes and the benefits from the UDP checksums are significant. Jesse Gross (3): ovn-controller: Fix memory leak when updating tunnels. ovn-controller: Make

Re: [ovs-dev] [PATCH v5 13/16] system-tests: Run conntrack tests with userspace.

2016-07-27 Thread Jesse Gross
On Wed, Jul 27, 2016 at 1:40 PM, Daniele Di Proietto wrote: > On 27/07/2016 13:12, "Joe Stringer" wrote: > >>On 26 July 2016 at 17:58, Daniele Di Proietto wrote: >>> The userspace connection tracker doesn't support ALGs, frag reassembly >>> or NAT yet, so skip those tests. >>> >>> Also, connecti

Re: [ovs-dev] Considering the possibility of integrating DPDK generic classifier APIs in OVS.

2016-07-27 Thread Jesse Gross
On Thu, Jul 21, 2016 at 3:55 AM, Chandran, Sugesh wrote: > Hi Mark & Jesse > > Thank you for looking into the the proposal, > Please find my answers inline below. > > Regards > _Sugesh > >> -Original Message- >> From: Gray, Mark D >> Sent:

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

2016-07-27 Thread Jesse Gross
On Thu, Jul 21, 2016 at 3:40 PM, Jan Scheurich wrote: > 1. The pending question whether to model NSH headers as packet header match > fields, metadata fields, or both applies in particular to the MD2 TLVs. > > We have three main OpenFlow use cases for the MD2 TLVs: > a) Match on an MD2 TLV of an

Re: [ovs-dev] [PATCH v2 1/3] datapath: compat: fix udp checksum calculation

2016-07-26 Thread Jesse Gross
On Tue, Jul 26, 2016 at 3:59 PM, pravin shelar wrote: > On Tue, Jul 26, 2016 at 3:53 PM, Jesse Gross wrote: >> On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote: >>> diff --git a/datapath/linux/compat/include/net/udp.h >>> b/datapath/linux/compat/include/

Re: [ovs-dev] [PATCH v2 3/3] datapath: compat: simplify ip_local_out().

2016-07-26 Thread Jesse Gross
On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar > --- > datapath/linux/compat/gso.c | 82 > ++--- > 1 file changed, 33 insertions(+), 49 deletions(-) Acked-

Re: [ovs-dev] [PATCH v2 2/3] datapath: compat: unset skb encapsulation bit

2016-07-26 Thread Jesse Gross
42:00.0: TX driver issue detected, PF reset issued > > Following patch resets this bit in case compat layer handles the packet. > > VMware-BZ: 1698877 > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvsw

Re: [ovs-dev] [PATCH v2 1/3] datapath: compat: fix udp checksum calculation

2016-07-26 Thread Jesse Gross
On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/include/net/udp.h > b/datapath/linux/compat/include/net/udp.h > index fa49fa5..266e70a 100644 > --- a/datapath/linux/compat/include/net/udp.h > +++ b/datapath/linux/compat/include/net/udp.h > @@ -54,7 +54

Re: [ovs-dev] releasing 2.6: branch Aug 1, release Sep 15

2016-07-26 Thread Jesse Gross
On Sun, Jul 24, 2016 at 10:53 AM, Ben Pfaff wrote: > On Sun, Jul 24, 2016 at 08:39:31AM -0300, Thadeu Lima de Souza Cascardo wrote: >> On Sat, Jul 23, 2016 at 08:59:35AM -0700, Ben Pfaff wrote: >> > The proposed Open vSwitch release schedule calls for branching 2.6 from >> > master on Aug. 1, foll

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 4.6

2016-07-26 Thread Jesse Gross
On Mon, Jul 25, 2016 at 6:40 PM, Pravin B Shelar wrote: > Most of patch iron out USE_UPSTREAM_TUNNEL case where datapath > directly use upstream tunneling modules. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mail

Re: [ovs-dev] [PATCH 2/3] datapath: compat: unset skb encapsulation bit

2016-07-26 Thread Jesse Gross
On Tue, Jul 26, 2016 at 12:30 PM, pravin shelar wrote: > On Tue, Jul 26, 2016 at 11:14 AM, Jesse Gross wrote: >> On Tue, Jul 26, 2016 at 10:56 AM, pravin shelar wrote: >>> On Tue, Jul 26, 2016 at 10:06 AM, Jesse Gross wrote: >>>> On Mon, Jul 25, 2016 at 5

  1   2   3   4   5   6   7   8   9   10   >