Re: [ovs-dev] unix socket whitelist limits a controller to one bridge

2011-12-21 Thread Jari Sundell
On Wed, Dec 21, 2011 at 2:38 AM, Ben Pfaff wrote: > On Tue, Dec 20, 2011 at 06:28:17PM +0900, Jari Sundell wrote: >> A while ago whitelisting of some pathnames were made for controller >> communication using unix sockets, however these are tied to the >> bridge/switch name.

[ovs-dev] unix socket whitelist limits a controller to one bridge

2011-12-20 Thread Jari Sundell
whitelist to also allow e.g. '$PREFIX/var/run/openvswitch/*.controller.shared' or similar for all switches? Jari Sundell ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] learn: Avoid 1-byte buffer underrun in learn_format().

2011-11-30 Thread Jari Sundell
Confirmed that this patch fixes the bug for me. Jari Sundell On Thu, Dec 1, 2011 at 4:40 AM, Ben Pfaff wrote: > Reported-by: Jari Sundell > --- >  lib/learn.c |   11 +++ >  1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/lib/learn.c b/lib/learn

[ovs-dev] [PATCH] Fixed segfault in learn_format

2011-11-14 Thread Jari Sundell
This patch fixes an issue where dst_field->n_bytes == 1 and src_value_bytes == 2 causing a segfault. Jari Sundell --- diff --git a/lib/learn.c b/lib/learn.c index 9f95a13..9fea40a 100644 --- a/lib/learn.c +++ b/lib/learn.c @@ -622,8 +622,10 @@ learn_format(const struct nx_action_learn *le

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-09 Thread Jari Sundell
On Thu, Nov 10, 2011 at 1:20 AM, Ben Pfaff wrote: > OK, great, so what are those issues? > > On Wed, Nov 09, 2011 at 05:12:13PM +0900, Jari Sundell wrote: >> The attached file shows output from dpctl dump-flows for the working, >> and non-working revisions. I think the mod_d

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-09 Thread Jari Sundell
erted. Jari Sundell On Tue, Nov 8, 2011 at 3:16 AM, Ben Pfaff wrote: > I'm still having a really hard time spotting the problem.  Can you > pass along an "ovs-dpctl dump-flows" output that includes a > set(eth(...)) action?  An "ofproto/trace" output that includes

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-05 Thread Jari Sundell
Pfaff wrote: > Does the problem only appear for flows that contain a mod_dl_dst action? > > On Sat, Nov 05, 2011 at 12:27:52PM +0900, Jari Sundell wrote: >> Yes, everything was recompiled and rebooted several times to narrow >> down the point at which the issue appeared. >>

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-04 Thread Jari Sundell
Yes, everything was recompiled and rebooted several times to narrow down the point at which the issue appeared. I suspect this could be related to the issue with packet out not working when mod_dl_dst action is specified (earlier mail in ovs-discuss), rather than the in-band issue. Jari Sundell

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-04 Thread Jari Sundell
Hi, The specific change was: git diff a0003c0c359bc3ffe8a6683dbd0121877a3ce700..4edb9ae90e4092f5f56b9d914d2b88783c49860d Jari Sundell On Fri, Nov 4, 2011 at 4:53 PM, Jari Sundell wrote: > After more testing it turns out it isn't the patch itself, rather > something that was comm

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-04 Thread Jari Sundell
After more testing it turns out it isn't the patch itself, rather something that was committed since 65c3058c22. Jari Sundell On Fri, Nov 4, 2011 at 4:30 PM, Jari Sundell wrote: > Seems things are not yet done... Without this patch (git master) > packets are properly being passed to

Re: [ovs-dev] [PATCH] stream: Fix uninitialized values in stream_init().

2011-11-04 Thread Jari Sundell
Seems things are not yet done... Without this patch (git master) packets are properly being passed to local port when disable-in-band is true. With the patch no packets get through, with or without disable-in-band set. Jari Sundell On Thu, Nov 3, 2011 at 5:10 AM, Ben Pfaff wrote: > Tha