Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-09 Thread Hannes Frederic Sowa
On 09.06.2016 22:35, Alexander Duyck wrote: > On Thu, Jun 9, 2016 at 12:23 PM, Hannes Frederic Sowa > wrote: >> On 09.06.2016 18:14, Alexander Duyck wrote: >>> On Thu, Jun 9, 2016 at 3:57 AM, Hannes Frederic Sowa >>> wrote: >>>> On 09.06.2016 04:33,

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-09 Thread Hannes Frederic Sowa
On 09.06.2016 18:14, Alexander Duyck wrote: > On Thu, Jun 9, 2016 at 3:57 AM, Hannes Frederic Sowa > wrote: >> On 09.06.2016 04:33, Alexander Duyck wrote: >>> On Wed, Jun 8, 2016 at 3:20 PM, Hannes Frederic Sowa >>> wrote: >>>> The remaining probl

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-09 Thread Hannes Frederic Sowa
On 09.06.2016 04:33, Alexander Duyck wrote: > On Wed, Jun 8, 2016 at 3:20 PM, Hannes Frederic Sowa > wrote: >> The remaining problem regarding offloads would be, that we by default >> get into the situation that without the special offloading rule the >> vxlan stream w

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-08 Thread Hannes Frederic Sowa
On 08.06.2016 23:21, Alexander Duyck wrote: > On Wed, Jun 8, 2016 at 12:46 PM, Hannes Frederic Sowa > wrote: >> On 08.06.2016 17:38, Alexander Duyck wrote: >>> On Wed, Jun 8, 2016 at 7:48 AM, Hannes Frederic Sowa >>> wrote: >>>> On 08.06.2016 14:51, Ji

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-08 Thread Hannes Frederic Sowa
On 08.06.2016 17:38, Alexander Duyck wrote: > On Wed, Jun 8, 2016 at 7:48 AM, Hannes Frederic Sowa > wrote: >> On 08.06.2016 14:51, Jiri Benc wrote: >>> On Mon, 6 Jun 2016 14:22:58 -0700, Jesse Gross wrote: >>>> On Sat, Jun 4, 2016 at 6:39 AM, Yi Yang wrote:

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

2016-06-08 Thread Hannes Frederic Sowa
On 08.06.2016 14:51, Jiri Benc wrote: > On Mon, 6 Jun 2016 14:22:58 -0700, Jesse Gross wrote: >> On Sat, Jun 4, 2016 at 6:39 AM, Yi Yang wrote: >> [...] >>> datapath/vport-netdev.c | 3 +- >>> datapath/vport-vxlan.c| 17 ++- >> >> These chan

Re: [ovs-dev] [PATCH net v3] ovs: limit ovs recursions in ovs_execute_actions to not corrupt stack

2016-01-15 Thread Hannes Frederic Sowa
On 15.01.2016 17:45, Eric Dumazet wrote: On Fri, 2016-01-15 at 15:33 +0100, Hannes Frederic Sowa wrote: It was seen that defective configurations of openvswitch could overwrite the STACK_END_MAGIC and cause a hard crash of the kernel because of too many recursions within ovs

[ovs-dev] [PATCH net v3] ovs: limit ovs recursions in ovs_execute_actions to not corrupt stack

2016-01-15 Thread Hannes Frederic Sowa
(RECURSION_LIMIT). We use the already existing recursion counter in ovs_execute_actions to implement an upper bound of 5 recursions. Cc: Pravin Shelar Cc: Simon Horman Signed-off-by: Hannes Frederic Sowa Reviewed-by: Simon Horman --- v2) added preemption guards v3) Pravin suggested to reuse

Re: [ovs-dev] [PATCH v2] net: preserve IP control block during GSO segmentation

2016-01-14 Thread Hannes Frederic Sowa
On 14.01.2016 00:36, Florian Westphal wrote: David Miller wrote: From: Konstantin Khlebnikov Date: Fri, 08 Jan 2016 15:21:46 +0300 Skb_gso_segment() uses skb control block during segmentation. This patch adds 32-bytes room for previous control block which will be copied into all resulting se

[ovs-dev] [PATCH net v2] ovs: add recursion limit to ovs_vport_receive

2016-01-14 Thread Hannes Frederic Sowa
(RECURSION_LIMIT). Thus add an extra recursion limit counter for ovs_vport_receive until parts of the stack usage is moved to percpu scratch space. Cc: Pravin Shelar Signed-off-by: Hannes Frederic Sowa --- v2) add preemption protection net/openvswitch/vport.c | 20 ++-- 1 file

Re: [ovs-dev] [PATCH net] ovs: add recursion limit to ovs_vport_receive

2016-01-12 Thread Hannes Frederic Sowa
On 13.01.2016 00:39, Hannes Frederic Sowa wrote: + if (__this_cpu_inc_return(ovs_recursion) > ovs_recursion_limit) { + net_crit_ratelimited("ovs: recursion limit reached on datapath %s, probable configuration error\n", +ovs_

[ovs-dev] [PATCH net] ovs: add recursion limit to ovs_vport_receive

2016-01-12 Thread Hannes Frederic Sowa
(RECURSION_LIMIT). Thus add an extra recursion limit counter for ovs_vport_receive until parts of the stack usage is moved to percpu scratch space. Cc: Pravin Shelar Signed-off-by: Hannes Frederic Sowa --- net/openvswitch/vport.c | 18 -- 1 file changed, 16 insertions(+), 2

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-08 Thread Hannes Frederic Sowa
On 07.01.2016 19:40, Thomas Graf wrote: On 01/07/16 at 06:50pm, Hannes Frederic Sowa wrote: On 07.01.2016 18:21, Thomas Graf wrote: On 01/07/16 at 08:35am, Jesse Gross wrote: On Thu, Jan 7, 2016 at 3:49 AM, Thomas Graf wrote: A simple start could be to add a new return code for > MTU dr

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread Hannes Frederic Sowa
On 07.01.2016 18:21, Thomas Graf wrote: On 01/07/16 at 08:35am, Jesse Gross wrote: On Thu, Jan 7, 2016 at 3:49 AM, Thomas Graf wrote: A simple start could be to add a new return code for > MTU drops in the dev_queue_xmit() path and check for NET_XMIT_DROP_MTU in ovs_vport_send() and emit prope

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-06 Thread Hannes Frederic Sowa
Hi, On 07.01.2016 00:57, Jesse Gross wrote: On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote: David Miller writes: Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of any size, constrained only by the ability to transmit the resulting UDP packets. 4.3 introduced vxlan ne