Re: [ovs-dev] [PATCH] nf_nat_packet: Clear skb hash after modifying packet headers.

2016-04-30 Thread Florian Westphal
Jarno Rajahalme wrote: > In the OVS datapath we clear the skb hash whenever we change any of the > fields that may be used to compute it. This guarantees that any given flow > will get the same hash value when assigning packets to bond interfaces based > on the skb hash. If the hash is not clea

Re: [ovs-dev] [PATCH] nf_nat_packet: Clear skb hash after modifying packet headers.

2016-04-29 Thread Florian Westphal
Pablo Neira Ayuso wrote: > On Wed, Apr 20, 2016 at 02:31:10PM -0700, Jarno Rajahalme wrote: > > Clear the skb hash when it does not reflect the actual header values > > any more. > > > > Signed-off-by: Jarno Rajahalme > > --- > > net/netfilter/nf_nat_core.c | 1 + > > 1 file changed, 1 insertio

Re: [ovs-dev] [PATCH v2] net: preserve IP control block during GSO segmentation

2016-01-13 Thread Florian Westphal
David Miller wrote: > From: Konstantin Khlebnikov > Date: Fri, 08 Jan 2016 15:21:46 +0300 > > > Skb_gso_segment() uses skb control block during segmentation. > > This patch adds 32-bytes room for previous control block which > > will be copied into all resulting segments. > > > > This patch fix

Re: [ovs-dev] [RFC PATCH 5/5] openvswitch: Interface with NAT.

2015-10-21 Thread Florian Westphal
Thomas Graf wrote: > On 10/21/15 at 11:34am, Florian Westphal wrote: > > Jarno Rajahalme wrote: > > > #define OVS_CS_F_REPLY_DIR 0x08 /* Flow is in the reply > > > direction. */ > > > #define OVS_CS_F_INVALID 0x10 /* Could not

Re: [ovs-dev] [RFC PATCH 5/5] openvswitch: Interface with NAT.

2015-10-21 Thread Florian Westphal
Jarno Rajahalme wrote: > Extend OVS conntrack interface to cover NAT. New nested > OVS_CT_ATTR_NAT may be used to include NAT with a CT action. A bare > OVS_CT_ATTR_NAT only mangles existing connections. If > OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested > attributes, new (

Re: [ovs-dev] 3.19-rc4: BUG: unable to handle kernel paging request at ffff880055f15000 ovs_packet_cmd_execute+0x1f/0x229

2015-01-14 Thread Florian Westphal
Thomas Graf wrote: > Copying ovs-dev mailing list and thus qutoing full message. > > On 01/14/15 at 01:14pm, Sander Eikelenboom wrote: > > Hi, > > > > I was testing 3.19-rc4 with openvswitch and encountered the splat below. > > What version of OVS are you using? Did this work properly with rc3

Re: [ovs-dev] [Discussion] About over-MTU-sized skb in virtualized env

2014-12-03 Thread Florian Westphal
Du Fan wrote: > Sorry for resend this mail, because my company email is rejected by netdev. > > > Hi Florian > > 214 static int ip_finish_output_gso(struct sk_buff *skb) > 215 { > 216 netdev_features_t features; > 217 struct sk_buff *segs; > 218 int ret = 0; > 219 > 220 /

Re: [ovs-dev] [net-next 3/7] openvswitch: Enable memory mapped Netlink i/o

2013-11-30 Thread Florian Westphal
Thomas Graf wrote: > Benchmark > * pktgen -> ovs internal port > * 5M pkts, 5M flows > * 4 threads, 8 cores > > Before: > Result: OK: 67418743(c67108212+d310530) usec, 500 (9000byte,0frags) > 74163pps 5339Mb/sec (5339736000bps) errors: 0 [..] > After: > Result: OK: 24229690(c24127165+