[ovs-dev] [patch_v6 0/3] ovn: arp responder fixes and documentation.

2016-11-04 Thread Darrell Ball
test to verify that arp requests from vtep ports are not responded to by logical switch arp responders after the fix for patch 1 is applied. Darrell Ball (3): ovn: Fix arping from vtep-gw physical port. ovn: Add additional comments regarding arp responders. ovn: Test arp requests received from

[ovs-dev] [patch_v6 1/3] ovn: Fix arping from vtep-gw physical port.

2016-11-04 Thread Darrell Ball
responder table because, potentially, multiple hypervisors could independently respond and confuse L2 learning at the arp originator. Signed-off-by: Ramu Ramamurthy Signed-off-by: Darrell Ball Co-authored-by: Darrell Ball --- ovn/northd/ovn-northd.c | 6 -- 1 file changed, 4 insertions(+), 2

[ovs-dev] [patch_v6 3/3] ovn: Test arp requests received from vtep ports.

2016-11-04 Thread Darrell Ball
Add a test that verifies that arp requests received from vtep ports are not responded to by logical switch arp responders. Signed-off-by: Darrell Ball --- v1->v2: Remove redundant MAC address binding command. tests/ovn.at | 30 ++ 1 file changed, 30 inserti

[ovs-dev] [patch_v6 2/3] ovn: Add additional comments regarding arp responders.

2016-11-04 Thread Darrell Ball
There has been enough confusion regarding logical switch datapath arp responders in ovn to warrant some additional comments; hence add a general description regarding why they exist and document the special cases. Signed-off-by: Darrell Ball Signed-off-by: Ramu Ramamurthy Co-authored-by: Ramu

Re: [ovs-dev] [patch_v5 2/3] ovn: Add additional comments regarding arp responders.

2016-11-02 Thread Darrell Ball
On Sun, Oct 23, 2016 at 11:19 AM, Mickey Spiegel wrote: > Acked-by: Mickey Spiegel > > A few very minor nits below. > > On Fri, Oct 21, 2016 at 1:36 PM, Darrell Ball wrote: > >> There has been enough confusion regarding logical switch datapath >> arp res

[ovs-dev] [patch_v5 3/3] ovn: Test arp requests received from vtep ports.

2016-10-21 Thread Darrell Ball
Add a test that verifies that arp requests received from vtep ports are not responded to by logical switch arp responders. Signed-off-by: Darrell Ball --- tests/ovn.at | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index 70f0331

[ovs-dev] [patch_v5 1/3] ovn: Fix arping from vtep-gw physical port.

2016-10-21 Thread Darrell Ball
responder table because, potentially, multiple hypervisors could independently respond and confuse L2 learning at the arp originator. Signed-off-by: Ramu Ramamurthy Signed-off-by: Darrell Ball Co-authored-by: Darrell Ball --- ovn/northd/ovn-northd.c | 6 -- 1 file changed, 4 insertions(+), 2

[ovs-dev] [patch_v5 2/3] ovn: Add additional comments regarding arp responders.

2016-10-21 Thread Darrell Ball
There has been enough confusion regarding logical switch datapath arp responders in ovn to warrant some additional comments; hence add a general description regarding why they exist and document the special cases. Signed-off-by: Darrell Ball Signed-off-by: Ramu Ramamurthy Co-authored-by: Ramu

[ovs-dev] [patch_v5 0/3] ovn: arp responder fixes and documentation.

2016-10-21 Thread Darrell Ball
test to verify that arp requests from vtep ports are not responded to by logical switch arp responders after the fix for patch 1 is applied. Darrell Ball (3): ovn: Fix arping from vtep-gw physical port. ovn: Add additional comments regarding arp responders. ovn: Test arp requests received from

Re: [ovs-dev] ovn: Improving southbound database security

2016-10-18 Thread Darrell Ball
On Wed, Oct 12, 2016 at 10:51 AM, Russell Bryant wrote: > Hello, I'm back to looking at southbound database security concerns in > OVN. A previous thread discussing approaches was here: > > http://openvswitch.org/pipermail/dev/2016-August/078106.html > > I'm now working with a few others on

Re: [ovs-dev] [patch_v4] ovn: Add additional comments regarding arp responders.

2016-10-10 Thread Darrell Ball
On Mon, Oct 10, 2016 at 12:27 AM, Mickey Spiegel wrote: > This is getting close. Some rewording suggestions below. > > On Thu, Oct 6, 2016 at 10:34 AM, Darrell Ball wrote: > >> There has been enough confusion regarding logical switch datapath >> arp responders in ovn to

Re: [ovs-dev] [patch_v4] ovn: Add additional comments regarding arp responders.

2016-10-10 Thread Darrell Ball
On Fri, Oct 7, 2016 at 5:25 PM, Han Zhou wrote: > Overall it looks good to me. Just suggestions for rewording. > > On Thu, Oct 6, 2016 at 10:34 AM, Darrell Ball wrote: > > > > There has been enough confusion regarding logical switch datapath > > arp responders in ovn

[ovs-dev] [patch_v4] ovn: Add additional comments regarding arp responders.

2016-10-06 Thread Darrell Ball
There has been enough confusion regarding logical switch datapath arp responders in ovn to warrant some additional comments; hence add a general description regarding why they exist and document the special cases. Signed-off-by: Darrell Ball --- Note this patch is meant to be merge with the

Re: [ovs-dev] [patch_v3] ovn: Add additional comments regarding arp responders.

2016-10-05 Thread Darrell Ball
This e-mail is a duplicate - ignore On Wed, Oct 5, 2016 at 6:06 PM, Darrell Ball wrote: > There has been enough confusion regarding logical switch datapath > arp responders in ovn to warrant some additional comments; > hence add a general description regarding why they exist and >

[ovs-dev] [patch_v3] ovn: Add additional comments regarding arp responders.

2016-10-05 Thread Darrell Ball
There has been enough confusion regarding logical switch datapath arp responders in ovn to warrant some additional comments; hence add a general description regarding why they exist and document the special cases. Signed-off-by: Darrell Ball --- ovn/northd/ovn-northd.8.xml | 51

[ovs-dev] [CudaMailTagged] [patch_v3] ovn: Add additional comments regarding arp responders.

2016-10-05 Thread Darrell Ball
There has been enough confusion regarding logical switch datapath arp responders in ovn to warrant some additional comments; hence add a general description regarding why they exist and document the special cases. Signed-off-by: Darrell Ball --- Note this patch is meant to be merge with the

Re: [ovs-dev] [patch_v5] ovn: Add datapaths of interest filtering.

2016-10-05 Thread Darrell Ball
I made a correction inline On Tue, Oct 4, 2016 at 10:04 PM, Darrell Ball wrote: > This patch adds datapaths of interest support where only datapaths of > local interest are monitored by the ovn-controller ovsdb client. The > idea is to do a flood fill in ovn-controller of datapath ass

Re: [ovs-dev] [patch_v2] ovn: Add additional comments regarding arp responders.

2016-10-05 Thread Darrell Ball
On Wed, Oct 5, 2016 at 2:37 PM, Mickey Spiegel wrote: > On Wed, Oct 5, 2016 at 10:08 AM, Darrell Ball wrote: > >> There has been enough confusion regarding logical switch datapath >> arp responders in ovn to warrant some additional comments; >> hence add a general descri

[ovs-dev] [patch_v2] ovn: Add additional comments regarding arp responders.

2016-10-05 Thread Darrell Ball
There has been enough confusion regarding logical switch datapath arp responders in ovn to warrant some additional comments; hence add a general description regarding why they exist and document the special cases. Signed-off-by: Darrell Ball --- v1->v2: Dropped RFC code change for logi

[ovs-dev] [patch_v5] ovn: Add datapaths of interest filtering.

2016-10-04 Thread Darrell Ball
Signed-off-by: Darrell Ball --- v4->v5: Correct cleanup of monitors. Fix warning. v3->v4: Refactor after incremental processing backout. Limit filtering to logical flows to limit risk. v2->v3: Line length violation fixups :/ v1->v2: Added logical port removal monitor

Re: [ovs-dev] [patch_v2 1/3] ovn: Skip logical switch "router type" port arp responder install.

2016-10-04 Thread Darrell Ball
On Tue, Oct 4, 2016 at 5:33 PM, Mickey Spiegel wrote: > > > On Tue, Oct 4, 2016 at 4:53 PM, Darrell Ball wrote: > >> >> >> On Tue, Oct 4, 2016 at 3:48 PM, Mickey Spiegel >> wrote: >> >>> On Mon, Oct 3, 2016 at 2:21 PM, Darrell Ball wrote

Re: [ovs-dev] [patch_v2 1/3] ovn: Skip logical switch "router type" port arp responder install.

2016-10-04 Thread Darrell Ball
16 at 3:27 PM, Darrell Ball wrote: > > > On Tue, Oct 4, 2016 at 11:04 AM, Han Zhou wrote: > >> >> >> On Tue, Oct 4, 2016 at 10:16 AM, Darrell Ball wrote: >> > >> > >> > >> > On Mon, Oct 3, 2016 at 3:16 PM, Han Zhou wrote:

Re: [ovs-dev] [patch_v2 1/3] ovn: Skip logical switch "router type" port arp responder install.

2016-10-04 Thread Darrell Ball
On Tue, Oct 4, 2016 at 3:48 PM, Mickey Spiegel wrote: > On Mon, Oct 3, 2016 at 2:21 PM, Darrell Ball wrote: > >> On Mon, Oct 3, 2016 at 10:54 AM, Han Zhou wrote: >> >> > >> > >> > On Sun, Oct 2, 2016 at 2:14 PM, Darrell Ball wrote: >> >

Re: [ovs-dev] [patch_v2 1/3] ovn: Skip logical switch "router type" port arp responder install.

2016-10-04 Thread Darrell Ball
On Tue, Oct 4, 2016 at 11:04 AM, Han Zhou wrote: > > > On Tue, Oct 4, 2016 at 10:16 AM, Darrell Ball wrote: > > > > > > > > On Mon, Oct 3, 2016 at 3:16 PM, Han Zhou wrote: > >> > >> > >> > >> On Mon, Oct 3, 2016 at 2:21 PM,

Re: [ovs-dev] [PATCH v3] ovn-vtep: fix arping from vtep-gw physical port

2016-10-04 Thread Darrell Ball
On Tue, Sep 27, 2016 at 12:14 PM, Ramu Ramamurthy wrote: > Currently, arping from a vtep-gw physical-switch port to > a VIF IP address does not work. > When a physical-switch-port arps for an IP address > of a VIF, that arp packet comes into the VIF hypervisor via a > vxlan tunnel. That arp pac

Re: [ovs-dev] [patch_v2 1/3] ovn: Skip logical switch "router type" port arp responder install.

2016-10-04 Thread Darrell Ball
On Mon, Oct 3, 2016 at 3:16 PM, Han Zhou wrote: > > > On Mon, Oct 3, 2016 at 2:21 PM, Darrell Ball wrote: > > > > > > > > On Mon, Oct 3, 2016 at 10:54 AM, Han Zhou wrote: > >> > >> > >> > >> On Sun, Oct 2, 2016 at 2:14 PM, Da

Re: [ovs-dev] [patch_v4] ovn: Add datapaths of interest filtering.

2016-10-04 Thread Darrell Ball
This patch does not include cleanup of stale datapaths of interest, with this post incremental processing code base. I will add the cleanup today. On Tue, Oct 4, 2016 at 12:49 AM, Darrell Ball wrote: > This patch adds datapaths of interest support where only datapaths of > local intere

[ovs-dev] [patch_v4] ovn: Add datapaths of interest filtering.

2016-10-04 Thread Darrell Ball
Signed-off-by: Darrell Ball --- v3->v4: Refactor after incremental processing backout. Limit filtering to logical flows to limit risk. v2->v3: Line length violation fixups :/ v1->v2: Added logical port removal monitoring handling, factoring in recent changes for in

Re: [ovs-dev] [patch_v2 1/3] ovn: Skip logical switch "router type" port arp responder install.

2016-10-03 Thread Darrell Ball
On Mon, Oct 3, 2016 at 10:54 AM, Han Zhou wrote: > > > On Sun, Oct 2, 2016 at 2:14 PM, Darrell Ball wrote: > > > > > > > > On Sun, Oct 2, 2016 at 11:27 AM, Han Zhou wrote: > >> > >> On Sat, Oct 1, 2016 at 4:34 PM, Darrell Ball wrote: > &

Re: [ovs-dev] [patch_v2 2/3] ovn: Add additional comments regarding arp responders.

2016-10-02 Thread Darrell Ball
On Sun, Oct 2, 2016 at 11:42 AM, Han Zhou wrote: > On Sat, Oct 1, 2016 at 4:34 PM, Darrell Ball wrote: > > > > > > > - These flows are omitted for logical ports (other than router > ports) > > - that are down. > > +

Re: [ovs-dev] [patch_v2 3/3] ovn: Adjust test for lack of arp responder.

2016-10-02 Thread Darrell Ball
, for the reason patch 1 breaks this test - that is one rule we use. > > On Sat, Oct 1, 2016 at 4:34 PM, Darrell Ball wrote: > >> If arp responders are unnecessay for logical switch >> "router type" ports. then an adjustment is necessary >> for a test. >&

Re: [ovs-dev] [patch_v2 1/3] ovn: Skip logical switch "router type" port arp responder install.

2016-10-02 Thread Darrell Ball
On Sun, Oct 2, 2016 at 11:27 AM, Han Zhou wrote: > On Sat, Oct 1, 2016 at 4:34 PM, Darrell Ball wrote: > > > > Do not install any potential logical switch "router type" > > port arp responders. Logical router port arp responders > > should be sufficient i

Re: [ovs-dev] [CudaMailTagged] [patch_v1] ovn: Add additional comments regarding arp responders.

2016-10-01 Thread Darrell Ball
On Tue, Sep 27, 2016 at 10:05 PM, Han Zhou wrote: > > > On Tue, Sep 27, 2016 at 5:11 PM, Darrell Ball wrote: > > >> > >> These port types are skipped because ARP responder is not supposed to > handle ARP requests that come from physical network. > >

[ovs-dev] [CudaMailTagged] [patch_v2 0/3] ovn: Some arp responder changes.

2016-10-01 Thread Darrell Ball
hange here for VTEP type ports is meant to be merged and consistent with the patch https://patchwork.ozlabs.org/patch/675796/ v1->v2: Change handling and documentation regarding logical switch "router type" port arp responders. Darrell Ball (3): ovn: Skip logical switch "rou

[ovs-dev] [patch_v2 3/3] ovn: Adjust test for lack of arp responder.

2016-10-01 Thread Darrell Ball
If arp responders are unnecessay for logical switch "router type" ports. then an adjustment is necessary for a test. Signed-off-by: Darrell Ball --- tests/ovn.at | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index f40940f..aff1

[ovs-dev] [patch_v2 1/3] ovn: Skip logical switch "router type" port arp responder install.

2016-10-01 Thread Darrell Ball
ally using this capability in ovn. Signed-off-by: Darrell Ball --- ovn/northd/ovn-northd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index eeeb41d..17ea90f 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ov

[ovs-dev] [patch_v2 2/3] ovn: Add additional comments regarding arp responders.

2016-10-01 Thread Darrell Ball
There has been enough confusion regarding arp responders in ovn to warrant some additional comments; hence add a general description regarding why they exist and document the special cases. Signed-off-by: Darrell Ball --- ovn/northd/ovn-northd.8.xml | 25 - 1 file

Re: [ovs-dev] [PATCH v2] ovn-vtep: fix arping from vtep-gw physical port

2016-09-29 Thread Darrell Ball
On Thu, Sep 29, 2016 at 7:31 PM, Ramu Ramamurthy wrote: > > Hello Ramu > > > > Can you describe your configuration for this test failure when logical > > switch > > arp responders are skipped for logical switch "router type" ports ? > > I know the existing OVN tests (both system and non-system)

Re: [ovs-dev] [PATCH v2] ovn-vtep: fix arping from vtep-gw physical port

2016-09-29 Thread Darrell Ball
On Mon, Sep 26, 2016 at 2:00 PM, Darrell Ball wrote: > > > On Mon, Sep 26, 2016 at 11:24 AM, Ramu Ramamurthy < > ramu.ramamur...@gmail.com> wrote: > >> -if (!strcmp(op->nbsp->type, "localnet")) { >> +/* Skip

Re: [ovs-dev] [PATCH] ovn: Do not reply to ARP or ND NS for a VM's own IP address.

2016-09-29 Thread Darrell Ball
tip_unknown=11.11.11.11 > -test_arp $s f0:00:00:00:00:0$s $sip $tip f0:00:00:00:00:0$d > #9 > +if test $d != $s; then reply_ha=f0:00:00:00:00:0$d; else > reply_ha=; fi > Would it be helpful to update bullet "9." in the preceding description? > +

Re: [ovs-dev] [CudaMailTagged] [patch_v1] ovn: Add additional comments regarding arp responders.

2016-09-27 Thread Darrell Ball
On Tue, Sep 27, 2016 at 4:49 PM, Han Zhou wrote: > > > On Tue, Sep 27, 2016 at 2:36 PM, Darrell Ball wrote: > > > > There has been enough confusion regarding arp responders in > > ovn to warrant some additional comments; hence add a > > general description rega

[ovs-dev] [CudaMailTagged] [patch_v1] ovn: Add additional comments regarding arp responders.

2016-09-27 Thread Darrell Ball
/ Signed-off-by: Darrell Ball --- ovn/northd/ovn-northd.8.xml | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml index 307e8be..0755213 100644 --- a/ovn/northd/ovn-northd.8.xml +++ b/ovn/northd/ovn-northd.8

Re: [ovs-dev] [PATCH v2] INSTALL.md: Add details about kernel module preference.

2016-09-27 Thread Darrell Ball
On Tue, Sep 27, 2016 at 8:21 AM, Guru Shetty wrote: > > > On 26 September 2016 at 20:52, Darrell Ball wrote: > >> >> >> On Mon, Sep 26, 2016 at 7:34 AM, Gurucharan Shetty wrote: >> >>> Signed-off-by: Gurucharan Shetty >>> --- >>&g

Re: [ovs-dev] [PATCH v2] INSTALL.md: Add details about kernel module preference.

2016-09-26 Thread Darrell Ball
On Mon, Sep 26, 2016 at 8:52 PM, Darrell Ball wrote: > > > On Mon, Sep 26, 2016 at 7:34 AM, Gurucharan Shetty wrote: > >> Signed-off-by: Gurucharan Shetty >> --- >> INSTALL.md | 23 ++- >> 1 file changed, 22 insertions(+), 1 deletio

Re: [ovs-dev] [PATCH v2] INSTALL.md: Add details about kernel module preference.

2016-09-26 Thread Darrell Ball
On Mon, Sep 26, 2016 at 7:34 AM, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty > --- > INSTALL.md | 23 ++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/INSTALL.md b/INSTALL.md > index bb40e4a..6ecefdf 100644 > --- a/INSTALL.md > +++ b/INS

Re: [ovs-dev] [PATCH v2] ovn-vtep: fix arping from vtep-gw physical port

2016-09-26 Thread Darrell Ball
On Mon, Sep 26, 2016 at 11:24 AM, Ramu Ramamurthy wrote: > -if (!strcmp(op->nbsp->type, "localnet")) { > +/* Skip arp responder if the logical switch inport is not > + * associated with a local VIF or a l2gateway port */ > +if ((strcmp(op->nbsp->type, "")) && > +

Re: [ovs-dev] [PATCH v2] ovn-vtep: fix arping from vtep-gw physical port

2016-09-23 Thread Darrell Ball
On Thu, Sep 22, 2016 at 1:07 PM, Ramu Ramamurthy wrote: > Currently, arping from a vtep-gw physical-switch port to > a VIF IP address does not work. > > When a physical-switch-port arps for an IP address > of a VIF, that arp packet comes into the VIF hypervisor via a > vxlan tunnel. That arp pack

Re: [ovs-dev] [PATCH] ovn-vtep: fix arping from vtep-gw physical port

2016-09-20 Thread Darrell Ball
On Tue, Sep 20, 2016 at 2:38 PM, Ramu Ramamurthy wrote: > > > > Does the following diff work on your system? > > > > > > diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml > > index 7797417..4f1cd89 100644 > > --- a/ovn/northd/ovn-northd.8.xml > > +++ b/ovn/northd/ovn-northd.8

Re: [ovs-dev] [PATCH] ovn-vtep: fix arping from vtep-gw physical port

2016-09-19 Thread Darrell Ball
On Mon, Sep 19, 2016 at 2:32 PM, Ramu Ramamurthy wrote: > Currently, arping from a vetp-gw physical-switch port to > a VIF IP address does not work. > > When a physical-switch-port arps for an IP address > of a VIF, that arp packet comes into the VIF hypervisor via a > vxlan tunnel. That arp pack

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-08-31 Thread Darrell Ball
On Wed, Aug 31, 2016 at 6:48 PM, Joe Stringer wrote: > On 31 August 2016 at 14:52, Daniele Di Proietto > wrote: > > Open vSwitch controls the MTU of internal ports and sets it to the > > minimum of physical ports MTU on the same bridge. > > > > Commit 47bf118665a3("ofproto: Always set MTU for ne

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-08-31 Thread Darrell Ball
On Wed, Aug 31, 2016 at 2:52 PM, Daniele Di Proietto wrote: > Open vSwitch controls the MTU of internal ports and sets it to the > minimum of physical ports MTU on the same bridge. > > Commit 47bf118665a3("ofproto: Always set MTU for new internal ports.") > made this more consistent. Now the MTU

Re: [ovs-dev] [RFC] ovn: minimize the impact of a compromised chassis

2016-08-23 Thread Darrell Ball
On Tue, Aug 23, 2016 at 2:20 PM, Russell Bryant wrote: > > > On Tue, Aug 23, 2016 at 5:05 PM, Darrell Ball wrote: > >> >> >> On Mon, Aug 22, 2016 at 1:08 PM, Lance Richardson >> wrote: >> >>> > From: "Ben Pfaff" >>> &

Re: [ovs-dev] [RFC] ovn: minimize the impact of a compromised chassis

2016-08-23 Thread Darrell Ball
On Mon, Aug 22, 2016 at 1:08 PM, Lance Richardson wrote: > > From: "Ben Pfaff" > > To: "Russell Bryant" > > Cc: "Lance Richardson" , "ovs dev" < > dev@openvswitch.org>, "Russell Bryant" > > Sent: Monday, August 22, 2016 1:22:43 PM > > Subject: Re: [ovs-dev] [RFC] ovn: minimize the impact of a

Re: [ovs-dev] [PATCH V3] ovs-vtep: vtep-ctl and ovs-vtep support of adding explicit tunnel key

2016-08-22 Thread Darrell Ball
uot;, RW}, {"del-mcast-local", 3, 4, NULL, pre_get_info, cmd_del_mcast_local, NULL, "", RW}, @@ -2568,11 +2605,11 @@ static const struct ctl_command_syntax vtep_commands[] = { "", RO}, {"list-local-macs", 1, 1, NULL, pre_get_info, cmd_list_l

Re: [ovs-dev] [patch_v3] ovn: Add datapaths of interest filtering.

2016-08-15 Thread Darrell Ball
On Wed, Aug 10, 2016 at 2:53 AM, Liran Schour wrote: > Darrell Ball wrote on 09/08/2016 08:02:06 PM: > > > On Thu, Aug 4, 2016 at 3:26 AM, Liran Schour wrote: > > "dev" wrote on 03/08/2016 09:09:48 AM: > > > > > From: Darrell Ball > >

Re: [ovs-dev] [PATCH V3] ovs-vtep: vtep-ctl and ovs-vtep support of adding explicit tunnel key

2016-08-12 Thread Darrell Ball
+self.add_tunnel(tunnel_ip, tunnel_key, tunnel_scope_key) On Thu, Aug 11, 2016 at 2:12 PM, Darrell Ball wrote: > I have various comments; I focused on the big picture mainly and > did not review most details except ovs-vtep and one or two selected > spots elsewhere, pending agreement on the bi

Re: [ovs-dev] [PATCH V3] ovs-vtep: vtep-ctl and ovs-vtep support of adding explicit tunnel key

2016-08-11 Thread Darrell Ball
I have various comments; I focused on the big picture mainly and did not review most details except ovs-vtep and one or two selected spots elsewhere, pending agreement on the big picture. Some comments are the same as I made in the first patch. Your patch did not apply cleanly due to previous cha

Re: [ovs-dev] [patch_v8] ovn: Fix receive from vxlan in ovn-controller.

2016-08-10 Thread Darrell Ball
On Wed, Aug 10, 2016 at 4:33 PM, Justin Pettit wrote: > > > On Aug 8, 2016, at 7:20 PM, Darrell Ball wrote: > > > > > > diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c > > index 589b053..43885fd 100644 > > --- a/ovn/controller/physica

Re: [ovs-dev] [patch_v3] ovn: Add datapaths of interest filtering.

2016-08-09 Thread Darrell Ball
On Thu, Aug 4, 2016 at 3:26 AM, Liran Schour wrote: > "dev" wrote on 03/08/2016 09:09:48 AM: > > > From: Darrell Ball > > To: dlu...@gmail.com, d...@openvswitch.com, b...@ovn.org > > Date: 03/08/2016 09:10 AM > > Subject: [ovs-dev] [patch_v3] ovn: Add d

[ovs-dev] [patch_v8] ovn: Fix receive from vxlan in ovn-controller.

2016-08-08 Thread Darrell Ball
state for receipt from a vxlan tunnel, a MFF logical flags register flag is allocated. As part of this change ovn-controller-vtep is hard-coded to set the replication mode of each logical switch to source node as OVN will only support source node replication. Signed-off-by: Darrell Ball ---

Re: [ovs-dev] [patch_v7] ovn: Fix receive from vxlan in ovn-controller.

2016-08-08 Thread Darrell Ball
closely with some folks. On Mon, Aug 8, 2016 at 12:57 PM, Darrell Ball wrote: > > > On Sat, Aug 6, 2016 at 12:38 PM, Ryan Moats wrote: > >> "dev" wrote on 07/29/2016 06:08:38 PM: >> >> > From: Darrell Ball >> > To: dlu...@gmail.com, d...@openvswi

Re: [ovs-dev] [patch_v7] ovn: Fix receive from vxlan in ovn-controller.

2016-08-08 Thread Darrell Ball
On Sat, Aug 6, 2016 at 12:38 PM, Ryan Moats wrote: > "dev" wrote on 07/29/2016 06:08:38 PM: > > > From: Darrell Ball > > To: dlu...@gmail.com, d...@openvswitch.com, b...@ovn.org > > Date: 07/29/2016 06:09 PM > > Subject: [ovs-dev] [patch_v7] ovn: Fi

[ovs-dev] [patch_v3] ovn: Add datapaths of interest filtering.

2016-08-02 Thread Darrell Ball
- related_datapaths to facilitate this so all datapaths associations are known quickly in ovn-controller. This allows monitoring to adapt quickly with a single new monitor setting for all datapaths of interest locally. Signed-off-by: Darrell Ball --- v2->v3: Line length violation fixups :/ v1-

[ovs-dev] [patch_v2] ovn: Add datapaths of interest filtering.

2016-08-02 Thread Darrell Ball
- related_datapaths to facilitate this so all datapaths associations are known quickly in ovn-controller. This allows monitoring to adapt quickly with a single new monitor setting for all datapaths of interest locally. Signed-off-by: Darrell Ball --- v1->v2: Added logical port removal monitor

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Darrell Ball
On Tue, Aug 2, 2016 at 2:38 PM, Mickey Spiegel wrote: > On Tue, Aug 2, 2016 at 1:39 PM, Darrell Ball wrote: > >> >> >> On Tue, Aug 2, 2016 at 12:05 PM, Russell Bryant wrote: >> >>> >>> >>> On Tue, Aug 2, 2016 at 3:02 PM, Darrell Ball

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Darrell Ball
On Tue, Aug 2, 2016 at 12:05 PM, Russell Bryant wrote: > > > On Tue, Aug 2, 2016 at 3:02 PM, Darrell Ball wrote: > >> >> >> On Tue, Aug 2, 2016 at 10:23 AM, Mickey Spiegel >> wrote: >> >>> On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Darrell Ball
On Tue, Aug 2, 2016 at 10:23 AM, Mickey Spiegel wrote: > On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote: > >> >> >> On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant wrote: >> >>> On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel >>> wrote: &g

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Darrell Ball
On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant wrote: > On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel > wrote: > > > On Fri, Jul 29, 2016 at 10:28 AM, Mickey Spiegel > > wrote: > > > > > > -"dev" wrote: - > > >> To: Mickey Spiegel > > >> From: Russell Bryant > > >> Sent by: "dev" >

Re: [ovs-dev] [patch_v1] ovn: Add datapaths of interest filtering (RFC).

2016-07-31 Thread Darrell Ball
On Sat, Jul 30, 2016 at 10:58 AM, Liran Schour wrote: > "dev" wrote on 29/07/2016 11:46:09 AM: > > > From: Darrell Ball > > To: dlu...@gmail.com, d...@openvswitch.com, b...@ovn.org > > Date: 29/07/2016 11:46 AM > > Subject: [ovs-dev] [patch_v1] ovn: Ad

Re: [ovs-dev] [patch_v6 1/2] ovn: Fix receive from vxlan in ovn-controller.

2016-07-29 Thread Darrell Ball
On Wed, Jul 27, 2016 at 1:35 PM, Ben Pfaff wrote: > On Sat, Jul 23, 2016 at 01:18:01PM -0700, Darrell Ball wrote: > > This patch enables source node replication in OVN for receive from Vxlan > > tunnels. OVN only supports source node replication mode. > > > > OV

[ovs-dev] [patch_v7] ovn: Fix receive from vxlan in ovn-controller.

2016-07-29 Thread Darrell Ball
to set the replication mode of each logical switch to source node as OVN will only support source node replication. Signed-off-by: Darrell Ball --- ovn/controller-vtep/vtep.c | 4 ovn/controller/physical.c | 25 - ovn/lib/logical-fields.h | 15 +++ ovn/ovn-arch

[ovs-dev] [patch_v1] ovn: Add datapaths of interest filtering (RFC).

2016-07-29 Thread Darrell Ball
area. Signed-off-by: Darrell Ball --- ovn/controller/binding.c| 21 +--- ovn/controller/ovn-controller.c | 116 ++-- ovn/controller/ovn-controller.h | 8 +++ ovn/controller/patch.c | 19 +-- ovn/northd/ovn-northd.c | 74

[ovs-dev] [patch_v6 2/2] ovn: Reformat some ovn design documentation.

2016-07-23 Thread Darrell Ball
following markdown parsers: https://jbt.github.io/markdown-editor/ http://dillinger.io/ The new flags register usage is also documented in the new OVN-DESIGN.md document. Signed-off-by: Darrell Ball --- ovn/OVN-DESIGN.md | 199 + ovn/automake.mk

[ovs-dev] [patch_v6 1/2] ovn: Fix receive from vxlan in ovn-controller.

2016-07-23 Thread Darrell Ball
vxlan context. As part of this change ovn-controller-vtep is hard-coded to set the replication mode of each logical switch to source node as OVN will only support source node replication. Signed-off-by: Darrell Ball --- ovn/controller-vtep/vtep.c | 4 ovn/controller/physical.c | 25

[ovs-dev] [patch_v6 0/2] ovn: Fix receive from vxlan in ovn-controller.

2016-07-23 Thread Darrell Ball
. Split code change for bug fix and documentation update into two patches. v1->v2: Rebased after recent conflicting commit. Converted some xml comments ported from the ovn-architecture document. Removed redundant register initialization and unnecessary bit declaration. Darrell Ball (2): ovn:

Re: [ovs-dev] [PATCH monitor_cond V10] RFC OVN: Implementation of conditional monitoring usage

2016-07-22 Thread Darrell Ball
On Thu, Jul 21, 2016 at 4:18 AM, Liran Schour wrote: > Mickey Spiegel/San Jose/IBM wrote on 20/07/2016 08:53:42 AM: > > > From: Mickey Spiegel/San Jose/IBM > > To: Liran Schour/Haifa/IBM@IBMIL > > Cc: Ben Pfaff , dev@openvswitch.org > > Date: 20/07/2016 08:53 AM > > Subject: Re: [ovs-dev] [PATCH

Re: [ovs-dev] Question about ovs-vtep implementation

2016-07-15 Thread Darrell Ball
On Fri, Jul 15, 2016 at 11:00 AM, Lance Richardson wrote: > > From: "Darrell Ball" > > To: "Lance Richardson" > > Cc: "ovs dev" > > Sent: Tuesday, July 12, 2016 5:34:04 PM > > Subject: Re: [ovs-dev] Question about ovs-vtep i

Re: [ovs-dev] [PATCH v2] ovn-controller-vtep: occasional failure in "binding 1" test case

2016-07-15 Thread Darrell Ball
for ovs-vtep to remove > entries for the deleted physical ports from the vtep db. > > Signed-off-by: Lance Richardson > Suggested-by: Darrell Ball > --- > tests/ovn-controller-vtep.at | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/o

Re: [ovs-dev] [PATCH v2] ovn-controller: Clean up bindings handling.

2016-07-14 Thread Darrell Ball
On Thu, Jul 14, 2016 at 12:47 PM, Russell Bryant wrote: > Remove the global set of logical port IDs called 'all_lports'. This is > no longer used for anything after conntrack ID assignment was moved out > of binding.c. > > Remove the global smap of logical port IDs to ovsrec_interface records. >

Re: [ovs-dev] [patch_v1] ovs-vtep: Handle tunnel key configuration in any order.

2016-07-14 Thread Darrell Ball
On Thu, Jul 14, 2016 at 1:51 PM, Russell Bryant wrote: > > On Thu, Jul 14, 2016 at 4:09 PM, Darrell Ball wrote: > >> Presently, ovs-vtep expects the datapath tunnel key to be available >> in the VTEP DB at startup. This may not be the case which is also >> observed

[ovs-dev] [patch_v2] ovs-vtep: Handle tunnel key configuration in any order.

2016-07-14 Thread Darrell Ball
Presently, ovs-vtep expects the datapath tunnel key to be available in the VTEP DB at startup. This may not be the case which is also observed as interrmittent unit test failures. This patch allows for the tunnel key to later appear in the VTEP database. Signed-off-by: Darrell Ball --- v1->

[ovs-dev] [patch_v1] ovs-vtep: Handle tunnel key configuration in any order.

2016-07-14 Thread Darrell Ball
Presently, ovs-vtep expects the datapath tunnel key to be available in the VTEP DB at startup. This may not be the case which is also observed as interrmittent unit test failures. This patch allows for the tunnel key to later appear in the VTEP database. Signed-off-by: Darrell Ball --- vtep/ovs

Re: [ovs-dev] [PATCH] ovn-controller-vtep: occasional failure in "binding 1" test case

2016-07-14 Thread Darrell Ball
On Wed, Jul 13, 2016 at 2:15 PM, Lance Richardson wrote: > > > diff --git a/tests/ovn-controller-vtep.at b/tests/ > ovn-controller-vtep.at > > > index c296f0e..c978137 100644 > > > --- a/tests/ovn-controller-vtep.at > > > +++ b/tests/ovn-controller-vtep.at > > > @@ -225,8 +225,9 @@ AT_CHECK([sed

Re: [ovs-dev] [PATCH] ovn-controller-vtep: occasional failure in "binding 1" test case

2016-07-12 Thread Darrell Ball
On Fri, Jul 8, 2016 at 7:16 AM, Lance Richardson wrote: > The ovn-controller-vtep "binding 1" test case fails occasionally > due to a race with the ovs-vtep daemon. If ovs-vtep happens to > execute handle_physical() after "ovs-vsctl del-port p0", but before > the test script has executed "vtep-c

Re: [ovs-dev] Question about ovs-vtep implementation

2016-07-12 Thread Darrell Ball
On Fri, Jul 8, 2016 at 12:20 PM, Lance Richardson wrote: > The "ovn-controller-vtep - vtep-macs 1" test case fails occasionally, > with ovs-vswitchd logs similar to these: > > bridge|INFO|bridge br-vtep_vtep_ls1: added interface vx1 on port 2 > tunnel|WARN|bfd1.2.3.5: attempting to add tu

[ovs-dev] [patch_v5 0/2] ovn: Fix receive from vxlan in ovn-controller.

2016-07-11 Thread Darrell Ball
e change for bug fix and documentation update into two patches. v1->v2: Rebased after recent conflicting commit. Converted some xml comments ported from the ovn-architecture document. Removed redundant register initialization and unnecessary bit declaration. Darrell Ball (2): ovn: Fix receiv

[ovs-dev] [patch_v5 1/2] ovn: Fix receive from vxlan in ovn-controller.

2016-07-11 Thread Darrell Ball
node as OVN will only support source node replication. Signed-off-by: Darrell Ball --- ovn/controller-vtep/vtep.c | 4 ovn/controller/physical.c | 24 +++- ovn/lib/logical-fields.h | 13 +++-- tests/ovn.at | 3 +++ 4 files changed, 37 insertions

[ovs-dev] [patch_v5 2/2] ovn: Reformat some ovn design documentation.

2016-07-11 Thread Darrell Ball
following markdown parsers: https://jbt.github.io/markdown-editor/ http://dillinger.io/ The new flags register usage is also documented in the new OVN-DESIGN.md document. Signed-off-by: Darrell Ball --- ovn/OVN-DESIGN.md | 185 ovn/automake.mk

Re: [ovs-dev] [patch_v8] ovn: Add local router support (RFC).

2016-07-11 Thread Darrell Ball
On Mon, Jul 11, 2016 at 8:14 AM, Lance Richardson wrote: > > > - Original Message - > > From: "Darrell Ball" > > To: dlu...@gmail.com, d...@openvswitch.com > > Sent: Monday, July 11, 2016 11:07:03 AM > > Subject: [ovs-dev] [patch_v8] ovn: A

[ovs-dev] [patch_v8] ovn: Add local router support (RFC).

2016-07-11 Thread Darrell Ball
detects changes in the local and patched datapath sets and triggers recalculation of the local_routers set. The code changes are limited to ovn-controller. Signed-off-by: Darrell Ball --- ovn/controller/binding.c| 34 ++--- ovn/controller/binding.h| 3 +- ovn/controller

[ovs-dev] [patch_v8] ovn: Add local router support (RFC).

2016-07-11 Thread Darrell Ball
sit LS v5->v6: Rebase and ordering fix for data path association checks v4->v5: Bug fix related to datapath_assoc_chgd v3->v4: line length issue v1->v3: explore different approaches Darrell Ball (1): ovn: Add local router support (RFC). ovn/controller/binding.c| 34 ++-

[ovs-dev] [patch_v7] ovn: Add local router support (RFC).

2016-07-08 Thread Darrell Ball
sit LS v5->v6: Rebase and ordering fix for data path association checks v4->v5: Bug fix related to datapath_assoc_chgd v3->v4: line length issue v1->v3: explore different approaches Darrell Ball (1): ovn: Add local router support (RFC). ovn/controller/binding.c| 34

[ovs-dev] [patch_v7] ovn: Add local router support (RFC).

2016-07-08 Thread Darrell Ball
detects changes in the local and patched datapath sets and triggers recalculation of the local_routers set. The code changes are limited to ovn-controller. Signed-off-by: Darrell Ball --- ovn/controller/binding.c| 34 ++--- ovn/controller/binding.h| 3 +- ovn/controller

[ovs-dev] [patch_v3] ovn: Remove unreferenced patched datapaths.

2016-07-07 Thread Darrell Ball
upport easier. Darrell Ball (1): ovn: Remove unreferenced patched datapaths. ovn/controller/ovn-controller.h | 4 +++- ovn/controller/patch.c | 41 ++--- 2 files changed, 41 insertions(+), 4 deletions(-) --

[ovs-dev] [patch_v3] ovn: Remove unreferenced patched datapaths.

2016-07-07 Thread Darrell Ball
Patched datapaths that are no longer referenced should be removed from the patched_datapaths map; otherwise incorrect state references for a patched datapath may be used and also datapaths that are absent will be interpreted as present. Signed-off-by: Darrell Ball --- ovn/controller/ovn

[ovs-dev] [patch_v2] ovn: Remove unreferenced patched datapaths.

2016-07-07 Thread Darrell Ball
patched_datapath structure itself, but that is outside the scope of this change; Guru will attend to that. v1->v2: Style change. Parse pre and post processing for add_logical_patch_ports() into separate functions which makes recommended subsequent support easier. Darr

[ovs-dev] [patch_v2] ovn: Remove unreferenced patched datapaths.

2016-07-07 Thread Darrell Ball
Patched datapaths that are no longer referenced should be removed from the patched_datapaths map; otherwise incorrect state references for a patched datapath may be used and also datapaths that are absent will be interpreted as present. Signed-off-by: Darrell Ball --- ovn/controller/ovn

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

2016-07-07 Thread Darrell Ball
On Thu, Jul 7, 2016 at 3:55 PM, Guru Shetty wrote: > >> >> I don't testcases for OVN NAT at all - did I miss them ? >> How can a feature be committed without testcases ? >> > > We currently do not have NAT in userspace datapath to test OVN NAT. I > think this is the same case with OVN firewall. B

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

2016-07-07 Thread Darrell Ball
On Thu, Jul 7, 2016 at 4:09 PM, Darrell Ball wrote: > > > On Thu, Jul 7, 2016 at 3:38 PM, Guru Shetty wrote: > >> >> >> On 6 July 2016 at 18:37, Darrell Ball wrote: >> >>> Patched datapaths that are no longer referenced should be removed from >&

Re: [ovs-dev] [patch_v1] ovn: Remove unreferenced patched datapaths

2016-07-07 Thread Darrell Ball
On Thu, Jul 7, 2016 at 3:38 PM, Guru Shetty wrote: > > > On 6 July 2016 at 18:37, Darrell Ball wrote: > >> Patched datapaths that are no longer referenced should be removed from >> the patched_datapaths map; otherwise incorrect state references for a >> patched

  1   2   3   >