Re: [ovs-dev] [PATCH] net: preserve IP control block during GSO segmentation

2016-01-11 Thread Cong Wang
On Sun, Jan 10, 2016 at 11:45 PM, Zang MingJie wrote: > On 01/08/2016 08:13 PM, David Laight wrote: >> >> You could set SKB_SGO_CB_OFFSET to sizeof ((skb)->cb) - sizeof (struct >> skb_gso_cb) >> so that the end of 'cb' is always used. >> (Assuming the former is a multiple of 4.) >> >> It might be

Re: [ovs-dev] [patch net-next RFC 03/12] net: introduce generic switch devices support

2014-08-27 Thread Cong Wang
On Thu, Aug 21, 2014 at 9:18 AM, Jiri Pirko wrote: > diff --git a/include/linux/switchdev.h b/include/linux/switchdev.h > new file mode 100644 > index 000..ba77a68 > --- /dev/null > +++ b/include/linux/switchdev.h It should be in include/net/ instead, since it never goes out of networking. __

Re: [ovs-dev] [PATCH v2 net-next] openvswitch: fix vport-netdev unregister

2013-10-13 Thread Cong Wang
On Sat, 12 Oct 2013 at 01:12 GMT, Alexei Starovoitov wrote: > @@ -87,7 +81,11 @@ static int dp_device_event(struct notifier_block *unused, > unsigned long event, > if (!vport) > return NOTIFY_DONE; > > - if (event == NETDEV_UNREGISTER) { > + if (event == NETDEV_UNREG

Re: [ovs-dev] A question on the design of OVS GRE tunnel

2013-07-09 Thread Cong Wang
On Mon, 2013-07-08 at 23:26 -0700, Jesse Gross wrote: > On Mon, Jul 8, 2013 at 7:41 PM, Cong Wang wrote: > > On Mon, 2013-07-08 at 09:28 -0700, Pravin Shelar wrote: > >> On Mon, Jul 8, 2013 at 2:51 AM, Cong Wang wrote: > >> > However, I noticed there is

Re: [ovs-dev] [RFC PATCH 1/2] add igmp snooping support

2013-03-06 Thread Cong Wang
On Tue, 2013-03-05 at 09:34 -0800, Ben Pfaff wrote: > On Fri, Mar 01, 2013 at 09:03:44PM +0800, Cong Wang wrote: > > WARNING: This patch *only* compiles! NOT tested yet! > > > > This patch adds the initial IGMP snooping support. > > I sent out this patch earl

[ovs-dev] [RFC PATCH 2/2] add igmp6 snooping support

2013-03-01 Thread Cong Wang
WARNING: This patch *only* compiles! NOT tested yet! Based on patch 1/2, this patch adds IPv6 support. Any comments are welcome! Cc: Ben Pfaff Cc: Jesse Gross Not-Yet-Signed-off-by: Cong Wang --- lib/flow.c | 18 +--- lib/flow.h | 12 +++- lib/igmp

[ovs-dev] [RFC PATCH 1/2] add igmp snooping support

2013-03-01 Thread Cong Wang
WARNING: This patch *only* compiles! NOT tested yet! This patch adds the initial IGMP snooping support. I sent out this patch early to get some early reviews, especially the design of the code. Any comments are welcome! Cc: Ben Pfaff Cc: Jesse Gross Not-Yet-Signed-off-by: Cong Wang

Re: [ovs-dev] [Patch] datapath: fix checksum after putting vlan tag

2013-02-26 Thread Cong Wang
On Tue, 2013-02-26 at 12:51 -0800, Jesse Gross wrote: > On Tue, Feb 26, 2013 at 1:46 AM, Cong Wang wrote: > > After inserting the VLAN tag with __vlan_put_tag(), we should > > re-calculate the skb checksum if it is done. > > > > Cc: Jesse Gross > > Signed-off-b

[ovs-dev] [Patch] datapath: fix checksum after putting vlan tag

2013-02-26 Thread Cong Wang
After inserting the VLAN tag with __vlan_put_tag(), we should re-calculate the skb checksum if it is done. Cc: Jesse Gross Signed-off-by: Cong Wang --- diff --git a/datapath/vport-netdev.c b/datapath/vport-netdev.c index 727194e..99a6eca 100644 --- a/datapath/vport-netdev.c +++ b/datapath

Re: [ovs-dev] [PATCH] ovs-ctl: Add support for built-in (non-modular) kernel support.

2013-02-08 Thread Cong Wang
On Sat, Feb 9, 2013 at 12:46 AM, Ben Pfaff wrote: > On Wed, Feb 06, 2013 at 08:44:36AM -0800, Ben Pfaff wrote: >> On Wed, Feb 06, 2013 at 03:54:14PM +0800, Cong Wang wrote: >> > On 02/06/2013 03:14 AM, Ben Pfaff wrote: >> > >Reported-by: Cong Wang

Re: [ovs-dev] [PATCH] ovs-ctl: Add support for built-in (non-modular) kernel support.

2013-02-05 Thread Cong Wang
BTW, I modified ovs-ctl.in manually, skipped inserting the kernel modules, ovs service start successfully and everything works fine so far. I am using openvswitch in fedora 17: # rpm -q openvswitch openvswitch-1.4.2-1.fc17.x86_64 ___ dev mailing list

Re: [ovs-dev] [PATCH] ovs-ctl: Add support for built-in (non-modular) kernel support.

2013-02-05 Thread Cong Wang
On 02/06/2013 03:14 AM, Ben Pfaff wrote: Reported-by: Cong Wang Signed-off-by: Ben Pfaff --- Cong, will you verify that this makes the init script work OK for your kernel with OVS built-in? I got: # ovs-dpctl show -voff ovs-dpctl: processing "off": unknown module "o

Re: [ovs-dev] What is datapath?

2012-11-21 Thread Cong Wang
On Thu, Nov 22, 2012 at 10:08 AM, 李强 wrote: > Hi, all. > I came up with some problems when I studied the openvswitch. > Can you explain it to me what a datapath definitely mean? Why it must > be implented in kernel mode? If I build openvswitch in userspace, does that > mean the advantag

Re: [ovs-dev] OpenVswitch dev document

2012-11-19 Thread Cong Wang
On Mon, Nov 19, 2012 at 3:51 PM, 李强 wrote: > Hi,all. > I'm a student and now going on some project related to OpenVswtich. But > the source code seems so complicated to me. Do you have development document > about openvswitch? If you have, could you please mail me a copy? I have written an ar

Re: [ovs-dev] [PATCH] ovs-ctl.in: increase the limit of fd

2012-11-14 Thread Cong Wang
On Thu, Nov 15, 2012 at 11:06 AM, Ben Pfaff wrote: > On Thu, Nov 15, 2012 at 10:31:04AM +0800, Cong Wang wrote: >> On Wed, Nov 14, 2012 at 11:43 PM, Ben Pfaff wrote: >> > On Wed, Nov 14, 2012 at 08:58:18PM +0800, Cong Wang wrote: >> >> We can't create more than

Re: [ovs-dev] [PATCH] ovs-ctl.in: increase the limit of fd

2012-11-14 Thread Cong Wang
On Wed, Nov 14, 2012 at 11:43 PM, Ben Pfaff wrote: > On Wed, Nov 14, 2012 at 08:58:18PM +0800, Cong Wang wrote: >> We can't create more than 248 bridges with the current limit 5000, >> so increase it to 6000 so that at least 256+ bridges could be created. >> >>

[ovs-dev] [PATCH] ovs-ctl.in: increase the limit of fd

2012-11-14 Thread Cong Wang
We can't create more than 248 bridges with the current limit 5000, so increase it to 6000 so that at least 256+ bridges could be created. Cc: Ben Pfaff Signed-off-by: Cong Wang --- diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in index 7febd1c..45cbbc1 100755 --- a/utilities/ovs-c

Re: [ovs-dev] [PATCH] ovs-vsctl: check if the device name is valid

2012-11-02 Thread Cong Wang
On Fri, Nov 2, 2012 at 12:44 AM, Ben Pfaff wrote: > Stepping back: I support your basic proposal, that "ovs-vsctl > add-port" should report a problem if the port cannot successfully be > added. The issue is that, so far, the approaches I've seen don't fit > well with the overall Open vSwitch desi

Re: [ovs-dev] [PATCH] ovs-vsctl: check if the device name is valid

2012-10-26 Thread Cong Wang
On 10/25/2012 11:20 PM, Ben Pfaff wrote: Furthermore, ovs-vsctl is meant to be generic in the sense that you can use an ovs-vsctl built in one place (on one OS) to control a switch and database running elsewhere (on another OS). You don't want to apply the local host's restrictions to changes to

Re: [ovs-dev] [PATCH] datapath: Deprecated CAPWAP support.

2012-10-26 Thread Cong Wang
On 10/28/2012 04:07 AM, Pravin B Shelar wrote: --- a/datapath/vport-capwap.c +++ b/datapath/vport-capwap.c @@ -473,6 +473,7 @@ static struct vport *capwap_create(const struct vport_parms *parms) struct vport *vport; int err; + pr_err("%s: capwap support is deprecated\n", _

Re: [ovs-dev] [PATCH] ovs-vsctl: check if the device name is valid

2012-10-25 Thread Cong Wang
On Wed, Oct 24, 2012 at 11:54 PM, Ben Pfaff wrote: > On Wed, Oct 24, 2012 at 05:45:36PM +0800, Cong Wang wrote: >> Before waiting for the kernel to reject an invalid name, we >> can actually check it before going into the kernel. The code >> is stolen from linux kernel fu

[ovs-dev] [PATCH] ovs-vsctl: check if the device name is valid

2012-10-24 Thread Cong Wang
-off-by: Cong Wang --- diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c index fda3a89..3015f8c 100644 --- a/utilities/ovs-vsctl.c +++ b/utilities/ovs-vsctl.c @@ -27,6 +27,7 @@ #include #include #include +#include #include "command-line.h" #include "compil