work with flows.
>
> Note that user can use random port netdevice to access the switch.
[...]
Why isn't the switch treated as a real device (not necessarily a net
device) that's included in the device model and that the port devices
refer to?
Ben.
--
Ben Hutchings
If at first
id generation */
> + memcpy(&psid->id, &tmp, sizeof(tmp));
[...]
Right, you must not expose kernel addresses to userland.
Ben.
--
Ben Hutchings
If at first you don't succeed, you're doing about average.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
patch that and its caller, but
not openvswitch.]
Signed-off-by: Ben Hutchings
---
On Tue, 2014-04-22 at 19:02 +0100, Zoltan Kiss wrote:
> On 22/04/14 16:38, Ben Hutchings wrote:
> > On Mon, 2014-04-21 at 12:26 +0100, Luis Henriques wrote:
> >> Hi David,
> >>
> >> O
e to some of the trees.
It was applied to 3.13, but needs backporting to earlier versions. I
posted my attempt in
<1397429860.10849.86.ca...@deadeye.wl.decadent.org.uk> but it needs
testing/reviewing.
Ben.
--
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein
signature.asc
Description: This is a digitally signed message part
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
make
this work with the current Debian kernel (3.13, to be replaced by 3.14
in a few weeks).
The most problematic API change in 3.13 is in genetlink multicast group
registration and identification changed. I don't see any good way to
hide this in the compat layer.
Ben.
--
Ben Hutc
WARN_ONCE(dp->user_features, "Dropping previously "
> + "announced user features");
Log messages shouldn't be split like this as it makes them harder to
find. There should also be a newline at the end of the message.
Ben.
&g
has the maximum number of
fragments, you would have to copy the last fragment in order to add
padding.
> + BUG_ON(frag->size > PAGE_SIZE);
[...]
I'm not sure that's a reasonable assumption either. We certainly allow
fragments to
Control: severity -1 grave
Control: tag -1 jessie sid
This is obviously grave, but not for stable.
Ben.
--
Ben Hutchings
The two most common things in the universe are hydrogen and stupidity.
___
dev mailing list
dev@openvswitch.org
http
tch/vport.c
> index ba81294..ba240a8 100644
> --- a/net/openvswitch/vport.c
> +++ b/net/openvswitch/vport.c
> @@ -38,10 +38,7 @@
> static const struct vport_ops *vport_ops_list[] = {
> &ovs_netdev_vport_ops,
> &ovs_internal_vport_ops,
> -
> -#if IS_ENABLED(CONFIG_
write
> + *
> + * This function is identical to skb_cow and sb_cow_head except that we
> + * replace the skb_cloned check by skb_cloned && !skb_clone_writable.
> + *
> + */
> +static inline int skb_cow_clone_head(struct sk_buff *skb, unsigned int len)
> +{
> + return
+ /* Keeps track of the ethernet type of an encapsualted
[...]
Typo: 'encapsualted' should be 'encapsulated'.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that So
Package: openvswitch-datapath-source
Version: 1.2.2-2
Severity: grave
This module fails to build against Linux 3.1:
make[3]: Entering directory `/usr/src/linux-headers-3.1.0-1-amd64'
/usr/src/linux-headers-3.1.0-1-common/arch/x86/Makefile:81: stack protector
enabled but no compiler support
CC
12 matches
Mail list logo
