[ovs-dev] [PATCH] openvswitch: call only into reachable nf-nat code

2016-03-19 Thread Arnd Bergmann
_attr(), where it does not cause a link error, but for consistency I'm changing it the same way. Signed-off-by: Arnd Bergmann Fixes: 05752523e565 ("openvswitch: Interface with NAT.") --- net/openvswitch/Kconfig | 3 ++- net/openvswitch/conntrack.c | 16 2 files

[ovs-dev] [PATCH] openvswitch: reduce padding in struct sw_flow_key

2016-03-19 Thread Arnd Bergmann
ovs_flow_cmd_new and ovs_flow_cmd_set have two copies of struct sw_flow_key on the stack, one of them nested within sw_flow_mask. If we could reduce that to a single instance, the stack usage would be cut in half here. Signed-off-by: Arnd Bergmann Fixes: 00a93babd06a ("openvswitch: add tun

Re: [ovs-dev] [PATCH] openvswitch: call only into reachable nf-nat code

2016-03-19 Thread Arnd Bergmann
On Wednesday 16 March 2016 14:25:36 Pablo Neira Ayuso wrote: > Not related with this patch, just a side note/recommendation. > > I understand this code just got into tree, and that this needs a bit > work/iterations but this thing above is ugly, I wonder if there is a > better way to avoid this. >

[ovs-dev] [PATCH v2] openvswitch: call only into reachable nf-nat code

2016-03-18 Thread Arnd Bergmann
(), where it does not cause a link error, but for consistency I'm changing it the same way. Signed-off-by: Arnd Bergmann Fixes: 05752523e565 ("openvswitch: Interface with NAT.") Acked-by: Joe Stringer --- v2: leave (!NF_NAT || NF_NAT) dependency in there, we also need that net/op

Re: [ovs-dev] [PATCH] openvswitch: call only into reachable nf-nat code

2016-03-18 Thread Arnd Bergmann
On Wednesday 16 March 2016 13:47:13 Arnd Bergmann wrote: > The openvswitch code has gained support for calling into the > nf-nat-ipv4/ipv6 modules, however those can be loadable modules > in a configuration in which openvswitch is built-in, leading > to link errors: > >