Re: [ovs-dev] [PATCH 1/1] netdev-linux: Don't set ethtool flags if flag is already set on netdev

2015-09-04 Thread Anoob Soman
My bad, Thanks. -Anoob On 03/09/15 20:54, Jesse Gross wrote: On Thu, Sep 3, 2015 at 6:53 AM, Anoob Soman wrote: Check if ethtool flags is already set on a netdev, before trying to set it. This patch works around issues with some older verison of ethernet drivers, which tend to reset the NIC

[ovs-dev] [PATCH 1/1] netdev-linux: Don't set ethtool flags if flag is already set on netdev

2015-09-03 Thread Anoob Soman
upgrade scenario as it causes extended downtime. Signed-off-by: Anoob Soman --- lib/netdev-linux.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 56eed04..fe92fb5 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -5298,7

Re: [ovs-dev] Inter-op openvswitch and openfcoe

2015-07-28 Thread Anoob Soman
On 27/07/15 22:53, Jesse Gross wrote: On Mon, Jul 27, 2015 at 9:59 AM, Anoob Soman wrote: Hi All, I am aware there had been some discussion on running lldpad and open-fcoe utils (like fcoemon) on top of ovs, but couldn’t figure out a way to successfully run lldpad and fcoemon on top of

[ovs-dev] Inter-op openvswitch and openfcoe

2015-07-27 Thread Anoob Soman
Hi All, I am aware there had been some discussion on running lldpad and open-fcoe utils (like fcoemon) on top of ovs, but couldn’t figure out a way to successfully run lldpad and fcoemon on top of openvswitch. I did some experimentation with openvswitch and open-fcoe and now I am trying to g

Re: [ovs-dev] performance with GCC 4.1

2014-07-09 Thread Anoob Soman
Hi Ben, Thanks for pointing this out. On 08/07/14 18:10, Ben Pfaff wrote: Hi Anoob. Guru noticed (and I confirmed) that recent versions of Open vSwitch on master suffer a little, performance-wise, on XenServer. In particular, the cmap code doesn't perform well. In the OVS testsuite, the cmap

Re: [ovs-dev] [PATCH RFC] lacp: Prefer slaves with running partner when selecting lead

2014-07-02 Thread Anoob Soman
Hi Zoli, On 01/07/14 20:52, Zoltan Kiss wrote: This patch modifies the LACP selection logic by prefering a slaves with up and running partners when looking for a lead. That fixes the following scenario: - bond has 2 ports, A and B, their other ends are in separate chassis with MC-LAG sync - t

Re: [ovs-dev] [PATCH RFC] lacp: Prefer slaves with running partner when selecting lead

2014-07-01 Thread Anoob Soman
iss Sent: 01 July 2014 20:52 To: dev@openvswitch.org Cc: Zoltan Kiss; Anoob Soman Subject: [PATCH RFC] lacp: Prefer slaves with running partner when selecting lead This patch modifies the LACP selection logic by prefering a slaves with up and running partners when looking for a lead. That fix

Re: [ovs-dev] [PATCH 1/1] netflow: Modify netflow_flow_clear() to do netflow_expire__

2014-06-23 Thread Anoob Soman
->8-- From: Anoob Soman Date: Tue, 20 May 2014 12:40:35 +0100 Subject: [PATCH] netflow: Fold netflow_expire() into netflow_flow_clear(). netflow_flow_clear() asserted that no packets or bytes were included in the statistics for the flow being cleared. Before threading Open vSwitch, this asserti

Re: [ovs-dev] [PATCH 1/1] netflow: Modify netflow_flow_clear() to do netflow_expire__

2014-05-27 Thread Anoob Soman
Hi Ben, Do you have comments on the scenario in which the assert might happen ? Thanks, Anoob. From: Anoob Soman Sent: 20 May 2014 20:06 To: Ben Pfaff Cc: dev@openvswitch.org Subject: RE: [ovs-dev] [PATCH 1/1] netflow: Modify netflow_flow_clear() to do

[ovs-dev] Soft lockup in OVS-2.1.2

2014-05-21 Thread Anoob Soman
Hi, I encountered softlockup (in stats_read@datapath/flow.c), while playing with OVS-2.1.2. I used change set 4f647e0a3c37b8d5086214128614a136064110c3 from linux-stable to fix the problem. I was wondering, if this changeset can be applied to ovs/branch-2.1. Other branches doesn't need this f

Re: [ovs-dev] [PATCH 1/1] netflow: Modify netflow_flow_clear() to do netflow_expire__

2014-05-20 Thread Anoob Soman
Ben Pfaff [b...@nicira.com] Sent: 20 May 2014 19:25 To: Anoob Soman Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 1/1] netflow: Modify netflow_flow_clear() to do netflow_expire__ On Tue, May 20, 2014 at 12:40:35PM +0100, Anoob Soman wrote: > This avoids causing failed assert(), when netflow_

[ovs-dev] [PATCH 1/1] netflow: Modify netflow_flow_clear() to do netflow_expire__

2014-05-20 Thread Anoob Soman
This avoids causing failed assert(), when netflow_flow_clear() and netflow_expire() are called together. Signed-off-by: Anoob Soman --- AUTHORS | 2 +- ofproto/netflow.c | 3 +-- ofproto/ofproto-dpif-upcall.c | 2 -- 3 files changed, 2 insertions(+), 5

[ovs-dev] [PATCH 1/1] ofproto-dpif-xlate: Fix null pointer dereference

2014-05-14 Thread Anoob Soman
actions (in xlate_actions__) would be NULL when xlate_actions() is called from packet_out()->ofproto_dpif_execute_actions(). This causes a NULL pointer to be dereferenced when ctx.xbridge->netflow is set. Signed-off-by: Anoob Soman --- ofproto/ofproto-dpif-xlate.c | 3 --- 1 file chan

Re: [ovs-dev] rhel ifup-ovs script add-bond with --fake-iface

2014-03-25 Thread Anoob Soman
On 25/03/14 16:07, Ben Pfaff wrote: On Tue, Mar 25, 2014 at 03:44:44PM +, Anoob Soman wrote: On 25/03/14 15:29, Gurucharan Shetty wrote: On Tue, Mar 25, 2014 at 5:32 AM, Anoob Soman wrote: Hi, Does rhel openvswitch deployments required fake bond interfaces to be created. rhel

Re: [ovs-dev] rhel ifup-ovs script add-bond with --fake-iface

2014-03-25 Thread Anoob Soman
On 25/03/14 15:29, Gurucharan Shetty wrote: On Tue, Mar 25, 2014 at 5:32 AM, Anoob Soman wrote: Hi, Does rhel openvswitch deployments required fake bond interfaces to be created. rhel/etc_sysconfig_network-scripts_ifup-ovs uses --fake-iface for creating bonds (add-bond). I have sent a patch

[ovs-dev] rhel ifup-ovs script add-bond with --fake-iface

2014-03-25 Thread Anoob Soman
Hi, Does rhel openvswitch deployments required fake bond interfaces to be created. rhel/etc_sysconfig_network-scripts_ifup-ovs uses --fake-iface for creating bonds (add-bond). I have sent a patch "[PATCH] rhel: Remove creation of fake bond interface" to remove --fake-iface and add --may-exist

[ovs-dev] [PATCH] rhel: Remove creation of fake bond interface

2014-03-25 Thread Anoob Soman
fake-iface, option to add-bond, was added for compatibility reasons and need not be used otherwise. Signed-off-by: Anoob Soman --- rhel/etc_sysconfig_network-scripts_ifup-ovs |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/rhel/etc_sysconfig_network-scripts_ifup-ovs b

[ovs-dev] [PATCH 1/1] lacp: Fix dumping of aggregation key

2013-01-02 Thread Anoob Soman
While dumping lacp information using ovs-appctl, "aggregation key" field displays port_id even though aggregation-key is set using "other-config:lacp-aggregation-key". Signed-off-by: Anoob Soman --- lib/lacp.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) dif