Hey Alin,
Thanks for the patch.
Please find my comments inline.
I have not worked on this code for sometime, so may miss something here.
Can you please also let us know the unit testing that you did? Although change
is minor, but editing FLOW_KEY* related code may end up breaking some
function
Acked-by: Ankur Sharma
From: dev on behalf of Eitan Eliahu
Sent: Tuesday, December 2, 2014 8:33 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: Add PID Number attribute for
port notification / Fix logic
[1] User mode OVS
Acked-by: Ankur Sharma
From: dev on behalf of Eitan Eliahu
Sent: Wednesday, November 12, 2014 10:53 AM
To: Nithin Raju
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 1/7] datapath-windows: fixes in
OvsGetExtInfoIoctl()
Yes, we planned
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Wednesday, November 12, 2014 10:56 AM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 7/7] datapath-windows: Fixes in HvCreatePort() to
re-add a port
On Nov 12
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Tuesday, November 11, 2014 7:04 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 6/7] datapath-windows: Change return type of
OvsInitVxlanTunnel()
OvsInitVxlanTunnel() need not
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Tuesday, November 11, 2014 7:04 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 5/7] datapath-windows: Changes to
InitOvsVportCommon()
If a Hyper-V port (for which there exists
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Tuesday, November 11, 2014 7:04 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 4/7] datapath-windows: Changes to
OvsRemoveAndDeleteVport()
In this patch, we add changes to
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Tuesday, November 11, 2014 7:04 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 3/7] datapath-windows: clarify 'portIdHashArray'
in the swithc context
In this patch,
Minor comments inline.
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Tuesday, November 11, 2014 7:04 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 2/7] datapath-windows: add WCHAR version of
OvsFindVportByHvName()
In this
add-port is done. And we can always add
check to block the case i have mentioned above.
I have a few minor comments regarding code style.
Acked-by: Ankur Sharma
Regards,
Ankur
From: dev on behalf of Eitan Eliahu
Sent: Friday, November 7, 2014 6:53 PM
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
index 14c3072..d2d0ae5 100644
--- a/datapath-windows/ovsext/Flow.c
+++ b/datapath-windows/ovsext/Flow.c
@@ -1184,8
Acked-by: Ankur Sharma
From: Eitan Eliahu
Sent: Thursday, October 30, 2014 3:01 PM
To: Ankur Sharma
Subject: FW: [PATCH] WMI Script Support for setting Hyper-V friendly port name
from NOVA driver
-Original Message-
From: Eitan Eliahu [mailto:elia
Hi Sorin,
Can you please provide some more details of the crash?
Either of following data would be helpful in review.
a. Repro steps.
b. Backtrace.
Thanks.
Regards,
Ankur
From: dev on behalf of Sorin Vinturis
Sent: Thursday, October 30, 2014 7:32 AM
To
Hi Nithin,
Thanks for the clarification.
Regards,
Ankur
From: Nithin Raju
Sent: Friday, October 24, 2014 3:53 PM
To: Ankur Sharma
Cc: Alin Serdean; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 3/7] datapath-windows: introduce bridge-internal
ports
Acked-by: Ankur Sharma
From: dev on behalf of Alin Serdean
Sent: Friday, October 24, 2014 3:15 PM
To: Nithin Raju; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 7/7] datapath-windows:
OvsFindVportByPortIdAndNicIndex() and external port
Acked-by: Ankur Sharma
From: dev on behalf of Alin Serdean
Sent: Friday, October 24, 2014 3:15 PM
To: Nithin Raju; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 6/7] datapath-windows: updates to vport add code
Acked-by: Alin Gabriel Serdean
Acked-by: Ankur Sharma
From: dev on behalf of Alin Serdean
Sent: Friday, October 24, 2014 3:14 PM
To: Nithin Raju; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 2/7] datapath-windows: clarify externalVport
Acked-by: Alin Gabriel Serdean
Tested-by
Acked-by: Ankur Sharma
From: dev on behalf of Alin Serdean
Sent: Friday, October 24, 2014 3:15 PM
To: Nithin Raju; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 5/7] datapath-windows: core refactoring in Vport.c
Acked-by: Alin Gabriel Serdean
Hi Nithin,
Some minor comments:
why did we add if (OvsIsBridgeInternalVport(vport)) check in OvsAddPorts?
minor comment
in OvsIsBridgeInternalVport
we can just do return vport->isBridgeInternal
instead of return vport->isBridgeInternal == TRUE
Acked-by: Ankur
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Friday, October 24, 2014 1:02 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] lib/netdev-windows.c: fixes in update flags and
copying MAC address
The .update_flags function in
Acked-by: Ankur Sharma
From: Nithin Raju
Sent: Friday, October 24, 2014 11:52 AM
To: Ankur Sharma
Subject: FW: [PATCH] datapath-windows: Allow encapsulation if source is
bridge-internal port
For Ack-ing.
Get the patch file from:
/dbc/pa-dbc1122/nithin
Refactored CreateQueue function so that packets are enqueued to correct
corresponding queue.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Actions.c | 4 +-
datapath-windows/ovsext/PacketIO.c | 2 +-
datapath-windows/ovsext/Switch.c | 2 +
datapath-windows/ovsext/Switch.h
Signed-off-by: Ankur Sharma
Acked-by: Sorin Vinturis
---
datapath-windows/ovsext/User.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
index 213d606..f6b1157 100644
--- a/datapath-windows
In this patch we have added APIs for insert, delete and search APIs.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
---
datapath-windows/ovsext/User.c | 57 ++
datapath-windows/ovsext/User.h | 10
2 files changed, 67 insertions(+)
diff --git
Sent: Thursday, October 23, 2014 12:44 PM
To: Ankur Sharma
Cc: Alin Serdean; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH] [datapath-windows] Broken build on windows
extension
On Thu, Oct 23, 2014 at 05:42:24PM +, Ankur Sharma wrote:
> Do not worry about this.
>
> It has
Signed-off-by: Ankur Sharma
Acked-by: Sorin Vinturis
---
datapath-windows/ovsext/User.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
index 213d606..f6b1157 100644
--- a/datapath-windows
In this patch we have added APIs for insert, delete and search APIs.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
---
datapath-windows/ovsext/User.c | 57 ++
datapath-windows/ovsext/User.h | 10
2 files changed, 67 insertions(+)
diff --git
Refactored CreateQueue function so that packets are enqueued to correct
corresponding queue.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Actions.c | 4 +-
datapath-windows/ovsext/PacketIO.c | 2 +-
datapath-windows/ovsext/Switch.c | 2 +
datapath-windows/ovsext/Switch.h
Hi Sorin,
Kindly let me know if you have concerns over it.
As per my understanding as well we are not skipping any valid list node.
Thanks.
Regards,
Ankur
From: Nithin Raju
Sent: Wednesday, October 22, 2014 4:55 PM
To: Sorin Vinturis
Cc: Ankur Sharma
Hi Alin,
Do not worry about this.
It has happened because of out of order patch application (patch 1 and 3 got
applied bt not 2).
I am working on addressing nithin and sorin's review comments and will submit a
v3.
Meanwhile please reset the head to get going.
Thanks.
Regards,
Ankur
_
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/User.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
index 6327959..54f9682 100644
--- a/datapath-windows/ovsext/User.c
+++ b
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/User.c | 20
1 file changed, 20 insertions(+)
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
index 36787cd..6327959 100644
--- a/datapath-windows/ovsext/User.c
+++ b/datapath-windows
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/User.c | 4 +++-
datapath-windows/ovsext/User.h | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
index 6797350..3da34da 100644
--- a/datapath-windows
Refactored CreateQueue function so that packets are enqueued to correct
corresponding queue.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Actions.c | 4 +-
datapath-windows/ovsext/PacketIO.c | 2 +-
datapath-windows/ovsext/Tunnel.c | 2 +-
datapath-windows/ovsext/User.c
This patch introduces data structure for holding instances hashed by pid.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.h | 2 ++
datapath-windows/ovsext/Switch.c | 15 ++-
datapath-windows/ovsext/Switch.h | 3 +++
datapath-windows/ovsext/User.c | 1
In this patch we have added APIs for insert, delete and search APIs.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/User.c | 57 ++
datapath-windows/ovsext/User.h | 10
2 files changed, 67 insertions(+)
diff --git a/datapath-windows
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/User.c | 45 +-
1 file changed, 40 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
index 42473ab..95b8652 100644
--- a/datapath-windows
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/User.c | 6 --
datapath-windows/ovsext/User.h | 6 +++---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
index 42b251f..cce99a5 100644
--- a/datapath
Refactored CreateQueue function so that packets are enqueued to
correct corresponding queue.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Actions.c | 4 +-
datapath-windows/ovsext/PacketIO.c | 2 +-
datapath-windows/ovsext/Tunnel.c | 2 +-
datapath-windows/ovsext/User.c
This patch introduces data structure for holding instances hashed by
pid.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.h | 2 ++
datapath-windows/ovsext/Event.c| 1 +
datapath-windows/ovsext/Switch.c | 15 ++-
datapath-windows/ovsext/Switch.h | 3
In this patch we have added APIs for insert, delete and
search APIs.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/User.c | 40
datapath-windows/ovsext/User.h | 10 ++
2 files changed, 50 insertions(+)
diff --git a/datapath-windows
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/User.c | 20
1 file changed, 20 insertions(+)
diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
index a8d9107..42473ab 100644
--- a/datapath-windows/ovsext/User.c
+++ b/datapath-windows
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Saturday, October 18, 2014 11:39 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 2/4 v2] datapath-windows: fixes in Flow.c in key
parsing
Signed-off-by: Nithin Raju
Added the handlers for update_flags and set_etheraddr.
These handlers were needed for vswitchd bringup on windows
platform.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
---
lib/netdev-windows.c | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff
Hi Nithin,
Please find my comments inline.
Regards,
Ankur
From: dev on behalf of Nithin Raju
Sent: Thursday, October 16, 2014 10:52 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 4/4] lib/netlink-socket.c: fixes in
nl_sock_recv__() on Windows
Hi Nithin,
While reading the ETHERTYPE attribute we already use ntohs.
Regards,
Ankur
From: dev on behalf of Nithin Raju
Sent: Thursday, October 16, 2014 10:52 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 2/4] datapath-windows: fixes in Flow.c i
Hi Nithin,
Changes look fine.
Please find a minor comment inline.
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Thursday, October 16, 2014 10:52 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 3/4] datapath-windows: Fixes in
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Thursday, October 16, 2014 10:52 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 1/4] datapath-windows: event read should not fail
when no events
The semantics are read operation
XXX To be implementd.
3. Rebase the patch.
Acked-by: Ankur Sharma
From: dev on behalf of Eitan Eliahu
Sent: Thursday, October 16, 2014 10:03 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH] datapath-windows: Packet subscribe handler
This cha
Acked-by: Ankur Sharma
From: Eitan Eliahu
Sent: Thursday, October 16, 2014 10:59 AM
To: Ankur Sharma
Subject: FW: [PATCH] datapath-windows: fix compilation error in release build
-Original Message-
From: Eitan Eliahu [mailto:elia...@vmware.com
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Wednesday, October 15, 2014 2:08 PM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 2/2] datapath-windows: Fixes in
OvsSetVportCmdHandler()
In this patch, we make a few simple
Changes look fine.
Please remove following comment
/*XXX: this function is dummy */
Acked-by: Ankur Sharma
From: dev on behalf of Nithin Raju
Sent: Wednesday, October 15, 2014 2:08 PM
To: dev@openvswitch.org
Cc: Samuel Ghinet
Subject: [ovs-dev] [PATCH
Added the handlers for update_flags and set_etheraddr.
These handlers were needed for vswitchd bringup on windows
platform.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
---
lib/netdev-windows.c | 83 +++-
1 file changed, 82 insertions(+), 1
Added the handlers for update_flags and set_etheraddr.
These handlers were needed for vswitchd bringup on windows
platform.
Signed-off-by: Ankur Sharma
---
lib/netdev-windows.c | 83 +++-
1 file changed, 82 insertions(+), 1 deletion(-)
diff --git
Added the handlers for update_flags and set_etheraddr.
These handlers were needed for vswitchd bringup on windows
platform.
Signed-off-by: Ankur Sharma
---
lib/netdev-windows.c | 83 +++-
1 file changed, 82 insertions(+), 1 deletion(-)
diff --git
Added changes to support error handling for non supported actions.
Added changes in packet execute for sending transactional errors.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Actions.c | 4 +--
datapath-windows/ovsext/Netlink/NetlinkError.h
In this patch we have implemented the handler for OVS_PACKET_CMD_EXECUTE
command.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
---
datapath-windows/ovsext/User.c | 111 +++--
1 file changed, 107 insertions(+), 4 deletions
fer.
OvsExecuteDpIoctl =>
We only need input buffer now. Hence Changed the function signature.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
---
datapath-windows/include/OvsPub.h | 8 ++--
datapath-windows/ovsext/User.c| 22 +-
datapath-windows/
In this patch we cover the basic registeration of OVS_PACKET_CMD_EXECUTE
command handler.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 18 +-
datapath-windows/ovsext/User.c | 18
In this patch we have made the Flow parsing policies global.
Pakcet execute handling requires these policies.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Flow.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a
In this patch we cover the basic registeration of OVS_PACKET_CMD_EXECUTE
command handler.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 18 +-
datapath-windows/ovsext/User.c | 18
fer.
OvsExecuteDpIoctl =>
We only need input buffer now. Hence Changed the function signature.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
---
datapath-windows/include/OvsPub.h | 8 ++--
datapath-windows/ovsext/User.c| 22 +-
datapath-windows/
In this patch we have made the Flow parsing policies global.
Pakcet execute handling requires these policies.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Flow.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a
In this patch we have implemented the handler for OVS_PACKET_CMD_EXECUTE
command.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/User.c | 111 +++--
1 file changed, 107 insertions(+), 4 deletions(-)
diff --git a/datapath
Added changes to support error handling for non supported actions.
Added changes in packet execute for sending transactional errors.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Actions.c | 4 +-
datapath-windows/ovsext/Netlink/NetlinkError.h | 17
Added the handlers for update_flags and set_etheraddr.
These handlers were needed for vswitchd bringup on windows
platform.
Signed-off-by: Ankur Sharma
---
lib/netdev-windows.c | 78 +++-
1 file changed, 77 insertions(+), 1 deletion(-)
diff --git
In this patch we have implemented the handler for OVS_PACKET_CMD_EXECUTE
command.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/User.c | 111 +++--
1 file changed, 108 insertions(+), 3 deletions(-)
diff --git a/datapath
In this patch we cover the basic registeration of OVS_PACKET_CMD_EXECUTE
command handler.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/Datapath.c | 18 +-
datapath-windows/ovsext/User.c | 18 ++
datapath-windows/ovsext
fer.
OvsExecuteDpIoctl =>
We only need input buffer now. Hence Changed the function signature.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
---
datapath-windows/include/OvsPub.h | 8 ++--
datapath-windows/ovsext/User.c| 22 +-
datapath-windows/ovsext/User.h| 4 +
In this patch we have made the Flow parsing policies global.
Pakcet execute handling requires these policies.
Signed-off-by: Ankur Sharma
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/Flow.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/datapath-windows
My changes for trasacation error handling for not needed for dump commands.
Fixed the same.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
Acked-by: Eitan Eliahu
---
datapath-windows/ovsext/Flow.c | 61 +-
1 file changed, 18 insertions(+), 43
OvsReadEventCmdHandler was calling OvsRemoveEventEntry after acquiring
CtrlLock. OvsRemoveEventEntry in turn also tries to acquire the same lock.
Added a new lock in Event.c for the eventQueue.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Event.c | 9 +
1 file changed, 5
My changes for trasacation error handling for not needed for dump commands.
Fixed the same.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 50 +++---
1 file changed, 13 insertions(+), 37 deletions(-)
diff --git a/datapath-windows/ovsext
Hi Eitan,
Sure, i will take care of this.
I thought that CtrlLock is used for all the global resources.
Thanks.
Regards,
Ankur
From: Eitan Eliahu
Sent: Tuesday, October 14, 2014 5:56 AM
To: Ankur Sharma; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH
Hi Sorin,
Sounds fair. I will introduce a new lock in v2.
Thanks.
Regards,
Ankur
From: Sorin Vinturis
Sent: Monday, October 13, 2014 11:26 PM
To: Ankur Sharma; dev@openvswitch.org
Subject: RE: [ovs-dev] [PATCH v1 1/2] datapath-windows: Fix CtrlLock
CtrlLock only. Apis OvsAcquireCtrlLock and OvsReleaseCtrlLock
should be used for this purpose.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c | 3 ++-
datapath-windows/ovsext/Event.c| 54 --
2 files changed, 25 insertions(+), 32 deletions
My changes for trasacation error handling for not needed for dump commands.
Fixed the same.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 50 +++---
1 file changed, 13 insertions(+), 37 deletions(-)
diff --git a/datapath-windows/ovsext
In this patch we cover the basic registeration of OVS_PACKET_CMD_EXECUTE
command handler.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c | 18 +-
datapath-windows/ovsext/User.c | 18 ++
datapath-windows/ovsext/User.h | 5 +
3
In this patch we have made the Flow parsing policies global.
Pakcet execute handling requires these policies.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath
In this patch we have implemented the handler for
OVS_PACKET_CMD_EXECUTE command.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/User.c | 104 -
1 file changed, 103 insertions(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/User.c b
fer.
OvsExecuteDpIoctl =>
We only need input buffer now. Hence Changed the function signature.
Signed-off-by: Ankur Sharma
---
datapath-windows/include/OvsPub.h | 8 ++--
datapath-windows/ovsext/User.c| 17 +++--
datapath-windows/ovsext/User.h| 4 +---
3 files changed, 6 inse
NlBufAt should be called with valid boundary limits (within head and tail).
Incorrect argument to NlBufAt was leading to assert hit, fixed the same.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
Tested-by: Nithin Raju
---
datapath-windows/ovsext/Netlink/Netlink.c | 4 ++--
1 file changed
Added changes to send a reply for FLOW_FUSH case. This is needed
as with nithin's transaction reply changes we'll need reply for each
command.
This patch also contains minor fixes for sending replies in
success case as well.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
---
This was one of the review comment which i forgot to address in
FLOW_DUMP checkin. We do not need to explicitly set replyLen to zero
as caller would have already set it.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
---
datapath-windows/ovsext/Flow.c | 6 --
1 file changed, 6
Assert(rc) would always hit for a valid case, hence
replaced it with error code based check.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
Tested-by: Nithin Raju
---
datapath-windows/ovsext/Flow.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/datapath-windows
In this patch we added the code to handle transactional errors
in flow commands.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 66 ++
datapath-windows/ovsext/Netlink/NetlinkError.h | 2 +-
2 files changed, 48 insertions(+), 20
During vswitchd boot up kernel is receiving FLOW_ADD commands
without ETHERTYPE attribute. Added additional check for the same
in this patch. During the same phase kernel is also receiving
packet_execute with no ETHERNET attribute.
Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
---
datapath
a. OvsGetUpcallMsgSize
Should not we do alignment after getting the final size?
b. /* XXX no need as the length is alreadt in the NL attrib */
Spelling typo.
c. We can use NlFillOvsMsg for creating upcall message.
Acked-by: Ankur Sharma
From: dev on
OvsTunKeyAttrSize & OvsFlowKeyAttrSize, i think the function names are swapped.
Acked-by: Ankur Sharma
From: dev on behalf of Eitan Eliahu
Sent: Friday, October 10, 2014 11:08 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 2/4] Upcall NL pa
Acked-by: Ankur Sharma
From: dev on behalf of Eitan Eliahu
Sent: Friday, October 10, 2014 11:08 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 1/4] Upcall NL packet format: Add NL utilities
Add NlAttrSize and NlAttrTotalSize
Signed-off-by
Acked-by: Ankur Sharma
From: dev on behalf of Eitan Eliahu
Sent: Friday, October 10, 2014 11:08 AM
To: dev@openvswitch.org
Subject: [ovs-dev] [PATCH 4/4] Upcall NL packet format: Call NL missed packet
function
Remove hard coded queue is, pass the key
Acked-by: Ankur Sharma
From: dev on behalf of Eitan Eliahu
Sent: Tuesday, October 7, 2014 8:01 PM
To: Nithin Raju; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2] lib/netlink-socket.c: always pass the output
buffer in a transaction
Hi Nithin
In this series we have fixed issues observed in flow netlink handler code
observed during vswitch and datapath-windows integration.
Ankur Sharma (6):
datapath-windows: Transactional error support in Flow commands.
datapath-windows: validate ETHERTYPE attribute.
datapath-windows: Reply for
NlBufAt should be called with valid boundary limits (within head and tail).
Incorrect argument to NlBufAt was leading to assert hit, fixed the same.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Netlink/Netlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a
This was one of the review comment which i forgot to address in
FLOW_DUMP checkin. We do not need to explicitly set replyLen to zero
as caller would have already set it.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 6 --
1 file changed, 6 deletions(-)
diff --git a
During vswitchd boot up kernel is receiving FLOW_ADD commands
without ETHERTYPE attribute. Added additional check for the same
in this patch.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/datapath
Added changes to send a reply for FLOW_FUSH case. This is needed
as with nithin's transaction reply changes we'll need reply for each
command.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
di
Assert(rc) would always hit for a valid case, hence
replaced it with error code based check.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/Flow.c
In this patch we added the code to handle transactional errors
in flow commands.
Signed-off-by: Ankur Sharma
---
datapath-windows/ovsext/Flow.c | 54 +++---
datapath-windows/ovsext/Netlink/NetlinkError.h | 32 ++-
2 files changed, 70 insertions
: Monday, October 6, 2014 4:59 PM
To: Ankur Sharma
Cc:
Subject: Re: [ovs-dev] [PATCH v1 3/3] datapath-windows: OVS_PACKET_CMD_EXECUTE
handler.
On Oct 6, 2014, at 4:23 PM, Ankur Sharma
wrote:
> In this patch we have implemented the handler for
> OVS_PACKET_CMD_EXECUTE command.
>
> S
1 - 100 of 271 matches
Mail list logo
