[ovs-dev] [PATCH v2] ovn-trace: Implement DHCP option support.

2016-10-23 Thread Ben Pfaff
The put_dhcp_opts(v6) logical action didn't really work because ovn-trace didn't handle DHCP options. This fixes the problem. This also makes the put_dhcp_opts(v6) logical provide useful tracing output showing what's happening and the assumptions. Signed-off-by: Ben Pfaff --- v1->v2: Improve ou

[ovs-dev] [PATCH] ovn-trace: Implement DHCP option support.

2016-10-23 Thread Ben Pfaff
The put_dhcp_opts(v6) logical action didn't really work because ovn-trace didn't handle DHCP options. This fixes the problem. This also makes the put_dhcp_opts(v6) logical provide useful tracing output showing what's happening and the assumptions. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn

[ovs-dev] [PATCH] ovn-trace: Add output format options to usage message.

2016-10-23 Thread Ben Pfaff
Also adjust the indentation of the option explanations so that they line up better. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-trace.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c index 3d62cf8.

Re: [ovs-dev] [patch_v5 2/3] ovn: Add additional comments regarding arp responders.

2016-10-23 Thread Mickey Spiegel
Acked-by: Mickey Spiegel A few very minor nits below. On Fri, Oct 21, 2016 at 1:36 PM, Darrell Ball wrote: > There has been enough confusion regarding logical switch datapath > arp responders in ovn to warrant some additional comments; > hence add a general description regarding why they exist

[ovs-dev] [PATCH 1/2] tests: Fix order confusion in "ovn -- 2 HVs, 4 lports/HV, localnet ports".

2016-10-23 Thread Ben Pfaff
The order of src and dst was swapped both in assignment and reference, which meant that the result worked OK but was really confusing to try to extend or modify. Signed-off-by: Ben Pfaff --- tests/ovn.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests

[ovs-dev] [PATCH 2/2] tests: Add tracing to "ovn -- 2 HVs, 4 lports/HV, localnet ports" test.

2016-10-23 Thread Ben Pfaff
Adding ovn-trace calls makes failures easier to understand and diagnose. Signed-off-by: Ben Pfaff --- tests/ovn.at | 96 +--- 1 file changed, 60 insertions(+), 36 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 1d782a3..a3b524e

[ovs-dev] [PATCH 2/2] ovn-trace: Fix implementation of get_arp and get_nd logical actions.

2016-10-23 Thread Ben Pfaff
These actions looked up the MAC binding but failed to update eth.dst with the result. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-trace.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c index 94321cf..261013b 100

[ovs-dev] [PATCH 1/2] ovn-trace: Fix daemon exit for bad datapaths or flows.

2016-10-23 Thread Ben Pfaff
When ovn-trace is running in daemon mode (with --detach), a trace command received via unixctl (e.g. "ovs-appctl -t ovn-trace trace ...") should not cause ovn-trace to exit, but it did. This fixes the problem. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-trace.c | 4 ++-- 1 file changed, 2 in

Re: [ovs-dev] [PATCH 07/15] doc: Convert WHY-OVS to rST

2016-10-23 Thread Stephen Fincane
On Fri, 2016-10-21 at 16:09 -0400, Russell Bryant wrote: > > > On Tue, Oct 18, 2016 at 4:03 PM, Stephen Finucane > wrote: > > Signed-off-by: Stephen Finucane [snip] > > +The advantage of hardware integration is not only performance > > within > > +virtualized environments. If physical switche