Re: [ovs-dev] [PATCH v4] Add configurable OpenFlow port name.

2016-10-21 Thread Xiao Liang
On Fri, Oct 21, 2016 at 1:46 AM, Flavio Leitner wrote: > On Tue, Jun 14, 2016 at 10:53:36AM +0800, Xiao Liang wrote: >> On Mon, Jun 6, 2016 at 9:35 AM, Ben Pfaff wrote: >> > On Sun, Jun 05, 2016 at 12:57:02AM +0800, Xiao Liang wrote: >> >> On Sat, Jun 4, 2016 at 1:15 AM, Ben Pfaff wrote: >> >> >

Re: [ovs-dev] load balancing using RYU

2016-10-21 Thread Ben Pfaff
On Sat, Oct 22, 2016 at 12:33:13AM +, Mohamed Ibrahem wrote: > hello guys, > i have a 4 port switch and the model as follows: > port 1>> client > port 2 ,3 and 4 are servers"python -m SimpleHTTPServer 80&" > i wanna do load balancing with the servers as the virtual IP = 10.0.0.5 and > virtual

[ovs-dev] load balancing using RYU

2016-10-21 Thread Mohamed Ibrahem
hello guys, i have a 4 port switch and the model as follows: port 1>> client port 2 ,3 and 4 are servers"python -m SimpleHTTPServer 80&" i wanna do load balancing with the servers as the virtual IP = 10.0.0.5 and virtual MAC = 00:00:00:00:00:05 and the client requests 10.0.0.5 with mac 00:00:00:00

[ovs-dev] missing the OVN meeting Oct. 27

2016-10-21 Thread Ben Pfaff
I'll miss the OVN meeting next week because I'll be in Barcelona. Hope to see some of you there, especially at the OVN party on Tuesday night (email me if you don't already have invitation). ___ dev mailing list dev@openvswitch.org http://openvswitch.org

[ovs-dev] [PATCH v1] debian: Include ovn-trace in ovn-common package

2016-10-21 Thread Flavio Fernandes
Include the ovn-trace binary and it's man page in ovn-common package Fixes: 4acd1e87a8bf ("ovn-trace: New utility.") Fixes: f448e5a4bb1f ("rhel: Include ovn-trace in ovn-common package") Signed-off-by: Flavio Fernandes --- debian/ovn-common.install | 1 + debian/ovn-common.manpages | 1 + 2 fil

Re: [ovs-dev] ovn: Improving southbound database security

2016-10-21 Thread Ben Pfaff
On Fri, Oct 21, 2016 at 04:38:43PM -0400, Lance Richardson wrote: > > From: "Ben Pfaff" > > To: "Russell Bryant" > > Cc: "ovs dev" > > Sent: Friday, October 21, 2016 4:33:33 PM > > Subject: Re: [ovs-dev] ovn: Improving southbound database security > > > > On Fri, Oct 21, 2016 at 04:10:58PM -040

Re: [ovs-dev] Native DNS support proposal in OVN for internal DNS resolution

2016-10-21 Thread Ben Pfaff
On Thu, Oct 13, 2016 at 05:34:22PM +0530, Numan Siddique wrote: > ​ovn-controller will translate the "extract_dns_packet" ovn action to > "controller action with pause flag set. > For the flows in the table "​ls_in_l7_match", ovn-controller will NOT > translate it into any OF Flow, instead it will

Re: [ovs-dev] ovn: Improving southbound database security

2016-10-21 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Russell Bryant" > Cc: "ovs dev" > Sent: Friday, October 21, 2016 4:33:33 PM > Subject: Re: [ovs-dev] ovn: Improving southbound database security > > On Fri, Oct 21, 2016 at 04:10:58PM -0400, Russell Bryant wrote: > > On Thu, Oct 20, 2016 at 5:52 PM, Han Zhou wrote: >

[ovs-dev] [patch_v5 3/3] ovn: Test arp requests received from vtep ports.

2016-10-21 Thread Darrell Ball
Add a test that verifies that arp requests received from vtep ports are not responded to by logical switch arp responders. Signed-off-by: Darrell Ball --- tests/ovn.at | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index 70f0331..d

[ovs-dev] [patch_v5 1/3] ovn: Fix arping from vtep-gw physical port.

2016-10-21 Thread Darrell Ball
from: Ramu Ramamurthy Currently, arping from a vtep-gw physical-switch port to a VIF IP address does not work. When a physical-switch-port arps for an IP address of a VIF, that arp packet comes into the VIF hypervisor via a vxlan tunnel. That arp packet must not be responded-to by the arp respon

[ovs-dev] [patch_v5 2/3] ovn: Add additional comments regarding arp responders.

2016-10-21 Thread Darrell Ball
There has been enough confusion regarding logical switch datapath arp responders in ovn to warrant some additional comments; hence add a general description regarding why they exist and document the special cases. Signed-off-by: Darrell Ball Signed-off-by: Ramu Ramamurthy Co-authored-by: Ramu Ra

[ovs-dev] [patch_v5 0/3] ovn: arp responder fixes and documentation.

2016-10-21 Thread Darrell Ball
The first patch fixes arping from vtep-gw physical ports and the code change was done by Ramu Ramamurthy. The second patch adds additional comments regarding arp responders in ovn. This is intended to aid in understanding and hopefully prevent future bugs in this area. The third patch adds a tes

Re: [ovs-dev] ovn: Improving southbound database security

2016-10-21 Thread Ben Pfaff
On Fri, Oct 21, 2016 at 04:10:58PM -0400, Russell Bryant wrote: > On Thu, Oct 20, 2016 at 5:52 PM, Han Zhou wrote: > > > > > On Thu, Oct 20, 2016 at 11:51 AM, Russell Bryant wrote: > > > > > > On Thu, Oct 20, 2016 at 1:47 PM, Ben Pfaff wrote: > > > > > > > On Thu, Oct 13, 2016 at 07:32:53PM +05

Re: [ovs-dev] ovn: Improving southbound database security

2016-10-21 Thread Russell Bryant
On Thu, Oct 20, 2016 at 5:52 PM, Han Zhou wrote: > > On Thu, Oct 20, 2016 at 11:51 AM, Russell Bryant wrote: > > > > On Thu, Oct 20, 2016 at 1:47 PM, Ben Pfaff wrote: > > > > > On Thu, Oct 13, 2016 at 07:32:53PM +0530, Numan Siddique wrote: > > > > > > > 5) Remove support from ovn-controller up

Re: [ovs-dev] [PATCH 07/15] doc: Convert WHY-OVS to rST

2016-10-21 Thread Russell Bryant
On Tue, Oct 18, 2016 at 4:03 PM, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane > --- > FAQ.md | 4 +- > Makefile.am | 2 +- > WHY-OVS.md | 106 - > WHY-OVS.rst |

[ovs-dev] [PATCH v2 6/7] checkpatch: fix the if and whitespace checks

2016-10-21 Thread Aaron Conole
The regex for the if/for/while bracket tests fails to distinguish non-space text. This means text such as do_something_if() would match incorrectly. Additionally, the ends-with-bracket test doesn't allow for the common coding paradigm: if (condition) { /* Text about conditional. */ } So

[ovs-dev] [PATCH v2 0/7] checkpatch: Misc. cleanups, and a new feature

2016-10-21 Thread Aaron Conole
This series cleans up and clarifies certain issues in the checkpatch infrastructure. Additionally, a fix for the some of the matches is included. The two features added by this series are: 1. The ability to parse a non-patch file (useful for applying cleanups to existing code) 2. Printing the

[ovs-dev] [PATCH v2 2/7] checkpatch: Print the line in question distinctly

2016-10-21 Thread Aaron Conole
This makes it easier to distinguish between the line, and the warning/error message. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 15b59a3..5fbac9a 100755 --

[ovs-dev] [PATCH v2 4/7] checkpatch: Print file line numbers

2016-10-21 Thread Aaron Conole
The line numbers being printed were the line numbers for the patchfile. This is sometimes okay to fix simple things (trailing or leading whitespace, missing signoffs, etc). But more complicated fixes, or those fixes which require a bit more care, aren't helped by this. So, we use the implied file

[ovs-dev] [PATCH v2 7/7] checkpatch: Add file-parsing mode

2016-10-21 Thread Aaron Conole
This adds a new argument and feature, 'check-file', which will allow checkpatch to run against files instead of only against patches. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git

[ovs-dev] [PATCH v2 1/7] checkpatch: Announce the file where errors occur

2016-10-21 Thread Aaron Conole
This makes finding the warning and error marks much easier. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 13 + 1 file changed, 13 insertions(+) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 754059a..15b59a3 100755 --- a/utilities/checkpatch.py +++

[ovs-dev] [PATCH v2 5/7] checkpatch: Fix signoff error

2016-10-21 Thread Aaron Conole
When no 'Signed-off-by' tags are found, the output will look like: E: No signatures found. E: Too many signoffs; are you missing Co-authored-by lines? Warnings: 0, Errors: 2 However, there should really only be one error reported in this case. Signed-off-by: Aaron Conole --- utilit

[ovs-dev] [PATCH v2 3/7] checkpatch: convert some of the warnings

2016-10-21 Thread Aaron Conole
These coding issues are not just things that shouldn't be done. They are styles which should never be submitted. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py

Re: [ovs-dev] [PATCH v2] datapath: compat: tunnel: Check if device is UP.

2016-10-21 Thread Pravin Shelar
On Fri, Oct 21, 2016 at 11:39 AM, Joe Stringer wrote: > On 21 October 2016 at 11:37, Joe Stringer wrote: >> On 21 October 2016 at 10:55, Pravin B Shelar wrote: >>> On upstream kernel datapath OVS make use of networking devices >>> where networking stack does check if device is UP. following >>>

Re: [ovs-dev] [PATCH v2] datapath: compat: tunnel: Check if device is UP.

2016-10-21 Thread Pravin Shelar
On Fri, Oct 21, 2016 at 11:37 AM, Joe Stringer wrote: > On 21 October 2016 at 10:55, Pravin B Shelar wrote: >> On upstream kernel datapath OVS make use of networking devices >> where networking stack does check if device is UP. following >> patch adds same check in case of compat tunneling implem

Re: [ovs-dev] [PATCH v2] datapath: compat: tunnel: Check if device is UP.

2016-10-21 Thread Joe Stringer
On 21 October 2016 at 11:37, Joe Stringer wrote: > On 21 October 2016 at 10:55, Pravin B Shelar wrote: >> On upstream kernel datapath OVS make use of networking devices >> where networking stack does check if device is UP. following >> patch adds same check in case of compat tunneling implementat

Re: [ovs-dev] [PATCH v2] datapath: compat: tunnel: Check if device is UP.

2016-10-21 Thread Joe Stringer
On 21 October 2016 at 10:55, Pravin B Shelar wrote: > On upstream kernel datapath OVS make use of networking devices > where networking stack does check if device is UP. following > patch adds same check in case of compat tunneling implementation. > This check also fixes kernel crash in case vxlan

[ovs-dev] [PATCH v2] datapath: compat: tunnel: Check if device is UP.

2016-10-21 Thread Pravin B Shelar
On upstream kernel datapath OVS make use of networking devices where networking stack does check if device is UP. following patch adds same check in case of compat tunneling implementation. This check also fixes kernel crash in case vxlan device was brought down by user. CPU: 4 PID: 12988 Comm: ha

Re: [ovs-dev] [PATCH v2] doc: v2: fix bad link to dpdk advance installation guide

2016-10-21 Thread Russell Bryant
On Fri, Oct 21, 2016 at 7:03 AM, Stephen Finucane wrote: > On 2016-10-21 04:51, Mauricio Vasquez B wrote: > >> Previous fix was also wrong. >> >> Fixes: 167703d ("doc: Convert INSTALL.DPDK to rST") >> >> Signed-off-by: Mauricio Vasquez B >> > > Drat - case sensitivity. > > Acked-by: Stephen Finu

Re: [ovs-dev] [PATCH 06/15] doc: Convert REPORTING-BUGS to rST

2016-10-21 Thread Russell Bryant
On Tue, Oct 18, 2016 at 4:03 PM, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane > --- > Makefile.am| 2 +- > REPORTING-BUGS.md | 58 --- > REPORTING-BUGS.rst | 73 ++ > > SECURITY.m

Re: [ovs-dev] [PATCH] doc: fix duplicated colons in rst documents

2016-10-21 Thread Russell Bryant
On Fri, Oct 21, 2016 at 6:57 AM, Stephen Finucane wrote: > PS: The online viewer at http://rst.ninjs.org/ is helpful for previewing > these things. > This seems like a good tip for the doc guide. -- Russell Bryant ___ dev mailing list dev@openvswitch

Re: [ovs-dev] [PATCH 05/15] doc: Convert README to rST

2016-10-21 Thread Russell Bryant
On Tue, Oct 18, 2016 at 4:03 PM, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane > --- > INSTALL.rst | 2 +- > Makefile.am | 2 +- > README.md | 131 -- > -- > README.rst

Re: [ovs-dev] [PATCH 04/15] doc: Convert PORTING to rST

2016-10-21 Thread Russell Bryant
On Tue, Oct 18, 2016 at 4:03 PM, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane > --- > FAQ.md| 4 +- > INSTALL.NetBSD.md | 4 +- > Makefile.am | 2 +- > PORTING.md| 326 -- > --- > PORTING.rst | 33

Re: [ovs-dev] [PATCH RFC 2/2] netdev-dpdk: Add vHost User PMD

2016-10-21 Thread Loftus, Ciara
> I'll post few comments to v4 here. > > > static int > > +dpdk_attach_vhost_pmd(struct netdev_dpdk *dev, int mode) > > +{ > > +char *devargs; > > +int err = 0; > > +uint8_t port_no = 0; > > +uint32_t driver_id = -1; > > + > > +if (id_pool_alloc_id(dpdk_get_vhost_id_pool(), &d

[ovs-dev] [PATCH RFC v5 1/2] netdev-dpdk: Add support for DPDK 16.11

2016-10-21 Thread Ciara Loftus
This commit announces support for DPDK 16.11. Compaitibilty with DPDK v16.07 is not broken yet thanks to only minor code changes being needed for the upgrade. This may change soon however with the addition of subsequent commits that integrate 16.11-only features. Signed-off-by: Ciara Loftus ---

[ovs-dev] [PATCH RFC v5 2/2] netdev-dpdk: Add vHost User PMD

2016-10-21 Thread Ciara Loftus
The vHost PMD allows vHost User ports to be controlled by the librte_ether API, like physical 'dpdk' ports and IVSHM 'dpdkr' ports. This commit integrates this PMD into OVS and removes direct calls to the librte_vhost DPDK library. This commit requires DPDK v16.11 functionality that isn't availabl

[ovs-dev] [PATCH RFC v5 0/2] Add DPDK 16.11 & vHost PMD Support

2016-10-21 Thread Ciara Loftus
Previous: http://openvswitch.org/pipermail/dev/2016-October/080893.html This RFC patchset adds support for DPDK 16.11 (rc1) and the vHost PMD. Thanks to a lack of API changes that affect OVS, the DPDK 16.11 support patch requires just one minimal code change and is mostly documentation updates.

Re: [ovs-dev] [PATCH net-next v12 7/9] openvswitch: add Ethernet push and pop actions

2016-10-21 Thread Jiri Benc
On Thu, 20 Oct 2016 21:22:21 -0700, Pravin Shelar wrote: > The eth pop substracts ETH_HLEN but here the length is set. I think it > should be consistent with respect to eth-pop. Agreed. Will use skb_reset_mac_len in both, that better reflects what's going on. Thanks, Jiri __

Re: [ovs-dev] [PATCH RFC 2/2] netdev-dpdk: Add vHost User PMD

2016-10-21 Thread Ilya Maximets
I'll post few comments to v4 here. > static int > +dpdk_attach_vhost_pmd(struct netdev_dpdk *dev, int mode) > +{ > +char *devargs; > +int err = 0; > +uint8_t port_no = 0; > +uint32_t driver_id = -1; > + > +if (id_pool_alloc_id(dpdk_get_vhost_id_pool(), &driver_id)) { > +

Re: [ovs-dev] [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-21 Thread Jiri Benc
On Thu, 20 Oct 2016 21:19:14 -0700, Pravin Shelar wrote: > On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > > @@ -609,8 +597,10 @@ static int ovs_packet_cmd_execute(struct sk_buff *skb, > > struct genl_info *info) > > > > err = ovs_flow_key_extract_userspace(net, a[OVS_PACKET_ATTR_KEY]

Re: [ovs-dev] [PATCH v2] doc: v2: fix bad link to dpdk advance installation guide

2016-10-21 Thread Stephen Finucane
On 2016-10-21 04:51, Mauricio Vasquez B wrote: Previous fix was also wrong. Fixes: 167703d ("doc: Convert INSTALL.DPDK to rST") Signed-off-by: Mauricio Vasquez B Drat - case sensitivity. Acked-by: Stephen Finucane ...for the immediate fix, but maybe we should switch to a reference style

Re: [ovs-dev] [PATCH] doc: fix duplicated colons in rst documents

2016-10-21 Thread Stephen Finucane
On 2016-10-21 04:40, Mauricio Vasquez B wrote: Signed-off-by: Mauricio Vasquez B --- INSTALL.DPDK.rst | 148 +- INSTALL.Debian.rst| 20 +-- INSTALL.Docker.rst| 76 +++--- INSTALL.KVM.rst | 24 ++-

Re: [ovs-dev] [PATCH RFC 2/2] netdev-dpdk: Add vHost User PMD

2016-10-21 Thread Loftus, Ciara
> > On 20.10.2016 19:33, Loftus, Ciara wrote: > @@ -894,6 +1006,66 @@ dpdk_dev_parse_name(const char > >> dev_name[], const char prefix[], > } > } > > +/* When attaching a vhost device to DPDK, a unique name of the > format > + * 'net_vhostX' is expected, where

[ovs-dev] [PATCH RFC v4 2/2] netdev-dpdk: Add vHost User PMD

2016-10-21 Thread Ciara Loftus
The vHost PMD allows vHost User ports to be controlled by the librte_ether API, like physical 'dpdk' ports and IVSHM 'dpdkr' ports. This commit integrates this PMD into OVS and removes direct calls to the librte_vhost DPDK library. This commit requires DPDK v16.11 functionality that isn't availabl

[ovs-dev] [PATCH RFC v4 0/2] Add DPDK 16.11 & vHost PMD Support

2016-10-21 Thread Ciara Loftus
Previous: http://openvswitch.org/pipermail/dev/2016-October/080858.html This RFC patchset adds support for DPDK 16.11 (rc1) and the vHost PMD. Thanks to a lack of API changes that affect OVS, the DPDK 16.11 support patch requires just one minimal code change and is mostly documentation updates.

[ovs-dev] [PATCH RFC v4 1/2] netdev-dpdk: Add support for DPDK 16.11

2016-10-21 Thread Ciara Loftus
This commit announces support for DPDK 16.11. Compaitibilty with DPDK v16.07 is not broken yet thanks to only minor code changes being needed for the upgrade. This may change soon however with the addition of subsequent commits that integrate 16.11-only features. Signed-off-by: Ciara Loftus ---

Re: [ovs-dev] [RFC] [PATCH] ovn: Support sample action in logical datapath

2016-10-21 Thread Valentine Sinitsyn
Hi all, Ping here :) During last few weeks I posted several questions regarding IPFIX implementation in OVS, and also a patch to improve (from my POV of course) the state of things. None of them yielded any responses, unfortunately. Am I doing anything wrong (such as violating some guideline

[ovs-dev] delivery failed

2016-10-21 Thread Bounced mail
This message was undeliverable due to the following reason: Your message was not delivered because the destination server was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely there

Re: [ovs-dev] [PATCH RFC 2/2] netdev-dpdk: Add vHost User PMD

2016-10-21 Thread Ilya Maximets
On 20.10.2016 19:33, Loftus, Ciara wrote: @@ -894,6 +1006,66 @@ dpdk_dev_parse_name(const char >> dev_name[], const char prefix[], } } +/* When attaching a vhost device to DPDK, a unique name of the format + * 'net_vhostX' is expected, where X is a unique identif