[ovs-dev] ovn: conditional monitor feature

Hi, Do we plan to include the ovn conditional monitoring usage in 2.6.0? Performance evaluation shows up to 75% reduction of computation at the ovn-controller and also a reduction of computation at the server side, depending at the spread of the logical networks over the physical hosts. (number

Re: [ovs-dev] [PATCH v2 21/21] ovn-trace: New utility.

On Tue, Aug 09, 2016 at 08:08:20AM +0800, nickcooper-zhangtonghao wrote: > > +/* --detailed: Show a detailed, table-by-table trace. */ > > +static bool detailed; > > + > > +/* --summary: Show a trace that omits table information. */ > > +static bool summary; > > + > > +/* --minimal: Show a trace wi

Re: [ovs-dev] [PATCH v3 9/9] ovn-trace: New utility.

On Mon, Aug 08, 2016 at 09:33:54PM -0500, Ryan Moats wrote: > "dev" wrote on 08/08/2016 01:21:52 PM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 08/08/2016 01:23 PM > > Subject: [ovs-dev] [PATCH v3 9/9] ovn-trace: New utility. > > Sent by: "dev" > > > > This n

Re: [ovs-dev] [PATCH V14] Function tracer to trace all function calls

"dev" wrote on 08/05/2016 10:51:38 PM: > From: Nirapada Ghosh/San Jose/IBM@IBMUS > To: dev@openvswitch.org > Date: 08/05/2016 10:52 PM > Subject: [ovs-dev] [PATCH V14] Function tracer to trace all function calls > Sent by: "dev" > > From: Nirapada Ghosh > > In some circumstances, we might need

[ovs-dev] the host will be soft lookup when some illeagal packets attack host

diff --git a/datapath/linux/compat/flow_dissector.c b/datapath/linux/compat/flow_dissector.c index 3f42dba..4c5d023 100644 --- a/datapath/linux/compat/flow_dissector.c +++ b/datapath/linux/compat/flow_dissector.c @@ -77,7 +77,7 @@ again: struct iphdr _iph; ip: iph =

Re: [ovs-dev] [PATCH v3 9/9] ovn-trace: New utility.

"dev" wrote on 08/08/2016 01:21:52 PM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 01:23 PM > Subject: [ovs-dev] [PATCH v3 9/9] ovn-trace: New utility. > Sent by: "dev" > > This new utility is intended to fulfill for OVN the purpose that > "ofproto/trace" has

[ovs-dev] [patch_v8] ovn: Fix receive from vxlan in ovn-controller.

The changes enable source node replication in OVN for receive from Vxlan tunnels. OVN only supports source node replication mode. This is needed for ovn-controller to interoperate with hardware switches. Previously hardware vtep interaction, which uses service node replication by default for mul

Re: [ovs-dev] [PATCH v2 21/21] ovn-trace: New utility.

> On Aug 9, 2016, at 12:15 AM, dev-requ...@openvswitch.org wrote: > > Date: Mon, 8 Aug 2016 09:14:32 -0700 > From: Ben Pfaff mailto:b...@ovn.org>> > To: dev@openvswitch.org > Cc: Ben Pfaff mailto:b...@ovn.org>> > Subject: [ovs-dev] [PATCH v2 21/21] ovn-trace: New uti

Re: [ovs-dev] Hitless resynchronisation of forwarding state

> From: Jarno Rajahalme [mailto:ja...@ovn.org] > Sent: Friday, 29 July, 2016 20:38 > > > Twice the memory of the steady state footprint would still be a significant > burden, in particular if that memory would have to reside on hugepages that > are statically reserved for ovs-vswitchd. I must say

Re: [ovs-dev] [RFC/PATCH v2] Make the PID part of socket path configurable

> > While it's an alternative, I feel like going down that path is hasty > > and for my use case I will probably just patch our local fork of > > OpenvSwitch. > > > > Why so hostile towards this change? Is there a better forum I can > > explain why I believe this problem should be reconsidered? >

Re: [ovs-dev] [RFC/PATCH v2] Make the PID part of socket path configurable

> > Is there really anyone that can justify the way socket paths are > > created should contain the PID? You clearly saw the problem with it in > > the Windows code base, but yet pushed on to keep it in the Linux one. > > I simply do not see why you're not taking this patch as a way to > > encourag

Re: [ovs-dev] [PATCH v2 3/3] pvector: Expose non-concurrent priority vector.

Hi Jarno, While trying to rebase my "dpcls per in_port" patch to your updated pvector/cpvector implementation, I have stumbled over a threading issue in your patch. I believe that dpcls_destroy_subtable(), which may be invoked from revalidater threads at flow removal, should not simply call th

Re: [ovs-dev] [RFC/PATCH v2] Make the PID part of socket path configurable

On Mon, Aug 08, 2016 at 10:05:03PM +0200, Christian Svensson wrote: > On Mon, Aug 8, 2016 at 7:59 PM, Ben Pfaff wrote: > > > OK, let's add that then. > > While it's an alternative, I feel like going down that path is hasty and > for my use case I will probably just patch our local fork of OpenvS

[ovs-dev] [PATCH 2/2] datapath: backport: net: vxlan: lwt: Use source ip address during route lookup.

Upstream commit: commit 272d96a5ab10662691b4ec90c4a66fdbf30ea7ba Author: pravin shelar Date: Fri Aug 5 17:45:36 2016 -0700 net: vxlan: lwt: Use source ip address during route lookup. LWT user can specify destination as well as source ip address for given tunnel endpoint

[ovs-dev] [PATCH 1/2] datapath: backport: net: vxlan: lwt: Fix vxlan local traffic.

Upstream commit: commit bbec7802c6948c8626b71a4fe31283cb4691c358 Author: pravin shelar Date: Fri Aug 5 17:45:37 2016 -0700 net: vxlan: lwt: Fix vxlan local traffic. vxlan driver has bypass for local vxlan traffic, but that depends on information about all VNIs on local

Re: [ovs-dev] [PATCH] ovs-vsctl: Change log level of vsctl_parent_process_info

On Mon, Aug 8, 2016 at 2:47 PM, Andy Zhou wrote: > > > On Mon, Aug 8, 2016 at 6:48 AM, Kyle Mestery wrote: >> >> While running the ovn-scale-test [1] port-binding tests [2], I notice a >> continual stream of messages such as this: >> >> 2016-08-04 13:05:28.705 547 INFO rally_ovs.plugins.ovs.scena

Re: [ovs-dev] [RFC/PATCH v2] Make the PID part of socket path configurable

On Mon, Aug 8, 2016 at 7:59 PM, Ben Pfaff wrote: > OK, let's add that then. > I forgot to add a critical point why I'm not ready to consider the alternative yet: One of the optional goals I'm trying to achieve is that ovs-appctl -t my-daemon should still work (keeping all documentation etc.), wh

Re: [ovs-dev] [RFC/PATCH v2] Make the PID part of socket path configurable

On Mon, Aug 8, 2016 at 7:59 PM, Ben Pfaff wrote: > OK, let's add that then. > While it's an alternative, I feel like going down that path is hasty and for my use case I will probably just patch our local fork of OpenvSwitch. Why so hostile towards this change? Is there a better forum I can expl

Re: [ovs-dev] [patch_v7] ovn: Fix receive from vxlan in ovn-controller.

hmm, it looks like a logical flags register was added by Justin recently hence there is no need for me to add that. Since this patch or patch series has been out for about 2 months and there has been some disagreement regarding documentation refactoring, it might be best to coordinate this closely

Re: [ovs-dev] [patch_v7] ovn: Fix receive from vxlan in ovn-controller.

On Sat, Aug 6, 2016 at 12:38 PM, Ryan Moats wrote: > "dev" wrote on 07/29/2016 06:08:38 PM: > > > From: Darrell Ball > > To: dlu...@gmail.com, d...@openvswitch.com, b...@ovn.org > > Date: 07/29/2016 06:09 PM > > Subject: [ovs-dev] [patch_v7] ovn: Fix receive from vxlan in > ovn-controller. > >

Re: [ovs-dev] [PATCH] ovs-vsctl: Change log level of vsctl_parent_process_info

On Mon, Aug 8, 2016 at 6:48 AM, Kyle Mestery wrote: > While running the ovn-scale-test [1] port-binding tests [2], I notice a > continual stream of messages such as this: > > 2016-08-04 13:05:28.705 547 INFO rally_ovs.plugins.ovs.scenarios.ovn [-] > bind lport_0996bf_cikzNO to sandbox-172.16.200.

Re: [ovs-dev] OVN: Limiting the impact of a compromised chassis

On Fri, Jul 15, 2016 at 1:53 PM, Lance Richardson wrote: > I've been doing some investigation into the "Limiting the impact of > a compromised chassis" issue described in ovn/TODO. These are some initial > thoughts, posting here for feedback and any other ideas folks might have > about how we sho

Re: [ovs-dev] [PATCH v3] ofproto: Reduce bundle memory use.

I just sent a v4, no need to review this one. Jarno > On Jul 29, 2016, at 6:37 PM, Jarno Rajahalme wrote: > > Instead of storing the (big) struct ofputil_flow_mod, create the new > rule and/or create the rule criteria for matching at bundle message > insert time. These can be uninitialized r

[ovs-dev] [PATCH v4] ofproto: Reduce bundle memory use.

Instead of storing the (big) struct ofputil_flow_mod, create the new rule and/or create the rule criteria for matching at bundle message insert time. This change reduces the size of a bundle flow mod from 3.5kb to 272 bytes, not counting the created rule, which was anyway created during bundle com

Re: [ovs-dev] [PATCH v2 17/21] meta-flow: New functions mf_subfield_copy() and mf_subfield_swap().

On Mon, Aug 08, 2016 at 12:29:42PM -0500, Ryan Moats wrote: > "dev" wrote on 08/08/2016 11:14:28 AM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 08/08/2016 11:17 AM > > Subject: [ovs-dev] [PATCH v2 17/21] meta-flow: New functions > > mf_subfield_copy() and mf_s

[ovs-dev] [PATCH v3 9/9] ovn-trace: New utility.

This new utility is intended to fulfill for OVN the purpose that "ofproto/trace" has for Open vSwitch. First, it's meant to be a useful tool for troubleshooting and diagnosis and in general for improving one's understanding of the emergent properties of a flow table. Second, it simplifies and inc

[ovs-dev] [PATCH v3 7/9] expr: New function expr_evaluate().

An upcoming commit will need to evaluate individual expressions outside the context of a classifier. test-ovn already had a function to do this but it wasn't general-purpose, so this commit makes a general-purpose version and adopts it for use in test-ovn as well. Signed-off-by: Ben Pfaff --- i

[ovs-dev] [PATCH v3 8/9] expr: New function expr_parse_microflow().

This allows "ovstest test-ovn evaluate-expr" work with arbitrary microflows rather than just a few restricted variables, but the main point is to enable the upcoming "ovn-trace" utility to accept arbitrary microflows in a format that seems reasonable for OVN. Signed-off-by: Ben Pfaff --- include

[ovs-dev] [PATCH v3 6/9] ovn-northd: Copy name in logical datapath southbound representations.

This makes it easier to debug based on the southbound database without looking at the northbound representation. This commit adds the name to "ovn-sbctl dump-flows" output and it will be even more useful in an upcoming commit. Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 16

[ovs-dev] [PATCH v3 4/9] lex: Integrate error handling into struct lexer.

The actions and expr modules had each developed their own error handling code that were very similar. Upcoming code needs similar error handling, so rather than duplicating it again, integrate it into the lexer itself. Signed-off-by: Ben Pfaff --- include/ovn/actions.h | 5 +- include/ovn/exp

[ovs-dev] [PATCH v3 3/9] ovn-util: Add common functions for the default NB and SB databases.

Signed-off-by: Ben Pfaff --- ovn/controller-vtep/ovn-controller-vtep.c | 5 +++-- ovn/lib/ovn-util.c| 27 + ovn/lib/ovn-util.h| 4 ovn/northd/ovn-northd.c | 27 - ovn/utilities

[ovs-dev] [PATCH v3 5/9] meta-flow: New functions mf_subfield_copy() and mf_subfield_swap().

The function nxm_execute_reg_move() was almost a general-purpose function for manipulating subfields, except for its awkward interface that took a struct ofpact_reg_move instead of a plain source and destination. This commit introduces a general-purpose function in meta-flow that corrects this fla

[ovs-dev] [PATCH v3 0/9] ovn-trace: New utility for testing and debugging OVN

The exciting part is the final commit. I recommend reading the documentation for the new program. Also available at https://github.com/blp/ovs-reviews/tree/ovnacts v1->v2: First 9 commits applied. Rebased. v2->v3: First 12 commits applied. Fixed bad %-specifier in patch 2. Ben Pfaff (9): me

[ovs-dev] [PATCH v3 1/9] meta-flow: Add ovs_be128 member to union mf_subvalue.

This makes it more convenient to access a 128-bit value stored in an mf_subvalue. Signed-off-by: Ben Pfaff --- include/openvswitch/meta-flow.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/openvswitch/meta-flow.h b/include/openvswitch/meta-flow.h index aaf7da1..76d915c 100644 --- a

Re: [ovs-dev] [ovs-discuss] Append output port to an existing flow

No, there's nothing special about VXLAN. There should no measurable overhead. On Mon, Aug 08, 2016 at 11:08:53PM +0530, Kapil Adhikesavalu wrote: > Hi Ben, > > I did a brief trial with 'groups' before mailing the list. Wanted to check > if there are other alternatives specific to vxlan. > > Tha

Re: [ovs-dev] [PATCH v2 12/21] logical-fields: Beautify conntrack definitions.

On Mon, Aug 08, 2016 at 12:21:18PM -0500, Ryan Moats wrote: > "dev" wrote on 08/08/2016 11:14:23 AM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 08/08/2016 11:16 AM > > Subject: [ovs-dev] [PATCH v2 12/21] logical-fields: Beautify > > conntrack definitions. > >

Re: [ovs-dev] [RFC/PATCH v2] Make the PID part of socket path configurable

On Mon, Aug 08, 2016 at 07:32:12PM +0200, Christian Svensson wrote: > The alternative I'm looking for would be something like > --unixctl=/run/openvswitch/my-daemon.ctl but that does not exist. OK, let's add that then. ___ dev mailing list dev@openvswitc

Re: [ovs-dev] [PATCH v2 10/21] lflow: Correct register definitions to use subfields for overlaps.

On Mon, Aug 08, 2016 at 12:12:53PM -0500, Ryan Moats wrote: > "dev" wrote on 08/08/2016 11:14:21 AM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 08/08/2016 11:16 AM > > Subject: [ovs-dev] [PATCH v2 10/21] lflow: Correct register > > definitions to use subfields

Re: [ovs-dev] [ovs-discuss] Append output port to an existing flow

Hi Ben, I did a brief trial with 'groups' before mailing the list. Wanted to check if there are other alternatives specific to vxlan. Thanks for confirming. Will there be any overhead in using 1 group for each tunnel in a scaled environment. Regards Kapil Thanks Kapil On 08-Aug-2016 9:54 PM, "

Re: [ovs-dev] [RFC/PATCH v2] Make the PID part of socket path configurable

Thanks for the comments. On Mon, Aug 8, 2016 at 6:29 PM, Ben Pfaff wrote: > > I don't think it's reasonable to make this a configuration-time option. > I want Open vSwitch behavior to be fairly uniform at runtime, not > unpredictable based on whatever flags were supplied at build time. > Isn't i

Re: [ovs-dev] [PATCH v2 17/21] meta-flow: New functions mf_subfield_copy() and mf_subfield_swap().

"dev" wrote on 08/08/2016 11:14:28 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 11:17 AM > Subject: [ovs-dev] [PATCH v2 17/21] meta-flow: New functions > mf_subfield_copy() and mf_subfield_swap(). > Sent by: "dev" > > The function nxm_execute_reg_move() wa

Re: [ovs-dev] [PATCH v2 12/21] logical-fields: Beautify conntrack definitions.

"dev" wrote on 08/08/2016 11:14:23 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 11:16 AM > Subject: [ovs-dev] [PATCH v2 12/21] logical-fields: Beautify > conntrack definitions. > Sent by: "dev" > > The previous definitions, in my opinion, were ugly and als

Re: [ovs-dev] [PATCH v2 10/21] lflow: Correct register definitions to use subfields for overlaps.

"dev" wrote on 08/08/2016 11:14:21 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 11:16 AM > Subject: [ovs-dev] [PATCH v2 10/21] lflow: Correct register > definitions to use subfields for overlaps. > Sent by: "dev" > > OVN expressions need to know what field

Re: [ovs-dev] [PATCH v2 09/21] logical-fields: Get rid of MFF_LOG_REGS in favor of something sensible.

"dev" wrote on 08/08/2016 11:14:20 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 11:16 AM > Subject: [ovs-dev] [PATCH v2 09/21] logical-fields: Get rid of > MFF_LOG_REGS in favor of something sensible. > Sent by: "dev" > > It's super-awkward to have to defi

Re: [ovs-dev] [PATCH v2 08/21] expr: Give a subfield a direct pointer to its parent in struct expr_symbol.

"dev" wrote on 08/08/2016 11:14:19 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 11:16 AM > Subject: [ovs-dev] [PATCH v2 08/21] expr: Give a subfield a direct > pointer to its parent in struct expr_symbol. > Sent by: "dev" > > Until now, symbols that repres

Re: [ovs-dev] [PATCH v2 04/21] expr: Tolerate having no macros.

"dev" wrote on 08/08/2016 11:14:15 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 11:15 AM > Subject: [ovs-dev] [PATCH v2 04/21] expr: Tolerate having no macros. > Sent by: "dev" > > A null set of macros seems reasonable, so tolerate it. > > Signed-off-by: B

Re: [ovs-dev] [PATCH v2 03/21] expr: Fine-tune parser error message for common typo.

"dev" wrote on 08/08/2016 11:14:14 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 11:15 AM > Subject: [ovs-dev] [PATCH v2 03/21] expr: Fine-tune parser error > message for common typo. > Sent by: "dev" > > It's easy to type "=" in place of "==" in an express

Re: [ovs-dev] [PATCH v2 02/21] smap: New function smap_get_ullong().

"dev" wrote on 08/08/2016 11:14:13 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 11:15 AM > Subject: [ovs-dev] [PATCH v2 02/21] smap: New function smap_get_ullong(). > Sent by: "dev" > > Signed-off-by: Ben Pfaff > --- Looks sane enough, no compiling or

Re: [ovs-dev] [PATCH v2 01/21] smap: New function smap_get_def().

"dev" wrote on 08/08/2016 11:14:12 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 11:14 AM > Subject: [ovs-dev] [PATCH v2 01/21] smap: New function smap_get_def(). > Sent by: "dev" > > Signed-off-by: Ben Pfaff > --- Much better... Acked-by: Ryan Moats

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Fix potential crash with timeout argument

>-Original Message- >From: Ben Pfaff [mailto:b...@ovn.org] >Sent: Monday, August 8, 2016 5:24 PM >To: Bodireddy, Bhanuprakash >Cc: nickcooper-zhangtonghao ; >dev@openvswitch.org >Subject: Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Fix potential crash with >timeout argument > >On Mon, Aug 08, 2

Re: [ovs-dev] [RFC/PATCH v2] Make the PID part of socket path configurable

On Mon, Aug 08, 2016 at 10:49:21AM +0200, Christian Svensson wrote: > As handling software via cgroups is more and more common, PID files are > not always needed. This change adds --disable-pid-socket-path to > ./configure to build OpenvSwitch without this PID section of the socket > path. This off

Re: [ovs-dev] [ovs-discuss] Append output port to an existing flow

On Mon, Aug 08, 2016 at 04:49:49PM +0530, Kapil Adhikesavalu wrote: > Want to check if there is an alternate way to append a output port to the > existing flow. > > > > For example, > > > > Existing flow: > > cookie=0x0, duration=14279.412s, table=0, n_packets=0, n_bytes=0, > idle_age=14316,

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Fix potential crash with timeout argument

On Mon, Aug 08, 2016 at 03:29:11PM +, Bodireddy, Bhanuprakash wrote: > >It seems to me that it’s unnecessary to change the codes. If the “timeout” is > >empty, the “atoi” function will convert it to 0, > > Got a signal when I passed empty timeout accidentally during my test runs and > so I s

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Fix potential crash with timeout argument

On Sun, Aug 07, 2016 at 10:06:05PM +0100, Bhanuprakash Bodireddy wrote: > ovs-appctl can crash with missing timeout argument. > # ovs-appctl --timeout= dpif-netdev/pmd-stats-show I don't see the crash when I run this. How is it caused? ___ dev mailing

[ovs-dev] [PATCH v2 06/21] expr: Initialize 'relop' of allocated exprs in crush_and_string().

Every relop at this point is always EXPR_R_EQ, and therefore it seems that no code actually examined it, so this doesn't appear to fix an existing bug, but some code I was working on was affected by the uninitialized member. Signed-off-by: Ben Pfaff --- ovn/lib/expr.c | 1 + 1 file changed, 1 in

[ovs-dev] [PATCH v2 21/21] ovn-trace: New utility.

This new utility is intended to fulfill for OVN the purpose that "ofproto/trace" has for Open vSwitch. First, it's meant to be a useful tool for troubleshooting and diagnosis and in general for improving one's understanding of the emergent properties of a flow table. Second, it simplifies and inc

Re: [ovs-dev] [PATCH 10/30] smap: New function smap_get_def().

On Mon, Aug 08, 2016 at 11:03:07AM -0500, Ryan Moats wrote: > The above piece of the patch set doesn't apply cleanly for me > and I'm missing parts 11-18 in my mailbox, so I'm going to stop > here ... > > I'll pick up after parts 1-9 merge and this gets rebased... OK, I applied 1-9, rebased, and

[ovs-dev] [PATCH v2 20/21] expr: New function expr_parse_microflow().

This allows "ovstest test-ovn evaluate-expr" work with arbitrary microflows rather than just a few restricted variables, but the main point is to enable the upcoming "ovn-trace" utility to accept arbitrary microflows in a format that seems reasonable for OVN. Signed-off-by: Ben Pfaff --- include

[ovs-dev] [PATCH v2 19/21] expr: New function expr_evaluate().

An upcoming commit will need to evaluate individual expressions outside the context of a classifier. test-ovn already had a function to do this but it wasn't general-purpose, so this commit makes a general-purpose version and adopts it for use in test-ovn as well. Signed-off-by: Ben Pfaff --- i

[ovs-dev] [PATCH v2 18/21] ovn-northd: Copy name in logical datapath southbound representations.

This makes it easier to debug based on the southbound database without looking at the northbound representation. This commit adds the name to "ovn-sbctl dump-flows" output and it will be even more useful in an upcoming commit. Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 16

[ovs-dev] [PATCH v2 16/21] lex: Integrate error handling into struct lexer.

The actions and expr modules had each developed their own error handling code that were very similar. Upcoming code needs similar error handling, so rather than duplicating it again, integrate it into the lexer itself. Signed-off-by: Ben Pfaff --- include/ovn/actions.h | 5 +- include/ovn/exp

[ovs-dev] [PATCH v2 17/21] meta-flow: New functions mf_subfield_copy() and mf_subfield_swap().

The function nxm_execute_reg_move() was almost a general-purpose function for manipulating subfields, except for its awkward interface that took a struct ofpact_reg_move instead of a plain source and destination. This commit introduces a general-purpose function in meta-flow that corrects this fla

[ovs-dev] [PATCH v2 13/21] meta-flow: Add ovs_be128 member to union mf_subvalue.

This makes it more convenient to access a 128-bit value stored in an mf_subvalue. Signed-off-by: Ben Pfaff --- include/openvswitch/meta-flow.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/openvswitch/meta-flow.h b/include/openvswitch/meta-flow.h index aaf7da1..76d915c 100644 --- a

[ovs-dev] [PATCH v2 15/21] ovn-util: Add common functions for the default NB and SB databases.

Signed-off-by: Ben Pfaff --- ovn/controller-vtep/ovn-controller-vtep.c | 5 +++-- ovn/lib/ovn-util.c| 27 + ovn/lib/ovn-util.h| 4 ovn/northd/ovn-northd.c | 27 - ovn/utilities

[ovs-dev] [PATCH v2 11/21] ovn: Use a common symbol table for ovn-controller and test-ovn.

Most of the differences were superficial, so it's better to reduce code duplication. This also adds a test to ensure that the OVN logical registers are built properly out of subfields. Signed-off-by: Ben Pfaff --- include/ovn/expr.h | 4 + ovn/controller/lflow.c | 163 +---

[ovs-dev] [PATCH v2 09/21] logical-fields: Get rid of MFF_LOG_REGS in favor of something sensible.

It's super-awkward to have to define a macro to use MFF_LOG_REGS; this makes more sense. Signed-off-by: Ben Pfaff --- ovn/controller/lflow.c| 17 + ovn/controller/physical.c | 6 +++--- ovn/lib/logical-fields.h | 15 +++ 3 files changed, 11 insertions(+), 27 del

[ovs-dev] [PATCH v2 12/21] logical-fields: Beautify conntrack definitions.

The previous definitions, in my opinion, were ugly and also went beyond 80 columns. This also adds a test that I generated based on the previous version, to guard against regression. Signed-off-by: Ben Pfaff --- ovn/lib/logical-fields.c | 34 +- tests/ovn.at

[ovs-dev] [PATCH v2 10/21] lflow: Correct register definitions to use subfields for overlaps.

OVN expressions need to know what fields overlap or alias one another. This is supposed to be done via subfields: if two fields overlap, then the smaller one should be defined as a subfield of the larger one. For example, reg0 should be defined as xxreg0[96..127]. The symbol table in lflow didn't

[ovs-dev] [PATCH v2 08/21] expr: Give a subfield a direct pointer to its parent in struct expr_symbol.

Until now, symbols that represent subfields and predicates were both implemented as the same string member, named 'expansion', inside struct expr. This makes it a little inconvenient to find the parent of a subfield for two reasons. First, one must actually parse the string, e.g. to convert "vlan

[ovs-dev] [PATCH v2 03/21] expr: Fine-tune parser error message for common typo.

It's easy to type "=" in place of "==" in an expression but the expression parser's error message was far from clear. For multibit numeric fields, it said: Explicit `!= 0' is required for inequality test of multibit field against 0. For string fields, the parser treated such an expression

[ovs-dev] [PATCH v2 04/21] expr: Tolerate having no macros.

A null set of macros seems reasonable, so tolerate it. Signed-off-by: Ben Pfaff --- ovn/lib/expr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ovn/lib/expr.c b/ovn/lib/expr.c index cb61b5d..050e694 100644 --- a/ovn/lib/expr.c +++ b/ovn/lib/expr.c @@ -735,7 +735,9 @@ pa

[ovs-dev] [PATCH v2 07/21] expr: Track writability as part of expr_symbol.

Until now it was only possible to find out whether an expr_symbol was read/write or read-only, for subfields, by chasing down whether the eventual parent field was read/write or read-only. This commit adds a new 'rw' member that indicates directly. Signed-off-by: Ben Pfaff --- include/ovn/expr.

[ovs-dev] [PATCH v2 05/21] expr: Refine handling of error parameter to expr_annotate().

In most cases expr_annotate() set '*errorp' to NULL if it was successful, but there was one case where it did not. This corrects that and refines the comment to better explain the intended behavior. This didn't affect any existing users because all of them passed in a pointer that was already NUL

[ovs-dev] [PATCH v2 02/21] smap: New function smap_get_ullong().

Signed-off-by: Ben Pfaff --- lib/netdev-dpdk.c | 16 ++ lib/netdev-linux.c | 89 + lib/smap.c | 11 lib/smap.h | 2 + vswitchd/bridge.c | 162 + 5 files changed, 92 insertions(+), 188 d

[ovs-dev] [PATCH v2 01/21] smap: New function smap_get_def().

Signed-off-by: Ben Pfaff --- lib/bfd.c | 60 + lib/smap.c | 25 + lib/smap.h | 4 ++- ovn/controller/chassis.c| 7 +++-- ovn/controller/encaps.c | 5 ++-- ovn

[ovs-dev] [PATCH v2 00/21] ovn-trace: New utility for testing and debugging OVN

The exciting part is the final commit. I recommend reading the documentation for the new program. Also available at https://github.com/blp/ovs-reviews/tree/ovnacts v1->v2: First 9 commits applied. Rebased. Ben Pfaff (21): smap: New function smap_get_def(). smap: New function smap_get_ullon

Re: [ovs-dev] [PATCH 10/30] smap: New function smap_get_def().

"dev" wrote on 08/08/2016 02:44:49 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 02:47 AM > Subject: [ovs-dev] [PATCH 10/30] smap: New function smap_get_def(). > Sent by: "dev" > > Signed-off-by: Ben Pfaff > --- > lib/bfd.c | 60 +++

Re: [ovs-dev] [PATCH V4 1/7] ofproto: Consider datapath_type when looking for internal ports.

On Mon, Aug 08, 2016 at 04:50:13PM +0100, Mark Kavanagh wrote: > From: Daniele Di Proietto > > Interfaces with type "internal" end up having a netdev with type "tap" > in the dpif-netdev datapath, so a strcmp will fail to match internal > interfaces. > > We can translate the types with ofproto_p

[ovs-dev] [PATCH V4 4/7] netdev-dummy: Add dummy-internal class.

From: Daniele Di Proietto "internal" netdevs are treated specially in OVS (e.g. for MTU), but the dummy datapath remaps both "system" and "internal" devices to the same "dummy" netdev class, so there's no way to discern those in tests. This commit adds a new "dummy-internal" netdev type, which w

[ovs-dev] [PATCH V4 7/7] netdev-dpdk: add support for Jumbo Frames

Add support for Jumbo Frames to DPDK-enabled port types, using single-segment-mbufs. Using this approach, the amount of memory allocated to each mbuf to store frame data is increased to a value greater than 1518B (typical Ethernet maximum frame length). The increased space available in the mbuf me

[ovs-dev] [PATCH V4 5/7] tests: Add a new MTU test.

From: Daniele Di Proietto Also, netdev-dummy needs to call netdev_change_seq_changed() in set_mtu(). Signed-off-by: Daniele Di Proietto --- lib/netdev-dummy.c| 5 - tests/ofproto-dpif.at | 30 ++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH V4 3/7] netdev: Pass 'netdev_class' to ->run() and ->wait().

From: Daniele Di Proietto This will allow run() and wait() methods to be shared between different classes and still perform class-specific work. Signed-off-by: Daniele Di Proietto --- lib/netdev-bsd.c | 6 +++--- lib/netdev-dummy.c| 4 ++-- lib/netdev-linux.c| 6 +++--- lib/net

[ovs-dev] [PATCH V4 6/7] netdev: Make netdev_set_mtu() netdev parameter non-const.

From: Daniele Di Proietto Every provider silently drops the const attribute when converting the parameter to the appropriate subclass. Might as well drop the const attribute from the parameter, since this is a "set" function. Signed-off-by: Daniele Di Proietto --- lib/netdev-dummy.c| 2 +-

[ovs-dev] [PATCH V4 2/7] vswitchd: Introduce 'mtu_request' column in Interface.

From: Daniele Di Proietto The 'mtu_request' column can be used to set the MTU of a specific interface. This column is useful because it will allow changing the MTU of DPDK devices (implemented in a future commit), which are not accessible outside the ovs-vswitchd process, but it can be used for

[ovs-dev] [PATCH V4 1/7] ofproto: Consider datapath_type when looking for internal ports.

From: Daniele Di Proietto Interfaces with type "internal" end up having a netdev with type "tap" in the dpif-netdev datapath, so a strcmp will fail to match internal interfaces. We can translate the types with ofproto_port_open_type() before calling strcmp to fix this. This fixes a minor issue

Re: [ovs-dev] [PATCH 09/30] ovn-nbctl: Add details for common options to manpage.

"dev" wrote on 08/08/2016 02:44:48 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 02:46 AM > Subject: [ovs-dev] [PATCH 09/30] ovn-nbctl: Add details for common > options to manpage. > Sent by: "dev" > > The new .xml files in this commit are translations to

Re: [ovs-dev] [PATCH 06/30] ofp-actions: Correct member name for write_actions.

"dev" wrote on 08/08/2016 02:44:45 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 02:46 AM > Subject: [ovs-dev] [PATCH 06/30] ofp-actions: Correct member name > for write_actions. > Sent by: "dev" > > For a variable-length action like write_actions, the memb

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Fix potential crash with timeout argument

>-Original Message- >From: nickcooper-zhangtonghao [mailto:nickcooper- >zhangtong...@opencloud.tech] >Sent: Monday, August 8, 2016 1:45 PM >To: Bodireddy, Bhanuprakash >Cc: dev@openvswitch.org >Subject: Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Fix potential crash with >timeout argument > > >

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Mon, 8 Aug 2016 17:17:17 +0200, Simon Horman wrote: > +bool skb_mac_header_present(struct sk_buff *skb) > +{ > + return skb->dev->type == ARPHRD_ETHER || > + (skb->dev->type == ARPHRD_NONE && > + skb->protocol == htons(ETH_P_TEB)); > +} > +EXPORT_SYMBOL(skb_mac_heade

Re: [ovs-dev] [PATCH 02/30] ovsdb-idl: Wake up ovsdb_idl_loop when a transaction commits.

"dev" wrote on 08/08/2016 02:44:41 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 02:45 AM > Subject: [ovs-dev] [PATCH 02/30] ovsdb-idl: Wake up ovsdb_idl_loop > when a transaction commits. > Sent by: "dev" > > There is a fair amount of code that defers modi

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Wed, Jul 20, 2016 at 11:06:37AM -0700, pravin shelar wrote: > On Tue, Jul 19, 2016 at 5:02 PM, Simon Horman > wrote: > > On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar wrote: > >> On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman > >> wrote: > >> > [CC Jiri Benc for portion regarding GRE]

Re: [ovs-dev] [PATCH 04/30] packets: Improve comment on eth_addr_from_string().

"dev" wrote on 08/08/2016 02:44:43 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 02:46 AM > Subject: [ovs-dev] [PATCH 04/30] packets: Improve comment on > eth_addr_from_string(). > Sent by: "dev" > > Signed-off-by: Ben Pfaff > --- > lib/packets.c | 3 +++

Re: [ovs-dev] [PATCH 03/30] flow: Comment that nw_src holds ARP SPA and nw_dst holds ARP TPA.

"dev" wrote on 08/08/2016 02:44:42 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 02:45 AM > Subject: [ovs-dev] [PATCH 03/30] flow: Comment that nw_src holds ARP > SPA and nw_dst holds ARP TPA. > Sent by: "dev" > > Signed-off-by: Ben Pfaff > --- > include/

Re: [ovs-dev] [PATCH 01/30] ovn-nbctl: Add "sync" command to wait for previous changes to take effect.

"dev" wrote on 08/08/2016 02:44:40 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 08/08/2016 02:45 AM > Subject: [ovs-dev] [PATCH 01/30] ovn-nbctl: Add "sync" command to > wait for previous changes to take effect. > Sent by: "dev" > > It's slow to add --wait to every o

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Fix potential crash with timeout argument

> On Aug 8, 2016, at 3:45 PM, dev-requ...@openvswitch.org wrote: > > Date: Sun, 7 Aug 2016 22:06:05 +0100 > From: Bhanuprakash Bodireddy > > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH 2/2] ovs-appctl: Fix potential c

[ovs-dev] [RFC] netdev-dpdk: Add SW queue before Vhost-user Rx virtqueue

This patch tries to address a packet drop issue on the Rx path, which may happen when VM's vCPU is not 1:1 mapped to a physical CPU, or when the VMs overcommits memory. In these configurations, the VM is paused for several milliseconds, resulting in the Rx virtqueue not to be emptied often enought

[ovs-dev] (no subject)

Your message was undeliverable due to the following reason(s): Your message was not delivered because the destination server was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely the

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: vHost client mode and reconnect

> > The patch mostly looks good to me, thanks. > I'm not 100% sure about the interface.  Can we make the flag interface > specific? I'm not 100% sure about making the flag interface specific :) Do you think there's a use case for both client and server mode ports to be used in conjunction with

[ovs-dev] [PATCH v3 1/3] netdev-dpdk: Remove dpdkvhostcuse ports

This commit removes the 'dpdkvhostcuse' port type from the userspace datapath. vhost-cuse ports are quickly becoming obsolete as the vhost-user port type begins to support a greater feature-set thanks to the addition of things like vhost-user multiqueue and potential upcoming features like vhost-us

[ovs-dev] [PATCH v3 3/3] netdev-dpdk: vHost client mode and reconnect

A new other_config DB option has been added called 'vhost-driver-mode'. By default this is set to 'server' which is the mode of operation OVS with DPDK has used up until this point - whereby OVS creates and manages vHost user sockets. If set to 'client', OVS will act as the vHost client and connec

  1   2   >