[ovs-dev] [patch_v3] ovn: Add datapaths of interest filtering.

This patch adds datapaths of interest support where only datapaths of local interest are monitored by the ovn-controller ovsdb client. The idea is to do a flood fill in ovn-controller of datapath associations calculated by northd. A new column is added to the SB database datapath_binding table - r

[ovs-dev] [PATCHv2] fedora.spec: Add OVN include files.

Current 'make rpm-fedora' fails due to files exists in $RPM_BUILD_ROOT directory but not found in the %files section, resulting in errors below: RPM build errors: Installed (but unpackaged) file(s) found: /usr/include/ovn/actions.h /usr/include/ovn/expr.h /usr/include/ovn/lex.h The

[ovs-dev] [patch_v2] ovn: Add datapaths of interest filtering.

This patch adds datapaths of interest support where only datapaths of local interest are monitored by the ovn-controller ovsdb client. The idea is to do a flood fill in ovn-controller of datapath associations calculated by northd. A new column is added to the SB database datapath_binding table - r

Re: [ovs-dev] Let's talk the NB DB IDL Part I - things we've see scaling the networking-ovn to NB DB connection

On Wed, Aug 03, 2016 at 12:06:47AM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 08/02/2016 11:52:23 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: ovs-dev > > Date: 08/02/2016 11:52 PM > > Subject: Re: [ovs-dev] Let's talk the NB DB IDL Part I - things > > we've see scali

Re: [ovs-dev] [PATCH] fedora.spec: Disable rpmbuild unpackaged files check.

> Is this just because the fedora packaging hasn't been updated to > provide OVN, or someone has forgotten to update the specfile after > adding/moving files? > > It seems to me like the right solution is to specify these files in > the specfile somehow, rather than overriding a warning about > unp

Re: [ovs-dev] Let's talk the NB DB IDL Part I - things we've see scaling the networking-ovn to NB DB connection

Ben Pfaff wrote on 08/02/2016 11:52:23 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs-dev > Date: 08/02/2016 11:52 PM > Subject: Re: [ovs-dev] Let's talk the NB DB IDL Part I - things > we've see scaling the networking-ovn to NB DB connection > > On Tue, Aug 02, 2016 at 11:45:

Re: [ovs-dev] Let's talk the NB DB IDL Part I - things we've see scaling the networking-ovn to NB DB connection

On Tue, Aug 02, 2016 at 11:45:07PM -0500, Ryan Moats wrote: > "dev" wrote on 08/02/2016 10:56:07 PM: > > Ben Pfaff wrote on 08/02/2016 10:14:46 PM: > > > Presumably this means that networking-ovn is calling "verify" on the > > > column in question. Probably, networking-ovn should use the partial

Re: [ovs-dev] Let's talk the NB DB IDL Part I - things we've see scaling the networking-ovn to NB DB connection

"dev" wrote on 08/02/2016 10:56:07 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: Ben Pfaff > Cc: ovs-dev > Date: 08/02/2016 10:56 PM > Subject: Re: [ovs-dev] Let's talk the NB DB IDL Part I - things > we've see scaling the networking-ovn to NB DB connection > Sent by: "dev" > > Ben Pfaff wrote

Re: [ovs-dev] Let's talk the NB DB IDL Part I - things we've see scaling the networking-ovn to NB DB connection

Ben Pfaff wrote on 08/02/2016 10:14:46 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs-dev > Date: 08/02/2016 10:15 PM > Subject: Re: [ovs-dev] Let's talk the NB DB IDL Part I - things > we've see scaling the networking-ovn to NB DB connection > > On Tue, Aug 02, 2016 at 04:25:

Re: [ovs-dev] Let's talk the NB DB IDL Part I - things we've see scaling the networking-ovn to NB DB connection

On Tue, Aug 02, 2016 at 04:25:03PM -0500, Ryan Moats wrote: > First, this code from ./ovsdb/execution.c (L693-707) looks > a bit funny: > > if (!strcmp(json_string(until), "==") != equal) { > if (timeout && x->elapsed_msec >= timeout_msec) { > if (x->elapsed_msec) { > error

[ovs-dev] ovs dpdk : userspace connection tracker cannot support L7？

Hello, We read the connection tracker code, and find this patch can not parse ftp protocol. Whether the userspace connection tracker only has L4 feather or has L7 feather too ? If the ct cannot L7, then ovs dpdk cannot be used for stateful security group, so do we have a plan for supporting L

Re: [ovs-dev] [PATCH] fedora.spec: Disable rpmbuild unpackaged files check.

On 2 August 2016 at 14:41, William Tu wrote: > Starting with RPM 4.1, rpmbuild will exit if all files in the $RPM_BUILD_ROOT > directory are not found in the %files section, resulting errors below: > RPM build errors: > Installed (but unpackaged) file(s) found: > /usr/include/ovn/actions.h

Re: [ovs-dev] Let's talk the NB DB IDL Part I - things we've see scaling the networking-ovn to NB DB connection

"dev" wrote on 08/02/2016 04:25:03 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: ovs-dev > Date: 08/02/2016 04:26 PM > Subject: [ovs-dev] Let's talk the NB DB IDL Part I - things we've > see scaling the networking-ovn to NB DB connection > Sent by: "dev" > > > As folks know, we've been working o

[ovs-dev] delivery failed

The original message was received at Wed, 3 Aug 2016 09:52:12 +0800 from fieldses.org [156.8.248.177] - The following addresses had permanent fatal errors - - Transcript of session follows - while talking to openvswitch.org.: >>> MAIL From:bfie...@fieldses.org <<< 501 bfie...@f

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Add support for DPDK 16.07

Given that using vhost PMD doesn't seem viable in the very short term, I think we should stick with the vhost lib. I sent a patch for ovsrcu to add a new RCU protected array index. http://openvswitch.org/pipermail/dev/2016-August/077097.html Thanks, Daniele 2016-07-28 6:26 GMT-07:00 Loftus, Ci

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-24 11:06 GMT-07:00 Ben Pfaff : > On Sun, Jul 24, 2016 at 10:17:13AM -0400, Aaron Conole wrote: > > Daniele Di Proietto writes: > > > > > Thanks for the patch. > > > > > > I have another concern with this. If we're still going to rely on RCU > to > > > protect the vhost device (and as poi

[ovs-dev] [PATCH] ovs-rcu: Add new ovsrcu_index type.

With RCU in Open vSwitch it's very easy to protect objects accessed by a pointer, but sometimes a pointer is not available. One example is the vhost id for DPDK 16.07. Until DPDK 16.04 a pointer was used to access a vhost device with RCU semantics. From DPDK 16.07 an integer id (which is an arra

Re: [ovs-dev] [PATCH 2/6] datapath: compat: Use checksum offload for outer header.

On Tue, Aug 2, 2016 at 3:55 PM, pravin shelar wrote: > On Tue, Aug 2, 2016 at 3:11 PM, Jesse Gross wrote: >> On Tue, Aug 2, 2016 at 2:17 PM, Pravin B Shelar wrote: >>> Signed-off-by: Pravin B Shelar >>> --- >>> datapath/linux/compat/include/net/udp.h | 2 +- >>> datapath/linux/compat/udp.c

[ovs-dev] not sure

Hey friend, I'm not sure whether I should tell you that, please read it yourself Speak to you later, bunkertor ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 6/6] datapath: Add support for kernel 4.7

On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar > --- > FAQ.md | 2 +- > NEWS | 2 +- > acinclude.m4 | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) Should we also add 4.7 to Travis? I noticed that there appear to be at least t

Re: [ovs-dev] [PATCH] tests: Fix conntrack tests on windows.

On 02/08/2016 13:19, "Joe Stringer" wrote: >On 2 August 2016 at 11:58, Daniele Di Proietto wrote: >> The conntrack unit tests seem to generate different megaflow masks on >> Windows. The megaflow masks depend on the internal ordering of the >> subtables, which are sorted using qsort(), based o

Re: [ovs-dev] [PATCH 2/6] datapath: compat: Use checksum offload for outer header.

On Tue, Aug 2, 2016 at 3:11 PM, Jesse Gross wrote: > On Tue, Aug 2, 2016 at 2:17 PM, Pravin B Shelar wrote: >> Signed-off-by: Pravin B Shelar >> --- >> datapath/linux/compat/include/net/udp.h | 2 +- >> datapath/linux/compat/udp.c | 19 ++- >> datapath/linux/compat/

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On Tue, Aug 2, 2016 at 2:38 PM, Mickey Spiegel wrote: > On Tue, Aug 2, 2016 at 1:39 PM, Darrell Ball wrote: > >> >> >> On Tue, Aug 2, 2016 at 12:05 PM, Russell Bryant wrote: >> >>> >>> >>> On Tue, Aug 2, 2016 at 3:02 PM, Darrell Ball wrote: >>> On Tue, Aug 2, 2016 at 10:23 AM, M

Re: [ovs-dev] [PATCH 5/6] datapath: compat: remove duplicate check.

On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote: > The check for tunnel GSO packet is done at ip-handle-offloads. Remove > same check from udp-handle-offloads. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@ope

Re: [ovs-dev] [PATCH 4/6] datapath: compat: fix SKB_INIT_FILL_METADATA_DST definition

On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote: > In case of OVS using compat fill metadata dst implementation we need to > setup temperory dst. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org h

Re: [ovs-dev] [PATCH 1/6] datapath: compat: Detect GSO support at ovs configure

On Tue, Aug 2, 2016 at 2:17 PM, Pravin B Shelar wrote: > OVS turns on tunnel GSO backport statically for kernel older than > 3.18. Some distributions kernels could backport tunnel GSO. To make > use of device tunnel offload on such kernel detect the support at > configure stage. > > Signed-off-by:

Re: [ovs-dev] [PATCH 3/6] datapath: compat: cleanup ip-tunnels

On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote: > Remove kernel version check related to unsupported kernel. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listin

Re: [ovs-dev] [PATCH 2/6] datapath: compat: Use checksum offload for outer header.

On Tue, Aug 2, 2016 at 2:17 PM, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar > --- > datapath/linux/compat/include/net/udp.h | 2 +- > datapath/linux/compat/udp.c | 19 ++- > datapath/linux/compat/udp_tunnel.c | 17 + > 3 files changed

[ovs-dev] [PATCH] fedora.spec: Disable rpmbuild unpackaged files check.

Starting with RPM 4.1, rpmbuild will exit if all files in the $RPM_BUILD_ROOT directory are not found in the %files section, resulting errors below: RPM build errors: Installed (but unpackaged) file(s) found: /usr/include/ovn/actions.h /usr/include/ovn/expr.h /usr/include/ovn/lex.h

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On Tue, Aug 2, 2016 at 1:39 PM, Darrell Ball wrote: > > > On Tue, Aug 2, 2016 at 12:05 PM, Russell Bryant wrote: > >> >> >> On Tue, Aug 2, 2016 at 3:02 PM, Darrell Ball wrote: >> >>> >>> >>> On Tue, Aug 2, 2016 at 10:23 AM, Mickey Spiegel >>> wrote: >>> On Tue, Aug 2, 2016 at 9:26 AM, Dar

[ovs-dev] Let's talk the NB DB IDL Part I - things we've see scaling the networking-ovn to NB DB connection

As folks know, we've been working on scaling up OVN coupled with openstack and we are now starting to hit issues in the networking-ovn to NB DBconnection. First, this code from ./ovsdb/execution.c (L693-707) looks a bit funny: if (!strcmp(json_string(until), "==") != equal) { if (timeout &&

[ovs-dev] [PATCH 5/6] datapath: compat: remove duplicate check.

The check for tunnel GSO packet is done at ip-handle-offloads. Remove same check from udp-handle-offloads. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/include/net/udp_tunnel.h | 4 1 file changed, 4 deletions(-) diff --git a/datapath/linux/compat/include/net/udp_tunnel.h b/da

[ovs-dev] [PATCH 3/6] datapath: compat: cleanup ip-tunnels

Remove kernel version check related to unsupported kernel. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/ip_tunnels_core.c | 8 1 file changed, 8 deletions(-) diff --git a/datapath/linux/compat/ip_tunnels_core.c b/datapath/linux/compat/ip_tunnels_core.c index 6e84e80..d1fe2

[ovs-dev] [PATCH 6/6] datapath: Add support for kernel 4.7

Signed-off-by: Pravin B Shelar --- FAQ.md | 2 +- NEWS | 2 +- acinclude.m4 | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/FAQ.md b/FAQ.md index 40e3a22..cb9ef41 100644 --- a/FAQ.md +++ b/FAQ.md @@ -172,7 +172,7 @@ A: The following table lists the Linux ker

[ovs-dev] [PATCH 4/6] datapath: compat: fix SKB_INIT_FILL_METADATA_DST definition

In case of OVS using compat fill metadata dst implementation we need to setup temperory dst. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/gso.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath/linux/compat/gso.h b/datapath/linux/compat/gso.h index 23ed

[ovs-dev] [PATCH 2/6] datapath: compat: Use checksum offload for outer header.

Signed-off-by: Pravin B Shelar --- datapath/linux/compat/include/net/udp.h | 2 +- datapath/linux/compat/udp.c | 19 ++- datapath/linux/compat/udp_tunnel.c | 17 + 3 files changed, 4 insertions(+), 34 deletions(-) diff --git a/datapath/linux/comp

[ovs-dev] [PATCH 1/6] datapath: compat: Detect GSO support at ovs configure

OVS turns on tunnel GSO backport statically for kernel older than 3.18. Some distributions kernels could backport tunnel GSO. To make use of device tunnel offload on such kernel detect the support at configure stage. Signed-off-by: Pravin B Shelar --- acinclude.m4

[ovs-dev] [PATCH 0/6] datapath: compatibility layer update.

Following patches brings in bug fixes and minor updates to compat layer. Last patch adds for latest released linux kernel support. Pravin B Shelar (6): datapath: compat: Detect GSO support at ovs configure datapath: compat: Use checksum offload for outer header. datapath: compat: cleanup ip-

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On Tue, Aug 2, 2016 at 12:05 PM, Russell Bryant wrote: > > > On Tue, Aug 2, 2016 at 3:02 PM, Darrell Ball wrote: > >> >> >> On Tue, Aug 2, 2016 at 10:23 AM, Mickey Spiegel >> wrote: >> >>> On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote: >>> On Tue, Aug 2, 2016 at 4:52 AM, Ru

Re: [ovs-dev] [PATCH] tests: Fix conntrack tests on windows.

On 2 August 2016 at 11:58, Daniele Di Proietto wrote: > The conntrack unit tests seem to generate different megaflow masks on > Windows. The megaflow masks depend on the internal ordering of the > subtables, which are sorted using qsort(), based on their max priority. > If two subtables have the

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On Tue, Aug 2, 2016 at 3:35 PM, Guru Shetty wrote: > > > On 2 August 2016 at 12:27, Russell Bryant wrote: > >> >> >> On Tue, Aug 2, 2016 at 3:17 PM, Guru Shetty wrote: >> >>> >>> >>> On 2 August 2016 at 12:01, Russell Bryant wrote: >>> On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wro

[ovs-dev] [PATCH v3 2/3] datapath-windows: Add multiple switch internal ports

This patch adds multiple internal ports support to the windows datapath. All tunnels types have been updated to accommodate this new functionality. Signed-off-by: Alin Gabriel Serdean Co-authored-by: Sorin Vinturis Acked-by: Paul Boca --- v3: Add acked v2: Rebase --- datapath-windows/ovsext/Ac

[ovs-dev] [PATCH v3 3/3] Windows: document multiple NIC support setup

This patch updates the documentation on how to set up OVS with multiple NICs. Also update the documentation to show users how new internal ports are created Signed-off-by: Alin Gabriel Serdean Acked-by: Paul Boca --- v3: Add acked v2: Rebase --- --- INSTALL.Windows.md | 143 +++

[ovs-dev] [PATCH v3 1/3] Windows: Add internal switch port per OVS bridge

This patch updates the following commands in the vswitch: ovs-vsctl add-br br-test ovs-vsctl del-br br-test ovs-vsctl add-br br-test: This command will now create an internal port on the MSFT virtual switch using the WMI interface from Msvm_VirtualEthernetSwitchManagementService leveraging

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On 2 August 2016 at 12:27, Russell Bryant wrote: > > > On Tue, Aug 2, 2016 at 3:17 PM, Guru Shetty wrote: > >> >> >> On 2 August 2016 at 12:01, Russell Bryant wrote: >> >>> >>> On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wrote: >>> The 2 ct_commit for deletion of firewall rules will likel

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On Tue, Aug 2, 2016 at 3:17 PM, Guru Shetty wrote: > > > On 2 August 2016 at 12:01, Russell Bryant wrote: > >> >> On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wrote: >> >>> The 2 ct_commit for deletion of firewall rules will likely be tricky. >>> This >>> will need unit tests. >>> >> >> I don't

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On 2 August 2016 at 12:01, Russell Bryant wrote: > > On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wrote: > >> The 2 ct_commit for deletion of firewall rules will likely be tricky. This >> will need unit tests. >> > > I don't think I understand the concern. Can you expand a bit on what you > mean

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On Tue, Aug 2, 2016 at 3:02 PM, Darrell Ball wrote: > > > On Tue, Aug 2, 2016 at 10:23 AM, Mickey Spiegel > wrote: > >> On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote: >> >>> >>> >>> On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant wrote: >>> On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spie

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wrote: > The 2 ct_commit for deletion of firewall rules will likely be tricky. This > will need unit tests. > I don't think I understand the concern. Can you expand a bit on what you mean by "2 ct_commit for deletion of firewall rules"? -- Russell B

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On Tue, Aug 2, 2016 at 10:23 AM, Mickey Spiegel wrote: > On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote: > >> >> >> On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant wrote: >> >>> On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel >>> wrote: >>> >>> > On Fri, Jul 29, 2016 at 10:28 AM, Mickey Spi

Re: [ovs-dev] FAILING UNIT ofproto-dpif.at:8215: testing ofproto-dpif - conntrack - output action

Hi Alin, Thanks for the report! I couldn't reproduce this on Linux or BSD, but Guru (thanks!) gave me a Windows setup, which showed the problem. I sent a patch to fix this and the other issue you reported here: http://openvswitch.org/pipermail/dev/2016-August/077062.html Thanks, Daniele 201

[ovs-dev] [PATCH] tests: Fix conntrack tests on windows.

The conntrack unit tests seem to generate different megaflow masks on Windows. The megaflow masks depend on the internal ordering of the subtables, which are sorted using qsort(), based on their max priority. If two subtables have the same priority the ordering between them depend on the stability

Re: [ovs-dev] Replication feature bug

On Mon, Aug 1, 2016 at 2:44 PM, Andy Zhou wrote: > > > On Mon, Aug 1, 2016 at 10:07 AM, Cabrera Vega, Mario Alberto < > mario.cabr...@hpe.com> wrote: > >> Hi, >> >> The replication_init() function initializes the set that contains the >> names of the >> tables to be monitored and the set that con

[ovs-dev] [PATCH v7] Windows: Local named pipe implementation

Currently in the case of command line arguments punix/unix, on Windows we create a file, write a TCP port number to connect. This is a security concern. This patch adds support for the command line arguments punix/unix trying to mimic AF_UNIX behind a local named pipe. This patch drops the TCP so

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

On Tue, Aug 02, 2016 at 12:59:42PM -0500, Ryan Moats wrote: > > Ben Pfaff wrote on 08/02/2016 12:45:49 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: Russell Bryant , ovs dev > > Date: 08/02/2016 12:46 PM > > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

Ben Pfaff wrote on 08/02/2016 12:45:49 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: Russell Bryant , ovs dev > Date: 08/02/2016 12:46 PM > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands > > On Tue, Aug 02, 2016 at 12:13:13PM -0500, Ryan Moats wrote: >

Re: [ovs-dev] [PATCH V8 00/17] Fix and enable Python tests on Windows

Hi Guru! There was a bug indeed and I solved it in V10 series. Thanks for reporting this, Paul From: Guru Shetty [mailto:g...@ovn.org] Sent: Friday, July 29, 2016 8:27 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH V8 00/17] Fix and enable Python tests on Windows Thank y

[ovs-dev] [PATCH V11 17/17] tests: Skip vlog tests that try to move opened file

On Windows if a file is opened by an application for writing, we cannot move it until all handles to that file are closed. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: Removed code that disables 'vlog/close' tests. V7: Sm

[ovs-dev] [PATCH V11 16/17] python tests: Skip ovn-controller-vtep tests on Windows

The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: No changes V7: Removed Python check on running this test V8: No changes V9

[ovs-dev] [PATCH V11 15/17] python tests: Ignore stderr output

test-unixctl.py and test-vlog.py outputs on stderr and on Windows stderr is not overriden by every AT_CHECK call, the logs are only apended to the file and subsequent AT_CHECKs get errors from previous call. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V

[ovs-dev] [PATCH V11 14/17] at tests: Allow Python tests to be run on Windows

This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes V9: No ch

[ovs-dev] [PATCH V11 13/17] python tests: Ported Python daemon to Windows

Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to sig

[ovs-dev] [PATCH V11 12/17] python tests: Prepare porting Python daemon on Windows

Renamed daemon.py to daemon_unix.py and implemented a wrapper over it. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V8: Initial commit. V9: No changes V10: Fixed exception on Unix V11: No changes --- python/automake.mk| 1 + python/ovs/daemon.py | 489 ++

[ovs-dev] [PATCH V11 11/17] python tests: Ported UNIX sockets to Windows

AF_UNIX sockets are not supported on Windows. Instead of an AF_UNIX socket use localhost tcp connections to communicate between components. This makes the python sockets compatible with the ones used in Windows applications. In case the socket returns WSAEWOULDBLOCK, it is replaced by EAGAIN error

[ovs-dev] [PATCH V11 08/17] python tests: Skip python tests on Windows where POSIX pid is used

There is a difference between POSIX pid and Windows pid, not all the time are equal. On Windows when a python script is started, a sh command is triggered as the parent for script. So when we try to get the daemon pid with 'echo $!', this will get the pid of sh not of python.exe as expected. Als

[ovs-dev] [PATCH V11 06/17] python tests: Skip IPsec test on Windows

IPsec is not used on Windows yet, and the services used by this test are non-existent on Windows. Also the paths in the test do not exist on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: Updated commit

[ovs-dev] [PATCH V11 09/17] python tests: Fixed OSError not iterable on Windows

On Windows if this exception is triggered then it will raise an exception while in the exception handler. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: Added comment when using OSE

[ovs-dev] [PATCH V11 05/17] python tests: Added fcntl module for Windows

This is needed for lockf function used to lock the PID file on Windows. ioctl and fcntl functions are not implemented at this time because they are not used by any script. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No chang

[ovs-dev] [PATCH V11 10/17] python tests: Fixed abs_file_name function for Windows

On windows a path containint ':' is considered an absolute path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes V9: No changes V10: No changes V11: No changes --- python/

[ovs-dev] [PATCH V11 07/17] python tests: Skip TCP6 idl tests on Windows

The IPPROTO_IPV6 is not defined on Python for Windows because of compatibility with older Windows versions. Here is this issue discussed:https://bugs.python.org/issue6926 Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No change

[ovs-dev] [PATCH V11 04/17] python tests: Fixed unixctl python tests for Windows

For bogus pid file path, use a windows-like file path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes V9: No changes V10: No changes V11: No changes --- tests/unixctl-py.

[ovs-dev] [PATCH V11 03/17] python tests: Fixed ctl file name for Windows

On Windows the CTL filename doesn't contain the pid of the process. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: Fixed flake8 errors. Addressed changes required by review. V8: Fixed small alignem

[ovs-dev] [PATCH V11 02/17] python tests: Register signal handlers only on supported types on Windows

SIGHUP and SIGALRM are not available on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: Fixed Python function inet_open_active, treat WSAEWOULDBLOCK error as EINPROGRESS on Windows V3: No changes V4: No changes V5: No changes V6: No changes V7: Simplified the

[ovs-dev] [PATCH V11 01/17] python tests: Implemented signal.alarm for Windows

signal.alarm is not available in Windows and would trigger an exception when called. Implemented this to mentain compatibility between Windows and Linux for python tests. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: Code styling changes V4: No changes V5:

[ovs-dev] [PATCH V11 00/17] Fix and enable Python tests on Windows

This series of patches ports the python damons to Windows and fixes the tests to work on Windows. There are still some python tests that fail on Windows, from which some are failing on Linux too. The patches in this series are dependent and are related to python tests on Windows. V2: Fixes more po

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

On Tue, Aug 02, 2016 at 12:13:13PM -0500, Ryan Moats wrote: > > Russell Bryant wrote on 08/02/2016 12:00:08 PM: > > > From: Russell Bryant > > To: Ben Pfaff > > Cc: Ryan Moats/Omaha/IBM@IBMUS, ovs dev > > Date: 08/02/2016 12:00 PM > > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for

[ovs-dev] [PATCH v6] Windows: Local named pipe implementation

Currently in the case of command line arguments punix/unix, on Windows we create a file, write a TCP port number to connect. This is a security concern. This patch adds support for the command line arguments punix/unix trying to mimic AF_UNIX behind a local named pipe. This patch drops the TCP so

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote: > > > On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant wrote: > >> On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel >> wrote: >> >> > On Fri, Jul 29, 2016 at 10:28 AM, Mickey Spiegel >> > wrote: >> > > >> > > -"dev" wrote: - >> > >> To:

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On 2 August 2016 at 10:23, Mickey Spiegel wrote: > On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote: > > > > > > > On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant wrote: > > > >> On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel > >> wrote: > >> > >> > On Fri, Jul 29, 2016 at 10:28 AM, Mickey S

Re: [ovs-dev] [PATCH] ovn-nbctl: fix help message for lsp-get/set-addresses

On Sun, Jul 31, 2016 at 2:17 AM, Han Zhou wrote: > Signed-off-by: Han Zhou > --- > ovn/utilities/ovn-nbctl.8.xml | 10 +- > ovn/utilities/ovn-nbctl.c | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > Thanks! I applied this to master. -- Russell Bryant ___

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

On Tue, Aug 2, 2016 at 12:13 PM, Ryan Moats wrote: > > Russell Bryant wrote on 08/02/2016 12:00:08 PM: > >> From: Russell Bryant >> To: Ben Pfaff >> Cc: Ryan Moats/Omaha/IBM@IBMUS, ovs dev >> Date: 08/02/2016 12:00 PM >> Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

[ovs-dev] [PATCH v2] ovn: Add second ACL stage

This patch adds a second logical switch ingress ACL stage, and correspondingly a second logical switch egress ACL stage. This allows for more than one ACL-based feature to be applied in the ingress and egress logical switch pipelines. The features driving the different ACL stages may be configure

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

Russell Bryant wrote on 08/02/2016 12:00:08 PM: > From: Russell Bryant > To: Ben Pfaff > Cc: Ryan Moats/Omaha/IBM@IBMUS, ovs dev > Date: 08/02/2016 12:00 PM > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands > > On Tue, Aug 2, 2016 at 12:03 PM, Ben Pfaff wrote: > On T

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

On Tue, Aug 2, 2016 at 12:03 PM, Ben Pfaff wrote: > On Tue, Aug 02, 2016 at 07:56:27AM -0400, Russell Bryant wrote: > > On Tue, Aug 2, 2016 at 12:20 AM, Ryan Moats wrote: > > > > > This commit creates wrapper scripts for the *ctl commands to use > > > --dry-run for those that have them, and to a

Re: [ovs-dev] [PATCH] netdev-dpdk: When no QoS set, set type to empty string

On 08/02/2016 05:19 PM, Stokes, Ian wrote: This patch sets *typep to an empty string instead of letting it uninitialized when no QoS configuration is set. It fixes the following vswitchd crash when no QoS has been set on vhost- user interface: $> ovs-appctl -t ovs-vswitchd qos/show vhost-use

[ovs-dev] [PATCH v1 1/1] netdev-dpdk: Fix egress policer error detection bug.

When egress policer is set as a QoS type for a port, an error may occur during setup if incorrect parameters are used for the rte_meter. If this occurs the egress policer construct and set functions should free any allocated memory relevant to the policer and set the QoS configuration pointer to nu

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant wrote: > On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel > wrote: > > > On Fri, Jul 29, 2016 at 10:28 AM, Mickey Spiegel > > wrote: > > > > > > -"dev" wrote: - > > >> To: Mickey Spiegel > > >> From: Russell Bryant > > >> Sent by: "dev" >

Re: [ovs-dev] [ovs-discuss] Compiler warnings with gcc 6.1 (On Fedora 24)

I have seen similar compiler error/warnings when compiling DPDK with Fedora 24. I tried to fix the warnings in the source code and passed the compilation, but still could not make the packet flow. Eventually I went back to Fedora 23. Thanks, Charlie On Tue, Jul 26, 2016 at 7:44 AM, Numan Siddique

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

Ben Pfaff wrote on 08/02/2016 11:03:52 AM: > From: Ben Pfaff > To: Russell Bryant > Cc: Ryan Moats/Omaha/IBM@IBMUS, ovs dev > Date: 08/02/2016 11:04 AM > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands > > On Tue, Aug 02, 2016 at 07:56:27AM -0400, Russell Bryant wrote:

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

Russell Bryant wrote on 08/02/2016 10:27:55 AM: > From: Russell Bryant > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev > Date: 08/02/2016 10:28 AM > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands > > On Tue, Aug 2, 2016 at 9:37 AM, Ryan Moats wrote: > "dev" wrote on

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

On Tue, Aug 02, 2016 at 07:56:27AM -0400, Russell Bryant wrote: > On Tue, Aug 2, 2016 at 12:20 AM, Ryan Moats wrote: > > > This commit creates wrapper scripts for the *ctl commands to use > > --dry-run for those that have them, and to allow for log level > > setting via ovs-appctl without allowin

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

On Tue, Aug 2, 2016 at 9:37 AM, Ryan Moats wrote: > "dev" wrote on 08/02/2016 08:34:08 AM: > > > From: Ryan Moats/Omaha/IBM@IBMUS > > To: Russell Bryant > > Cc: ovs dev > > Date: 08/02/2016 08:35 AM > > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands > > Sent by: "dev"

[ovs-dev] [PATCH v2 1/5] check-kernel: Add macros to check for and test 802.1ad.

Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN(). Signed-off-by: Eric Garver --- tests/system-common-macros.at | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at index 4ffc3822

[ovs-dev] [PATCH v2 4/5] check-kernel: 802.1ad: Add push/pop test case.

Test case to push and pop outer 802.1ad tag between two "customer" bridges. Signed-off-by: Eric Garver --- tests/system-traffic.at | 54 + 1 file changed, 54 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 817eca

Re: [ovs-dev] [PATCH] bridge: No QoS configured is not an error

> If no QoS is configured, type value is likely to be an empty string. > > This is not an error though, so use the regular command reply function, > not the error one. > > For example, before this patch: > # ovs-appctl -t ovs-vswitchd qos/show vhost-user1 > QoS not configured on vhost-user1 >

[ovs-dev] [PATCH v2 0/5] check-kernel: add 802.1ad tests

This series adds 6 test cases to the "check-kernel" make target for 802.1ad. It is meant as a counterpart to the 802.1ad work currently going on and being discussed on the dev list. User space support for 802.1ad is being worked on by Xiao Liang (based on Thomas F Herbert's work). Kernel support

Re: [ovs-dev] [PATCH] ovn-controller: if 'ovn-bridge-mappings' unconfigured, return directly.

On Mon, Aug 1, 2016 at 1:30 PM, Russell Bryant wrote: > > > On Mon, Aug 1, 2016 at 12:09 PM, Russell Bryant wrote: > >> >> >> On Mon, Aug 1, 2016 at 12:00 PM, Ben Pfaff wrote: >> >>> On Mon, Aug 01, 2016 at 02:55:26AM -0700, nickcooper-zhangtonghao wrote: >>> > If the chassis doesn't configure

[ovs-dev] [PATCH v2 5/5] check-kernel: 802.1ad: Add dot1q-tunnel test case.

Test case for dot1q-tunnel between two "customer" bridges. Signed-off-by: Eric Garver --- tests/system-traffic.at | 45 + 1 file changed, 45 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 3b51d0f91607..d2815aa0a34a

[ovs-dev] [PATCH v2 3/5] check-kernel: 802.1ad: Add conntrack ping tests for CVLANs.

Signed-off-by: Eric Garver --- tests/system-traffic.at | 106 1 file changed, 106 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 4f72292e5490..817eca1d5fea 100644 --- a/tests/system-traffic.at +++ b/tests/system

[ovs-dev] [PATCH v2 2/5] check-kernel: 802.1ad: Add datapath ping tests for CVLANs.

Signed-off-by: Eric Garver --- tests/system-traffic.at | 63 + 1 file changed, 63 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 1cdc2d2e0f4e..4f72292e5490 100644 --- a/tests/system-traffic.at +++ b/tests/system-

  1   2   >