Re: [ovs-dev] [PATCH] ovn-controller: update_ct_zone operates always on empty set

2016-07-26 Thread Babu Shanmugam
On Wednesday 27 July 2016 06:43 AM, Russell Bryant wrote: On Tue, Jul 26, 2016 at 6:46 AM, > wrote: From: Babu Shanmugam mailto:bscha...@redhat.com>> Commit 263064a (Convert binding_run to incremental processing.) removed the usage of all_lports fro

[ovs-dev] [PATCH] ovn-nbctl: Improve usage message.

2016-07-26 Thread Ben Pfaff
The most important change here is to delete misspelled "the". Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-nbctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c index e594a32..947e3a1 100644 --- a/ovn/utilities/ovn

[ovs-dev] distributors needed

2016-07-26 Thread Tony Ryan
Hi, I wanted to check in with you, did you receive my email from last week? We are a 27 year old USA based company. We manufacture slip resistant floor treatments We need distributors worldwide. One 30 minute treatment will make all types of floors slip resistant and safe for a minimum of 4 yea

Re: [ovs-dev] [PATCH v1 2/3] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-26 Thread Numan Siddique
On Wed, Jul 27, 2016 at 2:07 AM, Ben Pfaff wrote: > On Wed, Jul 27, 2016 at 12:55:00AM +0530, Numan Siddique wrote: > > This patch adds a new OVN action 'put_dhcpv6_opts' to support native > > DHCPv6 in OVN. > > > > ovn-controller parses this action and adds a NXT_PACKET_IN2 > > OF flow with 'pau

[ovs-dev] Returned mail: see transcript for details

2016-07-26 Thread lamquocthang
The original message was received at Wed, 27 Jul 2016 12:14:42 +0700 from 36.47.224.224 - The following addresses had permanent fatal errors - dev@openvswitch.org ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinf

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-07-26 Thread Ben Pfaff
On Wed, Jul 27, 2016 at 11:51:25AM +0800, Xiao Liang wrote: > On Tue, Jul 26, 2016 at 12:52 AM, Ben Pfaff wrote: > > On Tue, Jul 12, 2016 at 11:38:54PM +0800, Xiao Liang wrote: > >> Flow key handleing changes: > >> - Add VLAN header array in struct flow, to record multiple 802.1q VLAN > >> heade

Re: [ovs-dev] [PATCH] ovn-controller: squelch expected duplicate flow warnings

2016-07-26 Thread Ryan Moats
Guru Shetty wrote on 07/26/2016 10:22:30 PM: > From: Guru Shetty > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: Guru Shetty , ovs dev > Date: 07/26/2016 10:22 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: squelch expected > duplicate flow warnings > > > On Jul 26, 2016, at 5:30 PM, Ryan Moats wr

[ovs-dev] [PATCH] ovn-controller: Persist desired conntrack groups.

2016-07-26 Thread Ryan Moats
[1] indicates that with incremental processing of logical flows desired conntrack groups are not being persisted. This patch adds this capability, with the side effect of adding a ds_copy method that this capability leverages. [1] http://openvswitch.org/pipermail/dev/2016-July/076320.html Signed

Re: [ovs-dev] [PATCH] ovsdb: Fix memory leak in execute_update.

2016-07-26 Thread nickcooper-zhangtonghao
Hi William, I reviewed your patch codes and found other bugs. If the ‘ovsdb_condition_from_json’ return the error, cnd->clauses will be set NULL, so ‘ovsdb_condition_destroy’ should check the 'cnd->clauses’ before free it. It is applied to ‘ovsdb_row_from_json’. Signed-off-by: nickcooper-zhangt

Re: [ovs-dev] [PATCH] ovn-controller: squelch expected duplicate flow warnings

2016-07-26 Thread Ryan Moats
Guru Shetty wrote on 07/26/2016 10:22:30 PM: > From: Guru Shetty > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: Guru Shetty , ovs dev > Date: 07/26/2016 10:22 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: squelch expected > duplicate flow warnings > > > On Jul 26, 2016, at 5:30 PM, Ryan Moats wr

Re: [ovs-dev] [PATCH v4 1/4] Add support for 802.1ad (QinQ tunneling)

2016-07-26 Thread Xiao Liang
On Tue, Jul 26, 2016 at 12:52 AM, Ben Pfaff wrote: > On Tue, Jul 12, 2016 at 11:38:54PM +0800, Xiao Liang wrote: >> Flow key handleing changes: >> - Add VLAN header array in struct flow, to record multiple 802.1q VLAN >> headers. >> - Add dpif multi-VLAN capability probing. If datapath supports

[ovs-dev] [PATCH] ovsdb-client: Fix memory leak reported by Valgrind.

2016-07-26 Thread William Tu
Testcase 1857: ovsdb-monitor.at:538 monitor-cond-change reports the following definitely memory leak: ovsdb_schema_create (ovsdb.c:34) ovsdb_schema_from_json (ovsdb.c:196) fetch_schema (ovsdb-client.c:385) do_monitor_cond (ovsdb-client.c:1112) Signed-of-by: William Tu --- ovsdb/o

Re: [ovs-dev] [PATCH] ovn-controller: update_ct_zone operates always on empty set

2016-07-26 Thread Guru Shetty
> On Jul 26, 2016, at 6:13 PM, Russell Bryant wrote: > >> On Tue, Jul 26, 2016 at 6:46 AM, wrote: >> >> From: Babu Shanmugam >> >> Commit 263064a (Convert binding_run to incremental processing.) removed >> the usage >> of all_lports from binding_run, but it is infact used in the context of

Re: [ovs-dev] [PATCH] ovn-controller: squelch expected duplicate flow warnings

2016-07-26 Thread Guru Shetty
> On Jul 26, 2016, at 5:30 PM, Ryan Moats wrote: > > Guru Shetty wrote on 07/26/2016 06:05:47 PM: > > > From: Guru Shetty > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: ovs dev > > Date: 07/26/2016 06:06 PM > > Subject: Re: [ovs-dev] [PATCH] ovn-controller: squelch expected > > duplicate flow

[ovs-dev] [PATCH] ovsdb: Fix memory leak reported by Valgrind.

2016-07-26 Thread William Tu
Valgrind testcase 1967: simple idl, conditional, modify as delete due to condition - C reports the following leak: json_array_create_empty (json.c:185) json_parser_push_array (json.c:1234) json_parser_input (json.c:1328) json_lex_input (json.c:945) json_parser_feed (json.c:1103)

[ovs-dev] [PATCH, v4] Scanning only changed entries in the ovnsb

2016-07-26 Thread Hui Kang
- Improve performance by scanning only changed port binding entries when determining whether to mark the logical switch port up or down v3->v4: - Add an initialization function to scan all entries in Port_binding table when ovn-northd restarts or fails over Signed-off-by: Hui Kang --- ovn/nor

Re: [ovs-dev] [PATCH] ovn-controller: update_ct_zone operates always on empty set

2016-07-26 Thread Ryan Moats
"dev" wrote on 07/26/2016 08:13:00 PM: > From: Russell Bryant > To: Babu Shanmugam > Cc: ovs dev > Date: 07/26/2016 08:13 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: update_ct_zone > operates always on empty set > Sent by: "dev" > > On Tue, Jul 26, 2016 at 6:46 AM, wrote: > > > From:

[ovs-dev] [PATCH] ovsdb: Fix memory leak in execute_update.

2016-07-26 Thread William Tu
Valgrind testcase 1804 ovsdb-server.at:1023 insert rows, update rows by value reports the following leak. json_from_string (json.c:1025) execute_update (replication.c:614), similarily at execute_delete() process_table_update (replication.c:502) process_notification.part.5 (replicati

Re: [ovs-dev] ovsdb active backup deployment

2016-07-26 Thread Russell Bryant
On Tue, Jul 26, 2016 at 3:48 PM, Andy Zhou wrote: > > > On Tue, Jul 26, 2016 at 11:59 AM, Russell Bryant wrote: > >> >> >> On Tue, Jul 26, 2016 at 2:41 PM, Andy Zhou wrote: >> >>> >>> >>> On Tue, Jul 26, 2016 at 5:37 AM, Russell Bryant wrote: >>> On Mon, Jul 25, 2016 at 8:15 PM,

Re: [ovs-dev] [PATCH] ovn-controller: update_ct_zone operates always on empty set

2016-07-26 Thread Russell Bryant
On Tue, Jul 26, 2016 at 6:46 AM, wrote: > From: Babu Shanmugam > > Commit 263064a (Convert binding_run to incremental processing.) removed > the usage > of all_lports from binding_run, but it is infact used in the context of > the caller, > especially by update_ct_zones(). > > Without this chang

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 4.6

2016-07-26 Thread pravin shelar
On Tue, Jul 26, 2016 at 4:37 PM, Amitabha Biswas wrote: > Typo in the previous ack > > Acked-by: Amitabha Biswas > > On Jul 26, 2016, at 4:22 PM, Amitabha Biswas wrote: > > I was able to compile the openvswitch modules on Linux 4.6 kernel and > stacked using OpenStack networking-ovn. > > The bas

Re: [ovs-dev] [PATCH v2 1/3] datapath: compat: fix udp checksum calculation

2016-07-26 Thread pravin shelar
On Tue, Jul 26, 2016 at 4:03 PM, Jesse Gross wrote: > On Tue, Jul 26, 2016 at 3:59 PM, pravin shelar wrote: >> On Tue, Jul 26, 2016 at 3:53 PM, Jesse Gross wrote: >>> On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote: diff --git a/datapath/linux/compat/include/net/udp.h b/datapa

[ovs-dev] [PATCH v5 04/16] conntrack: New userspace connection tracker.

2016-07-26 Thread Daniele Di Proietto
This commit adds the conntrack module. It is a connection tracker that resides entirely in userspace. Its primary user will be the dpif-netdev datapath. The module main goal is to provide conntrack_execute(), which offers a convenient interface to implement the datapath ct() action. The conntra

[ovs-dev] [PATCH v5 12/16] tests: Add conntrack ofproto-dpif tests.

2016-07-26 Thread Daniele Di Proietto
While the system testsuite already has connection tracking tests, it will be still useful to add some to the standard testsuite because: * They're run more often by developers. * Some of them are more interesting for the userspace datapath. Signed-off-by: Daniele Di Proietto Acked-by: Flavio Lei

[ovs-dev] [PATCH v5 15/16] conntrack: Track ICMP type and code.

2016-07-26 Thread Daniele Di Proietto
From the connection tracker perspective, an ICMP connection is a tuple identified by source ip address, destination ip address and ICMP id. While this allows basic ICMP traffic (pings) to work, it doesn't take into account the icmp type: the connection tracker will allow requests/replies in any di

[ovs-dev] [PATCH v5 13/16] system-tests: Run conntrack tests with userspace.

2016-07-26 Thread Daniele Di Proietto
The userspace connection tracker doesn't support ALGs, frag reassembly or NAT yet, so skip those tests. Also, connection tracking state input from a local port is not possible in userspace. The userspace datapath pads all frames with 0, to make them at least 64 bytes. Finally, the userspace data

[ovs-dev] [PATCH v5 06/16] tests: Add very simple conntrack benchmark.

2016-07-26 Thread Daniele Di Proietto
This introduces a very limited but simple benchmark for conntrack_execute(). It just sends repeatedly the same batch of packets through the connection tracker and returns the time spent to process them. While this is not a realistic benchmark, it has proven useful during development to evaluate di

[ovs-dev] [PATCH v5 16/16] conntrack: Add 'dl_type' parameter to conntrack_execute().

2016-07-26 Thread Daniele Di Proietto
Now that dpif_execute has a 'flow' member, it's pretty easy to access a the flow (or the matching megaflow) in dp_execute_cb(). This means that's not necessary anymore for the connection tracker to reextract 'dl_type' from the packet, it can be passed as a parameter. This change means that we hav

[ovs-dev] [PATCH v5 03/16] flow: Introduce parse_dl_type().

2016-07-26 Thread Daniele Di Proietto
The function simply returns the ethernet type of the packet (after eventually discarding the VLAN tag). It will be used by a following commit. Signed-off-by: Daniele Di Proietto Acked-by: Flavio Leitner --- lib/flow.c | 14 -- lib/flow.h | 1 + 2 files changed, 13 insertions(+), 2

[ovs-dev] [PATCH v5 14/16] system-tests: Add ping through conntrack test.

2016-07-26 Thread Daniele Di Proietto
Signed-off-by: Daniele Di Proietto Acked-by: Joe Stringer --- tests/system-traffic.at | 84 + 1 file changed, 84 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 0b4b4b7..fd8b918 100644 --- a/tests/system-traffic.

[ovs-dev] [PATCH v5 09/16] dpif-netdev: Implement conntrack dump functions.

2016-07-26 Thread Daniele Di Proietto
New functions are implemented in the conntrack module to support this. Signed-off-by: Daniele Di Proietto Acked-by: Flavio Leitner --- lib/conntrack-private.h | 3 ++ lib/conntrack-tcp.c | 34 + lib/conntrack.c | 123 l

[ovs-dev] [PATCH v5 11/16] flow: Generate checksum and udp_len in flow_compose().

2016-07-26 Thread Daniele Di Proietto
This is useful to test the connection tracker, which performs checksum and udp length verification. Signed-off-by: Daniele Di Proietto Acked-by: Joe Stringer --- lib/flow.c| 62 ++-- tests/ofproto-dpif.at | 198 +- 2 files

[ovs-dev] [PATCH v5 10/16] dpif-netdev: Implement conntrack flush interface.

2016-07-26 Thread Daniele Di Proietto
New functions are implemented in the conntrack module to support this. Signed-off-by: Daniele Di Proietto Acked-by: Flavio Leitner --- lib/conntrack.c | 23 +++ lib/conntrack.h | 2 ++ lib/dpif-netdev.c | 10 +- 3 files changed, 34 insertions(+), 1 deletion(-)

[ovs-dev] [PATCH v5 08/16] dpif-netdev: Execute conntrack action.

2016-07-26 Thread Daniele Di Proietto
This commit implements the OVS_ACTION_ATTR_CT action in dpif-netdev. To allow ofproto-dpif to detect the conntrack feature, flow_put will not discard anymore flows with ct_* fields set. We still shouldn't allow flows with NAT bits set, since there is no support for NAT. Signed-off-by: Daniele Di

[ovs-dev] [PATCH v5 05/16] conntrack: Periodically delete expired connections.

2016-07-26 Thread Daniele Di Proietto
This commit adds a thread that periodically removes expired connections. The expiration time of a connection can be expressed by: expiration = now + timeout For each possible 'timeout' value (there aren't many) we keep a list. When the expiration is updated, we move the connection to the back of

[ovs-dev] [PATCH v5 02/16] flow: Export parse_ipv6_ext_hdrs().

2016-07-26 Thread Daniele Di Proietto
This will be used by a future commit. Signed-off-by: Daniele Di Proietto Acked-by: Joe Stringer Acked-by: Flavio Leitner --- lib/flow.c | 140 ++--- lib/flow.h | 3 ++ 2 files changed, 81 insertions(+), 62 deletions(-) diff --git a/lib

[ovs-dev] [PATCH v5 01/16] packets: Define ICMP types.

2016-07-26 Thread Daniele Di Proietto
Linux and FreeBSD have slightly different names for these constants. Windows doesn't define them. It is simpler to redefine them from scratch for OVS. The new names are different than those used in Linux and FreeBSD. These definitions will be used by a future commit. Signed-off-by: Daniele Di P

[ovs-dev] [PATCH v5 07/16] tests: Add test-conntrack pcap test.

2016-07-26 Thread Daniele Di Proietto
Simple program that runs the packet in a pcap file through the connection tracker and prints the 'ct_state' for each packet. E.g. the line: `./test/ovstest test-conntrack capture.pcap 2` sends the packets in `capture.pcap` to the connection tracker, 2 per call. Useful for debugging. Signed-off

[ovs-dev] [PATCH v5 00/16] Userspace (DPDK) connection tracker

2016-07-26 Thread Daniele Di Proietto
This series aims to implement the ct() action for the dpif-netdev datapath. The bulk of the code is in the new conntrack module: it contains some packet parsing code, some lookup tables and the logic to implements all the ct bits. The conntrack module is helped by conntrack-tcp, for TCP window and

Re: [ovs-dev] [PATCH 2/3] ovsdb: Fix memory leak in replication logic

2016-07-26 Thread William Tu
thanks for fixing the memory leak! Acked-by: William Tu On Tue, Jul 26, 2016 at 1:08 PM, Andy Zhou wrote: > Release the memory of reply message of the initial "monitor" request. > > Reported-at: http://openvswitch.org/pipermail/dev/2016-July/076075.html > Signed-off-by: Andy Zhou > --- > ovsd

Re: [ovs-dev] [PATCH 1/3] ovsdb: Properly close replication rpc connection

2016-07-26 Thread William Tu
Hi Andy, Thanks for fixing the memory leak! I've tested it and it solved the issue. btw, I think we don't have to assign "NULL" to static variable, C99 standard assume all static variable initializes to 0. Acked-by: William Tu On Tue, Jul 26, 2016 at 1:08 PM, Andy Zhou wrote: > This patch remo

Re: [ovs-dev] [PATCH] netdev-provider: fix comments for netdev_rxq_recv

2016-07-26 Thread William Tu
Sorry, this should be Acked-by: William Tu On Tue, Jul 26, 2016 at 8:32 AM, William Tu wrote: > Hi Mark, > > Thanks for fixing them! looks good to me. > > Signed-off-by: William Tu > > > > On Tue, Jul 26, 2016 at 6:19 AM, Mark Kavanagh > wrote: >> Commit 64839cf43 applies batch objects to net

Re: [ovs-dev] [PATCH] ovn-controller: squelch expected duplicate flow warnings

2016-07-26 Thread Ryan Moats
Guru Shetty wrote on 07/26/2016 06:05:47 PM: > From: Guru Shetty > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev > Date: 07/26/2016 06:06 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: squelch expected > duplicate flow warnings > > On 26 July 2016 at 15:54, Ryan Moats wrote: > > > > Guru

Re: [ovs-dev] [PATCH v4] dpif-netdev: XPS (Transmit Packet Steering) implementation.

2016-07-26 Thread Daniele Di Proietto
Thanks for the patch I think the caller of dp_netdev_execute_actions() should always pass a valid timestamp. We can pass it from aux->now to dp_execute_userspace_actions(), we can add it to fast_path_processing() so that it can be passed down to handle_packet_upcall(). In the other cases it's

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 4.6

2016-07-26 Thread Amitabha Biswas
Typo in the previous ack Acked-by: Amitabha Biswas mailto:abis...@us.ibm.com>> > On Jul 26, 2016, at 4:22 PM, Amitabha Biswas wrote: > > I was able to compile the openvswitch modules on Linux 4.6 kernel and stacked > using OpenStack networking-ovn. > > The basic NAT system tests passed and th

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 4.6

2016-07-26 Thread Amitabha Biswas
I was able to compile the openvswitch modules on Linux 4.6 kernel and stacked using OpenStack networking-ovn. The basic NAT system tests passed and the OVN test suite passed. Asked-by: Amitabha Biswas mailto:abis...@us.ibm.com>> > On Jul 26, 2016, at 2:07 PM, Jesse Gross wrote: > > On Mon, Ju

Re: [ovs-dev] [PATCH v3 3/3] dpif-netdev: Introduce pmd-rxq-affinity.

2016-07-26 Thread Daniele Di Proietto
Looks mostly good to me, a couple more comments inline Thanks, Daniele On 26/07/2016 06:48, "Ilya Maximets" wrote: >On 26.07.2016 04:46, Daniele Di Proietto wrote: >> Thanks for the patch. >> >> I haven't been able to apply this without the XPS patch. > >That was the original idea. Using of

Re: [ovs-dev] [PATCH] ovn-controller: squelch expected duplicate flow warnings

2016-07-26 Thread Guru Shetty
On 26 July 2016 at 15:54, Ryan Moats wrote: > > > > Guru Shetty wrote on 07/26/2016 03:54:29 PM: > > > From: Guru Shetty > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: ovs dev > > Date: 07/26/2016 03:54 PM > > Subject: Re: [ovs-dev] [PATCH] ovn-controller: squelch expected > > duplicate flow warni

Re: [ovs-dev] [PATCH v2 1/3] datapath: compat: fix udp checksum calculation

2016-07-26 Thread Jesse Gross
On Tue, Jul 26, 2016 at 3:59 PM, pravin shelar wrote: > On Tue, Jul 26, 2016 at 3:53 PM, Jesse Gross wrote: >> On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote: >>> diff --git a/datapath/linux/compat/include/net/udp.h >>> b/datapath/linux/compat/include/net/udp.h >>> index fa49fa5..266e70

[ovs-dev] openvswitch

2016-07-26 Thread Henry Kai
This is a confirmation letter regarding registration of your company name openvswitch, please read it carefully. Dear sir or madam, We are a registrar for domain names authorized by Chinese government. Today, we received an application from Htg Corporation LTD applying to register openvswitch as

Re: [ovs-dev] [PATCH v2 1/3] datapath: compat: fix udp checksum calculation

2016-07-26 Thread pravin shelar
On Tue, Jul 26, 2016 at 3:53 PM, Jesse Gross wrote: > On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote: >> diff --git a/datapath/linux/compat/include/net/udp.h >> b/datapath/linux/compat/include/net/udp.h >> index fa49fa5..266e70a 100644 >> --- a/datapath/linux/compat/include/net/udp.h >>

Re: [ovs-dev] [PATCH v2 3/3] datapath: compat: simplify ip_local_out().

2016-07-26 Thread Jesse Gross
On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar > --- > datapath/linux/compat/gso.c | 82 > ++--- > 1 file changed, 33 insertions(+), 49 deletions(-) Acked-by: Jesse Gross

Re: [ovs-dev] [PATCH v2 2/3] datapath: compat: unset skb encapsulation bit

2016-07-26 Thread Jesse Gross
On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote: > OVS compat layer can handle tunnel GSO packets. but it does > keep skb encapsulation on for packet handled in GSO. This can > confuse some NIC drivers. I have seen this issue on intel devices: > i40e :42:00.0: TX driver issue dete

Re: [ovs-dev] [PATCH] ovn-controller: squelch expected duplicate flow warnings

2016-07-26 Thread Ryan Moats
Guru Shetty wrote on 07/26/2016 03:54:29 PM: > From: Guru Shetty > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev > Date: 07/26/2016 03:54 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: squelch expected > duplicate flow warnings > > On 24 July 2016 at 10:07, Ryan Moats wrote: > In the ph

Re: [ovs-dev] [PATCH v2 1/3] datapath: compat: fix udp checksum calculation

2016-07-26 Thread Jesse Gross
On Tue, Jul 26, 2016 at 3:24 PM, Pravin B Shelar wrote: > diff --git a/datapath/linux/compat/include/net/udp.h > b/datapath/linux/compat/include/net/udp.h > index fa49fa5..266e70a 100644 > --- a/datapath/linux/compat/include/net/udp.h > +++ b/datapath/linux/compat/include/net/udp.h > @@ -54,7 +54

[ovs-dev] [PATCH v2 2/3] datapath: compat: unset skb encapsulation bit

2016-07-26 Thread Pravin B Shelar
OVS compat layer can handle tunnel GSO packets. but it does keep skb encapsulation on for packet handled in GSO. This can confuse some NIC drivers. I have seen this issue on intel devices: >>> i40e :42:00.0: TX driver issue detected, PF reset issued Following patch resets this bit in case co

[ovs-dev] [PATCH v2 0/3] datapath: tunneling fixes.

2016-07-26 Thread Pravin B Shelar
First two patches fixes to issues related to geneva and vxlan tunnel. Third patch is just code improvement. Pravin B Shelar (3): datapath: compat: fix udp checksum calculation datapath: compat: unset skb encapsulation bit datapath: compat: simplify ip_local_out(). acinclude.m4

[ovs-dev] [PATCH v2 1/3] datapath: compat: fix udp checksum calculation

2016-07-26 Thread Pravin B Shelar
In upstream linux kernel networking stack udp_set_csum() is called with only udp header applied but in case of compat layer it can be called with IP header. So following patch take the offset into account. Signed-off-by: Pravin B Shelar --- acinclude.m4| 1 - datapath

[ovs-dev] [PATCH v2 3/3] datapath: compat: simplify ip_local_out().

2016-07-26 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- datapath/linux/compat/gso.c | 82 ++--- 1 file changed, 33 insertions(+), 49 deletions(-) diff --git a/datapath/linux/compat/gso.c b/datapath/linux/compat/gso.c index 3a73bcd..fbbbc89 100644 --- a/datapath/linux/compat/gs

[ovs-dev] [PATCH] ovs-numa: fixed cmask parse with 0x prefix

2016-07-26 Thread Wei Shen
Fixed a minor bug that would print out a confusing warning about core mask, "ovs_numa|WARN|Invalid cpu mask: x", when dpdl-lcore-mask has 0x prefix, e.g. 0x123, which is the convention used in INSTALL.DPDK.md. --- lib/ovs-numa.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/ovs-numa.

Re: [ovs-dev] releasing 2.6: branch Aug 1, release Sep 15

2016-07-26 Thread Jesse Gross
On Sun, Jul 24, 2016 at 10:53 AM, Ben Pfaff wrote: > On Sun, Jul 24, 2016 at 08:39:31AM -0300, Thadeu Lima de Souza Cascardo wrote: >> On Sat, Jul 23, 2016 at 08:59:35AM -0700, Ben Pfaff wrote: >> > The proposed Open vSwitch release schedule calls for branching 2.6 from >> > master on Aug. 1, foll

Re: [ovs-dev] [PATCH] ovn: Rename "gateway" to "l3gateway".

2016-07-26 Thread Kyle Mestery
On Tue, Jul 26, 2016 at 3:49 PM, Russell Bryant wrote: > When L3 gateway support was added, it introduced a port type called > "gateway" and a corresponding option called "gateway-chassis". Since > that time, we also have an L2 gateway port type called "l2gateway" and a > corresponding option cal

Re: [ovs-dev] [PATCH] [PATCH v1] ovn-northd: Fix {}-enclosed constants for ND responder

2016-07-26 Thread Russell Bryant
On Tue, Jul 26, 2016 at 2:02 AM, Zong Kai LI wrote: > It missed comma as constant seperator in match string for ND responder. > > Signed-off-by: Zong Kai LI Thanks! I applied this to master. -- Russell Bryant ___ dev mailing list dev@openvswitch.o

Re: [ovs-dev] [PATCH 2/2] rhel: Allow openvswitch to get parent information

2016-07-26 Thread Flavio Leitner
On Tue, Jul 26, 2016 at 12:57:07PM -0700, Joe Stringer wrote: > On 25 July 2016 at 18:16, Flavio Leitner wrote: > > Updates SELinux to allow ovs-vsctl to get parent process > > information and log that to the database: > > > > record 241: 2016-07-26 00:59:47.418 "ovs-vsctl (invoked by /bin/bash >

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 4.6

2016-07-26 Thread Jesse Gross
On Mon, Jul 25, 2016 at 6:40 PM, Pravin B Shelar wrote: > Most of patch iron out USE_UPSTREAM_TUNNEL case where datapath > directly use upstream tunneling modules. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openv

Re: [ovs-dev] [PATCH] ovn-controller: squelch expected duplicate flow warnings

2016-07-26 Thread Guru Shetty
On 24 July 2016 at 10:07, Ryan Moats wrote: > In the physical processing of ovn-controller, there are two > sets of OF flows that are still fully recalculated every cycle: > > Flows that aren't associated with any logical flow, and > Flows calculated based on multicast groups > > Because thes

Re: [ovs-dev] [PATCH v1 3/3] ovn-northd: Add logical flows to support DHCPv6

2016-07-26 Thread Ben Pfaff
On Wed, Jul 27, 2016 at 12:55:24AM +0530, Numan Siddique wrote: > OVN implements native DHCPv6. DHCPv6 options are stored > in the 'DHCP_Options' NB table and logical ports refer to this > table to configure the DHCPv6 options. > > For each logical port configured with DHCPv6 Options following flo

[ovs-dev] [PATCH] ovn: Rename "gateway" to "l3gateway".

2016-07-26 Thread Russell Bryant
When L3 gateway support was added, it introduced a port type called "gateway" and a corresponding option called "gateway-chassis". Since that time, we also have an L2 gateway port type called "l2gateway" and a corresponding option called "l2gateway-chassis". This patch renames the L3 gateway port

Re: [ovs-dev] [PATCH] selinux: Allow ovs-ctl force-reload-kmod.

2016-07-26 Thread Flavio Leitner
On Tue, Jul 26, 2016 at 01:31:00PM -0700, Joe Stringer wrote: > On 26 July 2016 at 13:00, Flavio Leitner wrote: > > On Tue, Jul 26, 2016 at 12:41:01PM -0700, Joe Stringer wrote: > >> On 25 July 2016 at 16:57, Flavio Leitner wrote: > >> > On Fri, Jul 22, 2016 at 02:10:51PM -0700, Joe Stringer wrot

Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb

2016-07-26 Thread Hui Kang
Russell Bryant wrote on 07/26/2016 03:50:44 PM: > From: Russell Bryant > To: Hui Kang/Watson/IBM@IBMUS > Cc: Ben Pfaff , Hui Kang , ovs > dev > Date: 07/26/2016 03:51 PM > Subject: Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb > > On Tue, Jul 26, 2016 at 3:44 PM, Hui Kan

Re: [ovs-dev] [PATCH v1 2/3] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-26 Thread Ben Pfaff
On Wed, Jul 27, 2016 at 12:55:00AM +0530, Numan Siddique wrote: > This patch adds a new OVN action 'put_dhcpv6_opts' to support native > DHCPv6 in OVN. > > ovn-controller parses this action and adds a NXT_PACKET_IN2 > OF flow with 'pause' flag set and the DHCPv6 options stored in > 'userdata' fiel

Re: [ovs-dev] [PATCH v1 1/3] ovn-northd: Add logical flows to support native DHCPv4

2016-07-26 Thread Ben Pfaff
I added them myself, thanks for the reminder. On Wed, Jul 27, 2016 at 01:12:38AM +0530, Numan Siddique wrote: > This patch has "Tested-by: Ramu Ramamurthy " > and "Acked-by: Ramu Ramamurthy " and every time > I forget to add this when I resubmit the patch. > > Ramu - My apologies > > Thanks > Nu

Re: [ovs-dev] [PATCH v1 1/3] ovn-northd: Add logical flows to support native DHCPv4

2016-07-26 Thread Ben Pfaff
On Wed, Jul 27, 2016 at 12:54:39AM +0530, Numan Siddique wrote: > OVN implements a native DHCPv4 support which caters to the common > use case of providing an IP address to a booting instance by > providing stateless replies to DHCPv4 requests based on statically > configured address mappings. To d

Re: [ovs-dev] [PATCH] selinux: Allow ovs-ctl force-reload-kmod.

2016-07-26 Thread Joe Stringer
On 26 July 2016 at 13:00, Flavio Leitner wrote: > On Tue, Jul 26, 2016 at 12:41:01PM -0700, Joe Stringer wrote: >> On 25 July 2016 at 16:57, Flavio Leitner wrote: >> > On Fri, Jul 22, 2016 at 02:10:51PM -0700, Joe Stringer wrote: >> >> When invoking ovs-ctl force-reload-kmod via '/etc/init.d/open

[ovs-dev] [PATCH 3/3] test: Replication tests uses unix domain socket

2016-07-26 Thread Andy Zhou
Fix replication test titles to fit changes committed by 63b35ecc06cbd16bc0e93d1e26021d81c413a485. Signed-off-by: Andy Zhou --- tests/ovsdb-server.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at index e70498d..6c10164 100644 ---

[ovs-dev] [PATCH 2/3] ovsdb: Fix memory leak in replication logic

2016-07-26 Thread Andy Zhou
Release the memory of reply message of the initial "monitor" request. Reported-at: http://openvswitch.org/pipermail/dev/2016-July/076075.html Signed-off-by: Andy Zhou --- ovsdb/replication.c | 4 1 file changed, 4 insertions(+) diff --git a/ovsdb/replication.c b/ovsdb/replication.c index 3

[ovs-dev] [PATCH 1/3] ovsdb: Properly close replication rpc connection

2016-07-26 Thread Andy Zhou
This patch removes rpc related memory leak reported below. Reported-at: http://openvswitch.org/pipermail/dev/2016-July/076075.html Signed-off-by: Andy Zhou --- ovsdb/ovsdb-server.c | 1 + ovsdb/replication.c | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ovsdb/ovsdb-s

Re: [ovs-dev] [PATCH] selinux: Allow ovs-ctl force-reload-kmod.

2016-07-26 Thread Flavio Leitner
On Tue, Jul 26, 2016 at 12:41:01PM -0700, Joe Stringer wrote: > On 25 July 2016 at 16:57, Flavio Leitner wrote: > > On Fri, Jul 22, 2016 at 02:10:51PM -0700, Joe Stringer wrote: > >> When invoking ovs-ctl force-reload-kmod via '/etc/init.d/openvswitch > >> force-reload-kmod', spurious errors would

Re: [ovs-dev] [PATCH] ovn-controller: squelch expected duplicate flow warnings

2016-07-26 Thread Guru Shetty
On 24 July 2016 at 10:07, Ryan Moats wrote: > In the physical processing of ovn-controller, there are two > sets of OF flows that are still fully recalculated every cycle: > > Flows that aren't associated with any logical flow, and > Flows calculated based on multicast groups > > Because thes

[ovs-dev] [PATCH v4] Windows: Local named pipe implementation

2016-07-26 Thread Alin Serdean
Currently in the case of command line arguments punix/unix, on Windows we create a file, write a TCP port number to connect. This is a security concern. This patch adds support for the command line arguments punix/unix trying to mimic AF_UNIX behind a local named pipe. This patch drops the TCP so

Re: [ovs-dev] [PATCH 2/2] rhel: Allow openvswitch to get parent information

2016-07-26 Thread Joe Stringer
On 25 July 2016 at 18:16, Flavio Leitner wrote: > Updates SELinux to allow ovs-vsctl to get parent process > information and log that to the database: > > record 241: 2016-07-26 00:59:47.418 "ovs-vsctl (invoked by /bin/bash > (pid 1589)): ovs-vsctl -t 10 -- --if-exist ... > > Jul 25 12:57:35 local

Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb

2016-07-26 Thread Russell Bryant
On Tue, Jul 26, 2016 at 3:44 PM, Hui Kang wrote: > > > "dev" wrote on 07/26/2016 02:20:27 PM: > > > From: Ben Pfaff > > To: Hui Kang > > Cc: dev@openvswitch.org > > Date: 07/26/2016 02:20 PM > > Subject: Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the > ovnsb > > Sent by: "dev"

Re: [ovs-dev] [PATCH 2/3] datapath: compat: unset skb encapsulation bit

2016-07-26 Thread Jesse Gross
On Tue, Jul 26, 2016 at 12:30 PM, pravin shelar wrote: > On Tue, Jul 26, 2016 at 11:14 AM, Jesse Gross wrote: >> On Tue, Jul 26, 2016 at 10:56 AM, pravin shelar wrote: >>> On Tue, Jul 26, 2016 at 10:06 AM, Jesse Gross wrote: On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar wrote: > OV

Re: [ovs-dev] ovsdb active backup deployment

2016-07-26 Thread Andy Zhou
On Tue, Jul 26, 2016 at 11:59 AM, Russell Bryant wrote: > > > On Tue, Jul 26, 2016 at 2:41 PM, Andy Zhou wrote: > >> >> >> On Tue, Jul 26, 2016 at 5:37 AM, Russell Bryant wrote: >> >>> >>> >>> On Mon, Jul 25, 2016 at 8:15 PM, Andy Zhou wrote: >>> Hi, Rayn and Russell, >>> >>> Can we

Re: [ovs-dev] [PATCH v3] ovn: Make it possible for CMS to detect when the OVN system is up-to-date.

2016-07-26 Thread Russell Bryant
On Sun, Jul 24, 2016 at 4:14 PM, Ben Pfaff wrote: > Until now, there has been no reliable for the CMS (or ovn-nbctl, or > anything else) to detect when changes made to the northbound configuration > have been passed through to the southbound database or to the hypervisors. > This commit adds this

Re: [ovs-dev] [ovs-dev, v2, 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-07-26 Thread Ben Pfaff
On Wed, Jul 27, 2016 at 01:00:44AM +0530, Numan Siddique wrote: > On Wed, Jul 27, 2016 at 12:08 AM, Ben Pfaff wrote: > > > On Wed, Jul 27, 2016 at 12:01:06AM +0530, Numan Siddique wrote: > > > OVN implements native DHCPv6. DHCPv6 options are stored > > > in the 'DHCP_Options' NB table and logical

Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb

2016-07-26 Thread Hui Kang
"dev" wrote on 07/26/2016 02:20:27 PM: > From: Ben Pfaff > To: Hui Kang > Cc: dev@openvswitch.org > Date: 07/26/2016 02:20 PM > Subject: Re: [ovs-dev] [PATCH v3] Scanning only changed entries in the ovnsb > Sent by: "dev" > > On Sat, Jul 16, 2016 at 11:58:25PM -0400, Hui Kang wrote: > > Impr

Re: [ovs-dev] [PATCH v1 1/3] ovn-northd: Add logical flows to support native DHCPv4

2016-07-26 Thread Numan Siddique
This patch has "Tested-by: Ramu Ramamurthy " and "Acked-by: Ramu Ramamurthy " and every time I forget to add this when I resubmit the patch. Ramu - My apologies Thanks Numan On Wed, Jul 27, 2016 at 12:54 AM, Numan Siddique wrote: > OVN implements a native DHCPv4 support which caters to the co

Re: [ovs-dev] [PATCH] rhel/openvswitch.spec: Add SELinux policy.

2016-07-26 Thread Joe Stringer
On 25 July 2016 at 17:34, Flavio Leitner wrote: > On Mon, Jul 25, 2016 at 02:09:26PM -0700, Joe Stringer wrote: >> Commit 9b897c9125ef ("rhel: provide our own SELinux custom policy >> package") added the SELinux policy to the fedora packaging as a >> subpackage. This patch makes the corresponding

Re: [ovs-dev] [PATCH] selinux: Allow ovs-ctl force-reload-kmod.

2016-07-26 Thread Joe Stringer
On 25 July 2016 at 16:57, Flavio Leitner wrote: > On Fri, Jul 22, 2016 at 02:10:51PM -0700, Joe Stringer wrote: >> When invoking ovs-ctl force-reload-kmod via '/etc/init.d/openvswitch >> force-reload-kmod', spurious errors would output related to 'hostname' >> and 'ip', and the system's selinux au

Re: [ovs-dev] [networking-ovn] Re: Issue when using ovn with Openstack

2016-07-26 Thread Richard Theis
"dev" wrote on 07/20/2016 12:42:20 AM: > From: Chen Li > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org, "OpenStack Development Mailing List \(not > for usage questions\)" > Date: 07/20/2016 12:42 AM > Subject: Re: [ovs-dev] [networking-ovn] Re: Issue when using ovn > with Openstack

[ovs-dev] [PATCH] debian: Add six dependency to python-openvswitch.

2016-07-26 Thread Joe Stringer
python-openvswitch uses the python "six" library, add a dependency for this to the debian package. VMware-BZ: #1700259 Reported-by: Devang Doshi Signed-off-by: Joe Stringer --- debian/control | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/control b/debian/control ind

Re: [ovs-dev] [ovs-dev, v2, 2/2] ovn-northd: Add logical flows to support DHCPv6

2016-07-26 Thread Numan Siddique
On Wed, Jul 27, 2016 at 12:08 AM, Ben Pfaff wrote: > On Wed, Jul 27, 2016 at 12:01:06AM +0530, Numan Siddique wrote: > > OVN implements native DHCPv6. DHCPv6 options are stored > > in the 'DHCP_Options' NB table and logical ports refer to this > > table to configure the DHCPv6 options. > > > > Fo

Re: [ovs-dev] [PATCH 2/3] datapath: compat: unset skb encapsulation bit

2016-07-26 Thread pravin shelar
On Tue, Jul 26, 2016 at 11:14 AM, Jesse Gross wrote: > On Tue, Jul 26, 2016 at 10:56 AM, pravin shelar wrote: >> On Tue, Jul 26, 2016 at 10:06 AM, Jesse Gross wrote: >>> On Mon, Jul 25, 2016 at 5:49 PM, Pravin B Shelar wrote: OVS compat layer can handle tunnel GSO packets. but it does

[ovs-dev] [PATCH v1 3/3] ovn-northd: Add logical flows to support DHCPv6

2016-07-26 Thread Numan Siddique
OVN implements native DHCPv6. DHCPv6 options are stored in the 'DHCP_Options' NB table and logical ports refer to this table to configure the DHCPv6 options. For each logical port configured with DHCPv6 Options following flows are added - A logical flow which copies the DHCPv6 options to the DHCP

[ovs-dev] [PATCH v1 2/3] ovn-controller: Add 'put_dhcpv6_opts' action in ovn-controller

2016-07-26 Thread Numan Siddique
This patch adds a new OVN action 'put_dhcpv6_opts' to support native DHCPv6 in OVN. ovn-controller parses this action and adds a NXT_PACKET_IN2 OF flow with 'pause' flag set and the DHCPv6 options stored in 'userdata' field. When the valid DHCPv6 packet is received by ovn-controller, it frames a

[ovs-dev] [PATCH v1 1/3] ovn-northd: Add logical flows to support native DHCPv4

2016-07-26 Thread Numan Siddique
OVN implements a native DHCPv4 support which caters to the common use case of providing an IP address to a booting instance by providing stateless replies to DHCPv4 requests based on statically configured address mappings. To do this it allows a short list of DHCPv4 options to be configured and app

[ovs-dev] [PATCH v1 0/3] ovn: Support native DHCPv4 and DHCPv6 proposal

2016-07-26 Thread Numan Siddique
This patch series support native DHCPv4 and native DHCPv6 in OVN. Patch 1 adds DHCPv4 logical flows in ovn northd. It uses the OVN action "put_dhcp_opts". Patch 2 and 3 adds native DHCPv6 support. Numan Siddique (3): ovn-northd: Add logical flows to support native DHCPv4 ov

Re: [ovs-dev] [PATCH v2 3/3] rhel: Improved Systemd Integration

2016-07-26 Thread Flavio Leitner
On Mon, Jul 25, 2016 at 02:03:53PM -0400, Aaron Conole wrote: > This commit builds upon some of the recent ovs-ctl changes to build a > more integrated systemd setup. A new service (ovs-vswitchd) is > added to track the ovs-vswitchd, and ovsdb-server service is reserved > for the ovsdb-server daem

Re: [ovs-dev] ovsdb active backup deployment

2016-07-26 Thread Russell Bryant
On Tue, Jul 26, 2016 at 2:41 PM, Andy Zhou wrote: > > > On Tue, Jul 26, 2016 at 5:37 AM, Russell Bryant wrote: > >> >> >> On Mon, Jul 25, 2016 at 8:15 PM, Andy Zhou wrote: >> >>> Hi, Rayn and Russell, >>> >> >> Can we move this discussion to the ovs dev mailing list? Feel free to >> just add i

  1   2   3   >