[ovs-dev] Returned mail: see transcript for details

The original message was received at Thu, 9 Jun 2016 12:16:09 +0600 from 201.218.165.64 - The following addresses had permanent fatal errors - - Transcript of session follows - ... while talking to openvswitch.org.: >>> DATA <<< 400-aturner; -RMS-E-CRE, ACP file create failed <<

Re: [ovs-dev] [PATCH v10 0/2] ovn: Support native DHCP using 'continuations'

On Thu, Jun 9, 2016 at 11:09 AM, Ben Pfaff wrote: > I liked this series but I wanted to make some changes, so I sent out my > own proposal based on it, with patch 0/4 starting here: > http://openvswitch.org/pipermail/dev/2016-June/072517.html > > Will you look it over and see what you thi

Re: [ovs-dev] [PATCH v10 0/2] ovn: Support native DHCP using 'continuations'

I liked this series but I wanted to make some changes, so I sent out my own proposal based on it, with patch 0/4 starting here: http://openvswitch.org/pipermail/dev/2016-June/072517.html Will you look it over and see what you think? I might still have comments on the final patch; most not

[ovs-dev] [PATCH 1/4] expr: Shorten declarations of expr_context.

Seems to me that this makes the code slightly easier to follow. Signed-off-by: Ben Pfaff --- ovn/lib/expr.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/ovn/lib/expr.c b/ovn/lib/expr.c index f274ab4..7ff9538 100644 --- a/ovn/lib/expr.c +++ b/o

[ovs-dev] [PATCH 2/4] expr: Refactor parsing of assignments and exchanges.

As written, it was difficult for the OVN logical action code to add support for new actions of the form "dst = ...", because the code to parse the left side of the assignment was a monolithic part of the expr library. This commit refactors the code division so that an upcoming patch can support a

[ovs-dev] [PATCH 3/4] ovn-controller: Add 'put_dhcp_opts' action in ovn-controller

From: Numan Siddique This patch adds a new OVN action 'put_dhcp_opts' to support native DHCP in OVN. ovn-controller parses this action and adds a NXT_PACKET_IN2 OF flow with 'pause' flag set and the DHCP options stored in 'userdata' field. When the valid DHCP packet is received by ovn-controlle

[ovs-dev] [PATCH 4/4] ovn-northd: Add logical flows to support native DHCP

From: Numan Siddique OVN implements a native DHCP support which caters to the common use case of providing an IP address to a booting instance by providing stateless replies to DHCP requests based on statically configured address mappings. To do this it allows a short list of DHCP options to be c

[ovs-dev] [PATCH 0/4] OVN DHCP support proposal

Patches 1 and 2 are new. Patch 3 is based on https://patchwork.ozlabs.org/patch/631320/, with: - Minor style fixes. - Change syntax of put_dhcp_opts(), from: put_dhcp_opts(reg0, offerip=1.2.3.4, ...) to: reg0[0] = put_dhcp_opts(offerip=1.2.3.4, ...) That is, the result is n

Re: [ovs-dev] [PATCH] ovs-numa: Fix a compilation error

On Thu, Jun 9, 2016 at 3:31 AM, Ben Pfaff wrote: > On Wed, Jun 08, 2016 at 03:19:46PM +0900, YAMAMOTO Takashi wrote: > > Fix the following error on NetBSD 7.0. > > > > ../lib/ovs-numa.c: In function 'ovs_numa_set_cpu_mask': > > ../lib/ovs-numa.c:555:9: error: array subscript has type 'cha

Re: [ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum

Thanks for the review answer inlined. Thanks, Alin. > -Mesaj original- > De la: Nithin Raju [mailto:nit...@vmware.com] > Trimis: Wednesday, June 8, 2016 10:10 PM > Către: Alin Serdean ; > dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum > > > >+

Re: [ovs-dev] [PATCH] doc: Fix an error in FAQ.

"dev" wrote on 06/07/2016 12:56:50 AM: > From: Han Zhou > To: dev@openvswitch.org > Date: 06/07/2016 12:57 AM > Subject: [ovs-dev] [PATCH] doc: Fix an error in FAQ. > Sent by: "dev" > > Signed-off-by: Han Zhou > --- > FAQ.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [ovs-dev] [PATCH 8/8] automake: Add ovs-bugtool.in to flake8-check.

"dev" wrote on 06/06/2016 02:25:59 AM: > From: Gurucharan Shetty > To: dev@openvswitch.org > Date: 06/06/2016 12:23 PM > Subject: [ovs-dev] [PATCH 8/8] automake: Add ovs-bugtool.in to flake8-check. > Sent by: "dev" > > Signed-off-by: Gurucharan Shetty > --- > utilities/bugtool/automake.mk | 2

Re: [ovs-dev] [PATCH v6 1/2] doc: Refactor DPDK install documentation

On Tue, Jun 07, 2016 at 11:42:11PM +0200, Mauricio Vásquez wrote: > On Tue, Jun 7, 2016 at 10:52 PM, Bodireddy, Bhanuprakash < > bhanuprakash.bodire...@intel.com> wrote: > > > Thanks Mauricio for your comments, My comments inline. > > > > >+ it has to be configured with DPDK support and is done b

[ovs-dev] Bug#826780: Bug#826780: Please package OVS >= 2.6.0.dev1

On 8 June 2016 at 16:40, Ben Pfaff wrote: > On Thu, Jun 09, 2016 at 01:23:12AM +0200, Thomas Goirand wrote: >> Source: openvswitch >> Version: 2.3.0+git20140819-4 >> Severity: normal >> >> Hi, >> >> OpenStack Neutron currently has: >> >> ovs>=2.5.0;python_version=='2.7' # Apache-2.0 >> ovs>=2.6.0.

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

On Wed, Jun 8, 2016 at 3:20 PM, Hannes Frederic Sowa wrote: > On 08.06.2016 23:21, Alexander Duyck wrote: >> On Wed, Jun 8, 2016 at 12:46 PM, Hannes Frederic Sowa >> wrote: >>> On 08.06.2016 17:38, Alexander Duyck wrote: On Wed, Jun 8, 2016 at 7:48 AM, Hannes Frederic Sowa wrote: >>>

Re: [ovs-dev] [PATCH] ovn-controller: Fix memory leak reported byvalgrind.

"dev" wrote on 06/05/2016 09:37:35 AM: > From: William Tu > To: dev@openvswitch.org > Date: 06/05/2016 09:37 AM > Subject: [ovs-dev] [PATCH] ovn-controller: Fix memory leak reported > by valgrind. > Sent by: "dev" > > Calling ovsdb_idl_set_remote() might overwrite the 'idl->session'. The patch

Re: [ovs-dev] [PATCH] tests: Remove "test" from test names.

"dev" wrote on 06/08/2016 09:01:16 PM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 06/08/2016 09:01 PM > Subject: [ovs-dev] [PATCH] tests: Remove "test" from test names. > Sent by: "dev" > > Every test is a test, so each test doesn't need to attest to being a test. > >

[ovs-dev] [PATCH] tests: Remove "test" from test names.

Every test is a test, so each test doesn't need to attest to being a test. Signed-off-by: Ben Pfaff --- tests/auto-attach.at | 2 +- tests/library.at | 44 ++-- tests/ovn-controller-vtep.at | 12 ++-- tests/ovn-sbctl.at

Re: [ovs-dev] [PATCH] ovn-northd: fix logical router icmp response for directed broadcasts

On Wed, Jun 8, 2016 at 5:51 PM, Flavio Fernandes wrote: > Responding to icmp queries where the L3 destination is a directed broadcast > was not being properly handled, causing the reply to be sent to all logical > ports except for the one port that should receive it. > > Reference to the mailing

Re: [ovs-dev] [PATCH v3 5/5] ovn: DNAT and SNAT on a gateway router.

Guru, >The names "inside_ip" and "outside_ip" keeps tripping me up. The >nomenclature feels similar to tunnel outside_ip and tunnel inside_ip. What do >you think about "logical_ip" and "physical_ip" instead? A quick search revealed that "inside" and "outside" are not always used the way tha

[ovs-dev] [PATCH v18 9/9] Add incremental processing to lflow_run and physical_run

From: "RYAN D. MOATS" This code changes to allow incremental processing of the logical flow and physical binding tables whenver possible. Note: flows created by physical_run for multicast_groups are *NOT* handled incrementally due to to be solved issues with GWs and local routers. Signed-off-by

[ovs-dev] [PATCH v18 7/9] Refactor multicast group processing in physical.c

From: "RYAN D. MOATS" Extract block from SBREC_MULTICAST_GROUP_FOR_EACH block in physical_run to helper method so that it can be reused when doing incremental processing. Signed-off-by: RYAN D. MOATS --- ovn/controller/physical.c | 233 -- 1 file cha

[ovs-dev] [PATCH v18 6/9] Refactor port binding processing in physical.c

From: "RYAN D. MOATS" Extract block from SBREC_PORT_BINDING_FOR_EACH block in physical_run to helper method so that it can be reused when doing incremental processing. Side effects: - localvif_to_oport and tunnels are now static file scoped Signed-off-by: RYAN D. MOATS --- ovn/controller/ph

[ovs-dev] [PATCH v18 5/9] Refactor lflow.c

From: "RYAN D. MOATS" Refactor code block inside of SBREC_LOGICAL_FLOW_FOR_EACH loop in add_logical_flow so that this can be reused when incremental processing is added. Signed-off-by: RYAN D. MOATS --- ovn/controller/lflow.c | 315 ++--- 1 file chan

[ovs-dev] [PATCH v18 4/9] Persist ovn flow tables.

From: "RYAN D. MOATS" Ensure that ovn flow tables are persisted so that changes to them chan be applied incrementally - this is a prereq for making lflow_run and physical_run incremental. Signed-off-by: Ryan Moats --- ovn/controller/lflow.c | 26 ++-- ovn/controller/lflow.h

[ovs-dev] [PATCH v18 3/9] Persist lport_index and mcgroup_index structures

From: "RYAN D. MOATS" This is preparatory to making physical_run and lflow_run process incrementally as changes to the data in these structures control that processing. Signed-off-by: RYAN D. MOATS --- ovn/controller/lport.c | 220 +--- ovn/controll

[ovs-dev] You're Only Going to See This ONCE

This email is only going out to a select few people. Actually, you're one out of only a handful of people who will get to see this system. People like Warren Buffet have been using similar trading systems for years. People such as Warren make money while they sleep... And so can YOU. If you are

Re: [ovs-dev] [PATCH] bridge: allow OVS to connect to Unix Domain Sockets outside its run directory

On 8 June 2016 at 16:45, Ansis Atteka wrote: > > > On 8 June 2016 at 14:02, Ben Pfaff wrote: > >> On Thu, Jun 02, 2016 at 07:47:33PM -0700, Ansis Atteka wrote: >> > Before this patch OVS refused to connect to a local controller that >> > had its Unix Domain Socket outside Open vSwitch run direct

Re: [ovs-dev] [PATCH v10 2/2] ovn-northd: Add logical flows to support native DHCP

Sorry for the typo Ramu On Jun 9, 2016 5:40 AM, "Numan Siddique" wrote: > Thanks Dani for testing the patches. > Regards > Numan > On Jun 9, 2016 12:25 AM, "Ramu Ramamurthy" > wrote: > >> I tested and verified this patchset using the corresponding WIP >> openstack dhcp patch. >> native-dhcp work

Re: [ovs-dev] [PATCH v10 2/2] ovn-northd: Add logical flows to support native DHCP

Thanks Dani for testing the patches. Regards Numan On Jun 9, 2016 12:25 AM, "Ramu Ramamurthy" wrote: > I tested and verified this patchset using the corresponding WIP > openstack dhcp patch. > native-dhcp works end-to-end as advertized - I tested with the default > dhcp-options > that are used wh

Re: [ovs-dev] [PATCH] bridge: allow OVS to connect to Unix Domain Sockets outside its run directory

On 8 June 2016 at 14:02, Ben Pfaff wrote: > On Thu, Jun 02, 2016 at 07:47:33PM -0700, Ansis Atteka wrote: > > Before this patch OVS refused to connect to a local controller that > > had its Unix Domain Socket outside Open vSwitch run directory (e.g. > > outside '/var/run/openvswitch/'). > > > > A

[ovs-dev] Bug#826780: Please package OVS >= 2.6.0.dev1

On Thu, Jun 09, 2016 at 01:23:12AM +0200, Thomas Goirand wrote: > Source: openvswitch > Version: 2.3.0+git20140819-4 > Severity: normal > > Hi, > > OpenStack Neutron currently has: > > ovs>=2.5.0;python_version=='2.7' # Apache-2.0 > ovs>=2.6.0.dev1;python_version>='3.4' # Apache-2.0 > > in its

[ovs-dev] Bug#826780: Please package OVS >= 2.6.0.dev1

Source: openvswitch Version: 2.3.0+git20140819-4 Severity: normal Hi, OpenStack Neutron currently has: ovs>=2.5.0;python_version=='2.7' # Apache-2.0 ovs>=2.6.0.dev1;python_version>='3.4' # Apache-2.0 in its requirements.txt. Please package this at least to Debian Experimental, so that I can pac

Re: [ovs-dev] [PATCH v2 2/3] fedora: Add pcap, tcpdump and tcpundump utilities to test

On Wed, Jun 08, 2016 at 05:49:56PM -0400, Aaron Conole wrote: > The openvswitch-test package is setup for enabling / performing tests > for openvswitch setups. Adding these utilities would enable a richer > set of debugging utilities for performing diagnostics. > > Signed-off-by: Aaron Conole >

Re: [ovs-dev] [PATCH v2 1/3] ovs-tcpdump: Add a tcpdump wrapper utility

On Wed, Jun 08, 2016 at 05:49:55PM -0400, Aaron Conole wrote: > Currently, there is some documentation which describes setting up and > using port mirrors for bridges. This documentation is helpful to setup > a packet capture for specific ports. > > However, a utility to do such packet capture wou

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

On 08.06.2016 23:21, Alexander Duyck wrote: > On Wed, Jun 8, 2016 at 12:46 PM, Hannes Frederic Sowa > wrote: >> On 08.06.2016 17:38, Alexander Duyck wrote: >>> On Wed, Jun 8, 2016 at 7:48 AM, Hannes Frederic Sowa >>> wrote: On 08.06.2016 14:51, Jiri Benc wrote: > On Mon, 6 Jun 2016 14:

[ovs-dev] [PATCH] ovn-northd: fix logical router icmp response for directed broadcasts

Responding to icmp queries where the L3 destination is a directed broadcast was not being properly handled, causing the reply to be sent to all logical ports except for the one port that should receive it. Reference to the mailing list thread: http://openvswitch.org/pipermail/discuss/2016-June/021

[ovs-dev] [PATCH v2 1/3] ovs-tcpdump: Add a tcpdump wrapper utility

Currently, there is some documentation which describes setting up and using port mirrors for bridges. This documentation is helpful to setup a packet capture for specific ports. However, a utility to do such packet capture would be valuable, both as an exercise in documenting the steps an addition

[ovs-dev] [PATCH v2 2/3] fedora: Add pcap, tcpdump and tcpundump utilities to test

The openvswitch-test package is setup for enabling / performing tests for openvswitch setups. Adding these utilities would enable a richer set of debugging utilities for performing diagnostics. Signed-off-by: Aaron Conole --- v1->v2: * Introduced rhel/openvswitch-fedora.spec.in | 10 ++

[ovs-dev] [PATCH v2 3/3] debian: Add the tcpdump utility to the debian package

Add ovs-tcpdump to the debian build. Signed-off-by: Aaron Conole --- * Introduced debian/openvswitch-switch.install | 1 + debian/openvswitch-switch.manpages | 1 + 2 files changed, 2 insertions(+) diff --git a/debian/openvswitch-switch.install b/debian/openvswitch-switch.install index 1a545

[ovs-dev] [PATCH v2 0/3] ovs-tcpdump: A utility for convenient port mirroring

Open vSwitch ships with a mirroring facility. However, this facility can sometimes be cumbersome to setup. To make this easier for end users, this patch series introduces a utility `ovs-tcpdump` which wraps the various ovs database configurations to enable a mirror, and then invokes tcpdump or a

Re: [ovs-dev] [PATCH] [PATCH v3 2/2] ovn: add lflows for 'na' action for ND

On Wed, Jun 08, 2016 at 03:28:58PM +0800, Zong Kai LI wrote: > This patch adds some lflows for 'na' action to support ND versus ARP. > > For ovn-northd, it will generate lflows per each IPv6 address on > echo lport, with lport mac and IPv6 addresss, with 'na' action. > e.g. match=(ip6 && nd && icm

[ovs-dev] [patch_v2] ovn: Fix receive from vxlan in ovn-controller.

OVN only supports source_node replication and previously vtep interaction, which used service node replication by default for multicast/broadcast/unknown unicast traffic worked by happenstance. Because of limited vxlan encapsulation metadata, received packets were resubmitted to find the egress po

[ovs-dev] [patch_v2] ovn: Fix receive from vxlan in ovn-controller.

OVN only supports source_node replication and previously vtep interaction, which used service node replication by default for multicast/broadcast/unknown unicast traffic worked by happenstance. Because of limited vxlan encapsulation metadata, received packets were resubmitted to find the egress po

Re: [ovs-dev] [PATCH] [PATCH v3 1/2] ovn-controller: Add 'na' action for ND

On Wed, Jun 08, 2016 at 03:26:30PM +0800, Zong Kai LI wrote: > This patch adds a new OVN action 'na' to support ND versus ARP. > > When ovn-controller received a ND packet, it frames a NA packet for > reply, with mac address parsed from userdata as eth.dst. Then it > reloads metadata info from pre

Re: [ovs-dev] [PATCHv6 1/3] ofp-actions: Add truncate action.

On Tue, Jun 7, 2016 at 10:53 PM, William Tu wrote: > The patch adds a new action to support packet truncation. The new action > is formatted as 'output(port=n,max_len=m)', as output to port n, with > packet size being MIN(original_size, m). > > One use case is to enable port mirroring to send sma

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

On Wed, Jun 8, 2016 at 12:46 PM, Hannes Frederic Sowa wrote: > On 08.06.2016 17:38, Alexander Duyck wrote: >> On Wed, Jun 8, 2016 at 7:48 AM, Hannes Frederic Sowa >> wrote: >>> On 08.06.2016 14:51, Jiri Benc wrote: On Mon, 6 Jun 2016 14:22:58 -0700, Jesse Gross wrote: > On Sat, Jun 4, 2

Re: [ovs-dev] [PATCH] bridge: allow OVS to connect to Unix Domain Sockets outside its run directory

On Thu, Jun 02, 2016 at 07:47:33PM -0700, Ansis Atteka wrote: > Before this patch OVS refused to connect to a local controller that > had its Unix Domain Socket outside Open vSwitch run directory (e.g. > outside '/var/run/openvswitch/'). > > After this patch this restriction imposed by Open vSwitc

Re: [ovs-dev] [PATCH] sparse: Fix conflict between netinet/in.h and linux/in.h

On 08/06/2016 13:30, "Ben Pfaff" wrote: >On Wed, Jun 08, 2016 at 01:07:32PM -0700, Ben Pfaff wrote: >> On Wed, Jun 01, 2016 at 07:23:29PM -0700, Daniele Di Proietto wrote: >> > linux/in.h (from linux uapi headers) carries many of the same >> > definitions as netinet/in.h (from glibc). >> >

Re: [ovs-dev] [PATCH v3] lib: Use a more accurate value for CPU count (sched_getaffinity).

On Thu, Jun 02, 2016 at 04:34:35PM +0200, Quentin Monnet wrote: > From: David Marchand > > Relying on /proc/cpuinfo to count the number of available cores is not > the best option: > > - The code is x86-specific. > - If the process is started with a different CPU affinity, then it will > wrong

Re: [ovs-dev] [PATCH v2] ovsdb: Expose vhost-user socket directory in ovsdb

On Thu, Jun 02, 2016 at 11:25:56AM +0100, Robert Wojciechowicz wrote: > In order to correctly interoperate with Openstack and ODL, > the vhost-user socket directory must be exposed from OVS via OVSDB. > Different distros may package OVS in different ways, > so the locations of these sockets may var

Re: [ovs-dev] [PATCH] sparse: Fix conflict between netinet/in.h and linux/in.h

On Wed, Jun 08, 2016 at 01:07:32PM -0700, Ben Pfaff wrote: > On Wed, Jun 01, 2016 at 07:23:29PM -0700, Daniele Di Proietto wrote: > > linux/in.h (from linux uapi headers) carries many of the same > > definitions as netinet/in.h (from glibc). > > > > If linux/in.h is included after netinet/in.h, co

Re: [ovs-dev] [PATCH] ovs-tcpdump: Add a tcpdump wrapper utility

On Wed, Jun 08, 2016 at 04:54:31PM -0300, Flavio Leitner wrote: > On Tue, Jun 07, 2016 at 08:41:13AM -0700, Ben Pfaff wrote: > > On Wed, Jun 01, 2016 at 01:30:40PM -0400, Aaron Conole wrote: > > > Currently, there is some documentation which describes setting up and > > > using port mirrors for bri

Re: [ovs-dev] [PATCH v10 5/5] userspace: add non-tap (l3) support to GRE vports

On Wed, Jun 01, 2016 at 02:04:57PM +0900, Simon Horman wrote: > On Tue, May 31, 2016 at 08:20:24PM -0700, Ben Pfaff wrote: > > There's a change to tnl_port_show() to "Skip ports with duplicate 'port' > > field". I don't understand this change. Can you explain it? (It's > > O(n**2) in the number

Re: [ovs-dev] [PATCH] sparse: Fix conflict between netinet/in.h and linux/in.h

On Wed, Jun 01, 2016 at 07:23:29PM -0700, Daniele Di Proietto wrote: > linux/in.h (from linux uapi headers) carries many of the same > definitions as netinet/in.h (from glibc). > > If linux/in.h is included after netinet/in.h, conflicts are avoided in > two ways: > > 1) linux/libc-compat.h (inclu

Re: [ovs-dev] [PATCH] ovs-tcpdump: Add a tcpdump wrapper utility

On Tue, Jun 07, 2016 at 08:41:13AM -0700, Ben Pfaff wrote: > On Wed, Jun 01, 2016 at 01:30:40PM -0400, Aaron Conole wrote: > > Currently, there is some documentation which describes setting up and > > using port mirrors for bridges. This documentation is helpful to setup > > a packet capture for sp

[ovs-dev] [PATCH] ovn-northd: no logical router icmp response for directed broadcasts

Responding to icmp queries where the L3 destination is a directed broadcast was not being properly handled, causing the reply to be sent to all logical ports except for the one port that should receive it. Reference to the mailing list thread: http://openvswitch.org/pipermail/discuss/2016-June/021

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

On 08.06.2016 17:38, Alexander Duyck wrote: > On Wed, Jun 8, 2016 at 7:48 AM, Hannes Frederic Sowa > wrote: >> On 08.06.2016 14:51, Jiri Benc wrote: >>> On Mon, 6 Jun 2016 14:22:58 -0700, Jesse Gross wrote: On Sat, Jun 4, 2016 at 6:39 AM, Yi Yang wrote: [...] > datapath/vport-netd

Re: [ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum

> #endif >@@ -299,34 +312,21 @@ OvsDecapGre(POVS_SWITCH_CONTEXT switchContext, > EthHdr *ethHdr; > IPHdr *ipHdr; > GREHdr *greHdr; >-UINT32 tunnelSize = 0, packetLength = 0; >+UINT32 tunnelSize, packetLength; > UINT32 headRoom = 0; > PUINT8 bufferStart; > NDIS_STATU

Re: [ovs-dev] [PATCH v10 2/2] ovn-northd: Add logical flows to support native DHCP

I tested and verified this patchset using the corresponding WIP openstack dhcp patch. native-dhcp works end-to-end as advertized - I tested with the default dhcp-options that are used when VMs boot. On Mon, Jun 6, 2016 at 10:49 PM, Numan Siddique wrote: > OVN implements a native DHCP support whic

Re: [ovs-dev] [PATCH 3/3] JSON serialization via Python's json lib

On Wed, Jun 08, 2016 at 08:55:15AM -0500, Terry Wilson wrote: > There is no particularly good reason to use our own Python JSON > serialization implementation when serialization can be done faster > with Python's built-in JSON library. > > A few tests were changed due to Python's default JSON libr

Re: [ovs-dev] [PATCH 2/3] Add optional C extension wrapper for Python JSON parsing

On Wed, Jun 08, 2016 at 08:55:14AM -0500, Terry Wilson wrote: > The pure Python in-tree JSON parser is *much* slower than the > in-tree C JSON parser. A local test parsing a 100Mb JSON file > showed the Python version taking 270 seconds. With the C wrapper, > it took under 4 seconds. > > The C ext

[ovs-dev] [PATCH] Fix release date for 2.4.1.

Signed-off-by: Thadeu Lima de Souza Cascardo --- NEWS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 2eba9a1..8b1044e 100644 --- a/NEWS +++ b/NEWS @@ -2,7 +2,7 @@ v2.4.2 - xx xxx - -v2.4.1 - 20 Aug 2015 +v2.4.1 - 28 Mar 2016 --

Re: [ovs-dev] [PATCH 1/3] Ensure significand remains an integer in Python3 json parser

On Wed, Jun 08, 2016 at 08:55:13AM -0500, Terry Wilson wrote: > The / operation in Python 2 is "floor division" for int/long types > while in Python 3 is "true division". This means that the > significand can become a float with the existing code in Python 3. > This, in turn, can result in a parse

Re: [ovs-dev] [PATCH] ovs-numa: Fix a compilation error

On Wed, Jun 08, 2016 at 03:19:46PM +0900, YAMAMOTO Takashi wrote: > Fix the following error on NetBSD 7.0. > > ../lib/ovs-numa.c: In function 'ovs_numa_set_cpu_mask': > ../lib/ovs-numa.c:555:9: error: array subscript has type 'char' > [-Werror=char-subscripts] > > Signed-off-by: YAMAMOTO

Re: [ovs-dev] Question about SHA1 usage in OVSDB Server

On Wed, Jun 08, 2016 at 05:13:09PM +, Rodriguez Betancourt, Esteban wrote: > I was performing some profiling on OVSDB, when inserting a lot of > rows. The callgrind results shows that the SHA1 calculation takes near > 10% of the time within our test (the whole file writing, including > SHA1, ta

[ovs-dev] [PATCH v2 4/5] dpif-netlink: add GRE creation support

Creates GRE devices using rtnetlink and tunnel metadata. If the kernel does not support tunnel metadata, it will return EEXIST because of the fallback tunnel. However, on kernels between v3.10 and v3.12, it will not. So, we need to verify the created tunnel has the tunnel metadata attribute. This

[ovs-dev] [PATCH v2 5/5] dpif-netlink: add GENEVE creation support

Creates GENEVE devices using rtnetlink and tunnel metadata. If the kernel does not support tunnel metadata, it will return EINVAL because of the missing ID and REMOTE attributes. This was tested on kernels 4.2.3, 4.3.6, 4.4.9 and 4.5.5. All of them worked with the system traffic test "datapath - p

[ovs-dev] [PATCH v2 3/5] dpif-netlink: add VXLAN creation support

Creates VXLAN devices using rtnetlink and tunnel metadata. If the kernel does not support tunnel metadata, it will return EINVAL because of the missing VNI attribute. This was tested on kernels 4.2.3, 4.3.6, 4.4.9, 4.5.5 and RHEL-based 3.10. All of them worked with the system traffic test "datapat

[ovs-dev] [PATCH v2 2/5] dpif-netlink: break out code to add compat and non-compat vports

The vport type for adding tunnels is now compatibility code and any new features from tunnels must configure the tunnel as an interface using the tunnel metadata support. In order to be able to add those tunnels, we need to add code to create the tunnels and add them as NETDEV vports. And when the

[ovs-dev] [PATCH v2 1/5] netdev: get device type from vport prefix if not found

If we cannot find the device type because it's not opened yet, check if it uses a reserved prefix for a vport type and return that type. Since these names are reserved, we can assume this is the right type. This is important when we are querying the datapath right after vswitch has started and us

[ovs-dev] [PATCH v2 0/5] create tunnel devices using rtnetlink interface

This series adds support for the creation of tunnels using the rtnetlink interface. This will open the possibility for new features and flags on those vports without the need to change vport compatibility code. Support for STT and LISP have not been added because these are not upstream yet, so we

Re: [ovs-dev] [PATCH] sparse: Fix conflict between netinet/in.h and linux/in.h

On 1 June 2016 at 19:23, Daniele Di Proietto wrote: > linux/in.h (from linux uapi headers) carries many of the same > definitions as netinet/in.h (from glibc). > > If linux/in.h is included after netinet/in.h, conflicts are avoided in > two ways: > > 1) linux/libc-compat.h (included by linux/in.h)

[ovs-dev] [PATCH 3/3] JSON serialization via Python's json lib

There is no particularly good reason to use our own Python JSON serialization implementation when serialization can be done faster with Python's built-in JSON library. A few tests were changed due to Python's default JSON library returning slightly more precise floating point numbers. Signed-off-

[ovs-dev] [PATCH 2/3] Add optional C extension wrapper for Python JSON parsing

The pure Python in-tree JSON parser is *much* slower than the in-tree C JSON parser. A local test parsing a 100Mb JSON file showed the Python version taking 270 seconds. With the C wrapper, it took under 4 seconds. The C extension will be used automatically if it can be built. If the extension fai

[ovs-dev] [PATCH 1/3] Ensure significand remains an integer in Python3 json parser

The / operation in Python 2 is "floor division" for int/long types while in Python 3 is "true division". This means that the significand can become a float with the existing code in Python 3. This, in turn, can result in a parse of something like [1.10e1] returning 11 in Python 2 and 11.0 in Python

[ovs-dev] [PATCH v4 0/3] Python JSON improvements

This patch set adds an optional C extension wrapper for the Python JSON parser. In local tests, it sped up parsing a 100Mb JSON file by over 70x. It also switches to using the built-in Python JSON serializer and fixes a small difference between Python 2 and 3 when parsing numbers. Hopefully, the b

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: prevent memory leak on log message

On Wed, Jun 08, 2016 at 09:58:51AM -0700, Joe Stringer wrote: > On 8 June 2016 at 09:04, Thadeu Lima de Souza Cascardo > wrote: > > When DPIF does not support UFID (like old kernels), it may print this > > message > > quite frequently, if using an OVS version that does not include the > > upstre

[ovs-dev] Get Back On Track With Our Breakthrough Solution

Are you tired of the excess weight and would like to get back on track without any painful efforts? Brand-new formula and advanced structure of our exclusive product will compliment your results and will help you to lose weight with no side-effects. Click Here! Stock is limited, make sure to

[ovs-dev] Question about SHA1 usage in OVSDB Server

Hello, I was performing some profiling on OVSDB, when inserting a lot of rows. The callgrind results shows that the SHA1 calculation takes near 10% of the time within our test (the whole file writing, including SHA1, takes like 20%). We want to know further about why that checksum is need, in or

Re: [ovs-dev] [PATCH] ovs-numa: Fix a compilation error

Acked-by: Daniele Di Proietto 2016-06-07 23:19 GMT-07:00 YAMAMOTO Takashi : > Fix the following error on NetBSD 7.0. > > ../lib/ovs-numa.c: In function 'ovs_numa_set_cpu_mask': > ../lib/ovs-numa.c:555:9: error: array subscript has type 'char' > [-Werror=char-subscripts] > > Signed-off-by

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: prevent memory leak on log message

On 8 June 2016 at 09:04, Thadeu Lima de Souza Cascardo wrote: > When DPIF does not support UFID (like old kernels), it may print this message > quite frequently, if using an OVS version that does not include the upstream > fix > af50de8 ("ofproto-dpif-upcall: Pass key to dpif_flow_get()."). > > S

Re: [ovs-dev] [PATCH] WIP OVN ND for Logical_Port

> On Jun 8, 2016, at 1:12 AM, Zong Kai LI wrote: > > I know Justin is working on implement router patch port for IPv6 switch, but > I'm not sure whether will Justin also work on implement ND or not. Yes, I'm planning to add support for neighbor discovery and router advertisements as part of I

Re: [ovs-dev] OpenStack Proposal: Integration with OVN L3 Gateway

On 8 June 2016 at 09:16, Amitabha Biswas wrote: > Hi Brian, > > The each gateway router only has a single transit network attached to it, > and each gateway router to connected to the common provider/external > network as well. We can probably do away with the transit network if we use > router p

Re: [ovs-dev] OpenStack Proposal: Integration with OVN L3 Gateway

Here is the proposal in etherpad, I hope it makes it more readable - https://etherpad.openstack.org/p/Integration_with_OVN_L3_Gateway Thanks Amitabha > On Jun 8, 2016, at 5:59 AM, Kyle Mestery wrote: > > On Tue, Jun 7, 2016 at

Re: [ovs-dev] OpenStack Proposal: Integration with OVN L3 Gateway

Hi Brian, The each gateway router only has a single transit network attached to it, and each gateway router to connected to the common provider/external network as well. We can probably do away with the transit network if we use router pairing (at a later point). I will change the transit netw

[ovs-dev] [PATCH] ofproto-dpif-upcall: prevent memory leak on log message

When DPIF does not support UFID (like old kernels), it may print this message quite frequently, if using an OVS version that does not include the upstream fix af50de8 ("ofproto-dpif-upcall: Pass key to dpif_flow_get()."). Signed-off-by: Thadeu Lima de Souza Cascardo Fixes: af50de8 ("ofproto-dpif-

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

On Wed, Jun 8, 2016 at 7:48 AM, Hannes Frederic Sowa wrote: > On 08.06.2016 14:51, Jiri Benc wrote: >> On Mon, 6 Jun 2016 14:22:58 -0700, Jesse Gross wrote: >>> On Sat, Jun 4, 2016 at 6:39 AM, Yi Yang wrote: >>> [...] datapath/vport-netdev.c | 3 +- datapath

Re: [ovs-dev] [PATCH] at test vlog: Switch from stderr to log

Acked-by: Paul-Daniel Boca Tested-by: Paul-Daniel Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Wednesday, June 8, 2016 5:02 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH] at test vlog: Switch from stderr to log >

Re: [ovs-dev] [PATCH] netdev-dpdk: NUMA Aware vHost User

> Thanks for the patch! > I'm not sure how to best handle the libnuma dependency. Question: > Is it still useful to move the device to a PMD thread on the appropriate > numa socket, even if DPDK is compiled without > CONFIG_RTE_LIBRTE_VHOST_NUMA? If it's useful, I'm fine with the > approach followe

Re: [ovs-dev] [PATCH] at tests: Allow Python tests to be run on Windows

Our usual practice would be to fix the test failures before enabling the tests; this could for example be the final patch in a series that fixes them. On Wed, Jun 08, 2016 at 03:31:06PM +, Alin Serdean wrote: > ERROR: 225 tests were run, > 59 failed (1 expected failure). > 226 tests were skipp

Re: [ovs-dev] [PATCH] at tests: Allow Python tests to be run on Windows

ERROR: 225 tests were run, 59 failed (1 expected failure). 226 tests were skipped. Result given by running only the python tests. Paul will add more patches on top of this one to fix the failures. I can send this patch later on, after all his patches get integrated on top of master. Alin. > -

Re: [ovs-dev] [PATCH] at tests: Allow Python tests to be run on Windows

On Wed, Jun 08, 2016 at 02:16:28PM +, Alin Serdean wrote: > This patch removes the code which disables Python tests to be run on > Windows. > > Signed-off-by: Alin Gabriel Serdean Do the Python tests pass on Windows now, then? ___ dev mailing list

Re: [ovs-dev] [PATCH] VxLAN-gpe implementation

On 08.06.2016 14:51, Jiri Benc wrote: > On Mon, 6 Jun 2016 14:22:58 -0700, Jesse Gross wrote: >> On Sat, Jun 4, 2016 at 6:39 AM, Yi Yang wrote: >> [...] >>> datapath/vport-netdev.c | 3 +- >>> datapath/vport-vxlan.c| 17 ++- >> >> These chan

Re: [ovs-dev] [PATCH v6 2/2] doc: Refactor DPDK install guide, add ADVANCED doc

Thanks Mauricio for your comments. Comments inline. >+### 3.7 Compiler Optimizations >+ >+  The default compiler optimization level is '-O2'. Changing this to >+  more aggressive compiler optimization such as '-O3 -march=native' >+  with gcc(verified on 5.3.1) can produce performance gains though

Re: [ovs-dev] OpenStack Proposal: Integration with OVN L3 Gateway

On 06/07/2016 04:50 PM, Amitabha Biswas wrote: This proposal outlines the modifications needed in networking-ovn (addresses https://bugs.launchpad.net/networking-ovn/+bug/1551717 ) to provide Floating IP (FIP) and SNAT using the L3 gatewa

[ovs-dev] [PATCH] at tests: Allow Python tests to be run on Windows

This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Alin Gabriel Serdean --- tests/atlocal.in | 7 --- 1 file changed, 7 deletions(-) diff --git a/tests/atlocal.in b/tests/atlocal.in index f174061..410199f 100644 --- a/tests/atlocal.in +++ b/tests/at

[ovs-dev] [PATCH] at test vlog: Switch from stderr to log

Using the --detach parameter the child does not propagate the first message to the parent. Proposed change use the log file instead of the stderr. Signed-off-by: Alin Gabriel Serdean --- tests/vlog.at | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/vlog.at b

[ovs-dev] [PATCH v3] datapath-windows: Add GRE checksum

This patch introduces GRE checksum computation if the userspace requires it on Tx. On Rx we verify the GRE checksum if the checksum bit was specified and also inform the userspace about it. Also fix the GRE header length as specified by the GRE flags not the tunnel flags. Signed-off-by: Alin Gabr

Re: [ovs-dev] [PATCH] [PATCH v3 1/2] ovn-controller: Add 'na' action for ND

On Wed, Jun 8, 2016 at 6:19 PM, Numan Siddique wrote: > >> --- a/ovn/ovn-sb.xml >> +++ b/ovn/ovn-sb.xml >> @@ -985,6 +985,55 @@ >>Prerequisite: ip4 >> >> >> + >> + na{A; action; ... >> }; >> + >> + >> + >> + >> +Temporar

  1   2   >