[ovs-dev] Crashing OVS+DPDK at the host, from inside of a KVM Guest

2016-05-14 Thread Martinx - ジェームズ
Guys, If using OVS 2.5 with DPDK 2.2, on Ubuntu Xenial, it is possible to crash the OVS running at the host, from inside of a KVM Guest. Basically, what I'm trying to do, is to run OVS+DPDK at the host, and also, inside of a KVM Guest, with multi-queue, but it doesn't work and crashes. Soon a

Re: [ovs-dev] [PATCH 1/1] Add other_config to Global table

2016-05-14 Thread Dennis Sam
On Sat, May 14, 2016 at 11:57 AM, Ben Pfaff wrote: > On Wed, May 11, 2016 at 11:51:29AM -0700, Dennis Sam wrote: > > Extend the Global table to allow for additional configurations by > re-using > > the idea of an other_config column. > > > > Signed-off-by: Dennis Sam > > Seems fine to me. > > >

Re: [ovs-dev] [PATCHv2] ovn-nbctl: Fix memory leak reported by Valgrind.

2016-05-14 Thread Ben Pfaff
On Sat, May 14, 2016 at 04:08:42PM -0700, William Tu wrote: > Definitely lost is reported by test 2026: ovn -- 3 HVs, 1 LS, 3 lports/HV. > ds_put_char__ (dynamic-string.c:82) > ds_put_char (dynamic-string.h:88) > process_escape_args (process.c:103) > main (ovn-nbctl.c:92) > Another leak sho

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix UFID usage with flow_modify.

2016-05-14 Thread Ben Pfaff
On Fri, May 13, 2016 at 02:17:12PM -0700, Joe Stringer wrote: > As per the delete_op_init{,__}() functions, the UFID should only be > passed down if ukey->ufid_present is set. Otherwise it is possible to > request a flow modification only using a UFID in a datapath that doesn't > support UFID, whic

Re: [ovs-dev] [PATCH] ovsdb-server: Fix memory leak reported by Valgind.

2016-05-14 Thread Ben Pfaff
On Fri, May 13, 2016 at 10:33:07AM -0700, William Tu wrote: > Reported by test 1657: ovsdb-server/add-db and remove-db. > ds_put_format (dynamic-string.c:142) > query_db_remotes (ovsdb-server.c:798) > reconfigure_remotes (ovsdb-server.c:988) > main_loop (ovsdb-server.c:156) > > Signed-off-

Re: [ovs-dev] [PATCH] ovsdb-server: Fix memory leak reported by Valgind.

2016-05-14 Thread Ben Pfaff
On Fri, May 13, 2016 at 09:13:13PM -0500, Ryan Moats wrote: > > +free(remotes_error); > > Shouldn't this be > > if (remotes_error) { > free(remotes_error); > } No. free() is a no-op when passed a NULL pointer. ___ dev mailing list

[ovs-dev] RETURNED MAIL: SEE TRANSCRIPT FOR DETAILS

2016-05-14 Thread Mail Delivery Subsystem
Message could not be delivered ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Mail System Error - Returned Mail

2016-05-14 Thread MAILER-DAEMON
The original message was included as attachment ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Use of uninitialized mutex_lock at udpif->ukeys[i].mutex

2016-05-14 Thread William Tu
Hi Ben, Thanks, I applied diff below. Unfortunately it makes no difference. --- a/ofproto/ofproto-dpif-upcall.c +++ b/ofproto/ofproto-dpif-upcall.c @@ -402,7 +402,7 @@ udpif_create(struct dpif_backer *backer, struct dpif *dpif) atomic_init(&udpif->n_flows, 0); atomic_init(&udpif->n_flow

[ovs-dev] Qcxayy

2016-05-14 Thread MAILER-DAEMON
This message was not delivered due to the following reason(s): Your message was not delivered because the destination server was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely the

Re: [ovs-dev] [PATCH] ovn-nbctl: Fix memory leak reported by Valgrind.

2016-05-14 Thread William Tu
thank you. I submit patch v2 here: https://patchwork.ozlabs.org/patch/622297/ On Sat, May 14, 2016 at 11:46 AM, Ben Pfaff wrote: > On Fri, May 13, 2016 at 11:30:14PM -0700, William Tu wrote: > > Hi Ryan, > > > > Thanks for the feedback. > > > > > --- a/ovn/utilities/ovn-sbctl.c > > > > +++ b/ovn

[ovs-dev] [PATCHv2] ovn-nbctl: Fix memory leak reported by Valgrind.

2016-05-14 Thread William Tu
Definitely lost is reported by test 2026: ovn -- 3 HVs, 1 LS, 3 lports/HV. ds_put_char__ (dynamic-string.c:82) ds_put_char (dynamic-string.h:88) process_escape_args (process.c:103) main (ovn-nbctl.c:92) Another leak shown at ovn-sbctl.c with similar pattern. Signed-off-by: William Tu ---

Re: [ovs-dev] Use of uninitialized mutex_lock at udpif->ukeys[i].mutex

2016-05-14 Thread Ben Pfaff
That's a really weird one. This is for an unusual code path: it's an OpenFlow packet-out, that gets executed via dpif_netdev, which causes recirculation, which installs a new datapath flow. I wonder whether somehow this bypasses a normal initialization step through some weirdness. Does it make a

Re: [ovs-dev] [PATCH 1/1] Add other_config to Global table

2016-05-14 Thread Ben Pfaff
On Wed, May 11, 2016 at 11:51:29AM -0700, Dennis Sam wrote: > Extend the Global table to allow for additional configurations by re-using > the idea of an other_config column. > > Signed-off-by: Dennis Sam Seems fine to me. > - "version": "1.5.1"} > + "version": "1.5.2"} Though it doesn't mak

Re: [ovs-dev] [PATCH] ovn-controller: Fix errors reported by Valgrind.

2016-05-14 Thread Ben Pfaff
On Fri, May 13, 2016 at 11:58:43AM -0700, William Tu wrote: > Fix two errors reported by test 2026: ovn -- 3 HVs, 1 LS, 3 lports/HV. > 1. Conditional jump or move depends on uninitialised value(s) > physical_run (physical.c:366) > main (ovn-controller.c:382) > 2. Use of uninitialised value

Re: [ovs-dev] [PATCH] ovn-nbctl: Fix memory leak reported by Valgrind.

2016-05-14 Thread Ben Pfaff
On Fri, May 13, 2016 at 11:30:14PM -0700, William Tu wrote: > Hi Ryan, > > Thanks for the feedback. > > > --- a/ovn/utilities/ovn-sbctl.c > > > +++ b/ovn/utilities/ovn-sbctl.c > > > @@ -973,6 +973,7 @@ do_sbctl(const char *args, struct ctl_command > > > *commands, size_t n_commands, > > > fr

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Always generate wildcards.

2016-05-14 Thread Ben Pfaff
On Sat, Apr 23, 2016 at 03:40:56PM -0500, Ryan Moats wrote: > "dev" wrote on 04/22/2016 07:45:03 PM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 04/22/2016 07:45 PM > > Subject: [ovs-dev] [PATCH] ofproto-dpif-xlate: Always generate wildcards. > > Sent by: "dev"

Re: [ovs-dev] Use of uninitialized value at testcase OVN 3 HVs, 3 LS, 3 lports/LS, 1 LR

2016-05-14 Thread Ben Pfaff
Thanks for testing. I applied this to master and branch-2.5. On Fri, May 13, 2016 at 04:21:45PM -0700, William Tu wrote: > Hi Ben and Ryan, > > I've tested this patch and the "Conditional jump or move depends on > uninitialised value(s)" problem caused by xlate_actions() is resolved. > However,

Re: [ovs-dev] [PATCH v3] Add configurable OpenFlow port name.

2016-05-14 Thread Xiao Liang
On Fri, May 13, 2016 at 1:16 AM, Flavio Leitner wrote: > On Wed, May 11, 2016 at 10:13:48AM +0800, Xiao Liang wrote: >> On Wed, May 11, 2016 at 4:31 AM, Flavio Leitner wrote: >> > On Tue, May 10, 2016 at 10:31:19AM +0800, Xiao Liang wrote: >> >> On Tue, May 10, 2016 at 4:28 AM, Flavio Leitner wr

[ovs-dev] (no subject)

2016-05-14 Thread Mail Administrator
This message was undeliverable due to the following reason: Your message could not be delivered because the destination server was unreachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely the