On 26/04/2016 16:38, "Flavio Leitner" wrote:
>On Fri, Apr 15, 2016 at 05:02:45PM -0700, Daniele Di Proietto wrote:
>> The system userspace testsuite uses the userspace datapath with
>> netdev-linux devices, connected to veth pairs with the AF_PACKET socket:
>>
>> (veth pair)
On 26/04/2016 08:24, "Ben Pfaff" wrote:
>On Fri, Apr 22, 2016 at 06:02:58PM -0700, Daniele Di Proietto wrote:
>> Makes popping each member of the hmap a bit easier.
>>
>> Signed-off-by: Daniele Di Proietto
>
>Much better, thank you!
>
>Acked-by: Ben Pfaff
Thanks! I pushed this to master
___
On 26/04/2016 16:38, "Flavio Leitner" wrote:
>On Fri, Apr 15, 2016 at 05:02:46PM -0700, Daniele Di Proietto wrote:
>> Useful to test the datapath ability to forward tcp packets without the
>> complexity of connection tracking.
>>
>> Signed-off-by: Daniele Di Proietto
>> ---
>
>This patch can
On 26/04/2016 16:37, "Flavio Leitner" wrote:
>On Fri, Apr 15, 2016 at 05:02:41PM -0700, Daniele Di Proietto wrote:
>> This commit implements the OVS_ACTION_ATTR_CT action in dpif-netdev.
>>
>> To allow ofproto-dpif to detect the conntrack feature, flow_put will not
>> discard anymore flows
Hi Antonio,
great, thank you very much for performing this tests and share the results
On 25/04/2016 07:00, "Fischetti, Antonio" wrote:
>Hi Daniele,
>below are
> - Regression Tests results
> - ALWAYS_INLINE check
>
>
>Regression Tests on Performance
>===
>
>I d
Thank you for your comments, Flavio!
On 26/04/2016 16:35, "Flavio Leitner" wrote:
>On Fri, Apr 15, 2016 at 05:02:36PM -0700, Daniele Di Proietto wrote:
>> This commit adds the conntrack module.
>>
>> It is a connection tracker that resides entirely in userspace. Its
>> primary user will be t
On 26/04/2016 16:38, "Flavio Leitner" wrote:
>On Fri, Apr 15, 2016 at 05:02:43PM -0700, Daniele Di Proietto wrote:
>> Signed-off-by: Daniele Di Proietto
>
>This could be squashed with "[07/15] conntrack: Implement flush
>function"
>
>Just a suggestion.
>
>Acked-by: Flavio Leitner
As also
On 26/04/2016 16:36, "Flavio Leitner" wrote:
>On Fri, Apr 15, 2016 at 05:02:37PM -0700, Daniele Di Proietto wrote:
>> This introduces a very limited but simple benchmark for
>> conntrack_execute(). It just sends repeatedly the same batch of packets
>> through the connection tracker and retur
Hi Antonio,
Thank you for your comments, replies inline
On 25/04/2016 09:14, "Fischetti, Antonio" wrote:
>Hi Daniele,
>some comments inline prefixed with [Antonio F].
>
>Regards,
>Antonio
>
>> -Original Message-
>> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele
Thanks for the detailed review Joe, replies inline
On 19/04/2016 14:36, "Joe Stringer" wrote:
>On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
>> This commit adds the conntrack module.
>>
>> It is a connection tracker that resides entirely in userspace. Its
>> primary user will be the
On 19/04/2016 15:15, "Joe Stringer" wrote:
>On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
>> The system userspace testsuite uses the userspace datapath with
>> netdev-linux devices, connected to veth pairs with the AF_PACKET socket:
>>
>> (veth pair) (AF_PACKET)
>>
On 19/04/2016 17:24, "Joe Stringer" wrote:
>On 19 April 2016 at 16:53, Joe Stringer wrote:
>> On 15 April 2016 at 17:02, Daniele Di Proietto
>> wrote:
>>> The userspace connection tracker doesn't support ALGs, frag reassembly
>>> or NAT yet, so skip those tests.
>>>
>>> Also, connection t
On 26/04/2016 16:35, "Flavio Leitner" wrote:
>On Fri, Apr 15, 2016 at 05:02:35PM -0700, Daniele Di Proietto wrote:
>> The function simply returns the ethernet type of the packet (after
>> eventually discarding the VLAN tag). It will be used by a following
>> commit.
>>
>> Signed-off-by: Da
On 19/04/2016 13:03, "Joe Stringer" wrote:
>On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
>> This will be used by a future commit.
>>
>> Signed-off-by: Daniele Di Proietto
>> ---
>> lib/flow.c | 140
>> ++---
>> lib/flow.h |
On 19/04/2016 14:52, "Joe Stringer" wrote:
>On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
>> This commit implements the OVS_ACTION_ATTR_CT action in dpif-netdev.
>>
>> To allow ofproto-dpif to detect the conntrack feature, flow_put will not
>> discard anymore flows with ct_* fields
On 19/04/2016 14:54, "Joe Stringer" wrote:
>On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
>> Signed-off-by: Daniele Di Proietto
>
>Could be combined with the earlier patch that provides the actual
>implementation?
Done, thanks!
___
dev mail
On 19/04/2016 14:49, "Joe Stringer" wrote:
>On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
>> Signed-off-by: Daniele Di Proietto
>
>
>
>> +static void
>> +conn_key_to_tuple(const struct conn_key *key, struct ct_dpif_tuple *tuple)
>> +{
>> +if (key->dl_type == htons(ETH_TYPE_IP))
Good idea, I'll combine them
Thanks for the review!
On 19/04/2016 14:40, "Joe Stringer" wrote:
>On 15 April 2016 at 17:02, Daniele Di Proietto wrote:
>> Signed-off-by: Daniele Di Proietto
>
>Looks like this can be combined with patch #11 (to plumb it up through appctl).
>
>Acked-by: Joe St
The original message was received at Wed, 27 Apr 2016 12:05:14 +0700
from schleef.org [19.182.20.189]
- The following addresses had permanent fatal errors -
- Transcript of session follows -
... while talking to 162.107.103.184:
>>> DATA
<<< 400-aturner; %MAIL-E-OPENOUT, error op
On Thu, Apr 21, 2016 at 2:07 PM, Joe Stringer wrote:
> This short series addresses some of the netfilter/defrag-related changes
> recently upstream and backports the equivalent fixes to our compat code.
> The last two patches address bugs introduced from the second patch, I've
> left them as separ
On Thu, Apr 21, 2016 at 2:07 PM, Joe Stringer wrote:
> diff --git
> a/datapath/linux/compat/include/net/netfilter/ipv6/nf_defrag_ipv6.h
> b/datapath/linux/compat/include/net/netfilter/ipv6/nf_defrag_ipv6.h
> index fe99ced37227..a3b86dab2c9c 100644
> --- a/datapath/linux/compat/include/net/netfil
On Thu, Apr 21, 2016 at 2:07 PM, Joe Stringer wrote:
> Upstream commit:
> openvswitch: Orphan skbs before IPv6 defrag
>
> This is the IPv6 counterpart to commit 8282f27449bf ("inet: frag: Always
> orphan skbs inside ip_defrag()").
>
> Prior to commit 029f7f3b8701 ("netfilter: ipv6:
On 23/04/16 01:31, Nicolas Dichtel wrote:
> Goal of this patch is to use the new libnl API to align netlink attribute
> when needed.
> The layout of the netlink message will be a bit different after the patch,
> because the padattr (TASKSTATS_TYPE_STATS) will be inside the nested
> attribute inst
Offline discussion is documented in v1->v2 below.
There are various considerations to what kind of replication
configuration is needed and what is "better" varies with the
specific requirements. Feel free to suggest otherwise.
This patch series updates the vtep schema to support source node
replic
This patch series updates the vtep schema, vtep-ctl commands and vtep
simulator to support source node replication in addition to service node
replication per logical switch. The default replication mode is service node
as that was the only mode previously supported. Source node replication
mode
On Mon, Apr 25, 2016 at 2:35 PM, Pravin B Shelar wrote:
> diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c
> index eb397e8..a1b309a 100644
> --- a/datapath/linux/compat/stt.c
> +++ b/datapath/linux/compat/stt.c
> +static int coalesce_skb(struct sk_buff **headp)
> +{
> +
Thans for the fix.
Acked-by: Nithin Raju
-Original Message-
From: dev on behalf of Sairam Venugopal
Date: Tuesday, April 26, 2016 at 4:53 PM
To: "dev@openvswitch.org"
Subject: [ovs-dev] [PATCH] datapath-windows: Fix recirculation when it
is not the last attribute
>When the recir
When the recirc action is in middle, the current code creates a clone of
the NBL. However, it overwrites the pointer to point to the cloned NBL
without completing it. This causes a memory leak that crashes the kernel.
Signed-off-by: Sairam Venugopal
---
datapath-windows/ovsext/Actions.c | 8
On Fri, Apr 15, 2016 at 05:02:47PM -0700, Daniele Di Proietto wrote:
> The userspace connection tracker doesn't support ALGs, frag reassembly
> or NAT yet, so skip those tests.
>
> Also, connection tracking state input from a local port is not possible
> in userspace.
>
> Finally, the userspace d
On Fri, Apr 15, 2016 at 05:02:46PM -0700, Daniele Di Proietto wrote:
> Useful to test the datapath ability to forward tcp packets without the
> complexity of connection tracking.
>
> Signed-off-by: Daniele Di Proietto
> ---
This patch can be separated from this patchset as well.
Thanks for impr
On Fri, Apr 15, 2016 at 05:02:44PM -0700, Daniele Di Proietto wrote:
> While the system testsuite already has connection tracking tests, it
> will be still useful to add some to the standard testsuite because:
>
> * They're run more often by developers.
> * Some of them are more interesting for th
On Fri, Apr 15, 2016 at 05:02:45PM -0700, Daniele Di Proietto wrote:
> The system userspace testsuite uses the userspace datapath with
> netdev-linux devices, connected to veth pairs with the AF_PACKET socket:
>
> (veth pair) (AF_PACKET)
> TCP stack -> p0 ---> ovs-p0
On Fri, Apr 15, 2016 at 05:02:43PM -0700, Daniele Di Proietto wrote:
> Signed-off-by: Daniele Di Proietto
This could be squashed with "[07/15] conntrack: Implement flush
function"
Just a suggestion.
Acked-by: Flavio Leitner
> ---
> lib/dpif-netdev.c | 10 +-
> 1 file changed, 9 inser
On Fri, Apr 15, 2016 at 05:02:40PM -0700, Daniele Di Proietto wrote:
> Signed-off-by: Daniele Di Proietto
> ---
Acked-by: Flavio Leitner
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Apr 15, 2016 at 05:02:42PM -0700, Daniele Di Proietto wrote:
> Signed-off-by: Daniele Di Proietto
> ---
Acked-by: Flavio Leitner
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Apr 15, 2016 at 05:02:41PM -0700, Daniele Di Proietto wrote:
> This commit implements the OVS_ACTION_ATTR_CT action in dpif-netdev.
>
> To allow ofproto-dpif to detect the conntrack feature, flow_put will not
> discard anymore flows with ct_* fields set. We still shouldn't allow
> flows wi
On Fri, Apr 15, 2016 at 05:02:38PM -0700, Daniele Di Proietto wrote:
> Simple program that runs the packet in a pcap file through the
> connection tracker and prints the 'ct_state' for each packet.
>
> E.g. the line:
>
> `./test/ovstest test-conntrack capture.pcap 2`
>
> sends the packets in `ca
On Fri, Apr 15, 2016 at 05:02:39PM -0700, Daniele Di Proietto wrote:
> Signed-off-by: Daniele Di Proietto
> ---
Acked-by: Flavio Leitner
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Apr 15, 2016 at 05:02:37PM -0700, Daniele Di Proietto wrote:
> This introduces a very limited but simple benchmark for
> conntrack_execute(). It just sends repeatedly the same batch of packets
> through the connection tracker and returns the time spent to process
> them.
>
> While this is
On Fri, Apr 15, 2016 at 05:02:36PM -0700, Daniele Di Proietto wrote:
> This commit adds the conntrack module.
>
> It is a connection tracker that resides entirely in userspace. Its
> primary user will be the dpif-netdev datapath.
>
> The module main goal is to provide conntrack_execute(), which
On Fri, Apr 15, 2016 at 05:02:35PM -0700, Daniele Di Proietto wrote:
> The function simply returns the ethernet type of the packet (after
> eventually discarding the VLAN tag). It will be used by a following
> commit.
>
> Signed-off-by: Daniele Di Proietto
> ---
I agree with Joe that we should
On Fri, Apr 15, 2016 at 05:02:34PM -0700, Daniele Di Proietto wrote:
> This will be used by a future commit.
>
> Signed-off-by: Daniele Di Proietto
> ---
I see that you tried to split the interface and the function code so
that the miniflow_extract() could get the code inlined and have no
perfor
On Fri, Apr 15, 2016 at 05:02:33PM -0700, Daniele Di Proietto wrote:
> Linux and FreeBSD have slightly different names for these constants.
> Windows doesn't define them. It is simpler to redefine them from
> scratch for OVS. The new names are different than those used in Linux
> and FreeBSD.
>
>
> Is there an equivalent of GARP for IPv6?
>
The "Unsolicited Neighbor Advertisement" seems to be the
equivalent of GARP for IPv6.
http://tools.ietf.org/html/rfc2461#section-7.2.6
The problem motivating this fix was seen with IPv4 though.
___
dev mai
Thanks Bruce
I have one point that I would like to confirm.
On Tue, Apr 26, 2016 at 11:41 AM, Bruce Davie wrote:
> Darrell,
> I don’t think you can handle the error of unsupported replication mode
> the way it is described here:
>
> + +key="unsupported_source_node_replication">
>
On Sat, Apr 23, 2016 at 5:52 PM, Wanlong Gao wrote:
> The following error is caused by the undefined dev_get_stats64() of kernel
> v2.6.32-431. The HAVE_RTNL_LINK_STATS64 does not work because this series
> kernel have the "struct rtnl_link_stats64" but neither have 64bit
> dev_get_stats() nor dev
In some usecases such as VM migration or when VMs reuse IP addresses,
VMs become unreachable externally because
external switches/routers on localnet
have stale port-mac or arp caches. The problem resolves
after some time when the caches ageout which could be
minutes for port-mac bindings or hours
Move the function extract_lport_addresses to a file
in ovn/lib since that function can be used by ovn-controller also
to parse addresses stored in the mac column of the
port_binding table. Currently that function is used only
in ovn_northd.
Signed-off-by: Ramu Ramamurthy
---
ovn/lib/automake.mk
The first patch refactors the function extract_lport_addresses
so that it can be used in ovn-northd and in ovn-controller.
The second patch depends on the first patch, and implements the
functionality to send gratuitous arps on localnet.
Changes v1->v2:
Changes per code-review:
* send gratuito
A previous patch introduced the ability to pass arbitrary EAL command
line options via the dpdk_extras database entry. This commit enhances
that by warning the user when such a configuration is detected and
prefering the value in the database.
Suggested-by: Sean K Mooney
Signed-off-by: Aaron Cono
A previous change moved some commonly used arguments from commandline to
the database, and with it the ability to pass arbitrary arguments to
EAL. This change allows arbitrary eal arguments to be provided
via a new db entry 'other_config:dpdk-extra' which will tokenize the
string and add it to the
Since the vhost-user sockets directory now comes from the database, it is
possible for any user with database access to program an arbitrary filesystem
location for the sockets directory. This could result in unprivileged users
creating or deleting arbitrary filesystem files by using specially craf
Currently, configuration of DPDK parameters is done via the command line
through a --dpdk **OPTIONS** -- command line argument. This has a number of
challenges, including:
* It must be the first option passed to ovs-vswitchd
* It is the only datapath feature in OVS to be configured on the command
The user has control over the DPDK internal lcore coremask, but this
parameter can be autofilled with a bit more intelligence. If the user
does not fill this parameter in, we use the lowest set bit in the
current task CPU affinity. Otherwise, we will reassign the current
thread to the specified lco
When the DPDK init function is called, it changes the executing thread's
CPU affinity to a single core specified in -c. This will result in the
userspace bridge configuration thread being rebound, even if that is not
the intent.
This change fixes that behavior by rebinding to the original thread
a
Existing DPDK integration is provided by use of command line options which
must be split out and passed to librte in a special manner. However, this
forces any configuration to be passed by way of a special DPDK flag, and
interferes with ovs+dpdk packaging solutions.
This commit delays dpdk initia
Darrell,
I don’t think you can handle the error of unsupported replication mode the way
it is described here:
+
+Indicates that the requested source node replication mode cannot be
+supported by the physical switch; this specifically means in this
+context that the
Hallo ,
Es tut mir leid, Ihnen in dieser Angelegenheit ohne Ihre vorherige
Zustimmung zu kontaktieren. Es war aufgrund der Dringlichkeit
befestigt.
Mein Name ist Eduardus Charlemagne, Ich bin ein Rechtsanwalt und die
persönlichen Anwalt zu einer verstorbenen kunde aus Ihre Land. Ich
möchte wisse
Hosts after Windows 7 use LSOv2 by default. The issue is with using Windows XP
VM on a Win2012R2 host. The latter will be forced to use LSOv1 since XP doesn't
support V2. We discussed about this in the previous IRC meeting. You can check
the history of the irc channel for more info.
Regards,
S
On Fri, Apr 15, 2016 at 01:28:18PM -0700, ec...@vmware.com wrote:
> From: Edwin Chiu
>
> Compile and package ovs shared libraries and create new header
> package for debian (openvswitch-dev) and rhel (openvswitch-devel).
>
> VMware-BZ: #1556299
> Signed-off-by: Edwin Chiu
> Co-authored-by: Haro
Just a small nit: we could use the values from ipmib.h/netiodef.h instead of
defining our own types.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam
> Venugopal
> Trimis: Thursday, April 14, 2016 11:23 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-d
From: Lars Ellenberg
Date: Tue, 26 Apr 2016 13:54:27 +0200
> On Tue, Apr 26, 2016 at 10:06:10AM +0200, Nicolas Dichtel wrote:
>>
>> This is the continuation (series #3) of the work done to align netlink
>> attributes when these attributes contain some 64-bit fields.
>>
>> It's the last patchset
From: Jan Kara
Date: Tue, 26 Apr 2016 13:08:48 +0200
> On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote:
>> Signed-off-by: Nicolas Dichtel
>
> OK, so I somewhat miss a description of what will this do to the netlink
> message so that I can judge whether the change is fine for the userspace
> cou
From: Nicolas Dichtel
Date: Tue, 26 Apr 2016 10:06:10 +0200
> The last user of nla_put_u64() is block/drbd. This module does not use
> standard netlink API (see all the stuff in include/linux/genl_magic_struct.h
> and include/linux/genl_magic_func.h).
Yet another example where doing things in a
Beside the alignment problems, looks good to me.
Acked-by: Alin Gabriel Serdean
Thanks,
Alin.
> -Mesaj original-
> De la: dev [mailto:dev-boun...@openvswitch.org] În numele Paul Boca
> Trimis: Monday, April 25, 2016 2:16 PM
> Către: dev@openvswitch.org
> Subiect: [ovs-dev] [PATCH] datap
> >-UINT32 encapMss = OvsGetExternalMtu(switchContext) - sizeof(IPHdr) -
> >sizeof(TCPHdr);
> >+UINT32 encapMss = OvsGetExternalMtu(switchContext)
> >+ - sizeof(IPHdr)
> >+ - sizeof(TCPHdr);
> > if (ipTotalLen > encapMss) {
> >-lsoInfo.V
On Mon, Apr 25, 2016 at 06:07:36PM +0200, Petr Machata wrote:
> Ben Pfaff writes:
>
> >> > want to make sure that the additional providers can be built without
> >> > installing code that is available only under NDA.
> >>
> >> That is understood. The SAI backend will be optional.
> >
> > That's
On Fri, Apr 22, 2016 at 06:02:58PM -0700, Daniele Di Proietto wrote:
> Makes popping each member of the hmap a bit easier.
>
> Signed-off-by: Daniele Di Proietto
Much better, thank you!
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
htt
On Thu, Mar 10, 2016 at 01:33:42PM +, Alin Serdean wrote:
> A PnP(plug and play) event will be triggered before trying to disable
> the extension. We could use this PnP event to prepare for detaching
> the datapath.
>
> This patch sets the switch into a paused state so no more net buffers
> ar
On Mon, Apr 25, 2016 at 04:41:40PM +0530, Babu Shanmugam wrote:
> On Friday 22 April 2016 10:51 PM, Ben Pfaff wrote:
> >On Fri, Apr 22, 2016 at 12:44:12PM +0530, bscha...@redhat.com wrote:
> >>From: Babu Shanmugam
> >>
> >>Following are done through this series
> >>1. Changed the old approach of p
Acked-by: Nithin Raju
-Original Message-
From: dev on behalf of Sairam Venugopal
Date: Monday, April 25, 2016 at 2:38 PM
To: Alin Serdean , "dev@openvswitch.org"
Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: Pause switch state on
PnP event
>Thanks for incorporating the review co
On Tue 26-04-16 14:31:58, Nicolas Dichtel wrote:
> Le 26/04/2016 13:08, Jan Kara a écrit :
> > On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote:
> >> Signed-off-by: Nicolas Dichtel
> >
> > OK, so I somewhat miss a description of what will this do to the netlink
> > message so that I can judge whet
Le 26/04/2016 13:08, Jan Kara a écrit :
> On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote:
>> Signed-off-by: Nicolas Dichtel
>
> OK, so I somewhat miss a description of what will this do to the netlink
> message so that I can judge whether the change is fine for the userspace
> counterpart parsin
On Tue, Apr 26, 2016 at 01:54:27PM +0200, Lars Ellenberg wrote:
> On Tue, Apr 26, 2016 at 10:06:10AM +0200, Nicolas Dichtel wrote:
> >
> > This is the continuation (series #3) of the work done to align netlink
> > attributes when these attributes contain some 64-bit fields.
> >
> > It's the last
On Tue, Apr 26, 2016 at 10:06:10AM +0200, Nicolas Dichtel wrote:
>
> This is the continuation (series #3) of the work done to align netlink
> attributes when these attributes contain some 64-bit fields.
>
> It's the last patchset from what I've seen.
>
> The last user of nla_put_u64() is block/d
Tramite la direzione regionale delle borse straniere canadese, il segretariato
di stato in esame ed alla ricerca dell'università LAVAL lancia una chiamata
alla candidatura per 400 borse di studio canadese di
l'anno accademico 2016-2017. Queste borse sono destinate ai cittadini dei paesi
della
On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote:
> Signed-off-by: Nicolas Dichtel
OK, so I somewhat miss a description of what will this do to the netlink
message so that I can judge whether the change is fine for the userspace
counterpart parsing these messages. AFAIU this changes the message fo
Signed-off-by: Nicolas Dichtel
---
Documentation/networking/gen_stats.txt | 6 --
include/net/gen_stats.h | 6 --
include/uapi/linux/gen_stats.h | 1 +
include/uapi/linux/pkt_cls.h| 2 ++
include/uapi/linux/rtnetlink.h | 1 +
include/uap
Signed-off-by: Nicolas Dichtel
---
drivers/net/wireless/mac80211_hwsim.c | 2 +-
drivers/net/wireless/mac80211_hwsim.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mac80211_hwsim.c
b/drivers/net/wireless/mac80211_hwsim.c
index c757f14c4c00..9ed0ed1bf5
I also fix the value of INET_DIAG_MAX. It's wrong since commit 8f840e47f190
which is only in net-next right now, thus I didn't make a separate patch.
Fixes: 8f840e47f190 ("sctp: add the sctp_diag.c file")
Signed-off-by: Nicolas Dichtel
---
include/uapi/linux/inet_diag.h | 4 +++-
net/core/sock_d
Signed-off-by: Nicolas Dichtel
---
net/core/neighbour.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 6a395d440228..29dd8cc22bbf 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1857,7 +1857,8 @@ static int
I also fix commit 8b32ab9e6ef1: use nla_total_size_64bit() for
OVS_FLOW_ATTR_USED in ovs_flow_cmd_msg_size().
Fixes: 8b32ab9e6ef1 ("ovs: use nla_put_u64_64bit()")
Signed-off-by: Nicolas Dichtel
---
include/uapi/linux/openvswitch.h | 2 ++
net/openvswitch/datapath.c | 27 +++---
Signed-off-by: Nicolas Dichtel
---
fs/quota/netlink.c | 12 +++-
include/uapi/linux/quota.h | 1 +
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/fs/quota/netlink.c b/fs/quota/netlink.c
index d07a2f91d858..8b252673d454 100644
--- a/fs/quota/netlink.c
+++ b/fs/quot
Signed-off-by: Nicolas Dichtel
---
net/core/rtnetlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 9efc1f34ef3b..5503dfe6a050 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -876,7 +876,7 @@ static noin
Signed-off-by: Nicolas Dichtel
---
drivers/net/macsec.c | 121 ++---
include/uapi/linux/if_link.h | 1 +
include/uapi/linux/if_macsec.h | 6 ++
3 files changed, 95 insertions(+), 33 deletions(-)
diff --git a/drivers/net/macsec.c b/drivers/net/m
This is the continuation (series #3) of the work done to align netlink
attributes when these attributes contain some 64-bit fields.
It's the last patchset from what I've seen.
The last user of nla_put_u64() is block/drbd. This module does not use
standard netlink API (see all the stuff in includ
Hi Daniel,
I had the same reaction as Ben.
I would prefer to see any efforts being made towards improving the existing
OpenFlow “sample” action.
Some more comments inline below.
> On Apr 25, 2016, at 8:48 PM, Daniel Ye wrote:
>
> Hi Ben,
>
> Thanks for your review. I have sent a second patch
87 matches
Mail list logo
