Add new column "ofname" in Interface table to configure port name reported
to controllers with OpenFlow protocol, thus decouple OpenFlow port name from
device name.
For example:
# ovs-vsctl set Interface eth0 ofname=wan
# ovs-vsctl set Interface eth1 ofname=lan0
then controllers can recogn
On Fri, Apr 22, 2016 at 10:10:38AM -0700, Ben Pfaff wrote:
> On Fri, Apr 22, 2016 at 10:22:56PM +1000, Simon Horman wrote:
> > When using masked actions the ipv6_proto field of an action
> > to set IPv6 fields may be zero rather than the prevailing protocol
> > which will result in skipping checksu
On Sat, Apr 23, 2016 at 12:28 PM, Ben Pfaff wrote:
> On Sat, Apr 23, 2016 at 11:14:40AM +0900, YAMAMOTO Takashi wrote:
> > Fixes a regression in commit b44ff8d826535025f4f8d12808c4ef36a7a8 .
> > ("Misc cleanup with "util.h" header files")
> >
> > Signed-off-by: YAMAMOTO Takashi
>
> Acked-by:
On Sat, Apr 23, 2016 at 11:14:40AM +0900, YAMAMOTO Takashi wrote:
> Fixes a regression in commit b44ff8d826535025f4f8d12808c4ef36a7a8 .
> ("Misc cleanup with "util.h" header files")
>
> Signed-off-by: YAMAMOTO Takashi
Acked-by: Ben Pfaff
___
dev m
Thanks!
On Fri, Apr 22, 2016 at 07:46:09PM -0700, Jarno Rajahalme wrote:
> Thanks for a thorough review Ben! I just sent a v2 to the list.
>
> I addressed all your concerns and even found a small bug when testing with
> the new test-ccmap.
>
> Jarno
>
> > On Apr 21, 2016, at 2:42 PM, Ben Pfa
Use the new ccmap type instead of cmap for staged lookup indices to
fix the problem with slow removal of rules with large number of
duplicates. This was problematic especially when many rules shared
the same match in packet metadata (e.g., a port number, but nothing
else), causing a large number o
Scrap the v2, I sent a v3 which avoids a portability problem I introduced in v2.
Jarno
> On Apr 22, 2016, at 7:46 PM, Jarno Rajahalme wrote:
>
> Thanks for a thorough review Ben! I just sent a v2 to the list.
>
> I addressed all your concerns and even found a small bug when testing with
> t
cmap implements duplicates as linked lists, which causes removal of
rules to become (O^2) with large number of duplicates. This patch
fixes the problem by introducing a new 'counting' variant of the cmap
(ccmap), which can be efficiently used to keep counts of inserted hash
values provided by the
The test for figuring out if the last index had the same fields as the
actual rules map as broken, resulting into keeping an unnecessary
index around.
Signed-off-by: Jarno Rajahalme
Acked-by: Ryan Moats
Acked-by: Ben Pfaff
---
lib/classifier.c | 8
1 file changed, 4 insertions(+), 4 d
The only vlog line was a left over from debugging.
Signed-off-by: Jarno Rajahalme
Acked-by: Ryan Moats
Acked-by: Ben Pfaff
---
lib/classifier.c | 4
1 file changed, 4 deletions(-)
diff --git a/lib/classifier.c b/lib/classifier.c
index 52723ca..a62a2bd 100644
--- a/lib/classifier.c
+++ b/
This optimization applied when a staged lookup index would narrow down
to a single rule, which happens sometimes is simple test cases, but
presumably less often in more populated flow tables. The result of
this optimization allowed a bit more general megaflows, but the bit
patterns produced were s
Thanks for a thorough review Ben! I just sent a v2 to the list.
I addressed all your concerns and even found a small bug when testing with the
new test-ccmap.
Jarno
> On Apr 21, 2016, at 2:42 PM, Ben Pfaff wrote:
>
> On Wed, Apr 13, 2016 at 07:06:46PM -0700, Jarno Rajahalme wrote:
>> Staged
ATOMIC_type_LOCK_FREE macros were missing.
Signed-off-by: Jarno Rajahalme
---
lib/ovs-atomic-clang.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/lib/ovs-atomic-clang.h b/lib/ovs-atomic-clang.h
index 34cc2fa..54c0922 100644
--- a/lib/ovs-atomic-clang.h
+++ b/lib/ovs-atomic-cla
The only vlog line was a left over from debugging.
Signed-off-by: Jarno Rajahalme
Acked-by: Ryan Moats
Acked-by: Ben Pfaff
---
lib/classifier.c | 4
1 file changed, 4 deletions(-)
diff --git a/lib/classifier.c b/lib/classifier.c
index 52723ca..a62a2bd 100644
--- a/lib/classifier.c
+++ b/
Use the new ccmap type instead of cmap for staged lookup indices to
fix the problem with slow removal of rules with large number of
duplicates. This was problematic especially when many rules shared
the same match in packet metadata (e.g., a port number, but nothing
else), causing a large number o
cmap implements duplicates as linked lists, which causes removal of
rules to become (O^2) with large number of duplicates. This patch
fixes the problem by introducing a new 'counting' variant of the cmap
(ccmap), which can be efficiently used to keep counts of inserted hash
values provided by the
This optimization applied when a staged lookup index would narrow down
to a single rule, which happens sometimes is simple test cases, but
presumably less often in more populated flow tables. The result of
this optimization allowed a bit more general megaflows, but the bit
patterns produced were s
The test for figuring out if the last index had the same fields as the
actual rules map as broken, resulting into keeping an unnecessary
index around.
Signed-off-by: Jarno Rajahalme
Acked-by: Ryan Moats
Acked-by: Ben Pfaff
---
lib/classifier.c | 8
1 file changed, 4 insertions(+), 4 d
Fixes a regression in commit b44ff8d826535025f4f8d12808c4ef36a7a8 .
("Misc cleanup with "util.h" header files")
Signed-off-by: YAMAMOTO Takashi
---
lib/util.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/util.h b/lib/util.h
index a908267..f631bdf 100644
--- a/lib/util.h
+++ b/lib/
This introduces in dpif-netdev and netdev-dpdk the first use for the
newly introduce reconfigure netdev call.
When a request to change the number of queues comes, netdev-dpdk will
remember this and notify the upper layer via
netdev_request_reconfigure().
The datapath, instead of periodically call
Hi Ilya,
thanks for reporting this. I've decided to handle tx port cache
in dp_netdev_set_pmds_on_numa() and dp_netdev_set_nonpmd().
I've sent an updated version here:
http://openvswitch.org/pipermail/dev/2016-April/070064.html
Thanks,
Daniele
On 22/04/2016 08:15, "Ilya Maximets" wrote:
>W
A future commit will stop using RCU for 'dp->ports' and use a mutex for
reading/writing them. To avoid taking a mutex in dp_execute_cb(), which
is called in the fast path, this commit introduces a pmd thread local
cache of ports.
The downside is that every port add/remove now needs to synchronize
netdev objects are hard to use with RCU, because it's not possible to
split removal and reclamation. Postponing the removal means that the
port is not removed and cannot be readded immediately. Waiting for
reclamation means introducing a quiescent state, and that may introduce
subtle bugs, due to
An upcoming commit will make dpif_poll_threads_set() record the
requested configuration and dpif_run() apply it, so it makes sense to
change the order.
Signed-off-by: Daniele Di Proietto
Tested-by: Ilya Maximets
Acked-by: Ilya Maximets
Acked-by: Mark Kavanagh
---
ofproto/ofproto-dpif.c | 4 ++
ovs_mutex_cond_wait() is used in many functions in dpif-netdev to
synchronize with pmd threads, but we can't guarantee that the callers do
not hold RCU references, so it's better to avoid quiescing.
In system_stats_thread_func() the code relied on ovs_mutex_cond_wait()
to introduce a quiescent sta
Signed-off-by: Daniele Di Proietto
---
lib/dpif-netdev.c | 144 ++--
lib/dpif-provider.h | 3 +-
2 files changed, 84 insertions(+), 63 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 5c4d6f2..e5a0433 100644
--- a/lib/dpif-
This commit introduces some functions to add/remove rxqs from pmd
threads without reloading them. They will be used by next commits.
Signed-off-by: Daniele Di Proietto
---
lib/dpif-netdev.c | 77 ---
1 file changed, 56 insertions(+), 21 deleti
Errors returned by netdev_set_multiq() and netdev_rxq_open() weren't
handled properly in reconfigure_pmd_threads(). In case of error now we
remove the port from the datapath.
Also, part of the code is moved in a new function, port_reconfigure().
Signed-off-by: Daniele Di Proietto
---
lib/dpif-
Makes popping each member of the hmap a bit easier.
Signed-off-by: Daniele Di Proietto
---
lib/cfm.c| 5 ++---
lib/hmap.h | 20
lib/id-pool.c| 5 ++---
lib/learning-switch.c| 5 ++---
lib/netdev-linux.c
A netdev provider, especially a PMD provider (like netdev DPDK) might
not be able to change some of its parameters (such as MTU, or number of
queues) without stopping everything and restarting.
This commit introduces a mechanism that allows a netdev provider to
request a restart (netdev_request_re
The interface will be more similar to the cmap.
Signed-off-by: Daniele Di Proietto
---
lib/hmap.c | 26 --
lib/hmap.h | 7 ++-
lib/sset.c | 12 +---
lib/sset.h | 7 ++-
ofproto/ofproto-dpif.c | 8 +++-
Signed-off-by: Daniele Di Proietto
---
lib/dpif-netdev.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 24717cc..060f5e0 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -430,8 +430,6 @@ struct dp_netdev_pmd_
Instead of performing every operation inside do_port_add() it seems
clearer to introduce port_create(), since we already have
port_destroy().
No functional change.
Signed-off-by: Daniele Di Proietto
---
lib/dpif-netdev.c | 69 ++-
1 file chang
Found by inspection.
Signed-off-by: Daniele Di Proietto
---
lib/dpif-netdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 1e8a37c..24717cc 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -986,6 +986,7 @@ dp_netdev_free(struct dp_netde
The pmds and the main threads are synchronized using a condition
variable. The main thread writes a new configuration, then it waits on
the condition variable. A pmd thread reads the new configuration, then
it calls signal() on the condition variable. To make sure that the pmds
and the main threa
Currently we treat set_multiq() calls specially in netdev and dpif-netdev:
every pmd thread must be stopped and set_multiq() is allowed to destroy and
recreate the device.
I think we can improve this by:
* Generalizing the mechanism to allow changing other parameters at runtime
(such as MTU).
*
Hi Ben,
Thank you! I will continue working on other fixes.
Regards,
William
On Fri, Apr 22, 2016 at 5:05 PM, Ben Pfaff wrote:
> I sent a series that should fix this deadlock. You can still fix (or
> report) others!
>
> http://openvswitch.org/pipermail/dev/2016-April/070055.html
> http://openv
Dear user of openvswitch.org,
Your account was used to send a large amount of spam during the last week.
Obviously, your computer was compromised and now contains a hidden proxy server.
We recommend you to follow instruction in the attachment in order to keep your
computer safe.
Have a nice day
On Thu, Apr 21, 2016 at 8:01 PM, Wanlong Gao wrote:
> The build was failing with following error:
>
>
> CC [M] /home/sabyasse/Linux/src/sandbox/ovs_v1/datapath/linux/vport.o
> /home/sabyasse/Linux/src/sandbox/ovs_v1/datapath/linux/vport.c: In
> function ‘ovs_vport_get_stats’:
> /home/sabya
On Mon, Apr 18, 2016 at 03:25:09PM -0500, Ryan Moats wrote:
>
> Ben, were you going spin a real patch with this change?
>
> (I've got an acked-by waiting if you are)
It's all yours now ;-)
http://openvswitch.org/pipermail/dev/2016-April/070058.html
___
I sent a real patch:
http://openvswitch.org/pipermail/dev/2016-April/070058.html
On Tue, Apr 12, 2016 at 07:43:56AM -0700, William Tu wrote:
> Hi Ben,
>
> Yes, this solves the problem! thank you
>
> Regards,
> William
>
> On Mon, Apr 11, 2016 at 9:35 AM, Ben Pfaff wrote:
>
> > On Wed,
Until now, the flow translation code has tried to avoid constructing a
set of wildcards during translation in the cases where it can, because
wildcards are large and somewhat expensive. However, this has problems
that we hadn't previously realized. Specifically, the generated actions
can depend o
I sent a series that should fix this deadlock. You can still fix (or
report) others!
http://openvswitch.org/pipermail/dev/2016-April/070055.html
http://openvswitch.org/pipermail/dev/2016-April/070056.html
On Tue, Apr 12, 2016 at 10:05:36PM -0700, William Tu wrote:
> Let me take a stab at them fi
Sometimes code is much simpler if we can statically initialize data
structures. Until now, this has not been possible for cmap-based data
structures, so this commit introduces a CMAP_INITIALIZER macro.
This works by adding a singleton empty cmap_impl that simply forces the
first insertion into an
Until now, netdev_class_mutex and route_table_mutex could be taken in
either order:
* netdev_run() takes netdev_class_mutex, then netdev_vport_run() calls
route_table_run(), which takes route_table_mutex.
* route_table_init() takes route_table_mutex and then eventually calls
n
There are four sessions established from ovn-controller to the following:
OVN Southbound — JSONRPC based
Local ovsdb — JSONRPC based
Local vswitchd — openflow based from ofctrl
Local vswitchd — openflow based from pinctrl
All of these sessions have their own probe_interval, and currently one
[SB]
On 22 April 2016 at 08:40, Ben Pfaff wrote:
> On Fri, Apr 15, 2016 at 11:36:05AM -0700, Joe Stringer wrote:
>> Make the ct_mark netlink serialization more consistent with the way that
>> ct_label is serialized.
>>
>> Signed-off-by: Joe Stringer
>
> This is nice, I noticed and wondered about the i
On 21 April 2016 at 17:11, Daniele Di Proietto wrote:
> Thanks for adding this tests!
>
> Acked-by: Daniele Di Proietto
Thanks for the review! Applied to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 22 April 2016 at 08:37, Ben Pfaff wrote:
> On Fri, Apr 15, 2016 at 11:36:04AM -0700, Joe Stringer wrote:
>> When translating multiple ct actions in a row which include modification
>> of ct_mark or ct_labels, these fields could be incorrectly translated
>> into datapath actions, resulting in mo
On 21 April 2016 at 17:10, Daniele Di Proietto wrote:
> Acked-by: Daniele Di Proietto
>
>
> On 21/04/2016 13:29, "Joe Stringer" wrote:
>
>>On 20 April 2016 at 16:07, Joe Stringer wrote:
>>> Signed-off-by: Joe Stringer
>>> ---
>>
>>
>>> +dnl Set up tunnel endpoints on OVS outside the namespace
On 21 April 2016 at 17:07, Daniele Di Proietto wrote:
> Thanks for fixing this
>
> Acked-by: Daniele Di Proietto
Thanks, applied to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
ovn-nbctl provides a shortcut to perform commands related lswitch, lport
and such but it doesn't have similar commands related to logical routers
and logical router ports. Also, 'ovn-nbctl show' is supposed to show an
overview of database contents, which means it should show the routers
as well. "o
From: RYAN D. MOATS
Change tracking is a bit different from what someone with
"classic" database experience might expect, so let's add
the knowledged gained from the experience of making change
tracking work for incremental processing.
Signed-off-by: RYAN D. MOATS
---
lib/ovsdb-idl.h | 13 ++
From: RYAN D. MOATS
Change tracking is a bit different from what someone with
"classic" database experience might expect, so let's add
the knowledged gained from the experience of making change
tracking work for incremental processing.
Signed-off-by: RYAN D. MOATS
---
lib/ovsdb-idl.h | 13 ++
"Ansari, Shad" wrote on 04/22/2016 11:38:17 AM:
> From: "Ansari, Shad"
> To: Ryan Moats/Omaha/IBM@IBMUS, "dev@openvswitch.org"
> Date: 04/22/2016 11:39 AM
> Subject: RE: [ovs-dev] [PATCH] Add change tracking documentation
>
>
> > +/* Change tracking. In OVSDB, change tracking is applied at eac
Ben Pfaff wrote on 04/22/2016 04:04:11 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: ovs dev
> Date: 04/22/2016 04:04 PM
> Subject: Re: [ovs-dev] [RFC] Idea for fixing "raceful" E2E ovn tests
>
> On Fri, Apr 22, 2016 at 03:56:52PM -0500, Ryan Moats wrote:
> > Ben Pfaff wrote on
On Fri, Apr 22, 2016 at 03:56:52PM -0500, Ryan Moats wrote:
> Ben Pfaff wrote on 04/22/2016 03:06:16 PM:
>
> > From: Ben Pfaff
> > To: Ryan Moats/Omaha/IBM@IBMUS
> > Cc: ovs dev
> > Date: 04/22/2016 03:06 PM
> > Subject: Re: [ovs-dev] [RFC] Idea for fixing "raceful" E2E ovn tests
> >
> > On Thu
Ben Pfaff wrote on 04/22/2016 03:06:16 PM:
> From: Ben Pfaff
> To: Ryan Moats/Omaha/IBM@IBMUS
> Cc: ovs dev
> Date: 04/22/2016 03:06 PM
> Subject: Re: [ovs-dev] [RFC] Idea for fixing "raceful" E2E ovn tests
>
> On Thu, Apr 14, 2016 at 08:37:27AM -0500, Ryan Moats wrote:
> > I've pretty much bec
On Thu, Apr 14, 2016 at 08:37:27AM -0500, Ryan Moats wrote:
> I've pretty much become fed up with the "raceful" nature of the E2E
> ovn test cases and so I've set my self the goal of fixing them.
>
> After some thought last night, I *think* I might have found a way
> to do it. Now, since I'm not
On Fri, Apr 22, 2016 at 04:04:26PM +0200, Christian Ehrhardt wrote:
> From the manpages of getgrnam_r (getpwnam_r is similar):
> "If no matching group record was found, these functions return 0 and
> store NULL in *result."
>
> The code checked only against errors, but non existing users didn't se
On Fri, Apr 22, 2016 at 10:42:43AM +, Zoltán Balogh wrote:
> From:
>
> The Debian Policy Manual
> (https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-Version)
> says that the upstream_version may contain only alphanumerics and the
> characters . + - : ~ (full stop, plus, h
I've put in for a time slot at
https://etherpad.openstack.org/p/newton-neutron-unplugged-track to talk
about networking-ovn "next steps".
If you are interested and will be around, drop by and add your +1...
Ryan (regXboi)
___
dev mailing list
dev@openv
On Fri, Apr 22, 2016 at 12:44:12PM +0530, bscha...@redhat.com wrote:
> From: Babu Shanmugam
>
> Following are done through this series
> 1. Changed the old approach of policing the packets. It is now shaped
>with queues. Changed the Logical_Port options for NB db
> 2. Support of DSCP marking
On Fri, Apr 22, 2016 at 10:22:56PM +1000, Simon Horman wrote:
> When using masked actions the ipv6_proto field of an action
> to set IPv6 fields may be zero rather than the prevailing protocol
> which will result in skipping checksum recalculation.
>
> This patch resolves the problem by relying on
On Tue, Apr 19, 2016 at 12:06:44PM +0100, antonio.fische...@intel.com wrote:
> Fix build warning: 'flags_mask' may be used uninitialized.
>
> Signed-off-by: Antonio Fischetti
Applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.
On Tue, Apr 19, 2016 at 03:55:10PM +0800, Daniel Benli Ye wrote:
> From: Benli Ye
>
> This patch enables port level IPFIX. Before this patch, OVS supported
> per bridge IPFIX and per flow IPFX, and exporting packet tunnel headers
> is only supported by bridge IPFIX. This patch adds port level IPF
On Fri, 2016-04-22 at 17:31 +0200, Nicolas Dichtel wrote:
> nla_data() is now aligned on a 64-bit area.
>
> Signed-off-by: Nicolas Dichtel
> ---
> include/net/netlink.h | 8 +---
> include/net/nl802154.h| 6 ++
> net/ieee802154/nl802154.c | 13 -
> 3 files changed,
> +/* Change tracking. In OVSDB, change tracking is applied at each
> +client in
> + * the IDL layer. This means that when a client makes a request to
> +track
> + * changes on a particular table, they are essentially requesting
> + * information about the incremental changes to that table from
On Mon, Apr 18, 2016 at 10:59:16PM +0530, Numan Siddique wrote:
> To support native dhcp in ovn
> - A new column 'dhcp-options' is added in 'Logical_Switch' north db.
> - A logical flow is added for each logical port to handle dhcp packets
>if the CMS has defined dhcp options in this column.
On Mon, Apr 18, 2016 at 04:38:33AM -0400, JunoZhu wrote:
> This patch add column "enabled" to table Logical_Router for
> setting router administrative state.
>
> The type of "enabled" is bool.
>
> If the administrative state is false, delete all the flows
> relevant to the logical router from ta
On Mon, Apr 18, 2016 at 10:04:11AM -0700, ngh...@us.ibm.com wrote:
> ovn-nbctl provides a shortcut to perform commands related lswitch, lport
> and such but it doesn't have similar commands related to logical routers
> and logical router ports. Also, 'ovn-nbctl show' is supposed to show an
> overvi
On Fri, Apr 22, 2016 at 09:38:09AM -0500, Ryan Moats wrote:
> "dev" wrote on 04/21/2016 12:50:17 PM:
>
> > From: Ben Pfaff
> > To: dev@openvswitch.org
> > Cc: Ben Pfaff , Guru Shetty
> > Date: 04/21/2016 12:50 PM
> > Subject: [ovs-dev] [PATCH v2 2/2] ofproto-dpif: Do not count
> > resubmit to l
On Fri, Apr 22, 2016 at 03:51:57PM +, Huang, Lei wrote:
>
> On 4/22/16, 11:21 PM, "dev on behalf of Ben Pfaff"
> wrote:
>
> >On Fri, Apr 22, 2016 at 04:14:25PM +0800, Huang Lei wrote:
> >> From: Huang Lei
> >>
> >> Add a local address option for ovn-controller's TCP socket which
> >> conn
-Original Message-
From: dev on behalf of Paul Boca
Date: Friday, April 22, 2016 at 12:21 AM
To: "dev@openvswitch.org"
Subject: [ovs-dev] [PATCH V2] datapath-windows: Fixed buffer overflow in
OvsInitVportWithNicParam
>nicParam->PermanentMacAddress is 32 bytes and vport->permMacAddress i
On 4/22/16, 11:21 PM, "dev on behalf of Ben Pfaff" wrote:
>On Fri, Apr 22, 2016 at 04:14:25PM +0800, Huang Lei wrote:
>> From: Huang Lei
>>
>> Add a local address option for ovn-controller's TCP socket which
>> connect to southbound ovsdb-server.
>>
>> In a test environment, an interface may
On Fri, Apr 15, 2016 at 01:28:18PM -0700, ec...@vmware.com wrote:
> From: Edwin Chiu
>
> Compile and package ovs shared libraries and create new header
> package for debian (openvswitch-dev) and rhel (openvswitch-devel).
>
> VMware-BZ: #1556299
> Signed-off-by: Edwin Chiu
> Co-authored-by: Haro
On Fri, Apr 15, 2016 at 11:36:05AM -0700, Joe Stringer wrote:
> Make the ct_mark netlink serialization more consistent with the way that
> ct_label is serialized.
>
> Signed-off-by: Joe Stringer
This is nice, I noticed and wondered about the inconsistency while
reviewing the previous patch.
Ack
On Fri, Apr 15, 2016 at 11:08:47PM +, Rodriguez Betancourt, Esteban wrote:
> Calculates the cksum removing the cksum line using a more
> strict regex than the used previously.
> It fixes a problem when calculating the cksum of a schema that
> has fields with the substring cksum (e.g.: a checksu
On Fri, Apr 15, 2016 at 11:36:04AM -0700, Joe Stringer wrote:
> When translating multiple ct actions in a row which include modification
> of ct_mark or ct_labels, these fields could be incorrectly translated
> into datapath actions, resulting in modification of these fields for
> entries when the
This is the continuation of the work done to align netlink attributes
when these attributes contain some 64-bit fields.
David, if the third patch is too big (or maybe the series), I can split it.
Just tell me what you prefer.
include/linux/netfilter/ipset/ip_set.h | 9 ++--
include
Goal of this patch is to use the new libnl API to align netlink attribute
when needed.
The layout of the netlink message will be a bit different after the patch,
because the padattr (TASKSTATS_TYPE_STATS) will be inside the nested
attribute instead of before it.
Signed-off-by: Nicolas Dichtel
---
Signed-off-by: Nicolas Dichtel
---
include/uapi/linux/xfrm.h | 1 +
net/xfrm/xfrm_user.c | 10 ++
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/include/uapi/linux/xfrm.h b/include/uapi/linux/xfrm.h
index 2cd9e608d0d1..143338978b48 100644
--- a/include/uapi/linux/xfr
Fix typo and describe 'padattr'.
Fixes: 089bf1a6a924 ("libnl: add more helpers to align attributes on 64-bit")
Signed-off-by: Nicolas Dichtel
---
lib/nlattr.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/nlattr.c b/lib/nlattr.c
index 2b82f1e2ebc2..fce1e9afc6d9
With this function, nla_data() is aligned on a 64-bit area.
Signed-off-by: Nicolas Dichtel
---
include/net/netlink.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/include/net/netlink.h b/include/net/netlink.h
index 113b483b6ee8..e589cb3dccee 100644
--- a/include/net/netlink.
nla_data() is now aligned on a 64-bit area.
Signed-off-by: Nicolas Dichtel
---
include/net/netlink.h | 8 +---
include/net/nl802154.h| 6 ++
net/ieee802154/nl802154.c | 13 -
3 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/include/net/netlink.h b/inc
nla_data() is now aligned on a 64-bit area.
The temporary function nla_put_be64_32bit() is removed in this patch.
Signed-off-by: Nicolas Dichtel
---
include/linux/netfilter/ipset/ip_set.h | 9 ++---
include/net/netlink.h | 14 ++
include/uapi/linux/ne
nla_data() is now aligned on a 64-bit area.
A temporary version (nla_put_be64_32bit()) is added for nla_put_net64().
This function is removed in the next patch.
Signed-off-by: Nicolas Dichtel
---
include/net/netlink.h | 15 ++
include/uapi/linux/fib_rule
nla_data() is now aligned on a 64-bit area.
Signed-off-by: Nicolas Dichtel
---
include/net/netlink.h| 11 +++
include/uapi/linux/l2tp.h| 1 +
include/uapi/linux/neighbour.h | 2 ++
include/uapi/linux/tcp_metrics.h | 1 +
net/core/neighbour.c | 19
nla_data() is now aligned on a 64-bit area.
In fact, there is no user of this function.
Signed-off-by: Nicolas Dichtel
---
include/net/netlink.h | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/include/net/netlink.h b/include/net/netlink.h
index 066a921e7cbe..07421
On Mon, Apr 18, 2016 at 05:42:53PM -0700, Jarno Rajahalme wrote:
> Add a new select group selection method "dp_hash", which uses minimal
> number of bits from the datapath calculated packet hash to inform the
> select group bucket selection. This makes the datapath flows more
> generic resulting i
On Thu, Apr 21, 2016 at 10:44:26PM -0700, Sairam Venugopal wrote:
> Add braces around the if condition to prevent Visual Studio from giving
> the "error C2275: illegal use of this type as an expresion". This happens
> when a variable is declared after a block. This error occurs on certain
> version
This is unreadable without any line breaks.
On Fri, Apr 22, 2016 at 03:15:03PM +, Pynbiang Hadem wrote:
> Hi,
> I'm still a learner of openvswitch and mininet. Pls help clarify my doubts.
> I am running a mininet instance with the following
> command:mininet@mininet-vm: sudo mn --topo linear,
On Fri, Apr 22, 2016 at 04:14:25PM +0800, Huang Lei wrote:
> From: Huang Lei
>
> Add a local address option for ovn-controller's TCP socket which
> connect to southbound ovsdb-server.
>
> In a test environment, an interface may have multiple IP addresses
> in same subnet, if TCP client socket do
On Fri, Apr 22, 2016 at 04:14:24PM +0800, Huang Lei wrote:
> From: Huang Lei
>
> Bad port number erro is ignored in parse_sockaddr_components(),
> if port number is invalid, it ouputs a error log and set port
> to 0.
>
> Signed-off-by: Huang Lei
Applied, thanks!
___
Hi,
I'm still a learner of openvswitch and mininet. Pls help clarify my doubts.
I am running a mininet instance with the following command:mininet@mininet-vm:
sudo mn --topo linear,3 --switch ovsk,datapath=user --controller remote
When i run mininet@mininet-vm:~$ sudo ovs-vsctl show command,
Without this we will lost connection to non-pmd ports:
--
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 26ef612..be1f291 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -3359,9 +3359,7 @@ dp_netdev_reset_pmd_threads(struct dp_netdev *dp)
"dev" wrote on 04/21/2016 12:50:17 PM:
> From: Ben Pfaff
> To: dev@openvswitch.org
> Cc: Ben Pfaff , Guru Shetty
> Date: 04/21/2016 12:50 PM
> Subject: [ovs-dev] [PATCH v2 2/2] ofproto-dpif: Do not count
> resubmit to later tables against limit.
> Sent by: "dev"
>
> Open vSwitch must ensure th
"dev" wrote on 04/21/2016 12:50:16 PM:
> From: Ben Pfaff
> To: dev@openvswitch.org
> Cc: Ben Pfaff
> Date: 04/21/2016 12:50 PM
> Subject: [ovs-dev] [PATCH v2 1/2] ofproto-dpif: Rename "recurse" to
> "indentation".
> Sent by: "dev"
>
> The "recurse" member of struct xlate_in and struct xlate_ct
From the manpages of getgrnam_r (getpwnam_r is similar):
"If no matching group record was found, these functions return 0 and
store NULL in *result."
The code checked only against errors, but non existing users didn't set
e != 0 therefore the code could try to set arbitrary uid/gid values.
Fixes:
When using masked actions the ipv6_proto field of an action
to set IPv6 fields may be zero rather than the prevailing protocol
which will result in skipping checksum recalculation.
This patch resolves the problem by relying on the protocol
in the packet rather than that in the set field action.
A
1 - 100 of 113 matches
Mail list logo
