Re: [ovs-dev] Implementation of Packet-Out in Bundles

2016-03-14 Thread Ben Pfaff
Jarno, what do you think? On Mon, Mar 14, 2016 at 11:16:27PM +, André Mantas wrote: > Ok. And what about Packet_Out validation complicating the implementation of > group and meter mod in bundles? > > Should I create new validation functions that don't check for group and > meter in the action

Re: [ovs-dev] [PATCH v2] datapath-windows: Support for IPv6 in TCP segmentation

2016-03-14 Thread Ben Pfaff
On Mon, Feb 29, 2016 at 11:42:12AM -0800, Sairam Venugopal wrote: > When a packet which needs segmentation is received, the header for > each segment is being calculated, i.e. IP length, checksum, TCP seq, > TCP checksum. > > The problem with the current code is that it wrongly assumes that > the

[ovs-dev] [PATCH net-next repost] openvswitch: allow output of MPLS packets on tunnel vports

2016-03-14 Thread Simon Horman
Currently output of MPLS packets on tunnel vports is not allowed by Open vSwitch. This is because historically encapsulation was done in such a way that the inner_protocol field of the skb needed to hold the inner protocol for both MPLS and tunnel encapsulation in order for GSO segmentation to be p

Re: [ovs-dev] [PATCH net-next] openvswitch: allow output of MPLS packets on tunnel vports

2016-03-14 Thread Simon Horman
On Tue, Mar 15, 2016 at 11:52:42AM +0900, Simon Horman wrote: > From: Simon Horman Sorry, I mixed up my own email address somehow. I will repost. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH net-next] openvswitch: allow output of MPLS packets on tunnel vports

2016-03-14 Thread Simon Horman
From: Simon Horman Currently output of MPLS packets on tunnel vports is not allowed by Open vSwitch. This is because historically encapsulation was done in such a way that the inner_protocol field of the skb needed to hold the inner protocol for both MPLS and tunnel encapsulation in order for GSO

Re: [ovs-dev] [PATCH nf-next v10 0/8] openvswitch: NAT support

2016-03-14 Thread Pablo Neira Ayuso
On Thu, Mar 10, 2016 at 10:54:15AM -0800, Jarno Rajahalme wrote: > This series adds NAT support to openvswitch kernel module. A few > changes are needed to the netfilter code to facilitate this (patches > 1-2/8). Patches 3-7 make the openvswitch kernel module ready for the > patch 8 that adds the

Re: [ovs-dev] Implementation of Packet-Out in Bundles

2016-03-14 Thread André Mantas
Ok. And what about Packet_Out validation complicating the implementation of group and meter mod in bundles? Should I create new validation functions that don't check for group and meter in the action of Packet_Out? Ben Pfaff escreveu no dia segunda, 14/03/2016 às 16:54: > On Wed, Mar 09, 2016 a

Re: [ovs-dev] [RFC 1/8] system-traffic: Load balancing.

2016-03-14 Thread Ben Pfaff
On Mon, Mar 14, 2016 at 01:57:57PM -0700, Jarno Rajahalme wrote: > > > On Mar 14, 2016, at 10:42 AM, Ben Pfaff wrote: > > > > On Sun, Feb 28, 2016 at 10:33:17PM -0800, Gurucharan Shetty wrote: > >> From: Jarno Rajahalme > >> > >> Signed-off-by: Jarno Rajahalme > > > > The core of the change

Re: [ovs-dev] Unable to rmmod openvswitch kernel module

2016-03-14 Thread Jesse Gross
On Mon, Mar 14, 2016 at 1:55 PM, William Tu wrote: > Hi Jesse, > > Thanks! It works... although I don't quite understand why. > > [root@vm-dev ovs]# ovs-appctl -t ovs-vswitchd exit > [root@vm-dev ovs]# ovs-appctl -t ovsdb-server exit > [root@vm-dev ovs]# lsmod | grep open > openvswitch 1

Re: [ovs-dev] [RFC 1/8] system-traffic: Load balancing.

2016-03-14 Thread Jarno Rajahalme
> On Mar 14, 2016, at 10:42 AM, Ben Pfaff wrote: > > On Sun, Feb 28, 2016 at 10:33:17PM -0800, Gurucharan Shetty wrote: >> From: Jarno Rajahalme >> >> Signed-off-by: Jarno Rajahalme > > The core of the change here seems to be: > >> diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c >> index

Re: [ovs-dev] Unable to rmmod openvswitch kernel module

2016-03-14 Thread William Tu
Hi Jesse, Thanks! It works... although I don't quite understand why. [root@vm-dev ovs]# ovs-appctl -t ovs-vswitchd exit [root@vm-dev ovs]# ovs-appctl -t ovsdb-server exit [root@vm-dev ovs]# lsmod | grep open openvswitch 155648 4> still 4 [root@vm-dev ovs]# ovs-dpctl del-dp sys

[ovs-dev] [PATCH] Dynamically reconnect ovn-controller if ovn-remote value changes

2016-03-14 Thread Ryan Moats
From: RYAN D. MOATS Allows for auto detection and reconnect if the ovn-remote needs to change. ovn-controller test case updated to include testing this code Signed-off-by: RYAN D. MOATS --- ovn/controller/ovn-controller.c | 12 tests/ovn-controller.at | 16 +++

Re: [ovs-dev] Unable to rmmod openvswitch kernel module

2016-03-14 Thread Jesse Gross
On Sun, Mar 13, 2016 at 8:39 PM, William Tu wrote: > Hi Darrell, > > Thanks, however, it still doesn't work for me. On linux 4.3, modules that > depends on openvswitch.ko are > vport-gre > vport-vxlan > vport-geneve > I've made sure they all unloaded, but my openvswitch.ko still shows "used > by 4

Re: [ovs-dev] [PATCH 4/6] tunneling: Handle multiple ip address for given device.

2016-03-14 Thread pravin shelar
On Thu, Mar 10, 2016 at 4:49 PM, Ben Pfaff wrote: > On Wed, Mar 09, 2016 at 04:40:43PM -0800, Pravin B Shelar wrote: >> From: Pravin B Shelar >> >> Device can have multiple IP address but netdev_get_in4/6() >> returns only one configured IPv6 address. Following >> patch fixes it. >> OVS router is

Re: [ovs-dev] [PATCH 6/6] tunneling: Enable IPv6 tuneling.

2016-03-14 Thread pravin shelar
On Fri, Mar 11, 2016 at 10:02 AM, Jesse Gross wrote: > On Wed, Mar 9, 2016 at 4:40 PM, Pravin B Shelar wrote: >> From: Pravin B Shelar >> >> There is check to disable IPv6 tunneling. Following patch >> removes it and reintroduces the tunneling automake tests. >> >> This reverts commit 250bd94d1e

Re: [ovs-dev] [PATCH 3/6] lib: Fix compose nd

2016-03-14 Thread pravin shelar
On Fri, Mar 11, 2016 at 11:29 AM, Thadeu Lima de Souza Cascardo wrote: > On Wed, Mar 09, 2016 at 04:40:42PM -0800, Pravin B Shelar wrote: >> Following patch fixes number of issues with compose nd, like >> setting ip packet header, set ICMP opt-len, checksum. >> >> Signed-off-by: Pravin B Shelar >

Re: [ovs-dev] [PATCH] datapath: Fix build failure related to missing vlan.h

2016-03-14 Thread pravin shelar
On Mon, Mar 14, 2016 at 12:39 PM, Jesse Gross wrote: > On Mon, Mar 14, 2016 at 11:18 AM, Pravin B Shelar wrote: >> ---8<--- >> make[1]: Entering directory `/home/travis/build/openvswitch/ovs/datapath' >> make[1]: *** No rule to make target `vlan.h', needed by `distdir'. Stop. >> make[1]: Leaving

Re: [ovs-dev] [PATCH] datapath: Fix build failure related to missing vlan.h

2016-03-14 Thread Jesse Gross
On Mon, Mar 14, 2016 at 11:18 AM, Pravin B Shelar wrote: > ---8<--- > make[1]: Entering directory `/home/travis/build/openvswitch/ovs/datapath' > make[1]: *** No rule to make target `vlan.h', needed by `distdir'. Stop. > make[1]: Leaving directory `/home/travis/build/openvswitch/ovs/datapath' > m

[ovs-dev] [PATCH] Change TCP connections to support DNS names

2016-03-14 Thread Ryan Moats
From: RYAN D. MOATS Allow TCP connection strings to also use DNS names in addition to IPv4 and IPv6 addresses. Updated test case "ovsdb-client get-schema-version - tcp socket" to verify. Signed-off-by: RYAN D. MOATS --- lib/stream-tcp.c | 66 +

[ovs-dev] ovn: broadcast packets dropped with "drop recirc action"

2016-03-14 Thread Ramu Ramamurthy
When a logical switch (localnet) has lots of ports on a hypervisor, I find that broadcast packets from one of the ports is only forwarded to a subset of the other ports, and the kernel module shows the message - "kernel: openvswitch: ovs-system: deferred action limit reached, drop recirc action"

Re: [ovs-dev] [PATCH] Build Windows include runtime

2016-03-14 Thread Alin Serdean
Ty! > -Mesaj original- > De la: Ben Pfaff [mailto:b...@ovn.org] > Trimis: Monday, March 14, 2016 7:25 PM > Către: Alin Serdean > Cc: dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] Build Windows include runtime > > On Fri, Feb 26, 2016 at 01:59:10PM +, Alin Serdean wrote: > > Th

[ovs-dev] [PATCH] datapath: Fix build failure related to missing vlan.h

2016-03-14 Thread Pravin B Shelar
---8<--- make[1]: Entering directory `/home/travis/build/openvswitch/ovs/datapath' make[1]: *** No rule to make target `vlan.h', needed by `distdir'. Stop. make[1]: Leaving directory `/home/travis/build/openvswitch/ovs/datapath' make: *** [distdir] Error 1 cat: */_build/tests/testsuite.log: No suc

Re: [ovs-dev] [RFC 0/8] OVN east-west loadbalancing.

2016-03-14 Thread Ryan Moats
"dev" wrote on 03/14/2016 12:57:10 PM: > From: Ben Pfaff > To: Guru Shetty > Cc: ovs dev > Date: 03/14/2016 12:57 PM > Subject: Re: [ovs-dev] [RFC 0/8] OVN east-west loadbalancing. > Sent by: "dev" > > On Mon, Feb 29, 2016 at 08:32:13AM -0800, Guru Shetty wrote: > > On 28 February 2016 at 22:

Re: [ovs-dev] [RFC 4/8] ovn-northd: Introduce stateful table.

2016-03-14 Thread Ben Pfaff
On Sun, Feb 28, 2016 at 10:33:20PM -0800, Gurucharan Shetty wrote: > Currently, the only use of stateful services in conntrack is > OVN ACLs. In table ACL, we commit the packet to conntrack > via ct_commit action. > > As we introduce more stateful services, the ACL feature will > have to share the

Re: [ovs-dev] [RFC 0/8] OVN east-west loadbalancing.

2016-03-14 Thread Ben Pfaff
On Mon, Feb 29, 2016 at 08:32:13AM -0800, Guru Shetty wrote: > On 28 February 2016 at 22:33, Gurucharan Shetty wrote: > > > This series adds support for OVN loadbalancing. This is very > > lightly tested (with a very simple OVN topology of 1 router > > and 2 lswitches), but the patches are far en

Re: [ovs-dev] [RFC 3/8] ovn-northd: Introduce pre-stateful table.

2016-03-14 Thread Ben Pfaff
On Sun, Feb 28, 2016 at 10:33:19PM -0800, Gurucharan Shetty wrote: > Currently, the only use of stateful services in conntrack is > OVN ACLs. In table pre-ACL, we send the packet to conntrack > to track it (to get its status) via the ct_next action. > > As we introduce more stateful services, the

Re: [ovs-dev] [RFC 2/8] ovn-northd: Split ACL and pre-ACL processing.

2016-03-14 Thread Ben Pfaff
On Sun, Feb 28, 2016 at 10:33:18PM -0800, Gurucharan Shetty wrote: > Future patches introduce more tables between > pre-ACL and ACL processing. As such, it looks > easier to separate these out into separate > functions to enhance code readability. > > Signed-off-by: Gurucharan Shetty Acked-by: B

Re: [ovs-dev] [RFC 1/8] system-traffic: Load balancing.

2016-03-14 Thread Ben Pfaff
On Sun, Feb 28, 2016 at 10:33:17PM -0800, Gurucharan Shetty wrote: > From: Jarno Rajahalme > > Signed-off-by: Jarno Rajahalme The core of the change here seems to be: > diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c > index becf02d..8f6e02e 100644 > --- a/lib/ofp-actions.c > +++ b/lib/ofp-

Re: [ovs-dev] [PATCH v4 0/3] Testsuite fixes.

2016-03-14 Thread Ben Pfaff
No, I'm happy with it. On Mon, Mar 07, 2016 at 04:01:58PM -0800, Joe Stringer wrote: > This series looks good to me, thanks! > > Ben, did you have any remaining comments? > > On 3 March 2016 at 21:31, Ilya Maximets wrote: > > version 4: > > * Reworked prohibition of parallel execution.

Re: [ovs-dev] [PATCH v3 0/7] Add color output to `ovs-ofctl dump-flows` command

2016-03-14 Thread Ben Pfaff
On Mon, Mar 14, 2016 at 05:17:15PM +0100, Quentin Monnet wrote: > Do the fixes in v3 correctly address Ben's comments [1], or is there > further work to do on this series? I think this is a review week for me, so I'll probably get to this series in a day or two. ___

Re: [ovs-dev] [PATCH] Build Windows include runtime

2016-03-14 Thread Ben Pfaff
On Fri, Feb 26, 2016 at 01:59:10PM +, Alin Serdean wrote: > This patch adds the Visual Studio runtime to the binaries by adding > the code generation compile flags: MT (release version) and MTd (debug > version). > > More on the subject can be found under: > https://msdn.microsoft.com/en-us/li

Re: [ovs-dev] [PATCH v2] ovsdb-idl: improve error handling when schema is not available

2016-03-14 Thread Ben Pfaff
On Wed, Feb 24, 2016 at 10:48:34AM -0500, Lance Richardson wrote: > A common error scenario with OVN is to attempt to use ovn-nbctl when > the OVN databases have not been created in ovsdb-server: >1. ovn-nbctl sends a "get_schema" request for the OVN db to ovsdb-server. >2. ovsdb-server fai

Re: [ovs-dev] [PATCH] Add --enable-jemalloc argument to build

2016-03-14 Thread Ben Pfaff
On Tue, Feb 23, 2016 at 10:21:21PM +, Rodriguez Betancourt, Esteban wrote: > During our tests with OVSDB we found out that memory allocation is > used intensively by the server, so we thought that using a different > memory allocator could increase the performance. We tried jemalloc > and the p

Re: [ovs-dev] [PATCH v3 1/2] datapath: Drop support for kernel older than 3.10

2016-03-14 Thread pravin shelar
On Fri, Mar 11, 2016 at 1:57 PM, Jesse Gross wrote: > On Mon, Feb 29, 2016 at 9:54 AM, Pravin B Shelar wrote: >> diff --git a/FAQ.md b/FAQ.md >> index 8bd7ab9..12ef2fa 100644 >> --- a/FAQ.md >> +++ b/FAQ.md > [...] >> Open vSwitch userspace is not sensitive to the Linux kernel version. >> -

Re: [ovs-dev] [PATCH v4 0/4] Support native dhcp in ovn controller

2016-03-14 Thread Ben Pfaff
On Wed, Mar 09, 2016 at 07:09:55PM +0530, Numan Siddique wrote: > On 12/22/2015 01:31 PM, Ben Pfaff wrote: > > Hi Babu and Numan. > > > > So far, we've been able to build OVN so that the logic of the system is > > implemented in terms of OVN logical flows. That is, the logical flow > > table deter

Re: [ovs-dev] Implementation of Packet-Out in Bundles

2016-03-14 Thread Ben Pfaff
On Wed, Mar 09, 2016 at 09:10:41AM +, André Mantas wrote: > By the way, I'm still starting vswitchd with valgrind and detected some > memory errors after using "sudo ovs-appctl exit". Is there other way to > exit/stop ovs? > > To run I used: valgrind --tool=memcheck --leak-check=full ovs-vswit

Re: [ovs-dev] [PATCH v3 0/7] Add color output to `ovs-ofctl dump-flows` command

2016-03-14 Thread Quentin Monnet
2016-03-02 15:56 GMT+01:00 Quentin Monnet : > Proposal: add an option to ovs-ofctl utility so as to obtain colorized > output > in tty, for easier reading. Currently, only the dump-flows command supports > colors. > > A new `--color` option has been added to ovs-ofctl so as to indicate > whether >

Re: [ovs-dev] What looks like a bug in OVSDB change seqno tracking

2016-03-14 Thread Ben Pfaff
On Tue, Mar 08, 2016 at 11:01:21PM -0600, Ryan Moats wrote: > > > > Ben Pfaff wrote on 03/08/2016 10:07:19 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 03/08/2016 10:07 PM > > Subject: Re: [ovs-dev] What looks like a bug in OVSDB change se

Re: [ovs-dev] How to define enum raw constants for two new vendor actions

2016-03-14 Thread Ben Pfaff
On Mon, Mar 14, 2016 at 06:47:34PM +0530, Ajmer Singh wrote: > Hi, > I have a requirement of adding GTP headers in open Vswitch source code. We > need to define 2 new actions: STRIP_GTP and ENCAP_GTP. these are the > extensions. > > As per openflow specifications 1.0 and 1.1. If we add our 2 new a

Re: [ovs-dev] [PATCH v4 0/3] Testsuite fixes.

2016-03-14 Thread Ilya Maximets
Ping. On 08.03.2016 03:01, Joe Stringer wrote: > This series looks good to me, thanks! > > Ben, did you have any remaining comments? > > On 3 March 2016 at 21:31, Ilya Maximets wrote: >> version 4: >> * Reworked prohibition of parallel execution. >> >> version 3: >> * AT_SKIP_IF

[ovs-dev] [PATCH 10/10] testsuite-pmd: Add PMD specific tests.

2016-03-14 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- tests/automake.mk | 1 + tests/pmd.at | 199 + tests/testsuite-pmd.at | 1 + 3 files changed, 201 insertions(+) create mode 100644 tests/pmd.at diff --git a/tests/automake.mk b/tests/automake.mk

[ovs-dev] [PATCH 08/10] testsuite: Filter out unnecessary info about queues for dummy ports.

2016-03-14 Thread Ilya Maximets
Preparation to multiqueue support for dummy_pmd. Signed-off-by: Ilya Maximets --- tests/bridge.at | 6 +++--- tests/dpctl.at | 8 tests/mpls-xlate.at | 2 +- tests/ofproto-dpif.at| 8 tests/ovs-ofctl.at | 2 +- tests/ovs-vswitchd.at|

[ovs-dev] [PATCH 06/10] automake.mk: New target 'check-pmd'.

2016-03-14 Thread Ilya Maximets
New target 'make check-pmd' introduced to run many of existing tests with new dummy_pmd interfaces. This is reasonable because many parts of code uses pmd_id or alters their behavior for PMD netdevs. Later will be added new PMD specific tests. Signed-off-by: Ilya Maximets --- NEWS

[ovs-dev] [PATCH 04/10] ofproto-dpif.at: Ignore port type while checking result of dpctl/dump-flows.

2016-03-14 Thread Ilya Maximets
Many ofproto-dpif tests works only with non-pmd interfaces because of hard coded output of 'dpctl/dump-flows'. Fix that by clearing out port types. Signed-off-by: Ilya Maximets --- tests/ofproto-dpif.at | 32 1 file changed, 16 insertions(+), 16 deletions(-) di

[ovs-dev] [PATCH 09/10] netdev-dummy: Add fake multiqueue support to dummy_pmd.

2016-03-14 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- lib/netdev-dummy.c | 42 -- 1 file changed, 36 insertions(+), 6 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 4903e56..f427965 100644 --- a/lib/netdev-dummy.c +++ b/lib/netdev-dummy.c @@ -700,9 +70

[ovs-dev] [PATCH 00/10] PMD Testsuite.

2016-03-14 Thread Ilya Maximets
New 'dummy_pmd' class created in purposes of testing of PMD interfaces. Added new target 'make check-pmd' and a bunch of PMD specific tests. Ilya Maximets (10): netdev: New field 'is_pmd' in netdev_class. dummy: Add dummy_pmd class. dpctl: Implement dpctl/flow-get for dpif-netdev. ofproto-

[ovs-dev] [PATCH 01/10] netdev: New field 'is_pmd' in netdev_class.

2016-03-14 Thread Ilya Maximets
Made to simplify creation of derived classes. Signed-off-by: Ilya Maximets --- lib/netdev-bsd.c | 1 + lib/netdev-dpdk.c | 1 + lib/netdev-dummy.c| 1 + lib/netdev-linux.c| 1 + lib/netdev-provider.h | 3 +++ lib/netdev-vport.c| 20 +++- lib/netdev-windo

[ovs-dev] [PATCH 05/10] ofproto-dpif.at: Allow output from all threads in 'patch ports - stack'.

2016-03-14 Thread Ilya Maximets
Ignore thread_name suffix. Signed-off-by: Ilya Maximets --- tests/ofproto-dpif.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index 8868ddd..6a12484 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -6250,7 +62

[ovs-dev] [PATCH 07/10] netdev-dummy: Queue packets only to one rx queue.

2016-03-14 Thread Ilya Maximets
This is unused functionality and it will harm to multiqueue implementation. Signed-off-by: Ilya Maximets --- lib/netdev-dummy.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 0e536e8..4903e56 100644 --- a/li

[ovs-dev] [PATCH 03/10] dpctl: Implement dpctl/flow-get for dpif-netdev.

2016-03-14 Thread Ilya Maximets
Currently 'dpctl/flow-get' doesn't work for flows installed by PMD threads. Fix that by implementing search across all PMD threads. Will be returned flow from first PMD thread with match. Signed-off-by: Ilya Maximets --- lib/dpctl.c | 3 +-- lib/dpif-netdev.c | 49 +++

[ovs-dev] [PATCH 02/10] dummy: Add dummy_pmd class.

2016-03-14 Thread Ilya Maximets
'dummy_pmd' class is a replacement for 'dummy' class. Created in purposes of testing of PMD interfaces. May be activated instead of usual 'dummy' by additional parameter 'pmd' to --enable-dummy. Ex.: ovs-vswitchd --enable-dummy=pmd or ovs-vswitchd --enable-dummy=override,pmd Name

Re: [ovs-dev] [RFC] ovs-ctl: Allow selective start for db and switch

2016-03-14 Thread Ryan Moats
> Currently, ``ovs-ctl start'' will attempt to start both the DB and > vswitchd. This is quite convenient when the database already has all of > the configuration values required, and when using a single services file > for systemd integration. The same goes for the ``ovs-ctl stop'' command. > > H

Re: [ovs-dev] [PATCH v2] ovsdb-idl: improve error handling when schema is not available

2016-03-14 Thread Ryan Moats
- Original Message - > A common error scenario with OVN is to attempt to use ovn-nbctl when > the OVN databases have not been created in ovsdb-server: >1. ovn-nbctl sends a "get_schema" request for the OVN db to ovsdb-server. >2. ovsdb-server fails to find requested db, sends error

[ovs-dev] [PATCH 1/5] ofproto-dpif: rename wait() to avoid collision with system wait(2)

2016-03-14 Thread Lance Richardson
Rename ofproto-dpif wait() to avoid collision with wait(2) under OS X. Signed-off-by: Lance Richardson --- ofproto/ofproto-dpif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index b963ff2..2402a58 100644 --- a/ofproto/of

[ovs-dev] [PATCH 4/5] rtbsd: OS X does not implement RTM_IFANNOUNCE

2016-03-14 Thread Lance Richardson
Conditionally compile code referencing RTM_IFANNOUNCE only for non-OS X builds. Signed-off-by: Lance Richardson --- lib/route-table-bsd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/route-table-bsd.c b/lib/route-table-bsd.c index b5ff3cc..b8c7089 100644 --- a/lib/route-table-bsd.c

[ovs-dev] [PATCH 2/5] timeval: Add clock_gettime() for OS X

2016-03-14 Thread Lance Richardson
OS X does not implement clock_gettime(). Signed-off-by: Lance Richardson --- lib/timeval.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/lib/timeval.c b/lib/timeval.c index d390df1..8190b87 100644 --- a/lib/timeval.c +++ b/lib/timeval.c @@

[ovs-dev] [PATCH 5/5] osx: Temporary compilation workarounds

2016-03-14 Thread Lance Richardson
Base OS X does not implement a tap netdevice, stub out netdev-bsd.c for OS X. OS X rounding/padding rules for rtnetlink messages need to be researched, for now force route_table_fallback_lookup() to return failure on OS X systems. Signed-off-by: Lance Richardson --- lib/netdev-bsd.c | 2 ++ lib

[ovs-dev] [PATCH 0/5] Initial support for OS X builds

2016-03-14 Thread Lance Richardson
Add minimimal support for building under OS X. With this series, "make check" reports: ERROR: 1831 tests were run, 30 failed (1 expected failure). 199 tests were skipped. testsuite: 232 368 394 395 396 397 398 740 910 920 1018 1019 1020 1021 1022 1023 1084 1343 1951 2013 2014 2015 2016 2025 20

[ovs-dev] [PATCH 3/5] utilities: OS X compatibility

2016-03-14 Thread Lance Richardson
Handle OS X like other BSDs (date -r is not supported, use sha1 instead of sha1sum). Signed-off-by: Lance Richardson --- utilities/ovs-pki.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovs-pki.in b/utilities/ovs-pki.in index a96ada3..9b2b5aa 100755 --- a/utilit

Re: [ovs-dev] [PATCH] Add --enable-jemalloc argument to build

2016-03-14 Thread Ryan Moats
"dev" wrote on 03/13/2016 03:48:19 AM: > During our tests with OVSDB we found out that memory allocation is > used intensively by the server, so we thought that using a different > memory allocator could increase the performance. We tried jemalloc > and the performance gain was between 20% and 40

[ovs-dev] How to define enum raw constants for two new vendor actions

2016-03-14 Thread Ajmer Singh
Hi, I have a requirement of adding GTP headers in open Vswitch source code. We need to define 2 new actions: STRIP_GTP and ENCAP_GTP. these are the extensions. As per openflow specifications 1.0 and 1.1. If we add our 2 new actions then following structure will look like as follows. enum ofp_acti