Re: [ovs-dev] [PATCH v6 2/3] [ovn-controller] Make flow table persistent in ovn controller

2016-02-17 Thread Han Zhou
On Wed, Feb 17, 2016 at 10:42 AM, Ryan Moats wrote: > > This is a prerequisite for incremental processing. > > Signed-off-by: Ryan Moats > --- > ovn/controller/ofctrl.c | 118 +++ > ovn/controller/ofctrl.h |2 + > ovn/controller/ovn-contro

Re: [ovs-dev] [OVS-dev]: OVN: RFC re: logical and physical endpoint separation proposal

2016-02-17 Thread Mickey Spiegel
Darrell, Thanks for your replies. A few more questions for clarification. You said: >> There are multiple phys_endpts, one per chassis >> chassis and chassis_port are set per chassis  >> Each localnet port on a chassis is bound to a phys_endpt on that chassis In your earlier reply to Russell,

Re: [ovs-dev] [OVS-dev]: OVN: RFC re: logical and physical endpoint separation proposal

2016-02-17 Thread Darrell Ball
Hi Mickey Thanks for your questions/comments Darrell From: Mickey Spiegel mailto:emspi...@us.ibm.com>> Date: Tuesday, February 16, 2016 at 2:32 PM To: Darrel Ball mailto:db...@vmware.com>> Cc: Russell Bryant mailto:russ...@ovn.org>>, Darrell Lu mailto:dlu...@gmail.com>>, "dev@openvswitch.org

[ovs-dev] Error when using ovs

2016-02-17 Thread zhangyali (D)
Hi All, Recent days, I am using OVS to test my scenario. But I encounter a error when I issue flow tables. The error is: 2016-02-18T01:37:50Z|1|ofp_actions|WARN|invalid instruction ordering: apply_actions must appear before write_metadata, for OpenFlow 1.1+ compatibility 2016-02-18T01:37:5

Re: [ovs-dev] [PATCH v2] tunneling: Disable IPv6 tunnel

2016-02-17 Thread pravin shelar
Thanks for all reviews. I pushed patch to master and branch-2.5. On Tue, Feb 16, 2016 at 2:47 PM, Jesse Gross wrote: > On Thu, Feb 11, 2016 at 1:05 AM, Pravin B Shelar wrote: >> There are multiple issues in IPv6 userspace tunnel >> implementation. Even the kernel module that ships with >> 2.5 do

Re: [ovs-dev] [OVN] Applying ACL changes to existing connections

2016-02-17 Thread Justin Pettit
> On Feb 5, 2016, at 1:30 PM, Russell Bryant wrote: > > > Thank you for the write-up! This approach sounds great to me. Some > small questions... > > 1) If we're only using 1 bit for now, is there any reason to use > ct_label over ct_mark? The docs in ovs-ofctl(8) seem to suggest they're >

[ovs-dev] [PATCH] autoconf: Fix missing AS_VAR_APPEND for version 2.63.

2016-02-17 Thread William Tu
autoconf version 2.63 does not have AS_VAR_APPEND, resulting errors below: tests/testsuite.tmp:3863: error: possibly undefined macro: AS_VAR_APPEND If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. make[2]: *** [tests/testsuite]

[ovs-dev] [PATCH] gcc: Fix compile errors due to anonymous union initilization.

2016-02-17 Thread William Tu
gcc 4.4.7 lets you initialize named fields, and assign to anonymous union members, but cannot statically initialize a named member of an anonymous union. This causes errors when doing make: fproto/fail-open.c: In function ‘send_bogus_packet_ins’: ofproto/fail-open.c:130: error: unknown field ‘pin

[ovs-dev] OVN: VTEP emulator with OVN

2016-02-17 Thread Sid Khot
Hi, I brought up a VTEP emulator and connected it to OVN controller. I can see the VTEP chassis being created in the OVN southbound. I then created a neutron logical vtep port. I don't see any chassis/mac entry for this in OVN southbound port-binding database. I also see the status of this port as

Re: [ovs-dev] [PATCH nf-next v7 6/7] openvswitch: Delay conntrack helper call for new connections.

2016-02-17 Thread Joe Stringer
On 5 February 2016 at 17:41, Jarno Rajahalme wrote: > There is no need to help connections that are not confirmed, so we can > delay helping new connections to the time when they are confirmed. > This change is needed for NAT support, and having this as a separate > patch will make the following N

Re: [ovs-dev] [PATCH nf-next v7 4/7] openvswitch: Find existing conntrack entry after upcall.

2016-02-17 Thread Joe Stringer
On 5 February 2016 at 17:41, Jarno Rajahalme wrote: > /* Determine whether skb->nfct is equal to the result of conntrack lookup. */ > -static bool skb_nfct_cached(const struct net *net, const struct sk_buff *skb, > - const struct ovs_conntrack_info *info) > +static bool

Re: [ovs-dev] [PATCH nf-next v7 5/7] openvswitch: Handle NF_REPEAT in conntrack action.

2016-02-17 Thread Joe Stringer
On 5 February 2016 at 17:41, Jarno Rajahalme wrote: > Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This > avoids dropping a SYN packet re-opening an existing TCP connection. > > Signed-off-by: Jarno Rajahalme Arguably this is a bugfix. Acked-by: Joe Stringer __

Re: [ovs-dev] [PATCH nf-next v7 4/7] openvswitch: Find existing conntrack entry after upcall.

2016-02-17 Thread Joe Stringer
On 5 February 2016 at 17:41, Jarno Rajahalme wrote: > Add a new function ovs_ct_find_existing() to find an existing > conntrack entry for which this packet was already applied to. This is > only to be called when there is evidence that the packet was already > tracked and committed, but we lost t

Re: [ovs-dev] [OVS-dev]: OVN: RFC re: logical and physical endpoint separation proposal

2016-02-17 Thread Darrell Ball
On 2/15/16, 11:24 AM, "dev on behalf of Kyle Mestery" wrote: >On Fri, Jan 29, 2016 at 8:36 PM, Darrell Lu wrote: >> The following is a proposal regarding how to allow logical >> and physical endpoint contexts for OVN to stay separated, from >> a CMS POV. >> >> A logical endpoint has the fo

Re: [ovs-dev] [PATCH 3/3] Handle tunnel set changes for BUM traffic in the vtep emulator

2016-02-17 Thread Darrell Ball
On 2/17/16, 6:40 AM, "Russell Bryant" wrote: >On 02/16/2016 09:26 PM, Darrell Ball wrote: >>> break - -ovs_ofctl("add-flow %s table=1,priority=0,action=%s" +# Handle remote tunnel port set changes +if ((existing_flow == 1) and (appen

Re: [ovs-dev] [PATCHv1 2/4] ovn: Add port_security proposal

2016-02-17 Thread Ryan Moats
> From: Ben Pfaff > > Signed-off-by: Numan Siddique Acked-By: Ryan Moats ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCHv1 4/4] ovn-northd: Add l3 port security for IPv6

2016-02-17 Thread Ryan Moats
> For each lport, adds a priority 90 lflow in ls_in_port_sec and ls_out_port_sec > stages to allow ipv6 traffic for > - known ipv6 addresses > - link local address of the lport > - ip6 packet with ip6.src = :: and > - ip6.dst=ff00::/8 > > Signed-off-by: Numan Siddique Acked-By: Ryan Moats _

Re: [ovs-dev] [PATCH 3/4] ovn-northd: Add l3 port security for IPv4 and ARP

2016-02-17 Thread Ryan Moats
> For every port security defined for a logical port, add following lflows > in "ls_in_port_sec" and "ls_out_port_sec" stage >- A priority 90 flow to allow ipv4 traffic for known ip addresses > and (broadcast ip - for ingress, mainly for dhcp) >- A priority 80 flow to drop all ipv4 tra

Re: [ovs-dev] [PATCHv1 1/4] ovn-northd: Support Logical_Port.addresses to store multiple ips in each set

2016-02-17 Thread Ryan Moats
> If a logical port has two ipv4 addresses and one ipv6 address > it will be stored as ["MAC IPv41 IPv42 IPv61"] instead of > ["MAC IPv41", "MAC IPv42", "MAC IPv61"]. > > Signed-off-by: Numan Siddique Acked-By: Ryan Moats ___ dev mailing list dev@open

[ovs-dev] [PATCH 1/3] tests: Fix MPLS tests.

2016-02-17 Thread Jarno Rajahalme
Some MPLS tests used non-MPLS ethertype for popping a label from a multi-label stack. Also, reveal actions in some MPLS tests. This will make later patches more easily understandable. Fix the mpls-xlate banner and remove '-generate' option from MPLS tests as it is no longer needed to create reci

[ovs-dev] [PATCH 3/3] xlate: Always recirculate after an MPLS POP to a non-MPLS ethertype.

2016-02-17 Thread Jarno Rajahalme
So far we have tried to optimize MPLS POP action not to recirculate unless later matching actually needs the inner headers. This made the code complex and error-prone. Also the cases where this optimization would have been useful seem rare, as one would typically want to do something else with th

[ovs-dev] [PATCH 2/3] odp-util: Format and scan multiple MPLS labels.

2016-02-17 Thread Jarno Rajahalme
So far we have been limited to including only one MPLS label in the textual datapath flow format. Allow upto 3 labels to be included so that testing with multiple labels becomes easier. Signed-off-by: Jarno Rajahalme --- lib/odp-util.c | 77 ++---

Re: [ovs-dev] [PATCH 5/5] datapath: lisp: Relax MTU constraints.

2016-02-17 Thread Jesse Gross
On Wed, Feb 17, 2016 at 10:26 AM, Joe Stringer wrote: > On 16 February 2016 at 12:35, Joe Stringer wrote: >> On 16 February 2016 at 11:43, Jesse Gross wrote: >>> On Tue, Feb 16, 2016 at 10:43 AM, Joe Stringer wrote: diff --git a/datapath/linux/compat/lisp.c b/datapath/linux/compat/lisp.c >

[ovs-dev] [PATCH v6 0/3] [ovn-controller] Add incremental logical flow processing

2016-02-17 Thread Ryan Moats
This series of patches changes lflow_run from processing the entire southbound logical flow table to doing incremental processing each run. Ryan Moats (3): Add useful information to ovn E2E test Make flow table persistent in ovn controller Add incremental processing ovn/controller/lflow.c

[ovs-dev] [PATCH v6 3/3] [ovn-controller] Add incremental processing

2016-02-17 Thread Ryan Moats
This code changes lflow_run to do incremental processing rather than recreating the flow table on each run. Signed-off-by: Ryan Moats --- ovn/controller/lflow.c | 60 +++--- ovn/controller/lflow.h |5 ++- ovn/controller/ovn-controller.c |

[ovs-dev] [PATCH v6 2/3] [ovn-controller] Make flow table persistent in ovn controller

2016-02-17 Thread Ryan Moats
This is a prerequisite for incremental processing. Signed-off-by: Ryan Moats --- ovn/controller/ofctrl.c | 118 +++ ovn/controller/ofctrl.h |2 + ovn/controller/ovn-controller.c |4 +- 3 files changed, 87 insertions(+), 37 deletions(-)

[ovs-dev] [PATCH v6 1/3] [ovn-controller] Add useful information to ovn E2E test

2016-02-17 Thread Ryan Moats
Make test 1737 output the OF flows from all three hypervisors to help in case something goes wrong. Signed-off-by: Ryan Moats --- tests/ovn.at | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index f4117b6..e13a9c3 100644 --- a/test

Re: [ovs-dev] [PATCH 5/5] datapath: lisp: Relax MTU constraints.

2016-02-17 Thread Joe Stringer
On 16 February 2016 at 12:35, Joe Stringer wrote: > On 16 February 2016 at 11:43, Jesse Gross wrote: >> On Tue, Feb 16, 2016 at 10:43 AM, Joe Stringer wrote: >>> diff --git a/datapath/linux/compat/lisp.c b/datapath/linux/compat/lisp.c >>> index e5a6a7fe00a4..0c81dd52ecab 100644 >>> --- a/datapat

Re: [ovs-dev] [PATCH 4/5] datapath: stt: Relax MTU constraints.

2016-02-17 Thread Joe Stringer
On 16 February 2016 at 14:02, Jesse Gross wrote: > On Tue, Feb 16, 2016 at 10:43 AM, Joe Stringer wrote: >> diff --git a/datapath/linux/compat/include/net/stt.h >> b/datapath/linux/compat/include/net/stt.h >> index 28d4dc53c061..aa55c9a0a2a5 100644 >> --- a/datapath/linux/compat/include/net/stt.

Re: [ovs-dev] Implementation of Packet-Out in Bundles

2016-02-17 Thread Jarno Rajahalme
> On Feb 17, 2016, at 2:39 AM, André Mantas wrote: > > Hi. I'm currently adding support for packet-out messages in bundles. > > I started to look at *handle_packet_out*, *handle_bundle_add *and > *do_bundle_commit > *functions to understand how things work. Here is what I did in each > function

[ovs-dev] [PATCH v5 2/3] Add incremental logical flow processing

2016-02-17 Thread Ryan Moats
From: RYAN D. MOATS Make flow table persistent in ovn controller This is a prerequisite for incremental processing. Signed-off-by: RYAN D. MOATS --- ovn/controller/ofctrl.c | 118 +++ ovn/controller/ofctrl.h |2 + ovn/controller/ovn-con

[ovs-dev] [PATCH v5 3/3] Add incremental logical flow processing

2016-02-17 Thread Ryan Moats
From: RYAN D. MOATS This code changes lflow_run to do incremental processing rather than recreating the flow table on each run. Signed-off-by: RYAN D. MOATS --- ovn/controller/lflow.c | 60 +++--- ovn/controller/lflow.h |5 ++- ovn/contro

[ovs-dev] [PATCH v5 1/3] Add incremental logical flow processing

2016-02-17 Thread Ryan Moats
From: RYAN D. MOATS Add useful information to ovn E2E test Make test 1737 output the OF flows from all three hypervisors to help in case something goes wrong. Signed-off-by: RYAN D. MOATS --- tests/ovn.at | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/tes

Re: [ovs-dev] [PATCH 1/2] : 802.1ad support in OVS & OVS-DPDK

2016-02-17 Thread Jesse Gross
In addition, there have been numerous revisions of a previous patch series that implements this. I believe that this is the most recent one: http://openvswitch.org/pipermail/dev/2015-November/061861.html Please work with that author instead of starting from scratch. On Wed, Feb 17, 2016 at 6:49 A

Re: [ovs-dev] [PATCH v8 0/5] Convert DPDK configuration from command line to DB based

2016-02-17 Thread Aaron Conole
"Mooney, Sean K" writes: > Hi sorry to jump back to this mail as I know the v9 patches are in flight. > I was on vacation for the last few days but my responses are inline. > I'll try to look at the revised patches also but I think you have > addressed most of my concerns. The only real differen

Re: [ovs-dev] [PATCH v9 5/6] netdev-dpdk: Check dpdk-extra when reading db

2016-02-17 Thread Aaron Conole
Hey Kevin, Sorry for the late response to this. "Traynor, Kevin" writes: >> -Original Message- >> From: Aaron Conole [mailto:acon...@redhat.com] >> Sent: Thursday, February 11, 2016 8:16 PM >> To: dev@openvswitch.org >> Cc: Flavio Leitner ; Panu Matilainen >> ; >> Traynor, Kevin ; Wojc

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: fix crash when using multicast snooping

2016-02-17 Thread Aaron Conole
Greetings Thadeu, Thadeu Lima de Souza Cascardo writes: > The revalidator thread may set may_learn and call xlate_actions with no packet > data. If the revalidated flow is IGMPv3 or MLD, vswitchd will crash when > trying > to access the NULL packet. > > Only process IGMP and MLD flows when ther

[ovs-dev] [PATCH V6] Add Passive TCP connection to IDL.

2016-02-17 Thread Ofer Ben Yacov
From: Ofer Ben-Yacov Currently the IDL does not support passive TCP connection, i.e. when the OVSDB connects to its manager. This patch enables IDL to use an already-open session (the one which was previously used for retrieving the db schema). In addition, it enables IDL to go back to "listen m

Re: [ovs-dev] [PATCH 1/2] : 802.1ad support in OVS & OVS-DPDK

2016-02-17 Thread Aaron Conole
Apologies for the top post. This post and your subsequent 2/2 have a few flaws: 1. The signed-off-by line is mangled (assuming that is done by your mail client) 2. it appears to be against 2.4 branch (why not against master, should be good to explain this in the scissors section)? 3. The spa

[ovs-dev] [PATCH] ofproto-dpif-xlate: fix crash when using multicast snooping

2016-02-17 Thread Thadeu Lima de Souza Cascardo
The revalidator thread may set may_learn and call xlate_actions with no packet data. If the revalidated flow is IGMPv3 or MLD, vswitchd will crash when trying to access the NULL packet. Only process IGMP and MLD flows when there is a packet. This is a similar behavior than what we have for other s

Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality.

2016-02-17 Thread Stokes, Ian
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Stokes, Ian > Sent: Thursday, February 11, 2016 2:42 PM > To: Flavio Leitner > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v3] netdev_dpdk.c: Add QoS functionality. > > > On Thu, 11 Feb 2016 12

Re: [ovs-dev] [PATCH 3/3] Handle tunnel set changes for BUM traffic in the vtep emulator

2016-02-17 Thread Russell Bryant
On 02/16/2016 09:26 PM, Darrell Ball wrote: >> >>> break >>> - >>> -ovs_ofctl("add-flow %s table=1,priority=0,action=%s" >>> +# Handle remote tunnel port set changes >>> +if ((existing_flow == 1) and (appended_flood_tunnel_port == 1)): >> >>if existing_flow

Re: [ovs-dev] [PATCH] rhel: provide our own SELinux custom policy package

2016-02-17 Thread Aaron Conole
Ansis Atteka writes: > On 16 February 2016 at 07:33, Aaron Conole wrote: > > > Thanks for this work, Ansis! > > Ansis Atteka writes: > > > From: Ansis Atteka > > > > CentOS, RHEL and Fedora distributions ship with their own Open vSwitch > > SELinux policy that is too strict and prevents

Re: [ovs-dev] [ovs-dev,V5] Add Passive TCP connection to IDL.

2016-02-17 Thread Ofer Ben-Yacov
I found the problem. I have few ovs python packages and one of the functions in the dev branch used the installed package instead of the branch's - this is why it worked for me. I will submit a new patch. Ofer. ‫בתאריך יום ג׳, 16 בפבר׳ 2016 ב-18:19 מאת ‪Ofer Ben-Yacov‬‏ <‪ ofer.benya...@gmail.

[ovs-dev] : ovs-appctl dump and flush command for userspace conntrack

2016-02-17 Thread sourabh.bansal
Hi Daniele, Like to contribute the following changes to your userconntrack branch. Please review and provide your comments Change Description: This implementation is based on top of this branch (By Daniele Di Proietto): https://github.com/ddiproietto/ovs/tree/userconntrack_20151115 and this pr

[ovs-dev] [PATCH 2/2] : 802.1ad support in OVS & OVS-DPDK

2016-02-17 Thread gayathri.manepalli
Hi All, Below is the patch for 802.1ad support in OVS-DPDK which is extension to below patch, https://patchwork.ozlabs.org/patch/584074/ // Patch for plain OVS Signed-off-by: Manepalli S Gayathri mailto:gayathri.manepa...@wipro.com>> --- For configuration details, please refer first part o

[ovs-dev] [PATCH 1/2] : 802.1ad support in OVS & OVS-DPDK

2016-02-17 Thread gayathri.manepalli
Hi All, Below are the configuration and patch details which provides the 802.1ad support for OVS. Description & configuration : OVS supports the following port types with respect to configuration and datapath handling. 1. Access 2. Trunk 3. Native-tagged. 4. Native-untagged. Access port adds vlan h

[ovs-dev] [PATCH 1/2] : 802.1ad support in OVS & OVS-DPDK

2016-02-17 Thread gayathri.manepalli
Hi All, Below are the configuration and patch details which provides the 802.1ad support for OVS. Description & configuration : OVS supports the following port types with respect to configuration and datapath handling. 1. Access 2. Trunk 3. Native-tagged. 4. Native-untagged. Access port adds vlan h

[ovs-dev] Implementation of Packet-Out in Bundles

2016-02-17 Thread André Mantas
Hi. I'm currently adding support for packet-out messages in bundles. I started to look at *handle_packet_out*, *handle_bundle_add *and *do_bundle_commit *functions to understand how things work. Here is what I did in each function: *handle_bundle_add:* added if case for OFPTYPE_PACKET_OUT which d

Re: [ovs-dev] [PATCH] ofproto-dpif : propagate may_enable flag as link aliveness

2016-02-17 Thread Markus Magnusson
Hello, Just adding info that the patch is about fixing "OVS seems to be missing an implementation of OFPPS_LIVE in OpenFlow port state ", as acknowledged by Ben in http://openvswitch.org/pipermail/dev/2014-August/044926.html Br

[ovs-dev] Invoice 2016-62857357

2016-02-17 Thread Stacey Joyce
Hi dev, Here's invoice 2016-62857357 for 99,24 USD for last weeks delivery. The amount outstanding of 205,51 USD is due on 23 Feb 2016. If you have any questions, please let us know. Thanks, Stacey Joyce United Stationers Inc. www.unitedstationers.com __

Re: [ovs-dev] Need a probe_interval option for jsonrpc session to southbound ovsdb-server in ovn-controller

2016-02-17 Thread Andy Zhou
On Tue, Feb 16, 2016 at 11:29 PM, Huang, Lei wrote: > Hi Andy, > > I has configured ovn southbound ovsdb-server's inactivity_probe option to > 0 by Open_vSwitch Manger table, and the ovsdb-server doesn’t set inactivity > probe messages anymore. > > But I found ovn-contorller still send inactivity