Re: [ovs-dev] [PATCHv2 10/20] compat: Backport IPv6 fragmentation.

2015-12-10 Thread Simon Horman
Hi Joe, On Wed, Dec 02, 2015 at 11:53:46PM -0800, Joe Stringer wrote: > From: Joe Stringer > > IPv6 fragmentation functionality is not exported by most kernels, so > backport this code from the upstream 4.3 development tree. > > Signed-off-by: Joe Stringer [snip] > diff --git a/datapath/linu

Re: [ovs-dev] [PATCH] datapath: Backport: skbuff: Fix skb checksum partial check.

2015-12-10 Thread Pravin Shelar
On Thu, Dec 10, 2015 at 3:38 PM, Jesse Gross wrote: > On Thu, Dec 10, 2015 at 2:42 PM, Pravin B Shelar wrote: >> This bug fix is not required for OVS use cases. But is it >> nice to keep function consistent with upstream implementation. >> >> Upstream commit: >> >> Earlier patch 6ae459bda tri

Re: [ovs-dev] [PATCH] datapath: Fix STT packet receive handling.

2015-12-10 Thread Pravin Shelar
On Thu, Dec 10, 2015 at 6:44 PM, Joe Stringer wrote: > On 10 December 2015 at 14:19, Pravin B Shelar wrote: >> STT reassembly can generate list of packets. But it was >> handled as a single skb. Following patch fixes it. >> >> Fixes: e23775f20 ("datapath: Add support for lwtunnel"). >> Signed-off

[ovs-dev] [PATCH 2/3] datapath: define compat ip_tunnel_get_link_net()

2015-12-10 Thread Pravin B Shelar
Same as ip_tunnel_get_iflink(), function ip_tunnel_get_link_net() also depends on ip_tunnel structure. So this patch defines compat implementation for same. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/include/net/ip_tunnels.h | 3 +++ datapath/linux/compat/ip_tunnel.c |

[ovs-dev] [PATCH 1/3] datapath: define compat ip_tunnel_get_iflink()

2015-12-10 Thread Pravin B Shelar
ip_tunnel_get_iflink() depends on ip_tunnel structure. But OVS compat layer defines its own ip_tunnel structure which is not compatible with all upstream kernel versions. Therefore we can no use such function. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/include/net/ip_tunnels.h | 2

[ovs-dev] [PATCH 3/3] datapath: compat: Block upstream ip_tunnels functions.

2015-12-10 Thread Pravin B Shelar
Since upstream and compat ip_tunnel structures are not same, we can not use exported upstream functions. Following patch blocks definitions which used ip_tunnel internal structure. Function which do not depend on these structures are allows by explicitly by defining it in the header files. e.g. ipt

Re: [ovs-dev] [PATCH 0/7] Enable NSH based Service Function Chaining support in OVS

2015-12-10 Thread Liu, Mengke
> -Original Message- > From: jgr...@nicira.com [mailto:jgr...@nicira.com] On Behalf Of Jesse > Gross > Sent: Tuesday, December 8, 2015 12:32 AM > To: Liu, Mengke > Cc: dev@openvswitch.org; Pritesh Kothari (pritkoth) ; > Zhou, Danny ; Li, Ricky ; > pa...@cisco.com > Subject: Re: [ovs-dev] [

Re: [ovs-dev] [PATCH] datapath: Fix STT packet receive handling.

2015-12-10 Thread Joe Stringer
On 10 December 2015 at 14:19, Pravin B Shelar wrote: > STT reassembly can generate list of packets. But it was > handled as a single skb. Following patch fixes it. > > Fixes: e23775f20 ("datapath: Add support for lwtunnel"). > Signed-off-by: Pravin B Shelar > --- > datapath/linux/compat/stt.c |

Re: [ovs-dev] [PATCH v2] FAQ: Add entry about different datapaths features.

2015-12-10 Thread Daniele Di Proietto
On 10/12/2015 16:42, "Justin Pettit" wrote: > >> On Dec 10, 2015, at 4:15 PM, Daniele Di Proietto >> wrote: >> >> + * *Hyper-V*: Also known as the windows datapath. > >"Windows" should probably be capitalized. You're right > >Acked-by: Justin Pettit Thanks! Pushed to master and branch-2.5

Re: [ovs-dev] [PATCH v2] FAQ: Add entry about different datapaths features.

2015-12-10 Thread Daniele Di Proietto
On 10/12/2015 17:35, "Joe Stringer" wrote: >On 10 December 2015 at 16:15, Daniele Di Proietto > wrote: >> This is an easy way to keep track of the features supported by the >> different datapaths. >> >> Nithin helped filling the list for the Hyper-V port. >> >> CC: Nithin Raju >> Signed-off-by

Re: [ovs-dev] [PATCH 5/5] xml2nroff: Read whole file instead of line by line.

2015-12-10 Thread Justin Pettit
> On Dec 10, 2015, at 11:29 AM, Russell Bryant wrote: > > The previous code processed the input file line by line, but I think > it looks a little more straight forward to just process the whole file > at once. > > This patch also explicitly closes the file after reading its contents. > > Sign

Re: [ovs-dev] [PATCH 3/5] xml2nroff: Fix issues pointed out by flake8.

2015-12-10 Thread Justin Pettit
> On Dec 10, 2015, at 11:29 AM, Russell Bryant wrote: > > This patch includes a few minor fixes pointed out by the flake8 tool. > It drops an unused variable and the related imports, adds some blank > lines where the PEP8 formatting standard indicates they should be, and > does a comparison with

Re: [ovs-dev] [PATCH 4/5] xml2nroff: Don't use built-in function name.

2015-12-10 Thread Justin Pettit
> On Dec 10, 2015, at 11:29 AM, Russell Bryant wrote: > > Don't use "input" as a variable name, as input is a built-in Python > function. > > Signed-off-by: Russell Bryant Acked-by: Justin Pettit --Justin ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH 2/5] xml2nroff: Don't use import *.

2015-12-10 Thread Justin Pettit
> On Dec 10, 2015, at 11:29 AM, Russell Bryant wrote: > > It's generally considered bad style to do a wildcard import. It makes > it more difficult to figure out where things come from. > > Signed-off-by: Russell Bryant Acked-by: Justin Pettit --Justin _

Re: [ovs-dev] [PATCH 1/5] xml2nroff: Drop duplicated usage().

2015-12-10 Thread Justin Pettit
> On Dec 10, 2015, at 11:29 AM, Russell Bryant wrote: > > The usage() function was included twice. Drop the one that was out of > date. > > Signed-off-by: Russell Bryant That's weird. Acked-by: Justin Pettit --Justin ___ dev mailing list dev

Re: [ovs-dev] [PATCH 0/9] Translation fixes for revalidation

2015-12-10 Thread Daniele Di Proietto
On 10/12/2015 16:27, "Jesse Gross" wrote: >On Thu, Dec 10, 2015 at 4:11 PM, Jarno Rajahalme wrote: >> >>> On Dec 10, 2015, at 3:20 PM, Jesse Gross wrote: >>> >>> On Wed, Dec 9, 2015 at 6:27 PM, Daniele Di Proietto >>> wrote: Sometimes the ofproto layer creates a flow which is not liked

Re: [ovs-dev] [ovs] ovn-nbctl:add db commands help (#93)

2015-12-10 Thread Justin Pettit
> On Dec 10, 2015, at 9:49 AM, Russell Bryant wrote: > > It looks like xml.dom.minidom doesn't support it. We'd have to manually > implement the interpretation of xi:include. That might be OK for our > limited usage since we only care about href="" to a local file and not > the full set of pos

[ovs-dev] [PATCH 3/5] ovsdb: perf counters

2015-12-10 Thread William Tu
perf counters are used by ovsdb_txn_commit(), which can be called while opening a database file. This means we have to move the call to perf_counters_init() before. Failed cases of Valgrind: 104, 106, 107 Signed-off-by: William Tu Signed-off-by: Daniele Di Proietto Co-authored-by: Daniele Di Pr

[ovs-dev] [PATCH 4/5] ofp-actions: Add padding in ofpacts_pull_openflow_instructions()

2015-12-10 Thread William Tu
ofpacts_pull_openflow_instructions() should fill 'ofpacts' with a list of OpenFlow actions and each action (including the last one) should be padded to OFP_ACTION_ALIGN(8) bytes. In most of the cases this is taken care of (e.g. by ofpacts_decode), but for the Goto-Table instruction (and Clear-Acti

[ovs-dev] [PATCH 5/5] tests: add Valgrind suppression file ovs.supp

2015-12-10 Thread William Tu
Signed-off-by: William Tu --- tests/automake.mk | 3 +- tests/ovs.supp| 86 +++ 2 files changed, 88 insertions(+), 1 deletion(-) create mode 100644 tests/ovs.supp diff --git a/tests/automake.mk b/tests/automake.mk index bd06a51..1b218da 1

[ovs-dev] [PATCH 1/5] tests: fix memory leak reported by valgrind

2015-12-10 Thread William Tu
Fix some of the "definitely loss" cases reported by Valgrind. Signed-off-by: William Tu Signed-off-by: Daniele Di Proietto Co-authored-by: Daniele Di Proietto --- lib/db-ctl-base.c | 1 + lib/odp-util.c | 21 + lib/ofp-parse.c| 5 - lib/ofp-print.

[ovs-dev] [PATCH 2/5] test-classifier: Use `in_port.ofp_port`, instead of `in_port`

2015-12-10 Thread William Tu
The test uses 16-bit ofp_port_t, however the struct flow member `in_port` is 32-bit, causing a memcpy to read uninitialized data. We should restrict the test to the `ofp_port` member of the `in_port` union Signed-off-by: William Tu Signed-off-by: Daniele Di Proietto Co-authored-by: Daniele Di Pr

[ovs-dev] [PATCH] ovn-controller: Add clarifying comment about main loop in binding_run().

2015-12-10 Thread Justin Pettit
Signed-off-by: Justin Pettit --- ovn/controller/binding.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ovn/controller/binding.c b/ovn/controller/binding.c index 7f31b31..8461df6 100644 --- a/ovn/controller/binding.c +++ b/ovn/controller/binding.c @@ -151,6 +151,9 @@ binding_run(struct c

Re: [ovs-dev] [PATCH] ovn: Fix ACLs for child logical ports.

2015-12-10 Thread Justin Pettit
Thanks for fixing this. It might be nice to include a comment such as the following since it's not super obvious from a quick look what's being added: /* Add child logical port to the set of all local ports. */ Acked-by: Justin Pettit I'd suggest cherry-picking this to "branch-2.5", too. --J

Re: [ovs-dev] [PATCH 6/9] odp-util: Correctly [de]serialize mask for ND attributes.

2015-12-10 Thread Daniele Di Proietto
On 10/12/2015 15:16, "Jarno Rajahalme" wrote: >With the comment below, > >Acked-by: Jarno Rajahalme > >> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto >> wrote: >> >> When converting between ODP attributes and struct flow_wildcards, we >> check that all the prerequisites are exact matched o

[ovs-dev] Avoid fakes, Get World Brand Meds

2015-12-10 Thread Mohammed
96 Man, getting a huge bone-on for drilling your girl will be easier than parking a car! p{margin:10px 0;padding:0;} table{border-collapse:collapse;} h1,h2,h3,h4,h5,h6{display:block;margin:0;padding:0;} img,a img{border:0;height:auto;outline:none;text-decoration:none;} body,#bodyTab

Re: [ovs-dev] [PATCH 5/9] odp-util: Return exact mask if netlink mask attribute is missing.

2015-12-10 Thread Daniele Di Proietto
Thanks, pushed to master and branch-2.5 On 10/12/2015 15:08, "Jarno Rajahalme" wrote: >Awesome, > >Acked-by: Jarno Rajahalme > >> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto >> wrote: >> >> In the ODP context an empty mask netlink attribute usually means that >> the flow should be an exact

Re: [ovs-dev] [PATCH 4/9] odp-util: Commit ICMP set only for ICMP packets.

2015-12-10 Thread Daniele Di Proietto
On 10/12/2015 14:57, "Jarno Rajahalme" wrote: >With a note below, > >Acked-by: Jarno Rajahalme > >> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto >> wrote: >> >> commit_set_icmp_action() should do its job only if the packet is ICMP, >> otherwise there will be two problems: >> >> * A set IC

Re: [ovs-dev] [PATCH 3/9] tnl-ports: Generate mask with correct prerequisites.

2015-12-10 Thread Daniele Di Proietto
On 10/12/2015 14:47, "Jarno Rajahalme" wrote: > >> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto >> wrote: >> >> We should match on the transport ports only if the tunnel has a UDP >> header. It doesn't make sense to match on transport port for GRE >> tunnels. >> >> Also, to match on fragm

Re: [ovs-dev] [PATCH 2/9] ofproto-dpif-xlate: Fix revalidation in execute_controller_action().

2015-12-10 Thread Daniele Di Proietto
On 10/12/2015 14:42, "Jarno Rajahalme" wrote: > >> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto >> wrote: >> >> If there's no actual packet (e.g. during revalidation), >> execute_controller_action() exits right away, without calling >> xlate_commit_actions(). >> >> xlate_commit_actions() m

Re: [ovs-dev] [PATCH 1/9] dpif-netdev: Initialize match.tun_md in various places.

2015-12-10 Thread Daniele Di Proietto
Pushed to master and branch-2.5 On 10/12/2015 14:37, "Jarno Rajahalme" wrote: >Acked-by: Jarno Rajahalme Thanks! > >> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto >> wrote: >> >> This solves a crash in dp_netdev_flow_add(), when log level is debug. >> >> Signed-off-by: Daniele Di Proiett

Re: [ovs-dev] [PATCH 1/2] datapath: Respect conntrack zone even if invalid.

2015-12-10 Thread Joe Stringer
On 10 December 2015 at 14:20, Pravin Shelar wrote: > On Tue, Dec 8, 2015 at 4:14 PM, Joe Stringer wrote: >> If userspace executes ct(zone=1), and the connection tracker determines >> that the packet is invalid, then the ct_zone flow key field is populated >> with the default zone rather than the

Re: [ovs-dev] [PATCH v2] FAQ: Add entry about different datapaths features.

2015-12-10 Thread Joe Stringer
On 10 December 2015 at 16:15, Daniele Di Proietto wrote: > This is an easy way to keep track of the features supported by the > different datapaths. > > Nithin helped filling the list for the Hyper-V port. > > CC: Nithin Raju > Signed-off-by: Daniele Di Proietto > Acked-by: Ben Pfaff > Acked-by

Re: [ovs-dev] [PATCH] datapath: Fix STT packet receive handling.

2015-12-10 Thread Jesse Gross
On Thu, Dec 10, 2015 at 2:19 PM, Pravin B Shelar wrote: > STT reassembly can generate list of packets. But it was > handled as a single skb. Following patch fixes it. > > Fixes: e23775f20 ("datapath: Add support for lwtunnel"). > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross

Re: [ovs-dev] [PATCH 08/14] actions: Implement OVN "arp" action.

2015-12-10 Thread Justin Pettit
> On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote: > > An upcoming commit will use this as a building block in adding ARP support > to the OVN L3 logical router implementation. Assuming that we don't switch to the controller generating ARP requests: Acked-by: Justin Pettit --Justin ___

Re: [ovs-dev] [PATCH 07/14] actions: Factor parsing a single action into a new function parse_action().

2015-12-10 Thread Justin Pettit
Acked-by: Justin Pettit --Justin > On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote: > > This will have another user in an upcoming commit. > > Signed-off-by: Ben Pfaff > --- > ovn/lib/actions.c | 70 +++ > 1 file changed, 39 insertions(+), 31 d

Re: [ovs-dev] [PATCH 06/14] actions: Factor out new helper function add_prerequisite().

2015-12-10 Thread Justin Pettit
Acked-by: Justin Pettit --Justin > On Dec 8, 2015, at 5:08 PM, Ben Pfaff wrote: > > This will acquire new users in upcoming commits. > > Signed-off-by: Ben Pfaff > --- > ovn/lib/actions.c | 24 +++- > 1 file changed, 15 insertions(+), 9 deletions(-) > > diff --git a/ovn/

Re: [ovs-dev] [PATCH v2] FAQ: Add entry about different datapaths features.

2015-12-10 Thread Justin Pettit
> On Dec 10, 2015, at 4:15 PM, Daniele Di Proietto > wrote: > > + * *Hyper-V*: Also known as the windows datapath. "Windows" should probably be capitalized. Acked-by: Justin Pettit Thanks for putting this together! --Justin ___ dev mailing l

Re: [ovs-dev] [PATCH 0/9] Translation fixes for revalidation

2015-12-10 Thread Jesse Gross
On Thu, Dec 10, 2015 at 4:11 PM, Jarno Rajahalme wrote: > >> On Dec 10, 2015, at 3:20 PM, Jesse Gross wrote: >> >> On Wed, Dec 9, 2015 at 6:27 PM, Daniele Di Proietto >> wrote: >>> Sometimes the ofproto layer creates a flow which is not liked by the >>> revalidation for various reasons. This be

Re: [ovs-dev] [PATCH 0/9] Translation fixes for revalidation

2015-12-10 Thread Jarno Rajahalme
> On Dec 10, 2015, at 4:11 PM, Jarno Rajahalme wrote: > > >> On Dec 10, 2015, at 3:20 PM, Jesse Gross wrote: >> >> On Wed, Dec 9, 2015 at 6:27 PM, Daniele Di Proietto >> wrote: >>> Sometimes the ofproto layer creates a flow which is not liked by the >>> revalidation for various reasons. Thi

Re: [ovs-dev] [PATCH 8/9] ofproto-dpif-xlate: Don't unwildcard tunnel attributes on set.

2015-12-10 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto > wrote: > > When translating a set action we also unwildcard the field in question. > This is done to correctly translate set actions with the value identical > to the ingress flow, like in the following example: > >

[ovs-dev] [PATCH v2] FAQ: Add entry about different datapaths features.

2015-12-10 Thread Daniele Di Proietto
This is an easy way to keep track of the features supported by the different datapaths. Nithin helped filling the list for the Hyper-V port. CC: Nithin Raju Signed-off-by: Daniele Di Proietto Acked-by: Ben Pfaff Acked-by: Nithin Raju --- v1 -> v2: * Mention FreeBSD and NetBSD in the userspac

Re: [ovs-dev] [PATCH] FAQ: Add entry about different datapaths features.

2015-12-10 Thread Daniele Di Proietto
On 08/12/2015 10:11, "Joe Stringer" wrote: > > >On 7 December 2015 at 13:00, Daniele Di Proietto > wrote: > >This is an easy way to keep track of the features supported by the >different datapaths. > >Nithin helped filling the list for the Hyper-V port. > >CC: Nithin Raju >Signed-off-by: Daniel

Re: [ovs-dev] [PATCH 0/9] Translation fixes for revalidation

2015-12-10 Thread Jarno Rajahalme
> On Dec 10, 2015, at 3:20 PM, Jesse Gross wrote: > > On Wed, Dec 9, 2015 at 6:27 PM, Daniele Di Proietto > wrote: >> Sometimes the ofproto layer creates a flow which is not liked by the >> revalidation for various reasons. This behavior, while not critical >> might impact the performance. Th

Re: [ovs-dev] [PATCH 9/9] ofproto-dpif-xlate: Do not include non existing MPLS lse in wc.

2015-12-10 Thread Jarno Rajahalme
> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto > wrote: > > An action list like > > actions=push_mpls:0x8847,load:10->OXM_OF_MPLS_LABEL[] > > will generate an exact match on the newly pushed mpls label, because the > load action needs to unwildcard its target to work properly. This > does

Re: [ovs-dev] [PATCH] FAQ: Add entry about different datapaths features.

2015-12-10 Thread Daniele Di Proietto
On 09/12/2015 02:45, "Gray, Mark D" wrote: >> From: Justin Pettit [mailto:jpet...@ovn.org] >> Sent: Tuesday, December 8, 2015 5:03 PM >> >> > On Dec 8, 2015, at 1:01 AM, Gray, Mark D >>wrote: >> > >> >> +Feature | Linux upstream | Linux OVS tree | Userspace >>| Hyper-V >> | >> >

Re: [ovs-dev] [PATCH 8/9] ofproto-dpif-xlate: Don't unwildcard tunnel attributes on set.

2015-12-10 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto > wrote: > > When translating a set action we also unwildcard the field in question. > This is done to correctly translate set actions with the value identical > to the ingress flow, like in the following example: > >

Re: [ovs-dev] [PATCH 7/9] ofproto-dpif-xlate: Generate right mask when checking prereqs.

2015-12-10 Thread Jarno Rajahalme
> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto > wrote: > > During translation we need to unwildcard each member of the flow that we > look at. When setting or moving a field, we need to look at (and > consequently unwildcard) the field itself an all the prerequisites. > > The current code

Re: [ovs-dev] [PATCH] datapath: Backport: skbuff: Fix skb checksum partial check.

2015-12-10 Thread Jesse Gross
On Thu, Dec 10, 2015 at 2:42 PM, Pravin B Shelar wrote: > This bug fix is not required for OVS use cases. But is it > nice to keep function consistent with upstream implementation. > > Upstream commit: > > Earlier patch 6ae459bda tried to detect void ckecksum partial > skb by comparing pul

Re: [ovs-dev] [PATCH 0/9] Translation fixes for revalidation

2015-12-10 Thread Jesse Gross
On Wed, Dec 9, 2015 at 6:27 PM, Daniele Di Proietto wrote: > Sometimes the ofproto layer creates a flow which is not liked by the > revalidation for various reasons. This behavior, while not critical > might impact the performance. This series aims to fix a lot of these > bugs. > > The detection

Re: [ovs-dev] [PATCH 6/9] odp-util: Correctly [de]serialize mask for ND attributes.

2015-12-10 Thread Jarno Rajahalme
With the comment below, Acked-by: Jarno Rajahalme > On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto > wrote: > > When converting between ODP attributes and struct flow_wildcards, we > check that all the prerequisites are exact matched on the mask. > > For ND(ICMPv6) attributes, an exact matc

[ovs-dev] Payment Nr: 78166191/AE0F0967

2015-12-10 Thread Jamey Simmons
Dear Client, Our finance department has processed your payment, unfortunately it has beendeclined. Please, double check the information provided in the invoice downbelow and confirm your details. Thank you for understanding. ___ dev mailing list dev@o

Re: [ovs-dev] [PATCH 5/9] odp-util: Return exact mask if netlink mask attribute is missing.

2015-12-10 Thread Jarno Rajahalme
Awesome, Acked-by: Jarno Rajahalme > On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto > wrote: > > In the ODP context an empty mask netlink attribute usually means that > the flow should be an exact match. > > odp_flow_key_to_mask{,_udpif}() instead return a struct flow_wildcards > with match

Re: [ovs-dev] [PATCH 4/9] odp-util: Commit ICMP set only for ICMP packets.

2015-12-10 Thread Jarno Rajahalme
With a note below, Acked-by: Jarno Rajahalme > On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto > wrote: > > commit_set_icmp_action() should do its job only if the packet is ICMP, > otherwise there will be two problems: > > * A set ICMP action will be inserted in the ODP actions and the flow

Re: [ovs-dev] [PATCH 3/9] tnl-ports: Generate mask with correct prerequisites.

2015-12-10 Thread Jarno Rajahalme
> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto > wrote: > > We should match on the transport ports only if the tunnel has a UDP > header. It doesn't make sense to match on transport port for GRE > tunnels. > > Also, to match on fragment bits we should use FLOW_NW_FRAG_MASK instead > of 0xF

[ovs-dev] [PATCH] datapath: Backport: skbuff: Fix skb checksum partial check.

2015-12-10 Thread Pravin B Shelar
This bug fix is not required for OVS use cases. But is it nice to keep function consistent with upstream implementation. Upstream commit: Earlier patch 6ae459bda tried to detect void ckecksum partial skb by comparing pull length to checksum offset. But it does not work for all cases s

Re: [ovs-dev] [PATCH 2/9] ofproto-dpif-xlate: Fix revalidation in execute_controller_action().

2015-12-10 Thread Jarno Rajahalme
> On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto > wrote: > > If there's no actual packet (e.g. during revalidation), > execute_controller_action() exits right away, without calling > xlate_commit_actions(). > > xlate_commit_actions() might have an influence on slow_path reason > (which is in

Re: [ovs-dev] [PATCH 1/9] dpif-netdev: Initialize match.tun_md in various places.

2015-12-10 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On Dec 9, 2015, at 6:27 PM, Daniele Di Proietto > wrote: > > This solves a crash in dp_netdev_flow_add(), when log level is debug. > > Signed-off-by: Daniele Di Proietto > --- > lib/dpif-netdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/dpif-

Re: [ovs-dev] [PATCH 2/2] datapath: Define nf_connlabels_{put, get}.

2015-12-10 Thread Pravin Shelar
On Tue, Dec 8, 2015 at 4:14 PM, Joe Stringer wrote: > Previously this was only done when connlabels were enabled in the kernel > config, even if the functions didn't exist. Fix the compile error. > > Reported-by: Simon Horman > Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar Thanks. ___

Re: [ovs-dev] [PATCH 1/2] datapath: Respect conntrack zone even if invalid.

2015-12-10 Thread Pravin Shelar
On Tue, Dec 8, 2015 at 4:14 PM, Joe Stringer wrote: > If userspace executes ct(zone=1), and the connection tracker determines > that the packet is invalid, then the ct_zone flow key field is populated > with the default zone rather than the zone that was specified. Even > though connection trackin

[ovs-dev] [PATCH] datapath: Fix STT packet receive handling.

2015-12-10 Thread Pravin B Shelar
STT reassembly can generate list of packets. But it was handled as a single skb. Following patch fixes it. Fixes: e23775f20 ("datapath: Add support for lwtunnel"). Signed-off-by: Pravin B Shelar --- datapath/linux/compat/stt.c | 28 ++-- 1 file changed, 22 insertions(+),

[ovs-dev] [PATCH] Fix broken sed

2015-12-10 Thread Alin Serdean
Patch 43000bc introduced a portability improvement. This patch adds the command for $SED 's' and also changes to x86 for 32 bit instead of x64. Signed-off-by: Alin Gabriel Serdean --- m4/openvswitch.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/openvswitch.m4 b/m

Re: [ovs-dev] [PATCH net-next v4 2/8] netfilter: Factor out nf_ct_get_info().

2015-12-10 Thread Jarno Rajahalme
> On Dec 10, 2015, at 11:14 AM, Pablo Neira Ayuso wrote: > > On Tue, Dec 08, 2015 at 05:01:04PM -0800, Jarno Rajahalme wrote: >> Define a new inline function to map conntrack status to enum >> ip_conntrack_info. This removes the need to otherwise duplicate this >> code in a later patch ("openvs

[ovs-dev] [PATCH] match: Add support for matching IGMP fields.

2015-12-10 Thread Jarno Rajahalme
Complete the IGMP protocol support by making IGMP fields (type, code, and group) matchable via OpenFlow by the way of new Nicira extensions. The new fields are: 8-bit NXM_NX_IGMP_TYPE (111), 8-bit NXM_NX_IGMP_CODE (112), and 32-bit NXM_NX_IGMP_GROUP (113). VMware-BZ: #1558992 Signed-off-by: Jarno

Re: [ovs-dev] [PATCH] datapath-windows: remove ASSERT in OvsDoFlowLookupOutput()

2015-12-10 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean Thanks, Alin. > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > Trimis: Thursday, December 10, 2015 9:17 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH] datapath-windows: remove ASSERT in > OvsDoFlowLo

[ovs-dev] Payment Request, Ref. nr: 57142962/2015

2015-12-10 Thread Katie Hebert
Dear Valued Client, The purpose of this e-mail is to follow up with you on a matter of your paymentof invoice #48EDB7B3 with a Ref. nr: 57142962/2015. As of today, your outstanding pastdue balance is -$7,558, as detailed on the statement and account reportattached to this e-mail. To keep your a

[ovs-dev] [PATCH 3/5] xml2nroff: Fix issues pointed out by flake8.

2015-12-10 Thread Russell Bryant
This patch includes a few minor fixes pointed out by the flake8 tool. It drops an unused variable and the related imports, adds some blank lines where the PEP8 formatting standard indicates they should be, and does a comparison with None as "is None" instead of "== None". Signed-off-by: Russell Br

[ovs-dev] [PATCH 2/5] xml2nroff: Don't use import *.

2015-12-10 Thread Russell Bryant
It's generally considered bad style to do a wildcard import. It makes it more difficult to figure out where things come from. Signed-off-by: Russell Bryant --- build-aux/xml2nroff | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/build-aux/xml2nroff b/build-aux/xml2

[ovs-dev] [PATCH 4/5] xml2nroff: Don't use built-in function name.

2015-12-10 Thread Russell Bryant
Don't use "input" as a variable name, as input is a built-in Python function. Signed-off-by: Russell Bryant --- build-aux/xml2nroff | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/build-aux/xml2nroff b/build-aux/xml2nroff index 314a5e1..d55a0d3 100755 --- a/build-aux/xm

[ovs-dev] [PATCH 5/5] xml2nroff: Read whole file instead of line by line.

2015-12-10 Thread Russell Bryant
The previous code processed the input file line by line, but I think it looks a little more straight forward to just process the whole file at once. This patch also explicitly closes the file after reading its contents. Signed-off-by: Russell Bryant --- build-aux/xml2nroff | 12 +--- 1

[ovs-dev] [PATCH 1/5] xml2nroff: Drop duplicated usage().

2015-12-10 Thread Russell Bryant
The usage() function was included twice. Drop the one that was out of date. Signed-off-by: Russell Bryant --- build-aux/xml2nroff | 12 1 file changed, 12 deletions(-) diff --git a/build-aux/xml2nroff b/build-aux/xml2nroff index 1f8519a..127d4cc 100755 --- a/build-aux/xml2nroff ++

[ovs-dev] [PATCH 0/5] xml2nroff minor cleanups.

2015-12-10 Thread Russell Bryant
Here's a set of clenups I made while looking at xml2nroff while discussing adding something to it in another thread. [PATCH 1/5] xml2nroff: Drop duplicated usage(). [PATCH 2/5] xml2nroff: Don't use import *. [PATCH 3/5] xml2nroff: Fix issues pointed out by flake8. [PATCH 4/5] xml2nroff: Don't use

[ovs-dev] [PATCH] datapath-windows: remove ASSERT in OvsDoFlowLookupOutput()

2015-12-10 Thread Nithin Raju
We needed this ASSERT earlier to catch unexpected cases. This code seems to be fairly stable, and we can remove the ASSERT. It is annoying to be hitting this ASSERT while changing the internal adapter properties. Signed-off-by: Nithin Raju --- datapath-windows/ovsext/Actions.c | 1 - 1 file cha

Re: [ovs-dev] [PATCH net-next v4 2/8] netfilter: Factor out nf_ct_get_info().

2015-12-10 Thread Pablo Neira Ayuso
On Tue, Dec 08, 2015 at 05:01:04PM -0800, Jarno Rajahalme wrote: > Define a new inline function to map conntrack status to enum > ip_conntrack_info. This removes the need to otherwise duplicate this > code in a later patch ("openvswitch: Find existing conntrack entry > after upcall."). > > Signed

Re: [ovs-dev] [PATCH net-next v4 8/8] openvswitch: Interface with NAT.

2015-12-10 Thread Pablo Neira Ayuso
On Tue, Dec 08, 2015 at 05:01:10PM -0800, Jarno Rajahalme wrote: > - /* Call the helper right after nf_conntrack_in() for confirmed > - * connections, but only when commiting for unconfirmed connections. > - */ > ct = nf_ct_get(skb, &ctinfo); > - if (ct && (nf_ct_is_confirme

Re: [ovs-dev] [PATCH 3/3 v2] datapath-windows: Add GRE TEB support for windows datapath

2015-12-10 Thread Nithin Raju
Hi Alin, I’ve replied to comments where you had a question. Will wait for the v3. -Original Message- From: Alin Serdean Date: Thursday, December 10, 2015 at 9:10 AM To: Nithin Raju , "dev@openvswitch.org" Subject: RE: [ovs-dev] [PATCH 3/3 v2] datapath-windows: Add GRE TEB support for win

Re: [ovs-dev] [PATCH] datapath-windows: reduce padding size in _OVS_PACKET_HDR_INFO

2015-12-10 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Tuesday, December 8, 2015 9:06 PM > Către: Nithin Raju ; dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] datapath-windows: reduce padding size i

Re: [ovs-dev] [PATCH] datapath-windows: Fix broken build

2015-12-10 Thread Alin Serdean
Oops. I did not saw patch: https://patchwork.ozlabs.org/patch/554961/. This patch can be dropped. > -Mesaj original- > De la: Alin Serdean > Trimis: Thursday, December 10, 2015 6:03 PM > Către: dev@openvswitch.org > Cc: Alessandro Pilotti ; Alin Serdean > > Subiect: [PATCH] datapath-wind

Re: [ovs-dev] [PATCH] datapath-windows: Fix compilation issue

2015-12-10 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju > Trimis: Thursday, December 10, 2015 3:35 AM > Către: Sairam Venugopal ; dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Fix compilation issue

Re: [ovs-dev] [ovs] ovn-nbctl:add db commands help (#93)

2015-12-10 Thread Russell Bryant
On 12/09/2015 10:43 PM, Wei Li wrote: > 在 2015/12/8 22:57, Russell Bryant 写道: >> On 12/08/2015 01:06 AM, Wei Li wrote: >>> >>> 在 2015/12/7 23:30, Russell Bryant 写道: Can you update the man page, as well? >>> I would like to do this,but have a question >>> >>> There is a reference to /db-ct

[ovs-dev] [PATCH] ovn: Use constants for conntrack state bits.

2015-12-10 Thread Russell Bryant
A previous commit fixed this code to match changes to the conntrack state bit assignments. This patch further updates the code to use the defined constants to ensure this code adapts automatically to any possible future changes. Signed-off-by: Russell Bryant Requested-by: Joe Stringer --- lib/

Re: [ovs-dev] [PATCH 3/3 v2] datapath-windows: Add GRE TEB support for windows datapath

2015-12-10 Thread Alin Serdean
Thanks for the review Nithin trimming the reply a bit so we have more visibility. Regarding the sequence number, I was keeping in mind GRE64 supported by OVS but that is deprecated now so we can remove it. > >+RtlZeroMemory(grePort, sizeof(*grePort)); > >+grePort->dstPort = udpDestPort

[ovs-dev] [PATCH v2] ovsdb-idl: Add support for column tracking in IDL

2015-12-10 Thread Ansari, Shad
(Resending patch with corrected Signed-off-by email address) Recent IDL change tracking patches allow quick traversal of changed rows. This patch adds additional support to track changed columns. It allows an IDL client to efficiently check if a specific column of a row was updated by IDL. Signed

[ovs-dev] [PATCH] datapath-windows: Fix broken build

2015-12-10 Thread Alin Serdean
Fix broken compilation in Debug/Release versions introduced by commit 4ac0645. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c inde

[ovs-dev] set -controller is causing the kernel crash with DPDK 2.0 + OVS 2.4

2015-12-10 Thread karuppusamy.marappagounder
Hi, In our experiment we are using OVS 2.4 with DPDK 2.0 with Centos 7.0 + kernel 3.18.22. We added few physical ports to the PMD thread and added to the bridge. Also created KNI interface between vEth and the physical port part of the bridge. We could send and receive the traffic v

[ovs-dev] Reference Number #13845256, Last Payment Notice

2015-12-10 Thread Vanessa Vaughan
Dear Client, This e-mail is pursuant to your contract with Foreman&Clark Ltd. for ourservices date November 15, 2015 for the amount of $7,280. Your failure to pay asper the December 1, 2015 invoice equals to the breach of our contract. Please, acknowledge the receipt of this e-mail within three

[ovs-dev] [PATCH] ovsdb-idl: Add support for column tracking in IDL

2015-12-10 Thread Ansari, Shad
Recent IDL change tracking patches allow quick traversal of changed rows. This patch adds additional support to track changed columns. It allows an IDL client to efficiently check if a specific column of a row was updated by IDL. Signed-off-by: Shad Ansari --- lib/ovsdb-idl-provider.h | 4 ++-

[ovs-dev] Mail System Error - Returned Mail

2015-12-10 Thread fridavo
This message was not delivered due to the following reason(s): Your message could not be delivered because the destination computer was unreachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likel