Re: [ovs-dev] Combining monitor2 and monitor_cond methods

2015-11-04 Thread Liran Schour
Andy Zhou wrote on 04/11/2015 05:20:08 PM: > From: Andy Zhou > To: Liran Schour/Haifa/IBM@IBMIL > Cc: dev > Date: 04/11/2015 05:20 PM > Subject: Re: Combining monitor2 and monitor_cond methods > > On Wed, Nov 4, 2015 at 5:22 AM, Liran Schour wrote: > > In order not to have 2 new monitor metho

[ovs-dev] Status

2015-11-04 Thread Post Office
Ù£œ›sV‚/]O)EԈNÔ.¤ñ{LÖÁ^qc 1†ßµ÷]aڍ3°»TŒvjßü§Þ'p匢¡Ô¶Å}یLrÁûQ™µAÃcÜQ–áÍuYÌ6ë¥È àöµltˆÈp¡Pðn.rИ}ÏzÑVݟ'†ãí¡*ü¢•©yQY¡G1¬¦í<Ç/ú”‚KnßJb҅ b­­I²bìsÉ|^RY97´·œŽp\ìßÝf3‰X; ֚³øQ}ʶ¢óPíú¬¨½/'òSºgìCÖ1¿Fãt©jóÒÅÍâRAP¼Î2äAðP h7‘õýSRÄNí¾×ö“eêBäó;"¯­¨÷Ü&҂T·åI%WÃ'‰ýä͘–³ò¿ê<¡Æ²ãöyêñRZݟL}æ4ªbŸV3  ©

[ovs-dev] report

2015-11-04 Thread Mail Administrator
The original message was received at Thu, 5 Nov 2015 10:37:37 +0530 from [119.216.73.176] - The following addresses had permanent fatal errors - dev@openvswitch.org ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listi

Re: [ovs-dev] [PATCH 1/2] lib: simplify daemon_become_new_user__()

2015-11-04 Thread Ansis Atteka
On Sat, Oct 10, 2015 at 1:07 AM, Andy Zhou wrote: > Global variable 'switch_user' is no longer needed to make sure > user switch only happens once per process. Testing for uid directly > simplifies the logic; if switch process has taken place, then the > currnet uid can not be zero. s/currnet/curr

Re: [ovs-dev] [PATCH 6/6] ofproto: Enable in-place modification for recirc actions.

2015-11-04 Thread Joe Stringer
On 28 October 2015 at 20:07, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme Looks ok to me. I have some minor style/doc suggestions at the end of the mail. In revalidate(), the way that 'recircs' is only initialised in some paths, then in an overlapping set of paths passed to reval_op_

[ovs-dev] OVS bridges always report UP + hotplugging support?

2015-11-04 Thread Karol Mroz
Hello, Support for configuring OVS bridges has been added to our (SUSE) network manager. During test (OVS 2.1.2, kernel 3.12.x), a couple things have been uncovered that I'd love to get some feedback on. 1. OVS bridges appear to report up state, regardless if this is true. For example, up is repo

[ovs-dev] OVN ACLs and DHCP

2015-11-04 Thread Russell Bryant
I mentioned before that I had some trouble getting DHCP working with OVN ACLs enabled. I think I have finally gotten to the bottom of it. My first workaround was a brute force patch to bypass conntrack if the packet was a DHCP request or response. That worked, but I wasn't able to explain why it

Re: [ovs-dev] [PATCH 5/6] upcall: Check for recirc_id in ukey_create_from_dpif_flow()

2015-11-04 Thread Joe Stringer
On 28 October 2015 at 20:07, Jarno Rajahalme wrote: > Filter out not only flows with recirculation actions, but also flows > with non-zero recirculation id in flow key when creating ukeys from > datapath flows, as such flows also depend on the recirculation > context, which have been lost after a

Re: [ovs-dev] [PATCH 4/6] ofp-actions: Fix conntrack action usable_protocols handling.

2015-11-04 Thread Joe Stringer
On 28 October 2015 at 20:07, Jarno Rajahalme wrote: > Restrictions from embedded actions should be folded in rather than discarded. > > Signed-off-by: Jarno Rajahalme Thanks for catching this, one comment below. Acked-by: Joe Stringer > @@ -6152,6 +6158,7 @@ ofpact_check__(enum ofputil_protoc

Re: [ovs-dev] [PATCH 3/6] ofproto: Allow xlate_actions() to fail.

2015-11-04 Thread Joe Stringer
On 28 October 2015 at 20:07, Jarno Rajahalme wrote: > Sometimes xlate_actions() fails due to too deep recursion, too many > MPLS labels, or missing recirculation context. Make xlate_actions() > fail in these circumstances, so that we can: > > - not install a datapath flow if xlate_actions() fail

Re: [ovs-dev] [PATCH 2/6] upcall: Eliminate dead code.

2015-11-04 Thread Joe Stringer
On 28 October 2015 at 20:07, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/6] tests: Strip more variable output from conntrack output.

2015-11-04 Thread Joe Stringer
On 28 October 2015 at 20:07, Jarno Rajahalme wrote: > 'conntrack' output format varies depending on the system > configuration, i.e., conntrack accounting or timestamping is enabled. > Modify the FORMAT_CT() macro to hide these differences. > > Signed-off-by: Jarno Rajahalme Acked-by: Joe String

Re: [ovs-dev] problems debugging datapath module

2015-11-04 Thread Joe Stringer
You need to make sure that you have loaded the new kernel module. Depending on the OVS version and Linux distribution, simply installing the new kernel module and loading it might not be enough; you can make sure you are running the right version by unloading previous openvswitch module using rmmod

Re: [ovs-dev] [PATCH v2] ovn-tutorial: Add a section on ACLs.

2015-11-04 Thread Russell Bryant
On 11/04/2015 10:58 AM, Kyle Mestery wrote: > Thanks for writing this up Russell! I found super pedantic (possible) > nit, but otherwise, this reads fine to me and was helpful in > understanding how ACLs work. Thanks! > > Acked-by: Kyle Mestery mailto:mest...@mestery.com>> Thanks for the review!

Re: [ovs-dev] [PATCH v2] ovn-tutorial: Add a section on ACLs.

2015-11-04 Thread Kyle Mestery
Thanks for writing this up Russell! I found super pedantic (possible) nit, but otherwise, this reads fine to me and was helpful in understanding how ACLs work. Thanks! Acked-by: Kyle Mestery On Wed, Nov 4, 2015 at 9:53 AM, Russell Bryant wrote: > Add a section that gives a quick introduction t

[ovs-dev] [PATCH v2] ovn-tutorial: Add a section on ACLs.

2015-11-04 Thread Russell Bryant
Add a section that gives a quick introduction to applying ACLs. It discusses how the ACLs are translated into OVN logical flows. It doesn't get down to the OpenFlow level because that's not supported in ovs-sandbox yet. Instead, it provides a reference to an OpenStack related blog post that talks

Re: [ovs-dev] Combining monitor2 and monitor_cond methods

2015-11-04 Thread Andy Zhou
On Wed, Nov 4, 2015 at 5:22 AM, Liran Schour wrote: > In order not to have 2 new monitor methods, maybe we should combine them > into a single method. > > However, as I thought on this, monitor_cond without any conditions should > not send any updates at all. A typical usage will be in OVN when >

[ovs-dev] Combining monitor2 and monitor_cond methods

2015-11-04 Thread Liran Schour
In order not to have 2 new monitor methods, maybe we should combine them into a single method. However, as I thought on this, monitor_cond without any conditions should not send any updates at all. A typical usage will be in OVN when ovn-controller will open a monitor_cond session with empty "w

[ovs-dev] Returned mail: Data format error

2015-11-04 Thread Mail Delivery Subsystem
Dear user of openvswitch.org, administration of openvswitch.org would like to inform you We have received reports that your account was used to send a huge amount of spam messages during the recent week. Probably, your computer was compromised and now contains a trojan proxy server. Please foll