Re: [ovs-dev] [branch-2.3 1/2] bitmap: Add new functions.

2015-09-11 Thread Ben Pfaff
On Fri, Sep 11, 2015 at 03:47:25PM -0700, Joe Stringer wrote: > From: Ben Pfaff > > These will be used in an upcoming commit. > > This is a backport of master commit c1a29506e854. > > Signed-off-by: Ben Pfaff > Acked-by: Jarno Rajahalme > Signed-off-by: Joe Stringer Thanks for the fixes. T

Re: [ovs-dev] [PATCH] vtep: add ACLs to VTEP schema

2015-09-11 Thread Gurucharan Shetty
Alex pointed out off-list that vtep-ctl still works. I think I badly phrased the previous comment. What I intended to say was that we dont have new commands for new features that nee tables added. I guess, one can still use database commands dorectly. Sorry for the confusion. > On Sep 10, 201

Re: [ovs-dev] [PATCH v2 06/14] ovn: Implement basic end-to-end full mesh test.

2015-09-11 Thread Ben Pfaff
All of the unreviewed patches in this series have now been superseded by the three independent series that I just posted, starting here: http://openvswitch.org/pipermail/dev/2015-September/059954.html ___ dev mailing list dev@openvswitch.org http:

[ovs-dev] [PATCH] ovn: Implement basic end-to-end full mesh test.

2015-09-11 Thread Ben Pfaff
This is a really basic test of the OVN features. It verifies that basic L2 connectivity works as expected over a 3-hypervisor setup with 3 VMs per hypervisor and all 9 VMs on a single logical switch, with a few ACLs. The infrastructure added by this patch, which is based on similar code from ovs-

[ovs-dev] [PATCH 3/4] ovn-sbctl: Support SSL for connecting to southbound database.

2015-09-11 Thread Ben Pfaff
Eventually we'll want this and it's easy to add, so go ahead and add it now. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-sbctl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index 1d43504..1104167 100644 --- a/ovn/utilities/ovn-s

[ovs-dev] [PATCH 2/4] ovn-sbctl: Indentation fixes.

2015-09-11 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-sbctl.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index 437a74b..1d43504 100644 --- a/ovn/utilities/ovn-sbctl.c +++ b/ovn/utilities/ovn-sbctl.c @@ -249,8 +249,7 @@

[ovs-dev] [PATCH 4/4] ovn-sbctl: Improve usage message.

2015-09-11 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-sbctl.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index 1104167..f7cb156 100644 --- a/ovn/utilities/ovn-sbctl.c +++ b/ovn/utilities/ovn-sbctl.c @@ -41,6 +41,7

[ovs-dev] [PATCH 1/4] Fix typos in comments.

2015-09-11 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-sbctl.c | 2 +- utilities/ovs-vsctl.c | 2 +- vtep/vtep-ctl.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index 5fa1499..437a74b 100644 --- a/ovn/utilities

[ovs-dev] [PATCH 0/4] ovn-sbctl improvements

2015-09-11 Thread Ben Pfaff
These patches were originally in the series that adds end-to-end tests for OVN, but they don't need to be there so I'm reposting them separately. Ben Pfaff (4): Fix typos in comments. ovn-sbctl: Indentation fixes. ovn-sbctl: Support SSL for connecting to southbound database. ovn-sbctl: Imp

[ovs-dev] [PATCH 4/4] ovn-nbctl: Enable database commands using db-ctl-base infrastructure.

2015-09-11 Thread Ben Pfaff
This makes ovn-nbctl into a pretty slavish imitation of ovn-nbctl, using almost the same code. It has two immediate benefits. First, multiple commands can now be chained together into a single ovn-nbctl invocation. Second, the database commands such as "create", "set", and so on allow queries and

[ovs-dev] [PATCH 0/4] ovn-nbctl improvements

2015-09-11 Thread Ben Pfaff
This series makes various improvement to ovn-nbctl, most notably adding support for the database commands already supported by ovs-vsctl and ovs-sbctl. Most of these patches were previously part of the series that added end-to-end tests to OVN. They are no longer needed as part of that series bec

[ovs-dev] [PATCH 2/4] ovn-nbctl: Fix typo and add minor clarification in documentation.

2015-09-11 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-nbctl.8.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/utilities/ovn-nbctl.8.xml b/ovn/utilities/ovn-nbctl.8.xml index 1555b02..f9f58e5 100644 --- a/ovn/utilities/ovn-nbctl.8.xml +++ b/ovn/utilities/ovn-nbctl.8.xml @@ -10

[ovs-dev] [PATCH 1/4] db-ctl-base: Make 'cmd_show_tables' argument to ctl_init() optional.

2015-09-11 Thread Ben Pfaff
This allows the client to omit the "show" command if it doesn't want it. This will be used in an upcoming commit. Signed-off-by: Ben Pfaff --- lib/db-ctl-base.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/lib/db-ctl-base.c b/lib/db-ctl-base.c index b01

[ovs-dev] [PATCH 3/4] ovn-nbctl: Give handler functions more specific names.

2015-09-11 Thread Ben Pfaff
I find that it's nice to give functions for commands names specific to the utility, even though they're static, because occasionally it makes it easier to find them using "tags", "grep", etc. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-nbctl.c | 108 +++

Re: [ovs-dev] [PATCH v2] expr: Properly handle several cases involving string variables.

2015-09-11 Thread Ben Pfaff
Thanks, I applied this to master. On Fri, Sep 11, 2015 at 03:56:24PM -0700, Justin Pettit wrote: > Thanks for fixing the issue and improving the tests. > > Acked-by: Justin Pettit > > --Justin > > > > On Aug 29, 2015, at 1:39 PM, Ben Pfaff wrote: > > > > The expr test cases covered string v

[ovs-dev] Hi

2015-09-11 Thread desk
The message was undeliverable due to the following reason: Your message could not be delivered because the destination computer was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely

Re: [ovs-dev] [PATCH RFC 00/13] IPv6 tunneling

2015-09-11 Thread Jesse Gross
On Fri, Sep 11, 2015 at 7:10 PM, Santosh Koshy wrote: > Hello Gentleman, > > do you know if OVS 2.4.0 is patched for [PATCH RFC 00/13] IPv6 > tunneling. IPv6 tunnel is not currently supported by any version of OVS. There is ongoing work to do this. ___

Re: [ovs-dev] [PATCH RFC 00/13] IPv6 tunneling

2015-09-11 Thread Santosh Koshy
Hello Gentleman, do you know if OVS 2.4.0 is patched for [PATCH RFC 00/13] IPv6 tunneling. Thanks, Santosh Koshy ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] tnl-ports: Add destination IP and MAC address to the match.

2015-09-11 Thread Jesse Gross
On Thu, Sep 3, 2015 at 12:42 AM, Pravin B Shelar wrote: > Currently tnl-port table wildcard destination ip and mac addresses > for given tunnel packet. That could result accepting tunnel > packets destined for other hosts. Following patch adds > support for matching for ip and mac address. > IP

[ovs-dev] [PATCH] tunnel: Validate IP header for userspace tunneling.

2015-09-11 Thread Jesse Gross
Currently, when doing userspace tunneling we don't perform much in the way of integrity checks on the incoming IP header. The case of tunneling is different from the usual case of switching since we are acting as the endpoint here and should not allow invalid packets to pass. This adds checks for

Re: [ovs-dev] [PATCH] datapath-windows: Compute checksums for VXLAN inner packets

2015-09-11 Thread Sairam Venugopal
Hey Alin, Am taking another stab at this code review. I will prefix my comments with a ³Sai:² just to be safe. I had few concerns over checksum calculations when LSO is enabled. Thanks, Sairam Venugopal On 9/11/15, 1:48 AM, "Alin Serdean" wrote: >Windows does not support VXLAN hardware offloa

Re: [ovs-dev] [PATCH 3/8] Add support for connection tracking.

2015-09-11 Thread Jarno Rajahalme
> On Sep 11, 2015, at 5:02 PM, Joe Stringer wrote: > > On 11 September 2015 at 16:37, Jarno Rajahalme wrote: >> Here is an provisional ACK, I trust you to address the comments to my >> satisfaction :-) >> >> Acked-by: Jarno Rajahalme >> >> Jarno > > Thanks, but I may yet send a round 2; t

Re: [ovs-dev] [PATCH] datapath-windows: Compute checksums for VXLAN inner packets

2015-09-11 Thread Sairam Venugopal
Sorry about the bad indents on my comments. I will re-send the review. -Sairam From: dev on behalf of Sairam Venugopal Sent: Friday, September 11, 2015 4:56 PM To: Alin Serdean; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: Compute

Re: [ovs-dev] [PATCH 3/8] Add support for connection tracking.

2015-09-11 Thread Joe Stringer
On 11 September 2015 at 16:37, Jarno Rajahalme wrote: > Here is an provisional ACK, I trust you to address the comments to my > satisfaction :-) > > Acked-by: Jarno Rajahalme > > Jarno Thanks, but I may yet send a round 2; there's a lot of scattered changes, so I wouldn't mind getting some ex

Re: [ovs-dev] [PATCH] datapath-windows: Compute checksums for VXLAN inner packets

2015-09-11 Thread Sairam Venugopal
Hey Alin, The comments are inline. From: dev on behalf of Alin Serdean Sent: Friday, September 11, 2015 1:48 AM To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Compute checksums for VXLAN inner packets Windows does not supp

Re: [ovs-dev] [PATCH 4/8] Add connection tracking mark support.

2015-09-11 Thread Joe Stringer
On 11 September 2015 at 15:50, Jarno Rajahalme wrote: > [I tried to reproduce the lost email message from the patch (from github).] > > With the comments below, > > Acked-by: Jarno Rajahalme Appreciate the extra effort. >> This patch adds a new 32-bit metadata field to the connection tracking >

Re: [ovs-dev] [PATCH 8/8] dpif-netlink: Allow MRU packet attribute.

2015-09-11 Thread Jarno Rajahalme
With the few comments below, Acked-by: Jarno Rajahalme The MRU is still lost if the packet is sent to the controller, but maybe sending (potentially) large packet to controller is a bad idea to begin with. Jarno > On Sep 9, 2015, at 7:00 PM, Joe Stringer wrote: > > From: Andy Zhou > > U

Re: [ovs-dev] [PATCH 3/8] Add support for connection tracking.

2015-09-11 Thread Jarno Rajahalme
Conditional to Ben’s approval of the nested actions within the OF ct action, of course :-) Jarno > On Sep 11, 2015, at 4:37 PM, Jarno Rajahalme wrote: > > Here is an provisional ACK, I trust you to address the comments to my > satisfaction :-) > > Acked-by: Jarno Rajahalme > > Jarno >

Re: [ovs-dev] [PATCH 7/8] Add support for connection tracking helper/ALGs.

2015-09-11 Thread Jarno Rajahalme
With the comments below, Acked-by: Jarno Rajahalme Sorry for repeating some comments over and over, no offense intended. > On Sep 9, 2015, at 7:00 PM, Joe Stringer wrote: > > This patch adds support for specifying a "helper" or ALG to assist > connection tracking for protocols that consist

Re: [ovs-dev] [PATCH 3/8] Add support for connection tracking.

2015-09-11 Thread Jarno Rajahalme
Here is an provisional ACK, I trust you to address the comments to my satisfaction :-) Acked-by: Jarno Rajahalme Jarno > On Sep 11, 2015, at 4:15 PM, Joe Stringer wrote: > > On 11 September 2015 at 14:42, Jarno Rajahalme wrote: >>> diff --git a/tests/system-traffic.at b/tests/system-traff

Re: [ovs-dev] [PATCH 6/8] Add connection tracking label support.

2015-09-11 Thread Jarno Rajahalme
[I did not receive this email either.] With the comments below, Acked-by: Jarno Rajahalme > This patch adds a new 128-bit metadata field to the connection tracking > interface. When a label is specified as part of the ct action and the > connection is committed, the value is saved with the curr

Re: [ovs-dev] [PATCH 3/8] Add support for connection tracking.

2015-09-11 Thread Joe Stringer
On 11 September 2015 at 14:42, Jarno Rajahalme wrote: >> diff --git a/tests/system-traffic.at b/tests/system-traffic.at >> index 7dbed68..de6b016 100644 >> --- a/tests/system-traffic.at >> +++ b/tests/system-traffic.at >> @@ -139,3 +139,472 @@ NS_CHECK_EXEC([at_ns0], [ping -s 3200 -q -c 3 -i 0.3

Re: [ovs-dev] [PATCH 5/8] lib: Introduce ovs_u128_is_zero().

2015-09-11 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > From 71d0ebf2d9b473bf0f848e3ae76223b35ffd4505 Mon Sep 17 00:00:00 2001 > From: Daniele Di Proietto > Date: Wed, 22 Jul 2015 18:41:48 +0100 > Subject: [PATCH] lib: Introduce ovs_u128_is_zero(). > > is_all_zeros() is quite slow for u128 initialization because: > - It i

Re: [ovs-dev] [PATCH v2] expr: Properly handle several cases involving string variables.

2015-09-11 Thread Justin Pettit
Thanks for fixing the issue and improving the tests. Acked-by: Justin Pettit --Justin > On Aug 29, 2015, at 1:39 PM, Ben Pfaff wrote: > > The expr test cases covered string variables poorly and thus a number of > bugs and omissions slipped through. This fixes them and generalizes the > test

Re: [ovs-dev] [PATCH 4/8] Add connection tracking mark support.

2015-09-11 Thread Jarno Rajahalme
[I tried to reproduce the lost email message from the patch (from github).] With the comments below, Acked-by: Jarno Rajahalme > This patch adds a new 32-bit metadata field to the connection tracking > interface. When a mark is specified as part of the ct action and the > connection is committe

[ovs-dev] [branch-2.3 2/2] ovsdb: Fix compilation of ovsdb/transaction.c.

2015-09-11 Thread Joe Stringer
The branch-2.3 backport of master commit eac0dc83c468 missed some changes required to build on the older codebase. Fix the issue. Fixes: b2235a2f4d4c ("ovsdb: Update _version more accurately in transaction commit.") Signed-off-by: Joe Stringer --- ovsdb/transaction.c | 4 ++-- 1 file changed, 2

[ovs-dev] [branch-2.3 1/2] bitmap: Add new functions.

2015-09-11 Thread Joe Stringer
From: Ben Pfaff These will be used in an upcoming commit. This is a backport of master commit c1a29506e854. Signed-off-by: Ben Pfaff Acked-by: Jarno Rajahalme Signed-off-by: Joe Stringer --- lib/bitmap.c | 44 lib/bitmap.h | 6 ++ 2 files ch

Re: [ovs-dev] [PATCH] expr: Fix crossproduct example.

2015-09-11 Thread Justin Pettit
> On Sep 11, 2015, at 3:34 PM, Ben Pfaff wrote: > > On Fri, Sep 11, 2015 at 03:32:12PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Someday, I will learn to count. > > Acked-by: Ben Pfaff Thanks. Pushed to master. --Justin _

Re: [ovs-dev] [PATCH] expr: Fix crossproduct example.

2015-09-11 Thread Ben Pfaff
On Fri, Sep 11, 2015 at 03:32:12PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Someday, I will learn to count. Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] expr: Fix crossproduct example.

2015-09-11 Thread Justin Pettit
Signed-off-by: Justin Pettit --- ovn/lib/expr.h |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ovn/lib/expr.h b/ovn/lib/expr.h index b411e65..d755b55 100644 --- a/ovn/lib/expr.h +++ b/ovn/lib/expr.h @@ -210,7 +210,7 @@ const char *expr_level_to_string(enum expr_leve

Re: [ovs-dev] [PATCH 3/3] ipfix: Fix SIGFPE in bridge exporter sampling.

2015-09-11 Thread Joe Stringer
On 11 September 2015 at 11:12, Romain Lenglet wrote: > LGTM, thanks! > > Acked-by: Romain Lenglet Thanks, applied to master and branch-2.[134]. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/3] ipfix: Add bridge_exporter_enabled().

2015-09-11 Thread Joe Stringer
On 11 September 2015 at 11:11, Romain Lenglet wrote: > LGTM, thanks! > > Acked-by: Romain Lenglet Thanks, applied to master and branch-2.[134]. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/3] tests: Add basic IPFIX test.

2015-09-11 Thread Joe Stringer
On 11 September 2015 at 11:11, Romain Lenglet wrote: > Thanks for doing this! > > Acked-by: Romain Lenglet Thanks, applied to master. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/3] ovn-northd: Document logical flow table structure.

2015-09-11 Thread Ben Pfaff
On Fri, Sep 11, 2015 at 01:54:45PM -0700, Justin Pettit wrote: > Looks good. Thanks for writing it! Do you think we should put a > comment in build_lflows() that says to update this file? Done, thanks for the reminder. > Acked-by: Justin Pettit Thanks, I applied this to master. __

Re: [ovs-dev] randconfig build error with next-20150911, in net/openvswitch

2015-09-11 Thread Joe Stringer
On 11 September 2015 at 09:53, Jim Davis wrote: > Building with the attached random configuration file, > > net/built-in.o: In function `ovs_ct_execute': > (.text+0x10f587): undefined reference to `nf_ct_frag6_gather' Thanks for the report, I sent a patch: https://patchwork.ozlabs.org/patch/51703

Re: [ovs-dev] [PATCH 3/8] Add support for connection tracking.

2015-09-11 Thread Joe Stringer
On 11 September 2015 at 14:02, Jarno Rajahalme wrote: >>> - new and reply are mutually exclusive (reply direction is defined as >>> opposite of the initial +new) >> >> Strictly speaking I don't think this is the case. I don't have an >> example, but it is possible for this to be set in the conntr

Re: [ovs-dev] [PATCH 3/8] Add support for connection tracking.

2015-09-11 Thread Jarno Rajahalme
Joe, Below some comments on the tests, Jarno > --- a/tests/atlocal.in > +++ b/tests/atlocal.in > @@ -110,3 +110,10 @@ fi > if test "$IS_WIN32" = "yes"; then > HAVE_PYTHON="no" > fi > + > +# Conntrack test requirements > +if test x`which conntrack` != x; then > +HAVE_CONNTRACK="yes" > +

[ovs-dev] [PATCH] datapath-windows: Enable checksum offloads in STT

2015-09-11 Thread Sairam Venugopal
Enable support for Checksum offloads in STT if it's enabled in the Windows VM. Signed-off-by: Sairam Venugopal --- datapath-windows/ovsext/Stt.c | 190 ++ 1 file changed, 176 insertions(+), 14 deletions(-) diff --git a/datapath-windows/ovsext/Stt.c b/data

Re: [ovs-dev] [PATCH 3/8] Add support for connection tracking.

2015-09-11 Thread Jarno Rajahalme
> On Sep 11, 2015, at 1:07 PM, Joe Stringer wrote: > > On 10 September 2015 at 19:03, Jarno Rajahalme wrote: >> >>> On Sep 9, 2015, at 7:00 PM, Joe Stringer wrote: >>> @@ -672,6 +705,8 @@ struct ovs_action_push_tnl { >>> * indicate the new packet contents. This could potentially still be >>>

Re: [ovs-dev] [PATCH 3/3] ovn-northd: Document logical flow table structure.

2015-09-11 Thread Justin Pettit
Looks good. Thanks for writing it! Do you think we should put a comment in build_lflows() that says to update this file? Acked-by: Justin Pettit --Justin > On Sep 11, 2015, at 11:36 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > --- > ovn/northd/ovn-northd.8.xml | 106 ++

Re: [ovs-dev] [PATCH 2/3] ovn-northd: Minor logical flow table optimizations.

2015-09-11 Thread Ben Pfaff
On Fri, Sep 11, 2015 at 12:57:18PM -0700, Justin Pettit wrote: > > > On Sep 11, 2015, at 11:36 AM, Ben Pfaff wrote: > > > > @@ -744,22 +744,23 @@ build_lflows(struct northd_context *ctx, struct hmap > > *datapaths, > > > > /* Port security flows have priority 50 (see below) and will >

Re: [ovs-dev] [PATCH 1/3] ovn-northd: Don't deliver even broadcast packets to disabled logical ports.

2015-09-11 Thread Ben Pfaff
On Fri, Sep 11, 2015 at 12:49:13PM -0700, Justin Pettit wrote: > > > On Sep 11, 2015, at 11:36 AM, Ben Pfaff wrote: > > > > Until now, the priority-100 flow for broadcast and multicast packets caused > > such packets to be delivered to disabled logical ports. This commit makes > > ovn-northd ad

Re: [ovs-dev] [PATCH 3/8] Add support for connection tracking.

2015-09-11 Thread Joe Stringer
On 10 September 2015 at 11:05, Ben Pfaff wrote: > Who do you think should review this? Jarno and I discussed the OpenFlow interface a little at lunch, would you mind looking at this particular aspect from an API cleanliness point of view? ___ dev mailin

Re: [ovs-dev] [PATCH 3/8] Add support for connection tracking.

2015-09-11 Thread Joe Stringer
On 10 September 2015 at 19:03, Jarno Rajahalme wrote: > >> On Sep 9, 2015, at 7:00 PM, Joe Stringer wrote: >> @@ -672,6 +705,8 @@ struct ovs_action_push_tnl { >> * indicate the new packet contents. This could potentially still be >> * %ETH_P_MPLS if the resulting MPLS label stack is not empty.

Re: [ovs-dev] [PATCH 2/3] ovn-northd: Minor logical flow table optimizations.

2015-09-11 Thread Justin Pettit
> On Sep 11, 2015, at 11:36 AM, Ben Pfaff wrote: > > @@ -744,22 +744,23 @@ build_lflows(struct northd_context *ctx, struct hmap > *datapaths, > > /* Port security flows have priority 50 (see below) and will continue > * to the next table if packet source is acceptable. */ > -

Re: [ovs-dev] [PATCH 1/3] ovn-northd: Don't deliver even broadcast packets to disabled logical ports.

2015-09-11 Thread Justin Pettit
> On Sep 11, 2015, at 11:36 AM, Ben Pfaff wrote: > > Until now, the priority-100 flow for broadcast and multicast packets caused > such packets to be delivered to disabled logical ports. This commit makes > ovn-northd add a priority-150 flow for each disabled logical port to > override that beh

[ovs-dev] [PATCH 3/3] ovn-northd: Document logical flow table structure.

2015-09-11 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.8.xml | 106 1 file changed, 106 insertions(+) diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml index 316f729..1655958 100644 --- a/ovn/northd/ovn-northd.8.xml +++ b/ovn/northd/o

[ovs-dev] [PATCH 1/3] ovn-northd: Don't deliver even broadcast packets to disabled logical ports.

2015-09-11 Thread Ben Pfaff
Until now, the priority-100 flow for broadcast and multicast packets caused such packets to be delivered to disabled logical ports. This commit makes ovn-northd add a priority-150 flow for each disabled logical port to override that behavior. Found by inspection. Signed-off-by: Ben Pfaff --- o

[ovs-dev] [PATCH 2/3] ovn-northd: Minor logical flow table optimizations.

2015-09-11 Thread Ben Pfaff
There's no need to add a priority-0 "drop" flow, because OVN logical flow tables always drop non-matching packets. There's no need to add a "drop" flow for ingress port security on disabled logical ports, because no other flow would allow those packets; it's more efficient to omit the logical flow

Re: [ovs-dev] [PATCH 3/3] ipfix: Fix SIGFPE in bridge exporter sampling.

2015-09-11 Thread Romain Lenglet
LGTM, thanks! Acked-by: Romain Lenglet --  Romain Lenglet On September 10, 2015 at 6:41:43 PM, Joe Stringer (joestrin...@nicira.com) wrote: A divide-by-zero exception like the below could occur when IPFIX configuration is cleared while handling sampled packets from the datapath. While it's

Re: [ovs-dev] [PATCH 2/3] ipfix: Add bridge_exporter_enabled().

2015-09-11 Thread Romain Lenglet
LGTM, thanks! Acked-by: Romain Lenglet --  Romain Lenglet On September 10, 2015 at 6:41:42 PM, Joe Stringer (joestrin...@nicira.com) wrote: Rather than describing this intention after the fact, encode this meaning in the name of a function. Signed-off-by: Joe Stringer --- ofproto/ofp

Re: [ovs-dev] [PATCH 1/3] tests: Add basic IPFIX test.

2015-09-11 Thread Romain Lenglet
Thanks for doing this! Acked-by: Romain Lenglet --  Romain Lenglet On September 10, 2015 at 6:41:41 PM, Joe Stringer (joestrin...@nicira.com) wrote: Previously, we had no IPFIX tests in the testsuite. Now we have one. Signed-off-by: Joe Stringer --- tests/ofproto-dpif.at | 37 +

Re: [ovs-dev] [PATCH 2/8] ofp-actions: Allow special handling for nested actions.

2015-09-11 Thread Joe Stringer
On 10 September 2015 at 11:01, Ben Pfaff wrote: > On Wed, Sep 09, 2015 at 07:00:18PM -0700, Joe Stringer wrote: >> The next patch will introduce nested actions with special restrictions. >> Refactor the action verification to allow ofpacts_verify() to identify >> nesting so that these retrictions

Re: [ovs-dev] [PATCH 1/8] ofproto-dpif-xlate: Introduce xlate_commit_actions().

2015-09-11 Thread Joe Stringer
On 10 September 2015 at 10:07, Ben Pfaff wrote: > On Wed, Sep 09, 2015 at 07:00:17PM -0700, Joe Stringer wrote: >> This combines a common set of operations into a single command. >> >> Signed-off-by: Joe Stringer > > Nice cleanup. > > Acked-by: Ben Pfaff Thanks, applied. ___

Re: [ovs-dev] [PATCH v3] dpif-netdev: Check for PKT_RX_RSS_HASH flag.

2015-09-11 Thread Daniele Di Proietto
On 10/09/2015 20:16, "Pravin Shelar" wrote: >On Thu, Sep 10, 2015 at 10:02 AM, Daniele Di Proietto > wrote: >> DPDK mbufs contain a valid RSS hash only if PKT_RX_RSS_HASH is >> set in 'ol_flags'. Otherwise the hash is garbage and doesn't >> relate to the packet. >> >> This fixes an issue with

[ovs-dev] [PATCH 2/2 v2] stream-ssl: Get peer-ca-cert functionality to work.

2015-09-11 Thread Gurucharan Shetty
When --certificate option is provided, we currently use SSL_CTX_use_certificate_chain_file() function to add that certificate. If our single certificate file had multiple certificates (as a chain), all of them would get added and sent to the remote peer. But once you call SSL_CTX_use_certificate_ch

[ovs-dev] [PATCH 1/2 v2] ovs-vsctl.at: Correct title of SSL test.

2015-09-11 Thread Gurucharan Shetty
The test claimed to test peer-ca-cert functionality. But the certificate provided via --peer-ca-cert was not actually sent to the peer for bootstrapping. The bootstrapping was successful because cert provided via --certificate was self-signed. Since the test was not really testing the --peer-ca-cer

Re: [ovs-dev] About the paper

2015-09-11 Thread Ben Pfaff
One tuple has five unique priorities. If the lowest priority 32767 is a match, then there are 20 tuples that follow it that contain a flow with priority greater than 32767. On Fri, Sep 11, 2015 at 04:37:10PM +0800, openvswitcher wrote: > Could any body tell me how the count 20 of 'up to 20 tuples

Re: [ovs-dev] [PATCH 2/2] stream-ssl: Get peer-ca-cert functionality to work.

2015-09-11 Thread Gurucharan Shetty
On Tue, Sep 8, 2015 at 3:36 PM, Ben Pfaff wrote: > On Wed, Sep 02, 2015 at 01:02:39PM -0700, Gurucharan Shetty wrote: >> When --certificate option is provided, we currently use >> SSL_CTX_use_certificate_chain_file() function to add >> that certificate. If our single certificate file had multiple

Re: [ovs-dev] [PATCH v2] ofctl: This patch add support for setting the first egress table for egress processing.

2015-09-11 Thread niti Rohilla
Hi Ben, I have resolved error reported by travis, but I am facing an issue. All the test cases are executing successfully in my local git repository but when I create a pull request for the patch many test cases are failing with the same error as reported by travis. The error is: netdev_linux|WA

[ovs-dev] [PATCH v2] ofproto: Implement OF1.4 error code for set-async-config

2015-09-11 Thread ambikaarora92
From: Ambika Arora This patch adds support for Openflow1.4 error codes for set-async-config. In this patch, a new error type, OFPET_ASYNC_CONFIG_FAILED is introduced that enables the switch to properly inform the controller when controller tries to set invalid mask or unsupported configuration.

Re: [ovs-dev] [PATCH v4] dpif-netdev: proper tx queue id

2015-09-11 Thread Ilya Maximets
Thanks. Fixed. New version here: http://openvswitch.org/pipermail/dev/2015-September/059895.html Best regards, Ilya Maximets. On 10.09.2015 21:03, Daniele Di Proietto wrote: > Sorry for the delay. > > There's still one problem with this patch: > > when a non-DPDK port is added to the datapath,

[ovs-dev] [PATCH v5] dpif-netdev: proper tx queue id

2015-09-11 Thread Ilya Maximets
Currently tx_qid is equal to pmd->core_id. This leads to unexpected behavior if pmd-cpu-mask different from '/(0*)(1|3|7)?(f*)/', e.g. if core_ids are not sequential, or doesn't start from 0, or both. Example: starting 2 pmd threads with 1 port, 2 rxqs per port, pmd-cpu-mask =

Re: [ovs-dev] Megaflows Question

2015-09-11 Thread openvswitcher
Hi, Ben Thank you very much. I eventually notice that the revalidate threads not only check weather it is needed to delete the flow in kernel for timeout but also it check whether the match masks or the actions still valid. Thank you for your help to make me understand my mistake. At 2

[ovs-dev] [PATCH] datapath-windows: Removed hardcoded names for internal/external vports

2015-09-11 Thread Sorin Vinturis
The internal/external vports will have the actual OS-based names, which represent the NIC interface alias that is displayed by running 'Get-NetAdapter' Hyper-V PS command. Signed-off-by: Sorin Vinturis --- datapath-windows/ovsext/Vport.c | 52 + 1 file cha

Re: [ovs-dev] [PATCH] datapath-windows: Compute checksums for VXLAN inner packets

2015-09-11 Thread Sorin Vinturis
Minor coding style issues highlighted below. Looks good otherwise. Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Friday, 11 September, 2015 11:49 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windo

Re: [ovs-dev] [PATCH] datapath-windows: Append flow attribute key

2015-09-11 Thread Sorin Vinturis
I had a minor comment inline. Looks good otherwise. Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Friday, 11 September, 2015 02:15 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] datapath-windows: Append flow

Re: [ovs-dev] [PATCH] [PATCH v4] datapath-windows: Output to multiple VXLAN ports

2015-09-11 Thread Sorin Vinturis
Acked-by: Sorin Vinturis -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean Sent: Friday, 11 September, 2015 01:10 To: dev@openvswitch.org Subject: [ovs-dev] [PATCH] [PATCH v4] datapath-windows: Output to multiple VXLAN ports If we have a flow ru

[ovs-dev] [PATCH] datapath-windows: Compute checksums for VXLAN inner packets

2015-09-11 Thread Alin Serdean
Windows does not support VXLAN hardware offloading. Currently we do not compute IP/TCP/UDP checksums for the inner packet. This patch computes the checksums mentioned above in regards with the enabled settings. i.e. if IP checksum offloading is enabled for the inner packet we compute it. The same

[ovs-dev] About the paper

2015-09-11 Thread openvswitcher
Could any body tell me how the count 20 of 'up to 20 tuples' is calculated? " As an example, we examined the OpenFlow table installed by a production deployment of VMware’s NVP controller [19]. This table contained 29 tuples. Of those 29 tuples, 26 contained flows of a single priority, which m