Re: [ovs-dev] [PATCH RFC 3/3] manager: Allow change to punix socket file group ownership.

2015-08-21 Thread Alex Wang
If we want to make ovsdb-server non-root, this change may not be need,~ On Fri, Aug 21, 2015 at 11:10 PM, Alex Wang wrote: > This commit adds a new key-value pair, 'punix_file_group=', > to the 'other_config' column in the 'Manager' table. This new config > allows user to change the punix socke

[ovs-dev] [PATCH RFC 3/3] manager: Allow change to punix socket file group ownership.

2015-08-21 Thread Alex Wang
This commit adds a new key-value pair, 'punix_file_group=', to the 'other_config' column in the 'Manager' table. This new config allows user to change the punix socket file's group ownership, so that non-root process can also connect to ovsdb-server. Signed-off-by: Alex Wang --- ovsdb/jsonrpc-s

[ovs-dev] [PATCH 2/3] service controller: Allow change to punix socket file group ownership.

2015-08-21 Thread Alex Wang
This commit adds a new key-value pair, 'punix_file_group=', to the 'other_config' column in the 'Controller' table. This new config allows user to change the punix socket file's group ownership, so that non-root process can also connect to ovs bridge. Signed-off-by: Alex Wang --- lib/socket-uti

[ovs-dev] [PATCH 1/3] bridge: Relax the whitelist format for punix path.

2015-08-21 Thread Alex Wang
This commit relaxes the whitelist format for punix path for service controller. Instead of only allowing punix:/.controller, the new format allows any suffix, like punix:/.*. Signed-off-by: Alex Wang --- tests/ovs-vswitchd.at | 11 +++ vswitchd/bridge.c | 11 ++- 2 files

[ovs-dev] News24,

2015-08-21 Thread HSBC BANK
Kindly View Attached File Yours Faithfully,Dr/ Mrs. Catherine.T.ButchHSBC Bank LondonKindly Contact Dr. Daniel Mminele by via Email: daniel.mmin...@mailbox.co.za Dr. Daniel Mminele Tel No: +27 837 425 342 ___

[ovs-dev] Returned mail: Data format error

2015-08-21 Thread researcher
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/3] ovsdb-server: Add the ability to push peer-cert.

2015-08-21 Thread Gurucharan Shetty
On Fri, Aug 21, 2015 at 2:43 PM, Ben Pfaff wrote: > On Thu, Aug 20, 2015 at 10:03:39AM -0700, Gurucharan Shetty wrote: >> In OVN, ovsdb-server is the daemon that manages the databases >> and can be called as the central controller. So it would be >> nice for ovsdb-server to be able to push its sel

Re: [ovs-dev] [PATCH v4 4/9] classifier: Pre-compute stage masks.

2015-08-21 Thread Jarno Rajahalme
I sent a v5 of the rest of the series (with some new patches, too). Jarno > On Aug 21, 2015, at 2:36 PM, Jarno Rajahalme wrote: > > >> On Aug 21, 2015, at 8:30 AM, Ben Pfaff > > wrote: >> >> On Fri, Aug 07, 2015 at 04:57:37PM -0700, Jarno Rajahalme wrote: >>> This ma

[ovs-dev] [PATCH v5 6/6] meta-flow: Avoid unnecessary large memset.

2015-08-21 Thread Jarno Rajahalme
mf_mask_field_and_prereqs() used to memset a static variable again and again. Now that mf_value is larger (due to tun_metadata field), this is more expensive. Avoid this by using static initialization. mf_mask_field_and_prereqs() is used only for set field and reg move, which never deal with the

[ovs-dev] [PATCH v5 3/6] flow: Add struct flowmap.

2015-08-21 Thread Jarno Rajahalme
Struct miniflow is now sometimes used just as a map. Define a new struct flowmap for that purpose. The flowmap is defined as an array of maps, and it is automatically sized according to the size of struct flow, so it will be easier to maintain in the future. It would have been tempting to use th

[ovs-dev] [PATCH v5 5/6] ofproto-dpif-rid: Make lookups cheaper.

2015-08-21 Thread Jarno Rajahalme
Tunnel metadata has grown large since the addition of Geneve options. Copying tunnel metadata for performing a lookup is not necessary. Change recirc_metadata to use a pointer to struct flow_tnl, and only copy the tunnel metadata when needed, and only copy as little of it as possible. Signed-off-b

[ovs-dev] [PATCH v5 2/6] classifier: Pre-compute stage masks.

2015-08-21 Thread Jarno Rajahalme
This makes stage mask computation happen only when a subtable is inserted and allows simplification of the main lookup function. Classifier benchmark shows that this speeds up the classification (with wildcards) about 5%. Signed-off-by: Jarno Rajahalme --- lib/classifier-private.h | 127 +++

[ovs-dev] [PATCH v5 1/6] flow: Use unsigned int for counts.

2015-08-21 Thread Jarno Rajahalme
Reserve the use of size_t for sizes of objects in bytes. Suggested-by: Joe Stringer Signed-off-by: Jarno Rajahalme --- lib/classifier-private.h | 10 +- lib/classifier.c | 45 +++-- lib/classifier.h | 6 +++--- lib/flow.c

[ovs-dev] [PATCH v5 4/6] classifier: Retire partitions.

2015-08-21 Thread Jarno Rajahalme
Classifier partitions allowed skipping subtables when if was known from the flow's metadata field that the subtable cannot possibly match. This functionality was later implemented in a more general fashion by staged lookup, where the first stage also covers the metadata field, among the rest of th

Re: [ovs-dev] [PATCH 0/4] datapath-windows: Update netlink attribute parsing

2015-08-21 Thread Ben Pfaff
On Mon, Jul 13, 2015 at 03:26:52PM +, Alin Serdean wrote: > Update netlink attribute parsing to use the array size of the > appropriate policy. Do these patches still need review? I don't see any. ___ dev mailing list dev@openvswitch.org http://open

Re: [ovs-dev] [PATCH v5 2/2] ofproto: Implement OF1.4 Group & Meter change notification messages

2015-08-21 Thread Ben Pfaff
On Wed, Aug 19, 2015 at 12:17:33PM +0530, niti1...@gmail.com wrote: > From: Niti Rohilla > > This patch adds support for Openflow1.4 Group & meter change notification > messages. In a multi controller environment, when a controller modifies the > state of group and meter table, the request that s

Re: [ovs-dev] [PATCH] ovs-sandbox: Add support for ovn-controller-vtep.

2015-08-21 Thread Ben Pfaff
On Fri, Aug 21, 2015 at 01:42:18PM -0400, Russell Bryant wrote: > When ovs-sandbox is run with ovn enabled, create the vtep database and > run ovn-controller-vtep. This lets you do some basic testing with > ovn-controller-vtep. For example: > > $ make sandbox SANDBOXFLAGS="--ovn" > $ vte

Re: [ovs-dev] OVN: Broken pipe race

2015-08-21 Thread Alex Wang
On Fri, Aug 21, 2015 at 3:02 PM, Ben Pfaff wrote: > On Mon, Aug 17, 2015 at 11:24:48AM -0700, Alex Wang wrote: > > Hey, > > > > Want to open a thread to discuss the following race I encountered while > > unit testing ovn. > > > > The most simple case is when I run ovn-nbctl to add a lport in unit

Re: [ovs-dev] [PATCH 1/3] ovs-vsctl: Add the missing ssl bootstrapping option parsing.

2015-08-21 Thread Ben Pfaff
On Fri, Aug 21, 2015 at 03:06:08PM -0700, Gurucharan Shetty wrote: > > I guess this is a bug fix so it should get backported. > > > > Acked-by: Ben Pfaff > I think this has been forever. How long back do we generally backport? In this case I would backport to 2.3 and 2.4 and not bother otherwise.

Re: [ovs-dev] [PATCH v2 3/3] Implement OFPT_TABLE_STATUS Message.

2015-08-21 Thread Ben Pfaff
On Wed, Aug 19, 2015 at 12:54:37PM +0530, saloni.jai...@gmail.com wrote: > From: Saloni Jain > > On change in a table state, the controller needs to be informed with > the OFPT_TABLE_STATUS message. The message is sent with reason > OFPTR_VACANCY_DOWN or OFPTR_VACANCY_UP in case of change in rema

Re: [ovs-dev] [PATCH v2 2/3] Implement Vacancy Events for OFPMP_TABLE_DESC.

2015-08-21 Thread Ben Pfaff
On Wed, Aug 19, 2015 at 12:54:00PM +0530, saloni.jai...@gmail.com wrote: > From: Saloni Jain > > This patch adds support for vacancy events in table-desc. > > ovs-ofctl -O OpenFlow14 dump-tables-desc > -This command is enhanced to display the Vacancy Event configuration > of the tables on a ,

Re: [ovs-dev] [PATCH v2 1/3] Implement Openflow 1.4 Vacancy Events for OFPT_TABLE_MOD.

2015-08-21 Thread Ben Pfaff
On Wed, Aug 19, 2015 at 12:53:16PM +0530, saloni.jai...@gmail.com wrote: > From: Saloni Jain > > OpenFlow 1.4 introduces the ability to turn on vacancy events with an > OFPT_TABLE_MOD message specifying OFPTC_VACANCY_EVENTS. This commit adds > support for the new feature in ovs-ofctl mod-table. >

Re: [ovs-dev] [PATCH 1/3] ovs-vsctl: Add the missing ssl bootstrapping option parsing.

2015-08-21 Thread Gurucharan Shetty
> I guess this is a bug fix so it should get backported. > > Acked-by: Ben Pfaff I think this has been forever. How long back do we generally backport? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] OVN: Broken pipe race

2015-08-21 Thread Ben Pfaff
On Mon, Aug 17, 2015 at 11:24:48AM -0700, Alex Wang wrote: > Hey, > > Want to open a thread to discuss the following race I encountered while > unit testing ovn. > > The most simple case is when I run ovn-nbctl to add a lport in unit test: > 1. ovn-nbctl first creates/commits the logical_port ent

Re: [ovs-dev] [PATCH 8/8] json: increase Json string initial buffer size

2015-08-21 Thread Andy Zhou
On Fri, Aug 21, 2015 at 10:48 AM, Ben Pfaff wrote: > On Tue, Aug 11, 2015 at 05:55:14PM -0700, Andy Zhou wrote: >> Json string are usually created and freed immediately. Thus, there >> should not be any downside in creating a larger buffer initially to >> avoid the cost of moving strings around in

Re: [ovs-dev] [PATCH 3/3] ovn: Add bootstrap options for OVN controllers.

2015-08-21 Thread Ben Pfaff
On Thu, Aug 20, 2015 at 10:03:40AM -0700, Gurucharan Shetty wrote: > This lets the central controller to push > its certificate to the OVN controllers. > > Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org h

Re: [ovs-dev] [PATCH 2/3] ovsdb-server: Add the ability to push peer-cert.

2015-08-21 Thread Ben Pfaff
On Thu, Aug 20, 2015 at 10:03:39AM -0700, Gurucharan Shetty wrote: > In OVN, ovsdb-server is the daemon that manages the databases > and can be called as the central controller. So it would be > nice for ovsdb-server to be able to push its self-signed > certificate to all the other nodes where ovn-

Re: [ovs-dev] [PATCH v4 4/9] classifier: Pre-compute stage masks.

2015-08-21 Thread Jarno Rajahalme
> On Aug 21, 2015, at 8:30 AM, Ben Pfaff wrote: > > On Fri, Aug 07, 2015 at 04:57:37PM -0700, Jarno Rajahalme wrote: >> This makes stage mask computation happen only when a subtable is >> inserted and allows simplification of the main lookup function. >> >> Classifier benchmark shows that this

Re: [ovs-dev] [PATCH] tun-metadata: Always set option present when copying data.

2015-08-21 Thread Jesse Gross
On Fri, Aug 21, 2015 at 1:28 PM, Ben Pfaff wrote: > On Thu, Aug 13, 2015 at 07:59:29PM -0700, Jesse Gross wrote: >> Whenever we write into a tunnel option field, we also need to mark >> it as significant. If we don't, then the data will later be ignored. >> >> We currently do this in every case ex

Re: [ovs-dev] [PATCH 1/3] ovs-vsctl: Add the missing ssl bootstrapping option parsing.

2015-08-21 Thread Ben Pfaff
On Thu, Aug 20, 2015 at 10:03:38AM -0700, Gurucharan Shetty wrote: > 'man ovs-vsctl' mentions that ovs-vsctl can bootstrap itself > by getting the certificate from the server. But the option > was never parsed in the code. > > Signed-off-by: Gurucharan Shetty I guess this is a bug fix so it shou

Re: [ovs-dev] [PATCH] hmap: Ensure iterator is NULL after iteration.

2015-08-21 Thread Ben Pfaff
On Tue, Aug 18, 2015 at 11:43:18AM -0700, Russell Bryant wrote: > The HMAP_FOR_EACH_()* macros had a usability issue where the iterator > was only NULL at the completion of iteration if the hmap_node was the > first struct member. This change ensures that the iterator is set to > NULL when iterati

Re: [ovs-dev] [PATCH] tun-metadata: Always set option present when copying data.

2015-08-21 Thread Ben Pfaff
On Thu, Aug 13, 2015 at 07:59:29PM -0700, Jesse Gross wrote: > Whenever we write into a tunnel option field, we also need to mark > it as significant. If we don't, then the data will later be ignored. > > We currently do this in every case except for flow metadata. This causes > us to not correctl

Re: [ovs-dev] [dpdk-dev] OVS-DPDK performance problem on ixgbe vector PMD

2015-08-21 Thread Stephen Hemminger
Use perf top it gives much better data than oprofile On Fri, Aug 21, 2015 at 11:05 AM, Zoltan Kiss wrote: > Hi, > > I've set up a simple packet forwarding perf test on a dual-port 10G > 82599ES: one port receives 64 byte UDP packets, the other sends it out, one > core used. I've used latest OVS

Re: [ovs-dev] [PATCH] ovn-controller-vtep.at: Skip test when using Windows setup.

2015-08-21 Thread Ben Pfaff
On Fri, Aug 21, 2015 at 01:15:14PM -0700, Gurucharan Shetty wrote: > On Fri, Aug 21, 2015 at 12:59 PM, Ben Pfaff wrote: > > On Mon, Aug 17, 2015 at 03:09:46PM -0700, Alex Wang wrote: > >> The 'ovs-vtep' simulator is not ported to Windows. So, for now, > >> just skip all tests in ovn-controller-vt

Re: [ovs-dev] [PATCH v4 3/9] test-classifier: Add benchmark.

2015-08-21 Thread Jarno Rajahalme
I applied this before pushing to master, thanks! Jarno > On Aug 21, 2015, at 7:39 AM, Ben Pfaff wrote: > > On Fri, Aug 21, 2015 at 07:37:51AM -0700, Ben Pfaff wrote: >> On Fri, Aug 07, 2015 at 04:57:36PM -0700, Jarno Rajahalme wrote: >>> Add a benchmark command for classifier lookup performan

Re: [ovs-dev] [PATCH v4 3/9] test-classifier: Add benchmark.

2015-08-21 Thread Jarno Rajahalme
> On Aug 21, 2015, at 7:37 AM, Ben Pfaff wrote: > > On Fri, Aug 07, 2015 at 04:57:36PM -0700, Jarno Rajahalme wrote: >> Add a benchmark command for classifier lookup performance testing. >> >> Usage: > > This usage note is good, but putting it just in the commit log will mean > that it gets lo

Re: [ovs-dev] [PATCH] lib/automake.mk: Re-instate dependency generation

2015-08-21 Thread Ben Pfaff
On Tue, Aug 18, 2015 at 04:43:07PM +1200, Mark Wutzke wrote: > Commit 5b3c194f (lib/automake.mk: Fix dependency typos) > introduced dependencies that do not guarantee that > lib/ofp-msgs.inc is generated before lib/ofp-msgs.c > is compiled. This results in compilation issues when > using parallel b

Re: [ovs-dev] [PATCH] ovn-controller-vtep.at: Skip test when using Windows setup.

2015-08-21 Thread Gurucharan Shetty
On Fri, Aug 21, 2015 at 12:59 PM, Ben Pfaff wrote: > On Mon, Aug 17, 2015 at 03:09:46PM -0700, Alex Wang wrote: >> The 'ovs-vtep' simulator is not ported to Windows. So, for now, >> just skip all tests in ovn-controller-vtep.at when running in >> Windows. >> >> Signed-off-by: Alex Wang > > ... >

Re: [ovs-dev] [PATCH] ovn-controller-vtep.at: Skip test when using Windows setup.

2015-08-21 Thread Ben Pfaff
On Mon, Aug 17, 2015 at 03:09:46PM -0700, Alex Wang wrote: > The 'ovs-vtep' simulator is not ported to Windows. So, for now, > just skip all tests in ovn-controller-vtep.at when running in > Windows. > > Signed-off-by: Alex Wang ... > - [OVS_RUNDIR=`pwd`; export OVS_RUNDIR > + [ > + # this

Re: [ovs-dev] [PATCH] coverage: Add coverage_try_clear() for performance-critical threads.

2015-08-21 Thread Ben Pfaff
On Thu, Aug 13, 2015 at 11:48:49AM -0700, Alex Wang wrote: > For performance-critical threads like pmd threads, we currently make them > never call coverage_clear() to avoid contention over the global mutex > 'coverage_mutex'. So, even though pmd thread still keeps updating their > thread-local co

Re: [ovs-dev] [PATCH] rhel: define rundir for older distros

2015-08-21 Thread Ben Pfaff
On Sun, Aug 16, 2015 at 07:05:28PM -0400, Russell Bryant wrote: > On 08/13/2015 02:39 PM, Flavio Leitner wrote: > > Some older distros might not define _rundir yet so in this > > case the RPM build breaks. This patch defines it to the > > Fedora's default. > > minor commit message typo ... need

[ovs-dev] OVS-DPDK performance problem on ixgbe vector PMD

2015-08-21 Thread Zoltan Kiss
Hi, I've set up a simple packet forwarding perf test on a dual-port 10G 82599ES: one port receives 64 byte UDP packets, the other sends it out, one core used. I've used latest OVS with DPDK 2.1, and the first result was only 13.2 Mpps, which was a bit far from the 13.9 I've seen last year wit

Re: [ovs-dev] [PATCH] ovsdb-idl: Add additional support for change tracking.

2015-08-21 Thread Russell Bryant
On 08/21/2015 01:30 PM, Ansari, Shad wrote: > Ovsdb-idl notifies a client that something changed; it does not track > which table, row changed in what way (insert, modify or delete). > As a result, a client has to scan or reconfigure the entire idl after > ovsdb_idl_run(). This is presumably fine f

Re: [ovs-dev] [PATCH v4 8/9] flow: Add struct flowmap.

2015-08-21 Thread Jarno Rajahalme
> On Aug 21, 2015, at 8:33 AM, Ben Pfaff wrote: > > On Fri, Aug 07, 2015 at 04:57:41PM -0700, Jarno Rajahalme wrote: >> Struct miniflow is now sometimes used just as a map. Define a new >> struct flowmap for that purpose. The flowmap is defined as an array of >> maps, and it is automatically s

Re: [ovs-dev] [PATCH/RFC] ovs-ctl: do not attempt to restore flows when called with --delete-bridges

2015-08-21 Thread Ben Pfaff
On Fri, Aug 21, 2015 at 10:25:22AM -0700, Gurucharan Shetty wrote: > On Thu, Aug 20, 2015 at 4:45 PM, Simon Horman > wrote: > > When called with --delete-bridges saved flows cannot be restored as the > > bridges to which they belong no longer exist. This results in the following > > error messages

Re: [ovs-dev] [PATCH 8/8] json: increase Json string initial buffer size

2015-08-21 Thread Ben Pfaff
On Tue, Aug 11, 2015 at 05:55:14PM -0700, Andy Zhou wrote: > Json string are usually created and freed immediately. Thus, there > should not be any downside in creating a larger buffer initially to > avoid the cost of moving strings around in memory due to realloc() > call. > > The following scrip

[ovs-dev] [PATCH] ovs-sandbox: Add support for ovn-controller-vtep.

2015-08-21 Thread Russell Bryant
When ovs-sandbox is run with ovn enabled, create the vtep database and run ovn-controller-vtep. This lets you do some basic testing with ovn-controller-vtep. For example: $ make sandbox SANDBOXFLAGS="--ovn" $ vtep-ctl add-ps ps0 After those commands, you can see that ovn-controller-vtep

Re: [ovs-dev] [PATCH 2/2] Prepare for 2.4.1.

2015-08-21 Thread Ben Pfaff
On Fri, Aug 21, 2015 at 10:23:46AM -0700, Justin Pettit wrote: > > > On Aug 21, 2015, at 7:38 AM, Ben Pfaff wrote: > > > > On Thu, Aug 20, 2015 at 05:28:26PM -0700, Justin Pettit wrote: > >> Signed-off-by: Justin Pettit > > > > *Finally*. > > > > Acked-by: Ben Pfaff > > Amen. I pushed the

[ovs-dev] [PATCH] ovsdb-idl: Add additional support for change tracking.

2015-08-21 Thread Ansari, Shad
Ovsdb-idl notifies a client that something changed; it does not track which table, row changed in what way (insert, modify or delete). As a result, a client has to scan or reconfigure the entire idl after ovsdb_idl_run(). This is presumably fine for typical ovs schemas where tables are relatively s

Re: [ovs-dev] [PATCH/RFC] ovs-ctl: do not attempt to restore flows when called with --delete-bridges

2015-08-21 Thread Gurucharan Shetty
On Thu, Aug 20, 2015 at 4:45 PM, Simon Horman wrote: > When called with --delete-bridges saved flows cannot be restored as the > bridges to which they belong no longer exist. This results in the following > error messages on restart. > > ovs-ofctl: br0 is not a bridge or a socket > Restoring saved

Re: [ovs-dev] [PATCH 2/2] Prepare for 2.4.1.

2015-08-21 Thread Justin Pettit
> On Aug 21, 2015, at 7:38 AM, Ben Pfaff wrote: > > On Thu, Aug 20, 2015 at 05:28:26PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > *Finally*. > > Acked-by: Ben Pfaff Amen. I pushed the series and uploaded the binaries. Can you tag the release to the previous commit?

Re: [ovs-dev] [PATCH] classifier: Replace MINIFLOW_IN_MAP macro by function.

2015-08-21 Thread Justin Pettit
Don't let Keith see that comment. Acked-by: Justin Pettit --Justin > On Aug 21, 2015, at 8:26 AM, Ben Pfaff wrote: > > Functions are nicer. > > Signed-off-by: Ben Pfaff > --- > lib/classifier.c | 2 +- > lib/flow.h | 16 ++-- > 2 files changed, 11 insertions(+), 7 deletion

Re: [ovs-dev] [PATCH 4/8] jsonrpc: use json_to_ds to speed up jsonrpc_send

2015-08-21 Thread Ben Pfaff
On Tue, Aug 11, 2015 at 05:55:10PM -0700, Andy Zhou wrote: > This change reuses the string length that available from 'ds', saving > a strlen() call. > > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://open

Re: [ovs-dev] [PATCH 2/8] lib/ofpbuf: refactor ofpbuf_use__() API

2015-08-21 Thread Ben Pfaff
On Tue, Aug 11, 2015 at 05:55:08PM -0700, Andy Zhou wrote: > Add the size to its parameter list. > > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/8] lib/dynamic-string: coding style fix

2015-08-21 Thread Ben Pfaff
On Tue, Aug 11, 2015 at 05:55:07PM -0700, Andy Zhou wrote: > Remove tabs per coding style > > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4 8/9] flow: Add struct flowmap.

2015-08-21 Thread Ben Pfaff
On Fri, Aug 07, 2015 at 04:57:41PM -0700, Jarno Rajahalme wrote: > Struct miniflow is now sometimes used just as a map. Define a new > struct flowmap for that purpose. The flowmap is defined as an array of > maps, and it is automatically sized according to the size of struct > flow, so it will be

Re: [ovs-dev] [PATCH v4 4/9] classifier: Pre-compute stage masks.

2015-08-21 Thread Ben Pfaff
On Fri, Aug 07, 2015 at 04:57:37PM -0700, Jarno Rajahalme wrote: > This makes stage mask computation happen only when a subtable is > inserted and allows simplification of the main lookup function. > > Classifier benchmark shows that this speeds up the classification > (with wildcards) about 5%. >

[ovs-dev] [PATCH] classifier: Replace MINIFLOW_IN_MAP macro by function.

2015-08-21 Thread Ben Pfaff
Functions are nicer. Signed-off-by: Ben Pfaff --- lib/classifier.c | 2 +- lib/flow.h | 16 ++-- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/lib/classifier.c b/lib/classifier.c index e6227b9..a91d936 100644 --- a/lib/classifier.c +++ b/lib/classifier.c @@ -

Re: [ovs-dev] [PATCH 2/2] Prepare for 2.4.1.

2015-08-21 Thread Ben Pfaff
On Thu, Aug 20, 2015 at 05:28:26PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit *Finally*. Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] Set release dates for 2.4.0.

2015-08-21 Thread Ben Pfaff
On Thu, Aug 20, 2015 at 05:28:25PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Hurray. Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v4 3/9] test-classifier: Add benchmark.

2015-08-21 Thread Ben Pfaff
On Fri, Aug 21, 2015 at 07:37:51AM -0700, Ben Pfaff wrote: > On Fri, Aug 07, 2015 at 04:57:36PM -0700, Jarno Rajahalme wrote: > > Add a benchmark command for classifier lookup performance testing. > > > > Usage: > > This usage note is good, but putting it just in the commit log will mean > that it

Re: [ovs-dev] [PATCH v4 3/9] test-classifier: Add benchmark.

2015-08-21 Thread Ben Pfaff
On Fri, Aug 07, 2015 at 04:57:36PM -0700, Jarno Rajahalme wrote: > Add a benchmark command for classifier lookup performance testing. > > Usage: This usage note is good, but putting it just in the commit log will mean that it gets lost. It should be in a --help message, or failing that in a sourc

Re: [ovs-dev] [PATCH v4 1/9] classifier: Fix comment.

2015-08-21 Thread Ben Pfaff
On Fri, Aug 07, 2015 at 04:57:34PM -0700, Jarno Rajahalme wrote: > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Try it now to show her who's her daddy!

2015-08-21 Thread Carissa
Make sure that you made your woman happy tonight. style2 { text-align: center; color: #D90003; font-family: Cambria, 'Hoefler Text', 'Liberation Serif', Times, 'Times New Roman', serif; font-size: 20px; font-weight: bold; } style4 {border: 1px solid #707070; } style5 {t

[ovs-dev] Returned mail: see transcript for details

2015-08-21 Thread Mail Delivery Subsystem
This message was not delivered due to the following reason(s): Your message could not be delivered because the destination computer was unreachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likel